Commit graph

17031 commits

Author SHA1 Message Date
Rémi Verschelde 88935d47a8
Merge pull request #22623 from dualtagh/22586
22586: Dragging file icon on to another file causes "Error Moving" in FileSystem dock
2018-10-05 10:58:55 +02:00
Rémi Verschelde fc6cf69a90
Merge pull request #22737 from DualMatrix/warn_sort_custom
Added a check in sort_custom that test whether the given method exists.
2018-10-05 09:15:05 +02:00
Rémi Verschelde 0173cf6402
Merge pull request #22732 from DualMatrix/deselect
Deselect recents when selecting favorites and vice versa in Create Node window.
2018-10-05 08:50:44 +02:00
Rémi Verschelde 936cfd44ee
Merge pull request #22726 from marcelofg55/coremidi_warn
Fix CoreMidi warnings
2018-10-05 08:48:00 +02:00
DualMatrix 6415454581 Added a check in sort_custom thats test wether the given method exists.
Added a check in sort_custom thats test wether the given method exists.
2018-10-04 23:38:31 +02:00
DualMatrix 9b3c1f617f Deselect recents when selecting favorites and vice versa in Create Node.
Deselect recents when selecting favorites and vice versa in Create Node.
2018-10-04 22:31:48 +02:00
Dualtagh Murray fc0ae1d94d 22586: Dragging file icon on to another file causes "Error Moving" in FileSystem dock 2018-10-04 20:38:36 +01:00
Marcelo Fernandez cb99a15064 Fix CoreMidi warnings 2018-10-04 16:23:59 -03:00
Rémi Verschelde 8068d0217a
Merge pull request #22715 from groud/fix_tilemap_editor
Fixes tilemap editor offset tile selection
2018-10-04 18:20:29 +02:00
Simon Wenner 10718b0961 Fix some cppcheck errors
cppcheck: fix broken pre-processor statement
cppcheck: fix Uninitialized struct members in canvas editor plugin
cppcheck: fix uninitialized struct member: method_api.is_virtual
2018-10-04 18:16:04 +02:00
Rémi Verschelde 3ca2afc09c
Merge pull request #22719 from akien-mga/ci-werror
Travis: Enable 'werror' for X11 and Android builds
2018-10-04 16:21:08 +02:00
Rémi Verschelde 6bb5ee0ded Travis: Enable 'werror' for X11 and Android builds
They are currently warning-free, so let's keep it that way.
2018-10-04 15:38:43 +02:00
Rémi Verschelde f5532bb650 Fix unused variable and wrong warning workaround
I had been looking at the wrong line all along when attempting to fix:
```
core/os/memory.cpp:184:13: warning: unused variable 's' [-Wunused-variable]
                uint64_t *s = (uint64_t *)mem;
                          ^
```
2018-10-04 15:38:03 +02:00
groud c7725aa98a Fixes tilemap editor offset tile selection 2018-10-04 14:20:03 +02:00
Rémi Verschelde 181af9b484
Merge pull request #22713 from akien-mga/fix-warnings
Fix GCC 8 warnings about potentially unitialized variables
2018-10-04 14:19:05 +02:00
Rémi Verschelde 674b2567ae
Merge pull request #22693 from mineevgleb/fix-graphnode-title
#21661: fixed GraphNode title offset
2018-10-04 13:25:25 +02:00
Rémi Verschelde 8c8f5ca160
Merge pull request #22706 from GDquest/doc-texture-progress
[DOCS] Complete the TextureProgress reference
2018-10-04 13:24:50 +02:00
the 8th mage f7a9866417 Fix TileMap editor drawing
the tile cursor did not follow the mouse cursor, and the tile grid was displayed wrong,
because the forward_canvas_draw_over_viewport function used the wrong xform and thus its
map_to_world is not the inverse of the mouse interactor world_to_map, making the tiles
draw from 0,0 of the screen instead of 0,0 of the tile map (which is in a different place)
2018-10-04 13:19:55 +02:00
Rémi Verschelde f48ee838e7 Fix GCC 8 warnings about potentially unitialized variables
Fixes the following GCC 8 warnings:
```
core/image.cpp:730:44: warning: 'mip1_weight' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:293:20: warning: 'mip2' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:293:20: warning: 'mip1' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/audio_stream_preview.cpp:58:19: warning: 'vmax' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/audio_stream_preview.cpp:85:19: warning: 'vmin' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/editor_themes.cpp:306:53: warning: 'preset_contrast' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/plugins/animation_blend_space_2d_editor.cpp:459:27: warning: 'prev_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/plugins/animation_blend_space_2d_editor.cpp:443:27: warning: 'prev_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
main/tests/test_oa_hash_map.cpp:57:29: warning: 'value' may be used uninitialized in this function [-Wmaybe-uninitialized]
modules/csg/csg.cpp:764:40: warning: 'max_angle' may be used uninitialized in this function [-Wmaybe-uninitialized]
modules/csg/csg_shape.cpp:1945:3: warning: 'face_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1593:8: warning: 'cone_aperture' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1592:6: warning: 'cone_dir_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/animation/animation_blend_space_2d.cpp:471:8: warning: 'mind' may be used uninitialized in this function [-Wmaybe-uninitialized]

core/os/memory.cpp:94: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
core/os/memory.cpp:95: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
core/os/memory.cpp:98: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
```
2018-10-04 13:08:41 +02:00
Rémi Verschelde 156c4eab02
Merge pull request #22620 from akien-mga/warnings-shall-not-pass
SCons: Set default warnings level to all (-Wall or /W3)
2018-10-04 12:08:48 +02:00
Rémi Verschelde f92a29adfe
Merge pull request #22710 from akien-mga/fix-warnings
Fix some OSX and iOS Clang warnings
2018-10-04 12:04:54 +02:00
Rémi Verschelde 97b9697ea2 Fix some OSX and iOS Clang warnings
Fixes the following XCode 9.4.1 warnings:
```
core/os/memory.cpp:175:13: warning: unused variable 's' [-Wunused-variable]
drivers/coremidi/core_midi.cpp:68:14: warning: comparison between NULL and non-pointer ('MIDIEndpointRef' (aka 'unsigned int') and NULL) [-Wnull-arithmetic]
drivers/gles2/rasterizer_gles2.cpp:77:24: warning: unused function '_gl_debug_print' [-Wunused-function,34]
drivers/unix/thread_posix.cpp:106:12: warning: unused variable 'running_thread' [-Wunused-variable,34]
modules/gdnative/nativescript/nativescript.h:371:16: warning: in-class initialization of non-static data member is a C++11 extension [-Wc++11-extensions]
platform/iphone/gl_view.mm:56:14: warning: unused variable 'video_previous_volume' [-Wunused-variable,34]
platform/iphone/gl_view.mm:251:12: warning: unused function 'get_first_id' [-Wunused-function,34]
platform/iphone/main.m:45:15: warning: unused variable 'app' [-Wunused-variable,34]
platform/osx/os_osx.mm:79:15: warning: unused function 'convertRectToBacking' [-Wunused-function]
```
2018-10-04 11:50:16 +02:00
Rémi Verschelde 2024666305 SCons: Add 'werror' opt-in to treat warning as errors
Also reorder advanced options to a more natural order,
and fix MSVC warning when disabling warnings in secondary environment.
2018-10-04 10:11:07 +02:00
Rémi Verschelde 0e2de7481d SCons: Set default warnings level to all (-Wall or /W3) 2018-10-04 10:11:07 +02:00
Rémi Verschelde cfa373c69f
Merge pull request #22708 from akien-mga/fix-warnings
Fix warnings about non-static data member initializers in nativescript
2018-10-04 10:09:20 +02:00
Rémi Verschelde e9cb01e366 Fix warnings about non-static data member initializers in nativescript
Fixes the following GCC/Clang warnings:
```
modules/gdnative/nativescript/nativescript.h:280:37: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:281:37: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:283:42: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:285:38: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:287:38: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:290:45: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:291:44: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
```
2018-10-04 09:59:49 +02:00
Rémi Verschelde bdf898e38d
Merge pull request #22707 from karroffel/clang-warnings
fix enum cast warnings on clang
2018-10-04 09:25:07 +02:00
karroffel a0f206aae8 fix enum cast warnings on clang 2018-10-04 09:17:59 +02:00
Rémi Verschelde 171be91804
Merge pull request #22694 from swarnimarun/fix-create-spatial-root
Fixing create spatial root button
2018-10-04 08:37:57 +02:00
Nathan Lovato 86a138f154 [DOC] Complete the TextureProgress reference
Added 6 missing entries, clarified one definition
2018-10-04 10:38:18 +09:00
swarnimarun 97ffdf74c3 Fixing create spatial root button 2018-10-04 06:06:58 +05:30
Gleb Mineev 746ad820cf #21661: fixed GraphNode title offset 2018-10-03 20:43:14 +02:00
Rémi Verschelde caa141a1ac
Merge pull request #22659 from YeldhamDev/animation_doc_example
Add example to Animation doc
2018-10-03 20:35:09 +02:00
Rémi Verschelde 864772b900
Merge pull request #22643 from akerudesu/dynamic_font_fallback
Fix oversampling of DynamicFont fallback fonts
2018-10-03 20:34:52 +02:00
Rémi Verschelde 89d955615a
Merge pull request #22691 from jfmichaud31/fix_export_editor
Fix #22588: missing preset save after removing a export preset.
2018-10-03 20:25:24 +02:00
Rémi Verschelde 05fe312180
Merge pull request #22690 from jfmichaud31/fix_gles2_shader
Fix #22591: shader error when shadow enabled
2018-10-03 20:24:30 +02:00
Juan Linietsky fdd6950fc1 Fix lightmap baking crash, may close some issues but I am not sure. 2018-10-03 14:58:33 -03:00
Jean-François Michaud 700d5d26c9 Fix #22591: shader failed to compile when shadow enabled because of incompatible assignment of vec3 to a vec4. 2018-10-03 13:42:17 -04:00
Jean-François Michaud 00616360a3 Fix #22588: missing preset save after removing a export preset. 2018-10-03 13:40:16 -04:00
Rémi Verschelde 344a453bb8
Merge pull request #22681 from akien-mga/fix-warnings
Fix warnings on release builds and some MSVC warnings
2018-10-03 19:05:55 +02:00
Rémi Verschelde 1aa1398012
Merge pull request #22671 from Dragoncraft89/master
ItemList signals additional documentation
2018-10-03 18:20:23 +02:00
Rémi Verschelde 75fceb37f8
Merge pull request #22674 from Dragoncraft89/find_node
Document find_node()'s owner argument behaviour
2018-10-03 18:19:58 +02:00
Rémi Verschelde 0fa25206d2
Merge pull request #22683 from qonnop/fix-dds-w-h-attribs
Fixed DDS loader width/height attribs, fixes #22530
2018-10-03 18:19:11 +02:00
Michael Alexsander Silva Dias a02f02b9ed Add example to Animation doc 2018-10-03 13:17:49 -03:00
florian c14e034f06 Document find_node()'s owner argument behaviour 2018-10-03 18:16:27 +02:00
florian 65d182a939 ItemList signals additional documentation
Signals:
* item_selected
* item_rmb_select
2018-10-03 18:13:59 +02:00
Rémi Verschelde f7cb23f9e3
Merge pull request #22675 from DualMatrix/duplicate_err
Fixed error when duplicating node with signal from editor.
2018-10-03 18:07:13 +02:00
Rémi Verschelde dec20a987b Fix some warnings raised by MSVC 2017
Disabled signed/unsigned warnings like for GCC/Clang
(warning C4018: '>=': signed/unsigned mismatch).

Fixes the following MSVC 2017 warnings:
```
core\image.cpp(999): warning C4804: '>': unsafe use of type 'bool' in operation

core\io\compression.cpp(178): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
editor\doc\doc_dump.cpp(226): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
scene/resources/material.h(289): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
scene/resources/material.h(298): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

editor\editor_themes.cpp(379): warning C4805: '==': unsafe mix of type 'int' and type 'bool' in operation
```
2018-10-03 17:34:56 +02:00
Rémi Verschelde 95131e6f23 Fix warnings on release builds (not DEBUG_ENABLED)
Fixes the following Clang 5 warnings:
```
modules/bmp/image_loader_bmp.cpp:46:60: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
modules/bmp/image_loader_bmp.cpp:48:61: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
drivers/png/image_loader_png.cpp:231:20: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
scene/gui/graph_edit.cpp:1045:8: warning: comparison of constant 0 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]

core/class_db.cpp:812:13: warning: unused variable 'check' [-Wunused-variable]
core/io/file_access_pack.cpp:172:11: warning: unused variable 'ver_rev' [-Wunused-variable]
core/math/bsp_tree.cpp:195:13: warning: unused variable 'plane' [-Wunused-variable]
core/math/bsp_tree.cpp:168:6: warning: unused variable 'plane_count' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:685:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:706:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:755:19: warning: unused variable 'var_type' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:1306:12: warning: unused variable 'err' [-Wunused-variable]

modules/gdscript/gdscript_function.cpp:158:15: warning: unused function '_get_var_type' [-Wunused-function]
modules/gdscript/gdscript_parser.cpp:750:20: warning: unused variable 'lv' [-Wunused-variable]
modules/gdscript/gdscript_parser.cpp:59:15: warning: unused function '_find_function_name' [-Wunused-function]
scene/main/node.cpp:2489:13: warning: unused function '_Node_debug_sn' [-Wunused-function]
```
2018-10-03 17:34:55 +02:00
Akeru 81fa121909 Fix fallback font oversampling. 2018-10-03 17:25:28 +02:00