Commit graph

1483 commits

Author SHA1 Message Date
Benjamin Pasero 3e5c7e2c57
smoke - disable trust
cc @sbatten @lszomoru
2022-03-12 08:23:43 +01:00
SteVen Batten 24d49c0f84 disable workspace trust in web integration tests 2022-03-11 08:52:55 -08:00
SteVen Batten 6b74534212
rename side panel (#144862)
* rename side panel

* tweaks based on feedback
2022-03-10 16:20:23 -08:00
Robo 32d40cf44e
chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Matt Bierner c569182d08
Encode webview parent origin in authority
Fixes #144703
2022-03-08 11:28:59 -08:00
Robo df645f1450
chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Benjamin Pasero 5a17b1bb76
smoke - retry stable code download (fix #143386) (#143592) 2022-02-22 09:04:56 +01:00
Matt Bierner 31b199da9c
Bump webview commit 2022-02-15 18:36:12 -08:00
Benjamin Pasero b344f43498
Revert "linux: disable crash reporting in CI (#142572)"
This reverts commit 7dbd7367dc.
2022-02-15 16:27:08 +01:00
Benjamin Pasero 7dbd7367dc
linux: disable crash reporting in CI (#142572) 2022-02-15 08:26:18 +01:00
Matt Bierner 82fe581566
Bump webview commit 2022-02-14 13:45:05 -08:00
Benjamin Pasero 7d78913dff
smoke - remove only usage 2022-02-12 07:47:54 +01:00
Benjamin Pasero 5911ead4c6
smoke - open a different file for #142745 2022-02-12 07:38:04 +01:00
Martin Aeschlimann 22e5d7274a
prepare tests for license terms check 2022-02-09 16:18:37 +01:00
Benjamin Pasero f613ab462e
tests - skip some, enable some 2022-02-09 07:14:42 +01:00
Robo 01df559c18
chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Benjamin Pasero b6c093a888
💄 todos 2022-02-08 18:04:54 +01:00
Sandeep Somavarapu 3b1da68d60
#142027 enable preferences smoke test 2022-02-08 08:30:27 +01:00
Benjamin Pasero 0d741957d9
smoke - bring back keybindings test 2022-02-05 07:06:54 +01:00
Benjamin Pasero b667613ff8
smoke - retry fetch to update service (fix #142188) 2022-02-04 19:10:21 +01:00
Megan Rogge 921264bfe3
add splitCwd smoke test for linux/mac (NaiveCwdDetection) (#141974) 2022-02-03 19:57:26 -06:00
Rob Lourens b46986a65f Remove .only 2022-02-03 09:37:56 -08:00
Benjamin Pasero ee3556530f
smoke - skip test (#142020) 2022-02-02 18:16:10 +01:00
Benjamin Pasero 77a93b43e9
smoke - skip #141054 2022-02-02 16:51:55 +01:00
Johannes Rieken 4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Dima cab9713422
Fixes #141994: Address eslint problems 2022-02-02 13:18:12 +01:00
SteVen Batten a48c94c91f
bump node-fetch version in smoke tests 2022-02-01 11:40:45 -08:00
Benjamin Pasero 12c5c57e46
smoke - simplify line number test (#141054) 2022-02-01 10:08:15 +01:00
Sandeep Somavarapu fb8316c8f4
#141054 check line numbers in settigns file 2022-02-01 09:35:54 +01:00
Sandeep Somavarapu d4e08c85a9
#141054 enable the tests and keep debugging 2022-01-28 13:50:09 +01:00
Alex Dima 1b1d594671
Run headless on CI 2022-01-25 20:49:30 +01:00
Alex Dima 2ccb32cfe9
Use @playwright/test instead of playwright 2022-01-25 18:21:30 +01:00
Alex Dima bd369c638e
Add check that the editor's ESM JS files can be loaded in a browser 2022-01-25 15:19:30 +01:00
Alex Dima 81ad1f968d
Do not force that a connection token CLI argument is present 2022-01-24 14:02:41 +01:00
Benjamin Pasero c9960f9cee
Cleanup package.json test scripts (#141210)
* tests - remove `yarn test`

* fix smoke test

* readme

* 💄

* ci - do not install playwright
2022-01-22 13:07:14 +01:00
Benjamin Pasero b7cdfce7e5
Smoke test runner fails or hangs without error (fix #141148) 2022-01-22 08:43:21 +01:00
Martin Aeschlimann ef4549b141
Merge branch 'main' into aeschli/noremoteindicatorweb 2022-01-21 17:19:52 +01:00
Martin Aeschlimann 3640c1a425
move remote and web tests to scripts folder 2022-01-21 14:33:34 +01:00
Martin Aeschlimann 0d8bb5f2ba
Merge branch 'main' into aeschli/noremoteindicatorweb 2022-01-21 14:16:29 +01:00
Alex Dima 715dbb0c16
Refuse launching unless a connection token is provided 2022-01-21 13:25:20 +01:00
Martin Aeschlimann f9cac7c28a
adopt --server-data-dir 2022-01-21 12:11:47 +01:00
Alex Dima 1498d0f340
Add explicit layers for editor contributions (fixes #140995) 2022-01-21 10:29:55 +01:00
Martin Aeschlimann 8047f9c877
no remote indicator for code server web 2022-01-21 10:00:20 +01:00
Benjamin Pasero 01a976f80c
smoke - properly skip tests (#141054) 2022-01-21 08:55:59 +01:00
Benjamin Pasero 5993199079
smoke - skip flaky one (#141054) 2022-01-21 07:26:59 +01:00
Connor Peet 904c63debd
smoketests: use new extractSync option 2022-01-20 11:04:36 -08:00
Benjamin Pasero 295984b33b
tests - adopt new URL syntax when web is connected to a remote 2022-01-20 15:55:18 +01:00
Benjamin Pasero e07713a8a9
smoke - log fatal errors 2022-01-20 14:18:06 +01:00
Benjamin Pasero 365fea1d61
fix #141060 2022-01-20 13:59:47 +01:00
Benjamin Pasero 13461f8c61
Web: change yarn web to run with our server instead of playground (#139725)
* web - first cut `yarn web` via our server

* properly pipe output

* web - remove traces of web playground

* web - remember last opened workspace for convinience

* use vscode-test-web for server less, clean up web commands

* fix comment

* fix `yarn web`

* rename to code-server

* open system browser

* code-server script: use minimist

* test resolver: use ./scripts/code-server

* integartion tests: fix code-server command name

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-01-20 13:48:08 +01:00
Benjamin Pasero f317abfd68
layers - clean up top level workbench test folder 2022-01-20 10:47:35 +01:00
Martin Aeschlimann f7baac67c1
Merge branch 'aeschli/adoptServerScript' 2022-01-19 21:31:12 +01:00
Martin Aeschlimann 36089a9229
fix unused import 2022-01-19 19:49:37 +01:00
Benjamin Pasero 96206bb5a8
smoke - 🆙 timeouts 2022-01-19 19:45:03 +01:00
Connor Peet bdc81fc0a9
tests: log progress as stable code downloads 2022-01-19 09:16:39 -08:00
Martin Aeschlimann ad928a4e0f
adopt server script in integration tests 2022-01-19 18:08:04 +01:00
Benjamin Pasero c333d44ecd
update integration test docs how to compile 2022-01-19 07:29:38 +01:00
Sandeep Somavarapu 066671a902
Fix #140838 2022-01-18 17:43:20 +01:00
Benjamin Pasero 158cd6da42
smoke - log code download (#140769)
* smoke - log progress/errors of vscode download

//cc @connor4312

* reduce spam
2022-01-15 11:31:13 +01:00
Benjamin Pasero 9be2757019
🆙 playwright@1.18 (#140767)
* tests - use `@playwright/test@1.18.0-rc1`

* fix bad dependency

* clear more weird ts dependencies
2022-01-15 09:35:39 +01:00
Daniel Imms f2c755a878 Skip smoke test
Part of #139076
2022-01-14 09:47:56 -08:00
Daniel Imms 0b7bc6d73c Re-enable auto replies tests with retries on Windows only
Fixes #139076
2022-01-14 08:56:11 -08:00
Benjamin Pasero eecbd962ef
debt - rename iconv-lite-umd package (#140650) 2022-01-14 07:28:41 +01:00
João Moreno 8c9870d298
Smoke Test: forcefully kill electron if exit doesn't work (#140570)
* smoke test: forcefully kill electron if exit doesn't work

* use tree-kill

* roll back veto
2022-01-12 17:02:52 +01:00
Daniel Imms 860e935d1a Skip notebooks smoke test suite
Part of #140575
2022-01-12 07:35:56 -08:00
Benjamin Pasero af5de88a44
tests - add --sequential option and use in CI runs 2022-01-11 10:48:20 +01:00
Matt Bierner 9f867c3ed8
Revert service worker usage of MessageChannel (#140351)
* Revert service worker usage of MessageChannel

Reverts 66b6adf035

While I'm not 100% about this, I think 66b6adf035 causes resourses to occasionally not load. I believe this can happen if the service worker is unitilized while the webview remains active. I can't reproduce this myself so it may be related to memory pressure or resource usage, however relying on the service worker not being reinitilized does seem like a potentially bad idea https://stackoverflow.com/questions/34775105/what-causes-the-global-context-of-a-service-worker-to-be-reset

Will investigate if there's another way to achive this since using MessagePort did clean up the code and slightly improve performance

* Bump webview commit versions
2022-01-10 14:22:49 -08:00
Benjamin Pasero a224ef4fb3
smoke - fix selectTab to select tab? 2022-01-04 09:47:09 +01:00
Benjamin Pasero 18a7108073
smoke - select tab over quick pick (#139944)
* smoke - further try to reduce usages of quick pick

* poke
2021-12-30 22:38:59 +01:00
Benjamin Pasero 99fabbdb27
smoke - more logging 2021-12-29 17:46:52 +01:00
Benjamin Pasero bd43c04262
smoke - log electron stdout into log file 2021-12-29 17:35:54 +01:00
Benjamin Pasero 9c0cce1dae
smoke - take screenshot when waiting long for window ready 2021-12-28 15:32:35 +01:00
Benjamin Pasero b2e9e87c2e
smoke - skip flaky notebook test (#139672) 2021-12-23 17:12:29 +01:00
Benjamin Pasero b2e79a699f
smoke - improve app lifecycle (#139693)
* smoke - make sure app is closed when `app.start` fails

* smoke - `capturePage` to fallback to active window

* smoke - more logging around remote resolving
2021-12-23 16:38:54 +01:00
Daniel Imms daf4ba622f
Merge pull request #138516 from microsoft/tyriar/137847
Try removing timeout in checkWindowReady
2021-12-22 10:38:41 -08:00
Benjamin Pasero bb39ae82cf
smoke - improve runCommand and disable more tests 2021-12-20 08:25:08 +01:00
Benjamin Pasero 2d77c9e23a
smoke - more robust usage of quick input / access (#139367)
* smoke - more robust `openQuickAccessAndWait`

* tweaks

* 💄

* trigger

* fix fluke

* poke

* fix terminal weirdness

* poke

* address feedback
2021-12-17 18:49:17 +01:00
Daniel Imms 88fcbd84e0 Fix auto replies smoke tests
This was flaky because the shell's wrapping character may have come after the
input (eg. 'foo> bar'), the fix is to allow characters between the matching
string and reply via regex.

Fixes #139083
2021-12-17 09:42:50 -08:00
Benjamin Pasero 7141436baa
smoke - skip failing terminal test (#139353) 2021-12-17 08:21:58 +01:00
Benjamin Pasero 1a4a2714bf
smoke - skip failing terminal test (#139349) 2021-12-17 07:34:20 +01:00
Daniel Imms d33e3d2fbc Re-enable flaky auto replies tests
Need a new playwright trace from a failure to be able to diagnose

Part of #139083
2021-12-16 11:36:53 -08:00
Benjamin Pasero ae8aeb653d
smoke - use absolute paths for opening files (#139322) 2021-12-16 20:14:12 +01:00
Benjamin Pasero 9e22f1ccac
smoke - disable flaky notebook tests (#139270) 2021-12-16 15:55:15 +01:00
Daniel Imms dfc4077fb0 Use dom renderer for terminal smoke tests
Part of #139083
2021-12-16 06:38:11 -08:00
Sandeep Somavarapu 995d40b12d
#139183 enable the test and add a log statement 2021-12-16 14:34:47 +01:00
Benjamin Pasero fa739870a2
smoke - remove doubleClick usage 2021-12-16 14:27:21 +01:00
Benjamin Pasero fdc4b7101d
smoke - actually retry quick access usage 2021-12-16 14:25:12 +01:00
Benjamin Pasero 51eda13af4
smoke - move editor test into language test 2021-12-16 10:29:46 +01:00
Rob Lourens 86bdc567e9 Remove obsolete comment 2021-12-15 16:41:20 -08:00
Daniel Imms da308a9a7f Format 2021-12-15 19:35:16 +00:00
Daniel Imms fa61def811
Merge branch 'main' into tyriar/137847 2021-12-15 09:29:49 -08:00
Johannes Rieken 1b2c610ffe
skip bad test, https://github.com/microsoft/vscode/issues/139183 2021-12-15 10:51:01 +01:00
Rob Lourens b823936907 Wait for window to connect before starting browser smoketests
Fix #138045
2021-12-14 20:23:44 -08:00
Matt Bierner 8cf4dcdade
Re-enable notebook smoke tests (#139127)
Fixes #126371
2021-12-14 16:50:22 -08:00
Connor Peet 2b19344369
testing: debug test failures
For #137853
2021-12-14 11:29:14 -08:00
Daniel Imms 2eb4cec44b Wait for terminal to be ready before changing color
Fixes #139081
2021-12-14 10:14:06 -08:00
Daniel Imms 9c99eaa0b2 Also log exception in itSkipOnFail 2021-12-14 08:15:54 -08:00
Daniel Imms c29df4c2d5 Add itSkipOnFail util
Part of #139076
2021-12-14 08:05:43 -08:00
Benjamin Pasero 5526cd558f
smoke - remove only 2021-12-14 07:38:08 +01:00
Daniel Imms 9d1a7abe35 Some jsdoc 2021-12-13 16:57:14 -08:00