Commit graph

1816 commits

Author SHA1 Message Date
Aiday Marlen Kyzy ddc7a1e51a
tweaking the recursion, so that we do not do the recursion for a long time 2023-11-21 17:40:06 +01:00
Aiday Marlen Kyzy 5e89263580
polishing the code after review 2023-11-21 15:42:14 +01:00
Aiday Marlen Kyzy e46541edaf
removing export 2023-11-21 15:06:59 +01:00
Aiday Marlen Kyzy 5b297c488c
Squashed commit of the following:
commit bc4dc881ba
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 13:07:39 2023 +0100

    adding one more possibility which is lightbulb sparkle and auto-fix

commit a5dfa1f620
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:55:44 2023 +0100

    removing one because should be using zero based ranges

commit 78b29c0b56
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:49:50 2023 +0100

    using the navTree request instead

commit ba1b8fef77
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:20:38 2023 +0100

    polishing the code

commit 5ae767f43a
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:14:35 2023 +0100

    polishing the code

commit fd347bb0e2
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 11:03:04 2023 +0100

    remembering the class array that was previously set, so not removing the whole class array

commit fd5fd11bfc
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 10:54:18 2023 +0100

    using the appropriate icon

commit df29259136
Merge: 5285e1d97e 633efd8c55
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 10:47:18 2023 +0100

    Merge branch 'main' into aiday/differentLightBulbDependingOnCodeAction

commit 5285e1d97e
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 18:24:45 2023 +0100

    making the filtering function synchronous

commit a86c36c6b0
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 17:42:11 2023 +0100

    adding code in order to also include move to a new file only when on the range of interest

commit 2cedc2ffb4
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 17:11:13 2023 +0100

    not showing move to file all the time

commit 8f4ade1d3d
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 14:50:56 2023 +0100

    removing the code which does the selection check

commit 2e0e6c534e
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 14:31:55 2023 +0100

    adding code in order to execute the AI code action when it is unique

commit a037c7e8e9
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 14:05:32 2023 +0100

    adding code in order to be able to detect when different code actions partitions appear

commit abd005b78b
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 18:07:26 2023 +0100

    changing the heuristic of the move to code actions

commit e4886eab7a
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:25:57 2023 +0100

    removing model

commit 79102a983b
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:25:48 2023 +0100

    making lightbub icon appear on empty lines

commit ee8bb3475b
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:09:15 2023 +0100

    directly resolving the code action when it is an ai code action

commit 4d4bcb9b34
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:02:34 2023 +0100

    wip allow lightbulb menu to specify different icons depending on the code actions
2023-11-21 15:05:17 +01:00
Matt Bierner 620340c863
Bump hardcoded web TS version (#198713) 2023-11-21 00:25:20 +01:00
Matt Bierner 1d92f24bd8
Add telemetry for TS ai refactorings (#198708) 2023-11-20 15:01:33 -08:00
Matt Bierner 032109e5a7
Don't show references on anon function (#198711)
Fixes #198389
2023-11-20 23:08:00 +01:00
Matt Bierner 6805bb6d2b
Hook up mapped code edits experiment for TS (#198478)
For https://github.com/microsoft/TypeScript/pull/55406
2023-11-17 02:07:09 +00:00
John Murray 77dc8793db
Add typescript.implementationsCodeLens.showOnInterfaceMethods setting (#136282) (#198419)
* Add `typescript.implementationsCodeLens.showOnInterfaceMethods` setting (#136282)

* Update codelenses when `typescript.referencesCodeLens.showOnAllFunctions` changes

* Improve handling of disposables
2023-11-16 22:46:41 +00:00
Matt Bierner d98713bad1
Always send CodeActionTriggerKind (#198364)
Makes us always send this along instead of sometimes sending undefined
2023-11-15 14:02:55 -08:00
Raymond Zhao e1c8870cd2
chore: bump vscode-tas-client (#198257) 2023-11-15 00:12:17 +01:00
Ronak Jain d72005bfa7
Fix tsconfig resolution for navigation (#192851)
* Fix tsconfig resolution

* Resolve based on link type
2023-11-06 11:46:09 -08:00
Matt Bierner c57992a973
Always run code lens implementations on semantic server (#197578)
Fixes #197286

Already fixed this for references code lens. Just porting it to impl code lens now too
2023-11-06 20:05:00 +01:00
Andrew Branch 48f4a503f8
Add missing preference description for preferTypeOnlyAutoImports 2023-11-03 12:57:23 -07:00
Logan Ramos 9bea1fc96a
Bump telemetry package (#197168) 2023-11-01 20:51:03 +01:00
Matt Bierner 0279c52a02
Switch back to node as default for moduleResolution (#197031)
Fixes #196554

Looks like bundler breaks `require()` intellisense
2023-10-31 00:40:44 +01:00
Andrew Branch 82ece597ee
Add setting for preferring type-only imports (#196123) 2023-10-30 18:14:58 +00:00
Joyce Er dedfcf65d3
feat: add enum descriptions for TS locale setting (#195947) 2023-10-19 01:52:49 +02:00
Yuto Liyosa 672033e151
Resolve absolute file target links in tsconfig (#195514) (#195759)
fix #195514 again
2023-10-18 00:23:59 +00:00
Greg Van Liew ef0871b7bb
Edits to setting descriptions (#195007) 2023-10-06 10:04:37 -07:00
Matt Bierner 6ebac1703b
Updated inferred JS/TS project config (#194847)
- Switch to target es2022 by default
- Also switch default module resolution to `bundler` if using more recent TS versions
2023-10-05 12:44:38 +02:00
Matt Bierner a12bb0543d
Restore copilot fixes/refactorings (#194092)
Reverts #193810 to restore #193810
2023-09-26 09:40:27 +02:00
Johannes Rieken b7fad0df6d
Revert "Copilot-based TS refactors" 2023-09-22 16:05:04 +02:00
Nathan Shively-Sanders d534d6b441 Tweak wording and position of copilot infer-types 2023-09-21 09:36:28 -07:00
Nathan Shively-Sanders a9a66e4dc3 Correct+customise copilot-specific titles 2023-09-21 09:25:11 -07:00
Nathan Shively-Sanders 32bb21550c Merge remote-tracking branch 'origin/main' into ai-codefixes 2023-09-21 08:40:31 -07:00
Nathan Shively-Sanders 1e7d82c778 Code correctly treats empty config as default-false 2023-09-21 08:37:51 -07:00
Nathan Shively-Sanders 6c154dd347 Mark quickfixes/refactors with Copilot: prefix 2023-09-20 15:37:34 -07:00
Logan Ramos cc98e55794
Fix slow telemetry module (#193607) 2023-09-20 20:14:12 +01:00
Nathan Shively-Sanders 530870bd40 Config: change defaults and add descriptions 2023-09-20 10:12:11 -07:00
Nathan Shively-Sanders ba511b36f1 Merge branch 'main' into ai-codefixes 2023-09-20 08:35:13 -07:00
Aiday Marlen Kyzy 0a45b2737a
typos 2023-09-15 15:13:50 +02:00
Nathan Shively-Sanders 968d1bd1bb Merge branch 'main' into ai-codefixes 2023-09-14 11:24:50 -07:00
Nathan Shively-Sanders d1d6055aa5 Add more complex options 2023-09-14 11:23:16 -07:00
Nathan Shively-Sanders b1b350626f Fix lints 2023-09-14 09:16:39 -07:00
Stephen Melvin 627cffc8ed
Fixed import paths not being updated when multiple files are moved (#191403)
* Modified updatePathsOnRename.ts to fix issue where import paths were not being updated when multiple files were moved.

* Removed errant console log

* Changed return statements to continue in for-of loop

---------

Co-authored-by: Stephen Melvin <steve.melvin@dtn.com>
2023-09-13 21:23:21 +00:00
Gabriela Araujo Britto f563e33800
[typescript-language-features] Add option for excluding library symbols in "Go to Symbol in Workspace" (#192798)
* add option for excluding library symbols

* clarify in message that new option requires ts 5.3

* remove expect error
2023-09-13 18:19:52 +00:00
Nathan Shively-Sanders 3328d54c89 Clean up for review
Remove unused, abandoned ideas.
2023-09-08 09:28:53 -07:00
Nathan Shively-Sanders 7906b2bb61 Merge branch 'main' into ai-codefixes 2023-09-07 10:46:52 -07:00
Nathan Shively-Sanders 9c5b16a444 Switch entirely to inline+action-based expansion
Except for a couple that still rely only on navtree-based expansion.
Lots of cleanup and standardisation.
2023-09-07 10:13:01 -07:00
Gabriela Araujo Britto efc1b30976
Add custom Node option to run TS Server (#191019)
* Add config for running tsserver on custom node

* log when custom node install is used

* create node version manager

* get node path from node version manager everywhere

* modify prompt

* fix useIpc

* use spawn for custom node and set windowsHide

* detect node

* link memory setting to node setting
2023-09-06 20:27:16 +00:00
Nathan Shively-Sanders a0a2cb4de0 Pretty good ranges based on RefactorInfo
Results are not pretty good yet. They are still below average.
2023-09-06 12:54:07 -07:00
Nathan Shively-Sanders 63c84d3aab Rest of useful codefixes
Initial hacky versions only
2023-08-31 16:15:04 -07:00
Matt Bierner 45e2e0bfd0
JS/TS package acquisition (#184438)
* Experiment with adding ata using `@types` packages shipped in an extension

* Use own file system instead of `https`

* JS/TS type support on web

* Tsconfig needs esModuleInterop not module:nodenext

We actually want webpack to emit commonjs, but need to write ES default
imports to use node-maintainer

* fix package.json indentation

* Adding setting to disable web type acquisition

* Fix merge of yarn lock

* Fixing merge errors

* Fixing errors

* Pick up package externally

* Fixing conflicts

* Bump version

---------

Co-authored-by: Kat Marchán <kzm@zkat.tech>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2023-08-28 00:49:40 -07:00
Nathan Shively-Sanders 2aaf53bc41 Support addNameToNamelessParameter, refactor copilot code
Not done switching quick fix code to use CompositeCommand instead of
passing a followup to ApplyCodeActionCommand.
2023-08-25 14:16:43 -07:00
Aiday Marlen Kyzy cb1cdd872d
Merge pull request #190485 from microsoft/aiday/telemetryDiagnosticData
Adding typescript diagnostic error codes in typescript extension
2023-08-25 08:43:40 +02:00
Logan Ramos ecb0c80fc1
Bump extension telemetry module (#191237)
* Bump extension telemetry module

* Fix webpack
2023-08-24 12:53:41 -07:00
Alexandru Dima 0783235efc
Merge branch 'main' into aiday/telemetryDiagnosticData 2023-08-24 12:00:25 +02:00
Aiday Marlen Kyzy a597b9044f
disposing the telemetry emitter 2023-08-24 11:01:47 +02:00
Aiday Marlen Kyzy ca86548968
changing from a js doc to a doc 2023-08-24 10:57:12 +02:00
Alpha Romer Coma 7ef754c2f6
Fix supported markdown-lint violations in markdown files (#190750)
docs: fix supported markdownlint violations
2023-08-24 08:37:25 +00:00
Matt Bierner bf9604c568
Add event for when inlay hints are provided (#191134) 2023-08-23 23:15:07 +01:00
Matt Bierner 557695b920
Fix inlay hint location (#191122) 2023-08-23 14:10:55 -07:00
Nathan Shively-Sanders 2267ba86a6 Support extract to function and type alias as well 2023-08-23 10:40:45 -07:00
Nathan Shively-Sanders ea5af2da03 Include selected expression in conversatin prompt 2023-08-23 09:57:26 -07:00
Nathan Shively-Sanders 81fad69af7 AI name suggestions in Extract Constant refactor 2023-08-22 16:29:26 -07:00
Aiday Marlen Kyzy 82cbf90600
clearing the timeout on dispose of the class 2023-08-22 09:43:11 +02:00
Aiday Marlen Kyzy 46ca479aa3
using a resource map now, need to normalize to a string? 2023-08-22 09:42:12 +02:00
Aiday Marlen Kyzy df5bf004f4
checking also that the file is of type typescriptreact 2023-08-22 09:33:41 +02:00
Aiday Marlen Kyzy 32c476a056
adding a comment right above the setting 2023-08-22 09:31:25 +02:00
Aiday Marlen Kyzy 5fbf0d2ed1
passing in instead the diagnostic collection 2023-08-21 17:42:44 +02:00
Aiday Marlen Kyzy fb4b533d93
extracting the method _increaseDiagnosticCodeCount to avoid duplication 2023-08-21 17:01:53 +02:00
Aiday Marlen Kyzy 8db8d30dfa
using the utility method equals 2023-08-21 16:56:13 +02:00
Aiday Marlen Kyzy cf21c24624
updating all the diagnostics after the timeout 2023-08-21 16:48:48 +02:00
Aiday Marlen Kyzy 76cc0881d3
using instead the uri string 2023-08-21 16:24:57 +02:00
Aiday Marlen Kyzy afcac53ae9
review comments 2023-08-18 14:59:44 +02:00
Aiday Marlen Kyzy 03f09a238c
adding a comment 2023-08-18 14:40:14 +02:00
Aiday Marlen Kyzy 1f86585b9b
remove the setting of 10000 for updating the diagnostics 2023-08-18 14:37:30 +02:00
Aiday Marlen Kyzy d56bd87a31
using instead the vscode Uri instead of the entity from vscode-uri 2023-08-18 14:35:17 +02:00
Aiday Marlen Kyzy 3e937b6a20
cleaning the code 2023-08-18 12:55:25 +02:00
Aiday Marlen Kyzy 1829704675
cleaning the code 2023-08-18 12:17:35 +02:00
Aiday Marlen Kyzy 008b00d24f
taking the diff between current and previous snapshot 2023-08-18 11:33:03 +02:00
Aiday Marlen Kyzy 81ae16ba6e
sending the telemetry event in a loop 2023-08-18 10:47:35 +02:00
Nathan Shively-Sanders 4cb0bc5b1c Clean up for PR 2023-08-17 09:26:06 -07:00
Aiday Marlen Kyzy 0d4db5ffc4
sending the diagnostics on handle exit 2023-08-17 14:35:27 +02:00
Aiday Marlen Kyzy 614bfb3d33
sending diagnostics on file open 2023-08-17 14:07:03 +02:00
Aiday Marlen Kyzy b4801aeb02
adding the data relative to the diagnostic error codes in the typescript extension 2023-08-15 12:20:02 +02:00
Nathan Shively-Sanders a288cbbdaf Merge branch 'main' into ai-inferFromUsage 2023-08-14 16:41:26 -07:00
Nathan Shively-Sanders 44375f76ca Offer infer-types quickfix separate from Typescript one 2023-08-14 10:48:18 -07:00
Vitaly 432aac18f1
[typescript] Better paths matching for move to existing file quickpick (#181231)
* Better paths matching for move to existing file quickpick

* fix resolving selected item

* fix: select file dialog point to existing file

* skip computing if
use coalesce

* Improve typings

---------

Co-authored-by: Matt Bierner <matb@microsoft.com>
2023-08-09 21:29:30 +01:00
Matt Bierner 4f66a0c2c1
Updating bundled and build TS versions (#189868) 2023-08-07 17:04:12 -07:00
Robo ea490e5545
chore: update to Electron 25 (#188268)
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-08-07 21:46:27 +09:00
Matt Bierner 3cc82327b5
Bump TS versions (#189344)
Bumps TS version for building VS Code
Bumps bundled TS version
2023-07-31 20:13:11 +01:00
Alexandru Dima f94dcb9ae0
Turn off aiQuickFix by default for stable (#189069) 2023-07-27 17:16:25 +01:00
Matt Bierner e2720e7bf4
Make getWorkspaceRootForResource work for notebook cells (#188186)
Fixes #186811
2023-07-19 05:29:22 +10:00
Matt Bierner 40abe0e1d5
Explicitly add link in JSDoc (#188182)
Fixes #188159
2023-07-18 11:15:14 -07:00
Andrew Branch 6c94c8e088
[typescript-language-features] Update autoImportFileExcludePatterns description (#186528)
Update autoImportFileExcludePatterns description
2023-07-14 18:36:38 +00:00
Matt Bierner c0d560ed49
Don't parse @link inside @example JSDoc tags (#187877)
Fixes #187768
2023-07-13 16:02:57 -07:00
Matt Bierner a4fde6f2eb
Add more specific error for TS web server (#187752)
This should help us better understand why the access failed
2023-07-12 14:09:01 -07:00
Raymond Zhao 5be539a588
Bump semver (#187654) 2023-07-12 01:49:45 +02:00
Matt Bierner 00105d2ddb
Exclude azurerepos: files from JS/TS intellisense (#187521)
Fixes #186385
2023-07-11 08:45:12 -07:00
dependabot[bot] 8c8e8600b6
Bump semver from 5.5.1 to 7.5.2 in /extensions/typescript-language-features (#185968)
Bump semver in /extensions/typescript-language-features

Bumps [semver](https://github.com/npm/node-semver) from 5.5.1 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v5.5.1...v7.5.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-10 10:05:01 +02:00
Nathan Shively-Sanders 5e72826c4c AI quickFix noImplicitAny: replaces inferFromUsage 2023-07-06 13:11:17 -07:00
Matt Bierner 688bc028e3
Extends tsconfig link logic to references paths (#186227)
Fixes #182898
2023-06-26 14:55:10 -07:00
Johannes Rieken 50ad64e844
enable inline chat quick fix for TypeScript implements interface by default (#186167) 2023-06-26 17:34:39 +02:00
Matt Bierner 5ee455116f
Add codeql comments and small fix (#185931) 2023-06-23 02:40:39 +02:00
Matt Bierner 3a02b99fe8
Try to request workspace content caching on commit (#185920)
For #175972

Here's what believe is happening:

- Workspace opens. We download the archive for the current commit
- User makes a commit
- The commit has now changed, which invalidates the archive. However TS doesn't know this (all the uris seem to stay the same). This means that we silently start going to the network again on file system operations

To fix this, we're going to try re-requesting the archive when a file system change event is fired for the workspace root. This should happen when a commit is made
2023-06-22 15:33:06 -07:00
Matt Bierner 538da53226
Dispose of file watchers when web TS server exits (#185815)
Dispose of file watchers when TS server exits
2023-06-21 17:14:21 -07:00
Matt Bierner e30b2359c5
Add logging for TS extension file watcher creation (#185813)
Add logging for extension file watcher creation
2023-06-21 15:36:39 -07:00
Matt Bierner 1eabca5501
Support downloading repo contents for all github authorities (#185707)
For #175972

Previously this was broken for `github%2b...` style authorities
2023-06-20 15:19:11 -07:00