development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add more specific error for TS web server (#187752)

Browse source 
This should help us better understand why the access failed
This commit is contained in:
Matt Bierner 2023-07-12 14:09:01 -07:00 committed by GitHub
parent 14b9b06a74
commit a4fde6f2eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
extensions/typescript-language-features/web/webServer.ts
View file

@ -76,6 +76,15 @@ function toTsWatcherKind(event: 'create' | 'change' | 'delete') {
throw new Error(`Unknown event: ${event}`);
}
class AccessOutsideOfRootError extends Error {
constructor(
public readonly filepath: string,
public readonly projectRootPaths: readonly string[]
) {
super(`Could not read file outside of project root ${filepath}`);
}
}
type ServerHostWithImport = ts.server.ServerHost & { importPlugin(root: string, moduleName: string): Promise<ts.server.ModuleImportResult> };
function createServerHost(extensionUri: URI, logger: ts.server.Logger, apiClient: ApiClient | undefined, args: string[], fsWatcher: MessagePort): ServerHostWithImport {
@ -455,7 +464,7 @@ function createServerHost(extensionUri: URI, logger: ts.server.Logger, apiClient
}
if (allowRead === 'block') {
throw new Error(`Could not read file outside of project root ${filepath}`);
throw new AccessOutsideOfRootError(filepath, Array.from(projectRootPaths.keys()));
}
return uri;