Commit graph

136 commits

Author SHA1 Message Date
Aaron Munger af972cc9e6
Merge pull request #180569 from microsoft/aamunger/outputAccessibility
ensure the focus is actually set to the correct output
2023-04-24 16:32:39 -07:00
Aaron Munger 7c07ee8949
Merge pull request #180753 from microsoft/aamunger/truncationMessage
fix message formatting
2023-04-24 14:32:47 -07:00
aamunger 53b0058b13
fix message formatting 2023-04-24 14:17:44 -07:00
aamunger 4602cf075a
fix class selection query 2023-04-24 14:05:27 -07:00
Aaron Munger 3897a9cafb
Merge branch 'main' into aamunger/outputAccessibility 2023-04-24 12:53:28 -07:00
aamunger 59ef73fea3
check the scroll height of the correct element 2023-04-24 11:23:25 -07:00
aamunger 33c124ca7e
split out event propagation handling 2023-04-24 08:55:01 -07:00
aamunger 31cd1ee042
ensure focus is set correctly in output, enable keyboard scrolling for outputs 2023-04-21 13:26:35 -07:00
Raymond Zhao 8e89509008
Fix notebook-renderers compile error (#179506) 2023-04-10 10:01:12 -07:00
aamunger c21478e430
small padding 2023-04-05 11:08:09 -07:00
aamunger c60f757130
updated truncation comment styling 2023-04-05 11:08:08 -07:00
aamunger d722674f02
updated comment 2023-04-05 11:08:06 -07:00
aamunger b7a495cdb8
adjust output truncation message 2023-04-05 11:08:04 -07:00
aamunger 8d55402690
toggle scrollable outputs by cell 2023-04-05 11:08:01 -07:00
aamunger b0459b7b45
add aria-label to link 2023-03-21 15:09:53 -07:00
aamunger bd6f853061
wrap errors in parent div 2023-03-20 16:40:02 -07:00
aamunger 26c7018f95
style the cursor in the child to avoid the scrollbar 2023-03-20 16:40:00 -07:00
Aaron Munger 0a15931b49
Merge pull request #177537 from microsoft/aamunger/updateScrolling
show message to refresh if scrolling is enabled and not scrollable
2023-03-20 08:56:58 -07:00
aamunger a0a6fd1a35
show message to refresh if scrolling is enabled and not scrollable 2023-03-17 15:39:36 -07:00
aamunger d02908f51c
change cursor style over output 2023-03-17 12:50:18 -07:00
aamunger 859ffaca34
await promises 2023-03-16 14:49:14 -07:00
aamunger 7c610d1a4c
typo 2023-03-16 12:11:46 -07:00
aamunger 11c5e141ab
added notebook output renderer tests 2023-03-16 12:10:24 -07:00
aamunger 11eefc95cb
fixed alias 2023-03-14 16:38:37 -07:00
aamunger b8728a5e06
fixed word wrap 2023-03-14 16:24:41 -07:00
aamunger e703b05738
plain text rendering, more streaming consolidation 2023-03-14 15:28:24 -07:00
aamunger 51f2dc8d46
fixed styling on stream and errors 2023-03-14 15:28:23 -07:00
aamunger db07a2b60a
updated stream output to consolidate correctly 2023-03-14 15:28:23 -07:00
aamunger 39c8e79b13
simplify generated html 2023-03-14 15:28:21 -07:00
aamunger ec47753952
dispose of scroll event listener 2023-03-08 15:43:05 -08:00
aamunger 605bde227c
cleaner element selection, add css shadow 2023-03-08 14:44:15 -08:00
aamunger 01abe31271
more precise scroll top extraction 2023-03-08 11:25:18 -08:00
aamunger a0dee86464
don't look for scroll height if scrolling is disabled 2023-03-07 11:01:28 -08:00
aamunger 4b6837ca34
scroll to the bottom of scrollable outputs 2023-03-07 10:53:23 -08:00
aamunger 770db8e512
make error outputs scrollable with output scroll setting 2023-03-06 14:28:15 -08:00
Peng Lyu 2552748fc6
Re #174908. Allow renderers to respond to settings change. (#175606) 2023-02-28 08:37:18 -08:00
aamunger a1665b75bf
put open new editor link outside of scrollable div 2023-02-16 15:56:32 -08:00
Peng Lyu 6b45fd4bff
Polish default line wrap in text/error output (#174615) 2023-02-16 20:36:12 +01:00
Peng Lyu 9570a06456
Fix #174393. Clear error container. (#174494) 2023-02-15 20:55:31 +01:00
Peng Lyu 9d8b738122
Fix microsoft/vscode-jupyter#12842. Add output text word wrap setting. (#174384) 2023-02-14 19:43:27 +01:00
aamunger f1e7784c53
div outputs scrollable, register scroll setting 2023-01-17 15:46:47 -08:00
Peng Lyu 7ab8a39a89
Fix #132143. Softer image update on rerun. (#170917)
* Fix #132143. Softer image update on rerun.

* Output raw data update required.
2023-01-10 10:16:59 -08:00
Peng Lyu 44caddbba3
Fix #170683. Only disable word wrap for traceback. (#170709) 2023-01-06 10:30:45 -08:00
Peng Lyu 90277d5c56
Fix #170263, do not parse html for stream output. (#170264) 2022-12-30 08:05:30 +01:00
Peng Lyu aa2bb7034c
Support horizontal scrolling for error output (#170132) 2022-12-27 23:33:52 +01:00
Peng Lyu 42814d18a7
Fix #160745. Fix streaming output styling and duplicates. (#169792) 2022-12-21 20:58:23 -08:00
Peng Lyu f2e35ef4ce
Re #131239. Add html link and auto link detection support. (#169577) 2022-12-19 22:55:35 +01:00
Peng Lyu d4533c71ed
Link support for notebook output. re microsoft/vscode-jupyter#12285 (#169565)
* Link support for notebook output. re microsoft/vscode-jupyter#12285

* Resolve comments
2022-12-19 11:19:57 -08:00
aamunger 6ef30eeaba
fix line breaks in output 2022-11-18 10:18:33 -08:00
aamunger 708ec07316
thin border, no word wrap 2022-11-17 15:50:25 -08:00
aamunger b3f3de9cfe
border around scrollable area 2022-11-17 15:08:51 -08:00
aamunger 457e4d29da
update css selectors 2022-11-17 15:08:50 -08:00
aamunger 7b5a16bdd1
adjustable output height 2022-11-17 15:08:49 -08:00
aamunger d3351f8606
add box shadow for scrolling 2022-11-17 15:08:48 -08:00
aamunger 9f56904138
styling 2022-11-17 15:08:46 -08:00
aamunger a7997f050b
typed options 2022-11-17 15:08:44 -08:00
aamunger d7c8a6c272
css change to scroll output 2022-11-17 15:08:29 -08:00
Matt Bierner 186d3415a3
Use ??= in more places (#163594) 2022-10-13 14:59:35 -07:00
Don Jayamanne c6698eaced
Pass element to the JS preEvaluate renderer hook (#160851) 2022-09-14 17:21:48 -07:00
Matt Bierner a77d1c2563
Add JS notebook renderer hook (#160453)
Fixes #160451
2022-09-08 15:37:24 -07:00
Matt Bierner f4f68a568d
Make default JS renderer treat js as modules (#160347)
Fixes #157076
2022-09-08 06:47:01 +10:00
Matt Bierner 07025f0b0d
Remove notebook editor edit api (#158988)
Fixes #149181
2022-08-29 09:34:57 -07:00
Matt Bierner 8f4d1a97f3
Clean up HtmlRenderingHook (#154961)
- Pass `HtmlRenderingHook` to hook
-  Rename register function to make it clear it is experimental
- Add docs
2022-07-12 11:27:47 -07:00
Matt Bierner 82687c84ee
Add hook for extending built-in html renderer (#154316)
Fixes #153836

Lets extension register a hook that is invoked after the html element is renderered
2022-07-11 08:21:02 -07:00
Raymond Zhao 5f0a3888b4
Fix command encoding. Fixes #151364 (#152896) 2022-06-22 14:12:32 -07:00
Johannes 0656d21d11
auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Matt Bierner 45304da73d
Finalize NotebookEditor api proposal (#149767)
* Finalize NotebookEditor api proposal

Fixes #149271

This finalizes most parts of the NotebookEditor api proposal. I haven't removed the proposal entirely as there are still a few parts being left behind:

- The deprecated properties/functions
- A few contribution points such as `notebook/cell/executePrimary`

* remove extra quote
2022-05-23 23:27:17 +00:00
Rob Lourens a49e21c63b
Fix notebook output double spacing (#149842)
Fixes #149563
2022-05-18 15:37:22 -07:00
aamunger 9a87fe7eaf
added setting for notebook output line height 2022-04-13 09:12:28 -07:00
rebornix 0a2707bbf0
fix #146397. Clear container for html and plain text renderer. 2022-03-31 14:00:34 -07:00
rebornix 53c9e8e6b3
fix #142184. 2022-03-28 10:35:42 -07:00
Matt Bierner 2edb9bc9ca
Reapply parcel/watcher adoption
Revert "Revert e7fffbf1c9169087f1098aedfe54c59c079fa3ac"

This reverts commit 6786b0ad7d.

Two changes:

- Lazy import parcel/watcher
- Add `@parcel/watcher` as a dev dep in extensions folder so that we pull in correct version for build os
2022-03-24 14:13:39 -07:00
Dirk Baeumer 6786b0ad7d
Revert e7fffbf1c9 2022-03-24 09:04:05 +01:00
Matt Bierner e7fffbf1c9
Use parcel for watching esbuild build files
Seeing small but consistent cpu usage when using esbuild's watcher. Switch to parcel to avoid this
2022-03-23 14:49:59 -07:00
rebornix 9d673ebe34
FIX #144343. Update output items will re-render the cell output. 2022-03-18 10:50:50 -07:00
Matt Bierner eaf352e6d1
Hook up watch properly for extension build scripts 2022-03-08 17:54:16 -08:00
rebornix 4a6763d8d5
support more styles in ansi. 2022-03-02 11:56:21 -08:00
Martin Aeschlimann db9e8fba63 remove unecessary files in build 2022-02-18 20:38:55 +01:00
rebornix 8eb145d146
fix #143194 2022-02-16 16:09:03 -08:00
rebornix a785b7bae8
styling update and link handling for show more outputs 2022-02-08 14:52:11 -08:00
rebornix 86a9cf439d
pass line limit setting to output renderer 2022-02-08 13:12:32 -08:00
rebornix d5d7e03cfc
Move stream renderer to extension, support merging. 2022-02-08 12:54:56 -08:00
rebornix c70522765b
re #142429. error output w/ dup ansi handling 2022-02-07 16:07:04 -08:00
rebornix 88e5c12d3d
re #142429. javascript renderer 2022-02-07 14:06:35 -08:00
rebornix ac308c3e03
re #142429. html/svg renderer 2022-02-07 13:58:30 -08:00
rebornix f2b7964599
re #142429. Image renderer moved to extension. 2022-02-07 12:49:20 -08:00