development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

more precise scroll top extraction

Browse source
This commit is contained in:
aamunger 2023-03-08 11:25:18 -08:00
parent 4b154b8696
commit 01abe31271
No known key found for this signature in database
GPG key ID: F2CA0C6303FC6B74
1 changed files with 10 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
extensions/notebook-renderers/src/index.ts
View file

@ -223,20 +223,15 @@ function appendChildAndScroll(container: HTMLElement, child: HTMLElement, scroll
});
}
// Find the scrollTop of the existing scrollable output, return undefined if at the bottom
function findScrolledHeight(outputContainer: HTMLElement): number | undefined {
let result: number | undefined;
outputContainer.childNodes.forEach((output) => {
output.childNodes.forEach((node) => {
if (node instanceof HTMLElement && node.classList.contains(scrollableClass)) {
if (node.scrollHeight - node.scrollTop - node.clientHeight > 2) {
// not scrolled to the bottom
result = node.scrollTop;
}
}
});
});
return result;
// Find the scrollTop of the existing scrollable output, return undefined if at the bottom or element doesn't exist
function findScrolledHeight(outputContainer: HTMLElement, outputId: string): number | undefined {
const output = outputContainer.querySelector(`[output-item-id="${outputId}"]`);
const scrollableElement = output?.querySelector('.scrollable');
if (scrollableElement && scrollableElement.scrollHeight - scrollableElement.scrollTop - scrollableElement.clientHeight > 2) {
// not scrolled to the bottom
return scrollableElement.scrollTop;
}
return undefined;
}
function renderStream(outputInfo: OutputItem, container: HTMLElement, error: boolean, ctx: IRichRenderContext): IDisposable {
@ -275,7 +270,7 @@ function renderStream(outputInfo: OutputItem, container: HTMLElement, error: boo
const text = outputInfo.text();
insertOutput(outputInfo.id, [text], ctx.settings.lineLimit, outputScrolling, element, false);
const scrollTop = outputScrolling ? findScrolledHeight(container) : undefined;
const scrollTop = outputScrolling ? findScrolledHeight(container, outputInfo.id) : undefined;
while (container.firstChild) {
container.removeChild(container.firstChild);
}