isidor
c7fd9d6110
rawDebugSession: remove public keyword - it is just noise
2019-06-12 17:17:12 +02:00
Johannes Rieken
c5bddfa5c2
fix #75344
2019-06-12 17:03:42 +02:00
Sandeep Somavarapu
aded4e0310
revert moving to browser
2019-06-12 17:01:37 +02:00
Sandeep Somavarapu
9f3bb89b85
Move to browser namespace
2019-06-12 16:52:47 +02:00
Sandeep Somavarapu
92fed79878
#74846 Dispose internal commands
2019-06-12 16:49:10 +02:00
Sandeep Somavarapu
1bf2cab772
Move extension actions to browser namespace
2019-06-12 16:49:10 +02:00
isidor
d6555ce5fd
remove heap import no longer needed since it is removed
2019-06-12 16:32:57 +02:00
Johannes Rieken
a7d510160d
better workaround for #75106
2019-06-12 16:30:28 +02:00
Johannes Rieken
5b450a45b3
Revert "only dispose completion model when dispose suggest logic or when re-triggering, #75106 "
...
This reverts commit 238a8521bc
2019-06-12 16:23:22 +02:00
Johannes Rieken
34c1f859cf
remove gc-signals, heapservice, and mainThreadHeapService, #74846
2019-06-12 16:20:49 +02:00
Johannes Rieken
238a8521bc
only dispose completion model when dispose suggest logic or when re-triggering, #75106
2019-06-12 16:11:21 +02:00
isidor
a3baa1e2ee
explorer: polish drag n drop
2019-06-12 16:08:46 +02:00
Andre Weinand
fd05938a6d
properly quote empty arguments; fixes #25098
2019-06-12 15:57:59 +02:00
Joao Moreno
08bb5a13c0
use toInternal2
...
related to #74846
2019-06-12 15:19:44 +02:00
Joao Moreno
4e7545ba8a
Merge branch 'pr/69763'
2019-06-12 12:41:39 +02:00
Joao Moreno
718f19e8ab
💄
2019-06-12 12:40:16 +02:00
Isidor Nikolic
46a9c6d481
Merge pull request #75273 from microsoft/isidorn/workspaceRemoteLimit
...
Do not allow workspace folders with scheme different than the current…
2019-06-12 12:37:05 +02:00
Joao Moreno
fee4ee0df8
Merge commit 'refs/pull/69763/head' of github.com:Microsoft/vscode into pr/69763
2019-06-12 12:35:24 +02:00
Erich Gamma
632564ba5e
update distro
2019-06-12 12:22:40 +02:00
isidor
175580a76d
better error handling
2019-06-12 12:16:29 +02:00
Joao Moreno
b485ffb756
fix git nls
2019-06-12 12:02:58 +02:00
Joao Moreno
bcca26e3e2
Merge remote-tracking branch 'origin/master'
2019-06-12 12:02:48 +02:00
Joao Moreno
0403d69e75
use FalseContext, change Download Update label
2019-06-12 12:02:22 +02:00
Benjamin Pasero
99a599ecbb
update distro
2019-06-12 11:58:44 +02:00
Joao Moreno
0337567dfc
Merge commit 'refs/pull/75300/head' of github.com:Microsoft/vscode into pr/75300
2019-06-12 11:36:51 +02:00
Joao Moreno
4a3c056e9a
use --follow-tags instead of --tags when pushing
...
fixes #70081
fixes #75240
2019-06-12 11:06:54 +02:00
Johannes Rieken
8af1f7ebe8
no breadcrumbs for untitled files, #74924
2019-06-12 10:42:43 +02:00
Joao Moreno
13d0dad699
fix #41085
2019-06-12 10:38:35 +02:00
Johannes Rieken
622f08313b
Merge pull request #75286 from mjbvz/mutable-disposable-in-code-lens-controller
...
Use MutableDisposable in codeLensController
2019-06-12 10:01:48 +02:00
Sandeep Somavarapu
8a71ad8a10
add implements IWorkbenchContribution
2019-06-12 08:38:14 +02:00
Sandeep Somavarapu
2241c0f849
Adopt update actions to use globalActivity menuId
2019-06-12 08:35:44 +02:00
Matt Bierner
8de74d9255
Extracting common webview elements
...
Minimizing diff with the iframe based webview branch
2019-06-11 22:45:55 -07:00
malingyan2017
39947c7250
Fix Recent list in dock does not show recent files/folders #74788 ( #75108 )
...
* Fix Recent list in dock does not show recent files/folders #74788
macOS only shows recent list with max number based on sytem config. It takes bottom n entries from the list added through Electron app.addRecentDocument. To match macOS dock recent list with VSCode internal recent list, this change add items into macOS recent document list in reverse order of internal recent list.
* remove dock recent entries limit
* add entry of folder (5) back to allow show some files
* fix showsing wrong folders in recentlist
* simplify adding platform RecentDocument in macOS
* update based on bpasero suggestion
* set max entries
* rename macro
2019-06-12 07:29:27 +02:00
Matt Bierner
f291714906
Use undefined instead of null for IStatusbarEntryAccessor
2019-06-11 17:14:21 -07:00
Matt Bierner
1b95baa48b
Use MutableDisposable for tracking current code actions
2019-06-11 17:03:44 -07:00
Matt Bierner
9c14fecc87
Prevent dispose cycles
...
For #75304
Make sure we do not get into a loop of tyring to dispose of an object by checking `isDisposed` before calling into dispose again
Also log if you try to register a disposeable on itself
2019-06-11 16:48:55 -07:00
Sandeep Somavarapu
0e38ce807c
adopt online services settings entry
2019-06-11 22:45:45 +02:00
Sandeep Somavarapu
1f68acb368
Merge branch 'master' into sandy081/globalActivity
2019-06-11 22:41:44 +02:00
Rachel Macfarlane
af39a4d4fb
Expose command to open settings page with online services query from gear menu and preferences menu, fixes #75215
2019-06-11 11:34:08 -07:00
Miguel Solorio
94b23bc6c4
Fix #75187 , reduce width of find widget text
2019-06-11 10:55:16 -07:00
Sandeep Somavarapu
298b40cd8c
remove ref to css
2019-06-11 19:34:18 +02:00
Sandeep Somavarapu
27c448d032
update distro
2019-06-11 19:27:41 +02:00
Sandeep Somavarapu
59c79b84e3
#75079 Support keybindings resource
2019-06-11 19:27:10 +02:00
Matt Bierner
15f6609e3f
Use MutableDisposable in codeLensController
...
The `MutableDisposable` class represents a disposable value that can be changed. The class automatically disposeds of the old value when a new one is set, which can prevent a common programming mistake. `MutableDisposable` is useful in places we are currently using `private property?: IDisposable`.
This change uses a `MutableDisposable` to manage the code lens model.
2019-06-11 10:26:53 -07:00
Matt Bierner
65f4b4a159
Use MutableDisposable in a few more places
2019-06-11 10:20:31 -07:00
Matt Bierner
bf815f4cc2
Adding MutableDisposable
...
This class can help manage a disposable property that is optional or may be changed. It prevents errors when you forget to release the previously held disposable when setting a new one
2019-06-11 10:20:31 -07:00
Matt Bierner
728ace5370
Use DisposableStore
2019-06-11 10:20:31 -07:00
Matt Bierner
7806b147f5
Highlight example as json in editor
2019-06-11 10:20:31 -07:00
Sandeep Somavarapu
6150587c12
Use menu registry for global activity actions
2019-06-11 19:13:43 +02:00
Benjamin Pasero
29dadcc476
debt - ensure to dispose action toolbar of editor group view
2019-06-11 18:41:33 +02:00
