Commit graph

120367 commits

Author SHA1 Message Date
Daniel Imms a8bd1338de
Migrate rest of TerminalConfigHelper to TerminalConfigurationService
Fixes #181900
2024-04-01 13:11:19 -07:00
Connor Peet 87780c04c8
eng: fix CSS tooling crashes watch task (#209278)
Get rid of the gulp-postcss plugin and just implement our own, I couldn't get it to work.

Fixes #207827
2024-04-01 20:15:25 +02:00
Daniel Imms aac8155100
Merge pull request #209271 from microsoft/tyriar/xterm_private
Remove usage of several xterm private APIs
2024-04-01 10:44:36 -07:00
Daniel Imms 8bdc74cd9e
Merge pull request #209277 from microsoft/tyriar/209275
Remove xterm canvas renderer from fallback logic
2024-04-01 10:42:55 -07:00
Daniel Imms 596ee31f6c
Remove xterm canvas renderer from fallback logic
This simplifies things a lot, the plan is to remove the canvas renderer
completely from VS Code if all goes well (#209276).

Fixes #209275
2024-04-01 10:25:33 -07:00
Aaron Munger 16a39cb720
De-select output for focus cell container commands (#209269)
* pass message to de-select when container is selected from output

* clear selection in more cases
2024-04-01 10:24:08 -07:00
Connor Peet e169401ec2
testing: fix testing-coverage-lineHeight being marked as a color (#209273) 2024-04-01 19:22:09 +02:00
Megan Rogge b85a65938a
Merge pull request #209266 from microsoft/merogge/alpha-sounds
order sounds/announcements in quick pick alphabetically
2024-04-01 10:17:58 -07:00
Megan Rogge e4f949b7d5
Merge pull request #209270 from microsoft/merogge/qp-bug
fix accessibility signal qp bug
2024-04-01 10:07:41 -07:00
Daniel Imms ee7fe25638
Remove hack for canvas to force a refresh
I can no longer reproduce this issue and it was a big hack regardless.
Will track issues for any mentioned of bad resizes on the canvas
renderer.
2024-04-01 10:07:33 -07:00
Daniel Imms 7733a6a12b
Merge pull request #209261 from microsoft/tyriar/181900_2
Move terminal WSL recommendation into a workbench contrib
2024-04-01 10:07:13 -07:00
Daniel Imms 64aa2c302f
Remove unused event emitter type 2024-04-01 10:04:04 -07:00
Daniel Imms ad545a18d3
Remove unneeded lint suppression 2024-04-01 10:02:05 -07:00
Megan Rogge 081be73a38
Merge branch 'main' into merogge/alpha-sounds 2024-04-01 10:01:55 -07:00
Daniel Imms cdbe485a21
Remove _charSizeService access 2024-04-01 10:01:02 -07:00
Daniel Imms b6afddd5c5
Remove _onKey access 2024-04-01 10:00:42 -07:00
Matt Bierner cb83e0b39b
Don't use stateful regex (#209268)
Fixes #209254
2024-04-01 19:00:16 +02:00
Daniel Imms 28d47a5695
Remove _onData access 2024-04-01 09:59:26 -07:00
Daniel Imms 34bc7d4da6
Make types more correct 2024-04-01 09:57:01 -07:00
Daniel Imms 156db3ec27
Remove xterm triggerDataEvent private API usage 2024-04-01 09:56:15 -07:00
meganrogge 3dc6e72b58
clean up 2024-04-01 09:51:17 -07:00
Daniel Imms ee037b328f
Merge branch 'main' into tyriar/181900_2 2024-04-01 09:40:56 -07:00
meganrogge e349ecf688
move a line 2024-04-01 09:34:47 -07:00
meganrogge 9223965e42
fix #207946 2024-04-01 09:33:28 -07:00
Daniel Imms fd5ac01c55
Merge pull request #209258 from microsoft/tyriar/181900
Introduce ITerminalConfigurationService, move TerminalConfigHelper.config to it
2024-04-01 09:31:39 -07:00
Matt Bierner be1efcc505
Pick up latest TS for building VS Code (#209265) 2024-04-01 18:31:02 +02:00
Daniel Imms 9d6ef1bbe2
Merge branch 'tyriar/181900' into tyriar/181900_2 2024-04-01 09:19:43 -07:00
Daniel Imms 8a1fc77e7d
Fix tests for reals this time 2024-04-01 09:16:43 -07:00
Matt Bierner 8460b73ac4
Enable dnd in chat references list (#209263) 2024-04-01 18:15:11 +02:00
meganrogge 57847a545f
fix #209167 2024-04-01 09:14:30 -07:00
Daniel Imms e441414da2
Merge branch 'tyriar/181900' into tyriar/181900_2 2024-04-01 08:46:29 -07:00
Daniel Imms 24d832b639
Fix XtermTerminal.test 2024-04-01 08:46:13 -07:00
Daniel Imms 63d95c152b
Fix tests 2024-04-01 08:43:48 -07:00
Daniel Imms 4e62462ba7
Move wsl recommendations out of config helper and into contribution
Part of #181900
2024-04-01 08:37:48 -07:00
Tyler James Leonhardt 6394792f56
Include Command Description in _getAllCommands (#209260)
This is important information for the command so we should include it in this response.
2024-04-01 17:33:19 +02:00
Daniel Imms bf9f038606
Merge pull request #209118 from microsoft/tyriar/199964
Use IconSelectBox to change terminal icon, remove dupes
2024-04-01 08:32:50 -07:00
Daniel Imms a73b0e7baf
Fix leak in terminalConfigHelper.test 2024-04-01 08:13:28 -07:00
Tyler James Leonhardt ade21d7359
Pick up editor action command descriptions (#209259)
Continuation of https://github.com/microsoft/vscode/pull/193937 and https://github.com/microsoft/vscode/pull/197442

This adds the command descriptions of editor actions to the ICommandQuickPick results so that those results can be picked up by the "similar commands" feature.

Example:

I can add:
```
metadata: {
    description: nls.localize2('test', "xyz"),
}
```
to the [AddLineCommentAction](7d788e70b9/src/vs/editor/contrib/comment/browser/comment.ts (L105))... and then when I search "xyz" it'll show up.
2024-04-01 08:07:37 -07:00
Daniel Imms 343c37d37f
Test for TerminalConfigurationService 2024-04-01 06:11:59 -07:00
Daniel Imms 73d8189a3b
Init TerminalConfigurationService 2024-04-01 05:58:17 -07:00
Daniel Imms f7937cc5cf
Remove ITerminalConfigHelper.config completely
Part of #181900
2024-04-01 05:56:43 -07:00
Daniel Imms 868b8ef95a
Move more to terminal config service 2024-04-01 05:54:44 -07:00
Daniel Imms 2edf458471
Adopt terminal config service in more files 2024-04-01 05:49:48 -07:00
Daniel Imms 53e5c75dd4
Adopt terminal config service in terminalEditor 2024-04-01 05:46:44 -07:00
Daniel Imms 8317e8a686
Adopt terminal config service in terminalActions 2024-04-01 05:45:02 -07:00
Daniel Imms 714d93901b
Docs 2024-04-01 05:41:43 -07:00
Daniel Imms eb10cea101
Introduce ITerminalConfigurationService
Part of #181900
2024-04-01 05:37:04 -07:00
Matt Bierner 7d788e70b9
Limit drop disablement to just http(s) uris (#209240)
For #209239
2024-04-01 04:37:06 -07:00
Daniel Imms 511929fc52
Remove other icon smoke tests 2024-04-01 04:35:44 -07:00
Daniel Imms af3e721996
Merge branch 'main' into tyriar/199964 2024-04-01 04:34:54 -07:00