Commit graph

55933 commits

Author SHA1 Message Date
Alex Ross a0bc43dd73 Update grammars 2019-10-21 11:21:03 +02:00
Alex Ross fd2133691a Fix tasks depends on for tasks while in a workspace
Fixes #82938
2019-10-21 10:53:48 +02:00
isidor 0bf0936b81 fixes #82863 2019-10-21 10:37:34 +02:00
Andrew Liu 6bba03b84f Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks (#82757)
fixes #30419 and fixes #80649
2019-10-21 10:35:06 +02:00
Matt Bierner 82ca6ba87f document that suggest.names doesn't work with checkjs
Fixes #81895
2019-10-19 16:19:35 -07:00
Matt Bierner cbda1fdeb7
Fix drag and dropping of editors for webviews (#82813)
* Fix drag and dropping of editors for webviews

Fixes #25854

This change does the following:

- Have the webview editor create an `EditorDropTarget`. This is required because the webview itself is not part of the normal editor dom (it exists as a top level node in the workbench so that we never reparent it). This means that the standard `EditorDropTarget` does not work.

- Make webviews set `pointer-events: none` while a drag is happening. When a drag happens on Electron's webviews or a normal iframe, no  drag and drop events seem to get generated. The fix is to set `pointer-events: none` while the drag is happening. But it's also difficult to detect when the drag is happening because the  `EditorDropTargets` class eats the drop event itself. The only reliable seeming way I could find to determine when a drag starts and ends is looking at global events on the window.

This workaround is pretty ugly. I'm not sure if there's some better approach that would work with webviews

* Add public `createDropTargets` helper on editorPart

Unfortunatly we can't add this method to IEditorGroupsService as it uses the `HTMLElement` type

* Rename function to createEditorDropTarget

* Use instanceof instead of cast
2019-10-19 09:41:21 -07:00
Matt Bierner bd200eafd1 Add configuration for includeAutomaticOptionalChainCompletions
For https://github.com/microsoft/TypeScript/pull/34552
2019-10-18 22:00:11 -07:00
SteVen Batten 2710db93e2 fixes #70893 2019-10-18 18:08:03 -07:00
Rob Lourens dfaff021a8 Let ListWidget's reveal take no action if the revealed element is already overflowing the viewport
Fix #78237
2019-10-18 17:03:44 -07:00
Rob Lourens a9640d05a2 Fix gear icon cut off in settings editor sometimes
Fix #81764
2019-10-18 17:03:44 -07:00
Matt Bierner 693ffb4d57 Default maxTsServerMemory to 3GB 2019-10-18 16:14:48 -07:00
Matt Bierner 2a46387970 Use test instead of match 2019-10-18 16:14:48 -07:00
Matt Bierner 035963b1f1 Add basic pinning test for jsdoc completions
For #82874
2019-10-18 16:14:48 -07:00
SteVen Batten 81d1db9295 remove special case of titlebar visibility change 2019-10-18 15:38:49 -07:00
SteVen Batten c805ab792e centralize part visibility eventing
add context key for editor area visible
fixes #67707
2019-10-18 15:38:48 -07:00
Rob Lourens b3eb413eaf Fix refiltering when switching scopes with a search.
Fix #79987
2019-10-18 15:08:42 -07:00
Matt Bierner e86b622a2f Update monaco for TS 3.7 2019-10-18 14:44:17 -07:00
Matt Bierner 564d47339f Convert to async 2019-10-18 14:36:21 -07:00
Matt Bierner a64ca747fb Merge multiple triggers for parameter hints instead of always using latest
Fixes #82825
2019-10-18 14:36:21 -07:00
Matt Bierner 34e6f94afa Add try catch logging to parameter hints in tests 2019-10-18 14:36:21 -07:00
Eric Amodio abca16d16a Update distro 2019-10-18 17:14:01 -04:00
Eric Amodio 6f21fd7053 xterm@4.2.0-beta20
Diff: eb25243...6311076

    - Tests
    - Adds scrollSensitivity option for scrolling speed
2019-10-18 17:04:03 -04:00
Rob Lourens 207a56ee2c Add debounce for schema changes to fix slowness when launching with the settings editor persisted open 2019-10-18 12:35:00 -07:00
Rob Lourens 3006b97f30 When a search query is persisted set up the search
before the initial render, so we will only render once
when we get the search results.
Also, have to be sure to retrigger search whenever there is a
schema change so extension results show up
Fix #79989
2019-10-18 12:35:00 -07:00
Rob Lourens 7df5a0cff2 Fix #79293 2019-10-18 12:35:00 -07:00
SteVen Batten 207a00c7f6 string update 2019-10-18 11:44:56 -07:00
Daniel Imms 2284f76f2b Update distro 2019-10-18 10:48:35 -07:00
Daniel Imms 9f25911d3b xterm-addon-web-links@0.2.1
Fixes peer dependency warning on yarn
2019-10-18 10:43:52 -07:00
Daniel Imms 6bc460f9ab xterm@4.2.0-beta18
Diff: 91cbeec...eb25243

- Error telemetry fixes, fixes #82309
- comma, colon and semi-colon as word separators, fixes #82173
- Dev container fixes
- Fix scrollback going missing on Windows/conpty, fixes #78634
- Automation improvements
2019-10-18 10:42:04 -07:00
Rob Lourens 0d7c1e4265 Fix inconsistent setting search results with exact match
Always ignore remote results when an exact match is found. Also get rid of cached new extension results on each search
Fix #78455
2019-10-18 09:36:35 -07:00
Rob Lourens 7460d86cc6 Add remotePathService to workbench.common.main 2019-10-18 09:09:14 -07:00
Alex Ross 7f21095d16 Add a notification for slow task providers
Fixes #32467 and fixes #78082
2019-10-18 17:58:54 +02:00
isidor 9d786e3a44 breakpoints in overview to the left 2019-10-18 17:56:56 +02:00
Isidor Nikolic 043114925f
Merge pull request #82787 from anirudhrb/breakpoints_in_scrollbar
Show breakpoints in overview ruler
2019-10-18 17:55:12 +02:00
Andre Weinand ee432c084a don't use ParsedArgs in rawDebugSession; fixes #80461 2019-10-18 17:26:12 +02:00
Alexandru Dima a71065ae17
Fixes #34497: Count unicode points for the status bar 2019-10-18 17:22:44 +02:00
Alex Ross e1a254469c Use real task definition in fetchTasks
Fixes #81439
2019-10-18 16:45:04 +02:00
Anirudh Rayabharam 4f5a47be71 Improvements suggested in code review
1. Added a configuration change listener in breakpointEditorContribution
   that resets the decorations if debug.showBreakpointsInOverviewRuler
   changes.
2. Removed the color registry contribution for the breakpoint marker
   since it is tied to the breakpoint color which is not configurable
   today.
2019-10-18 20:04:15 +05:30
Benjamin Pasero d3972c622f opener - adopt fromUserGesture in more places 2019-10-18 16:16:33 +02:00
Daniel Imms 31434a4954 Add message for legacy console mode
Fixes #82786
2019-10-18 07:14:02 -07:00
Alexandru Dima a38ca5b537
Revert "Use null instead of undefined for openCodeEditor"
Revert "`getActiveCodeEditor` should return undefined instead of null"
Revert "Make `getFocusedCodeEditor` return undefined instead of null"

This reverts commit db11576dbc.
This reverts commit 0fdba0997c.
This reverts commit b18ef0e734
2019-10-18 16:01:48 +02:00
Johannes Rieken 3852e8221b better collapse behaviour for #69279 2019-10-18 15:53:07 +02:00
Alex Ross df10b76026
Add command to window progress (#82365)
and add command to task building progress

Fixes #81636
2019-10-18 15:52:55 +02:00
Alexandru Dima 3fe45ba47d
Partial Revert "Use equals helper function instead of re-implementing it so many places"
This reverts commit 40e0f496f9.
2019-10-18 15:48:57 +02:00
Alexandru Dima 61938981d5
Revert "Remove another duplicated array equals helper function"
This reverts commit 99dc069a0c.
2019-10-18 15:48:56 +02:00
Alex Ross 3404da9137 Add debounce to config change event in tasks
Fixes #82623
2019-10-18 15:47:10 +02:00
Alexandru Dima 7462c67a68
Partial Revert "Replacing more for loops with .every/.some or arrays.equals"
This reverts commit 2719c1ddc0.
2019-10-18 15:45:11 +02:00
isidor 4f54f19553 fixes #81768 2019-10-18 15:43:16 +02:00
Alexandru Dima 76be820533
Revert "Converting a few functions in ITokenizationRegistry to return undefined instead of null"
This reverts commit 4a461d267f.

Revert "null -> undefined"

This reverts commit
30dc021bf7
2019-10-18 15:41:38 +02:00
isidor 5727722320 enable strictFunctionTypes in VS Code codebase #81574 2019-10-18 15:20:34 +02:00