Matt Bierner
a04a714fa3
Format
2018-07-18 19:08:07 -07:00
Matt Bierner
cec4ca0152
Extract isValid hover check
2018-07-18 17:21:04 -07:00
Matt Bierner
6a9f2159e1
Return results directly instead of using temp array
2018-07-18 17:19:11 -07:00
Matt Bierner
c530bbb6c7
Refactoring
...
- Use const
- Remove use strict
- Return early instead of nesting
2018-07-18 17:16:19 -07:00
Matt Bierner
f30234030a
Use coalesce
2018-07-18 17:14:06 -07:00
Matt Bierner
0a1b3a5deb
Use DefinitionLink internally instead of location
2018-07-18 16:53:40 -07:00
Matt Bierner
4610214559
Make sure our internal DefinitionProvider has backwards compatible api
2018-07-18 16:44:48 -07:00
Matt Bierner
44cd521ced
Finalize definition link ( #54424 )
...
Finalize the definition link api
- Gives fields more explicit names (target and origin)
- Moves api to vscode.d.ts
- Makes other definition providers (such as type definition provider and implementation provider) also return definition links
Fixes #54101
2018-07-18 16:32:27 -07:00
Sandy Armstrong
80a472482c
Treat Xamarin .workbook files as markdown ( #51167 )
...
Xamarin Workbooks are interactive coding documents that are saved as
straight-forward markdown files with a YAML front matter header block.
Here is a sample: https://github.com/xamarin/Workbooks/blob/master/csharp/csharp6/csharp6.workbook
Github has been treating them as markdown files for over a year now
(https://github.com/github/linguist/pull/3500 ).
2018-07-18 16:27:03 -07:00
HUA Yang
9038bc7b45
fix #53590 ( #54257 )
2018-07-18 16:22:29 -07:00
Rachel Macfarlane
43cdb2c69b
High contrast border in comments editor widget
...
Fixes https://github.com/Microsoft/vscode-pull-request-github/issues/58
Fixes https://github.com/Microsoft/vscode-pull-request-github/issues/59
2018-07-18 15:34:51 -07:00
Rachel Macfarlane
346b9770bb
Block quote in comments styling, fixes https://github.com/Microsoft/vscode-pull-request-github/issues/60
2018-07-18 15:16:01 -07:00
Matt Bierner
533c6deb79
Move cancellation files to own dir
...
Fixes #53423
2018-07-18 14:28:55 -07:00
Matt Bierner
a51874590c
Extract common type
2018-07-18 14:28:55 -07:00
Matt Bierner
0fbc508f17
Prefix unused with _
2018-07-18 14:28:55 -07:00
Matt Bierner
b9bc23bb58
Only exec server call in try catch
2018-07-18 14:28:54 -07:00
Matt Bierner
3331d725e5
Use toFileLocationRequestArgs
2018-07-18 14:28:54 -07:00
Matt Bierner
708b16a96c
Remove unused property
2018-07-18 14:28:54 -07:00
Matt Bierner
6c2818d42e
Clean up provideDocumentSymbols
...
- Returned undefined instead of empty array
- Only execute server call in try catch
2018-07-18 14:28:54 -07:00
Matt Bierner
4c003dbbc1
Remove old navtree call
...
This API has been replaced with navbar. The code related to navbar is not being tested and a very small number of users are using < 2.1 in their workspaces
2018-07-18 14:28:54 -07:00
Matt Bierner
966bec8650
Reducing scope of try catch to just exec
...
We want to be alerted if an exception is thrown outside of execute
2018-07-18 14:28:54 -07:00
Rob Lourens
290af21d0f
Fix flaky SearchModel test
2018-07-18 14:21:24 -07:00
Daniel Imms
831a5c8630
Remove precondition from run terminal commands
2018-07-18 13:59:53 -07:00
Rob Lourens
630744a905
Add unit test helper, testRepeatOnly
2018-07-18 13:58:55 -07:00
Ramya Rao
d3ff1b2ff3
Open release notes in product from changelog in built in extensions ( #54522 )
...
* Open release notes in product from changelog in built in extensions
* Allow only the release notes command from webview
* Localized text may invalidate markdown, skip it
2018-07-18 13:36:49 -07:00
Daniel Imms
e90b3669a8
Add precondition for terminal menu items
2018-07-18 13:31:32 -07:00
SteVen Batten
cf54770f25
fixes #54479
2018-07-18 11:43:13 -07:00
Rob Lourens
9c2084b9ee
Fix #54603
2018-07-18 11:30:51 -07:00
Rachel Macfarlane
c48de0a981
Adjust comment glyph height
2018-07-18 11:10:25 -07:00
SteVen Batten
1519487838
fix #54156
2018-07-18 10:47:50 -07:00
Daniel Imms
958d0ae17f
Improve terminal ID and LABEL references
2018-07-18 10:08:53 -07:00
Daniel Imms
2ebd265486
Prefix COMMAND_ID enum with TERMINAL
2018-07-18 09:58:52 -07:00
Rachel Macfarlane
ed49f859ed
Fix handling of links in comment panel, fixes https://github.com/Microsoft/vscode-pull-request-github/issues/92
2018-07-18 09:57:28 -07:00
Daniel Imms
b4de528350
Organize commandsToSkipShell term commands
2018-07-18 09:56:57 -07:00
Daniel Imms
7f9a769bfd
Reference terminal command IDs from common
2018-07-18 09:56:03 -07:00
Daniel Imms
26e063642a
Reference termiinal command id enum for menu
2018-07-18 09:56:03 -07:00
Daniel Imms
c999e0372e
Move all terminal command IDs into common/
2018-07-18 09:56:03 -07:00
isidor
d03af90adb
Properly remove diagnostics.ts
...
fixes #54486
2018-07-18 18:13:40 +02:00
Daniel Imms
0f3ed38c8b
Move terminal menu to parts/terminal
...
Part of #54510
2018-07-18 09:11:07 -07:00
Rachel Macfarlane
b5b20c46c6
Move collapseDeepestExpandedLevel action implementation out of tree
2018-07-18 09:06:46 -07:00
Johannes Rieken
5c21818cfb
breadcrumbs - don't let editor group steal focus
2018-07-18 17:51:58 +02:00
Johannes Rieken
dd37f5b558
breadcrumbs - use darker drop shadow in dark theme
2018-07-18 17:42:44 +02:00
Johannes Rieken
a44fcb8e7f
set header size to its actual size, skip assertion when writing, #54570
2018-07-18 16:53:43 +02:00
isidor
7d2e4c4ada
Revert "remove diagnostics.ts"
...
This reverts commit e587012b1b
2018-07-18 16:22:02 +02:00
isidor
e587012b1b
remove diagnostics.ts
...
fixes #54486
2018-07-18 16:01:27 +02:00
isidor
5c8b57512b
debug: fix tests
2018-07-18 13:51:06 +02:00
Erich Gamma
5c5f93cdbc
Support to run the selected script in the editor
2018-07-18 12:58:19 +02:00
Johannes Rieken
c82766c068
fix #54554
2018-07-18 12:55:49 +02:00
Joao Moreno
8ced52378a
fixes #54075
2018-07-18 11:34:33 +02:00
Joao Moreno
09720aa140
fixes #53419
2018-07-18 11:28:56 +02:00
