João Moreno
a5d71aad39
Cleanup dependencies ( #195026 )
...
* move build dependencies to devDependencies
* build: bump tree-sitter
* dependencies cleanup
* remove leftover file
2023-10-09 09:34:15 +02:00
Connor Peet
c6a9da71a2
eng: allow snapshot mutation messages locally ( #194498 )
...
* eng: allow snapshot mutation messages locally
Fixes https://github.com/microsoft/vscode/issues/192439
Fixes https://github.com/microsoft/vscode/issues/194493
* keep snapshot tests allowed
2023-09-29 18:36:27 +01:00
Connor Peet
31067371f2
eng: fix snapshot tests in macos webkit for real? ( #193734 )
...
Second attempt at this, which should work. Stop trying to use
exposeFunction, which seems to work poorly on macOS webkit in CI, and
just run a server with HTTP endpoints to do the "RPC."
Reuses Alex's "yaserver" module that we were already using for other
tests. Uses a secure random prefix for security in each run.
2023-09-21 22:48:21 +01:00
Connor Peet
8730f56c09
eng: add io warmup for webkit tests in ci ( #193711 )
...
Should fix the issue that @roblourens and @Yoyokrazy were hitting with snapshot tests on macOS WebKit in CI. Not pretty, but I'd rather do this than spend a bunch of time chasing down something that certainly seems to be a browser issue.
2023-09-21 11:03:20 -07:00
Benjamin Pasero
6b9583d2dc
fix ( #192807 )
...
* fix
* fix
* fix
* fix
2023-09-11 12:54:53 -07:00
Benjamin Pasero
0c5c400ea5
debt - more polish in global test reporter ( #192774 )
...
* debt - more polish in global test reporter
* cleanup
* cleanup
* fixes
2023-09-11 17:16:16 +02:00
Benjamin Pasero
edd2f9f3f1
eng - fail test that logs unexpected output ( #192700 )
...
eng - fail test that logs
2023-09-11 14:35:48 +02:00
Johannes
8f4d4d4bad
workaround browser bug, fix browser test debugging
2023-09-05 11:47:13 +02:00
Alpha Romer Coma
7ef754c2f6
Fix supported markdown-lint violations in markdown files ( #190750 )
...
docs: fix supported markdownlint violations
2023-08-24 08:37:25 +00:00
Connor Peet
6a847ba6d1
eng: add support for snapshot tests ( #190444 )
...
* eng: add support for snapshot tests
This adds Jest-like support for snapshot testing.
Developers can do something like:
```js
await assertSnapshot(myComplexObject)
```
The first time this is run, the snapshot expectation file is written
to a `__snapshots__` directory beside the test file. Subsequent runs
will compare the object to the snapshot, and fail if it doesn't match.
You can see an example of this in the test for snapshots themselves!
After a successful run, any unused snapshots are cleaned up. On a failed
run, a gitignored `.actual` snapshot file is created beside the
snapshot for easy processing and inspection.
Shortly I will do some integration with the selfhost test extension to
allow developers to easily update snapshots from the vscode UI.
For #189680
cc @ulugbekna @hediet
* fix async stacktraces getting clobbered
* random fixes
* comment out leak detector, for now
* add option to snapshot file extension
2023-08-15 12:03:51 -07:00
Benjamin Pasero
424388032a
tests - increase timeout when running in CI ( #182288 )
2023-05-12 13:02:15 +02:00
Robo
e5f61433b5
chore: update to Electron 22 ( #177600 )
...
* Revert "chore: revert to Electron 19 (#175851 )"
This reverts commit 3a11b47eee
.
* chore: bump electron@22.3.3
* build: use custom version for V8 sandbox
* chore: update electron@22.4.1
* chore: enable forceAllocationsToV8Sandbox for extension host
* chore: bump electron@22.4.2
* chore: bump electron@22.4.3
* sandbox - cleanup from electron 22 update (#178919 )
* Revert "chore: revert to Electron 19 (#175851 )"
This reverts commit 3a11b47eee
.
* chore: bump electron@22.3.3
* build: use custom version for V8 sandbox
* chore: update electron@22.4.1
* chore: enable forceAllocationsToV8Sandbox for extension host
* chore: bump electron@22.4.2
* chore: bump electron@22.4.3
* temp: update distro
* sandbox - cleanup from electron 22 update
* missing comile
* more changes
* fix build
* restore
* 💄
* compile
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com>
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
Benjamin Pasero
b0b69338e8
debt - further reduce electron-browser
layer ( #178504 )
...
* debt - move more tests out of `electron-browser`
* move more tests
* move preload script as well
* fix
2023-03-28 10:35:58 -07:00
Rob Lourens
be54d2be91
Check notebook URIs in BulkCellEdits ( #169669 )
...
* Revert "Disallow cell URIs with NotebookEdit"
This reverts commit d7576eea81
.
* Check notebook URIs in BulkCellEdits
Fix #146690
2023-01-07 17:35:25 -08:00
Alexandru Dima
06b97f6be7
Add more logging and perf markers around resolving the connection token and the socket factory ( #170490 )
...
* Add more logging and perf markers around resolving the connection token and the socket factory
* set `exposeFunction` earlier
* bla windows
* also expose function for unit tests beofre opening
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-01-05 10:17:19 +01:00
Connor Peet
0899758dae
ipc: use vql for uint types ( #167407 )
...
* ipc: use vql for uint types
On the plane I was reverse-engineering ipc.ts to implement it in Rust
and see if we could have a "service mode" for the CLI that we could
interact with like any other vscode process.
In doing so, I noticed that numbers in the protocol--which are used at
least twice in the message header and ID--were encoded as JSON. I was
curious what benefits we'd get from encoding them as variable-length
integers instead.
It makes the message shorter, as expected. Encode/decode time are very,
very slightly lower. I'm not sure it's worth the extra complexity, but
I have included it here for your consideration.
* fixup tests
2022-12-02 15:54:36 -08:00
Johannes
d555777b1a
simplify _VSCODE_NODE_MODULES
util
2022-11-18 09:42:32 +01:00
Johannes
824c70b275
fix node tests
2022-11-18 09:42:15 +01:00
Johannes
8dd8d214d8
don't use __$__nodeRequire
to fetch product configuration
2022-11-18 09:41:51 +01:00
Johannes
2d6ad4be88
* add global for node_modules access
...
* remove most usages of require.__$__nodeRequire
* stop using require.nodeRequire
2022-11-18 09:41:43 +01:00
Raymond Zhao
9feaed8f51
Revert "joh/representative canidae" ( #166641 )
2022-11-17 13:53:17 -08:00
Johannes
6dd2726c73
simplify _VSCODE_NODE_MODULES
util
2022-11-17 17:58:51 +01:00
Johannes
1a0223da3f
fix node tests
2022-11-17 17:19:29 +01:00
Johannes
93c3f3202b
don't use __$__nodeRequire
to fetch product configuration
2022-11-17 15:41:23 +01:00
Johannes
0824db3bad
* add global for node_modules access
...
* remove most usages of require.__$__nodeRequire
* stop using require.nodeRequire
2022-11-17 12:09:14 +01:00
Johannes
15b8f56574
fix rendering/UI for ./scripts/test.sh --dev
2022-10-04 14:51:58 +02:00
Alexandru Dima
a68f9da5fe
There is no need to pass in nodeMain
when passing in baseUrl
( #160893 )
2022-09-14 13:04:14 +02:00
Johannes Rieken
1857d6c076
for test runinng, use --dev
instead of --debug
( #159040 )
...
fixes https://github.com/microsoft/vscode/issues/159011
2022-08-24 07:54:39 -04:00
Connor Peet
39e77d74ca
fix: parse errors in coverage command ( #156837 )
...
Fixes #155615
2022-08-05 18:27:40 +02:00
Benjamin Pasero
0a7226e9ad
Revert "Increase timeout of web unit tests" ( #157065 )
...
Revert "Increase timeout of web unit tests (#156894 )"
This reverts commit f86beb18e8
.
2022-08-04 11:52:56 +02:00
Benjamin Pasero
f86beb18e8
Increase timeout of web unit tests ( #156894 )
...
* Windows: some Firefox web tests are timing out randomly (#155760 )
See if this is a fundamental issue or really Firefox is slower.
* mention issue
2022-08-03 06:55:58 +02:00
Benjamin Pasero
86e7410278
unit tests - help diagnose test failure reason for web tests ( #155967 )
2022-07-22 18:50:34 +02:00
Alexandru Dima
3530e85ba8
Properly return a non 0 exit code in case a test times out and fix tests which used to time out ( #152329 )
2022-06-16 13:02:37 +00:00
deepak1556
c3077080ec
Merge remote-tracking branch 'origin' into electron-18.x.y
2022-06-10 18:29:22 +09:00
Johannes
0656d21d11
auto-fixed prefer-const violation
2022-06-08 17:49:21 +02:00
deepak1556
1044556d8b
chore: bump electron@18.0.0-beta.4
2022-05-31 08:25:29 +09:00
Benjamin Pasero
08ac1bb67c
tests - improve exclusion handling for node.js tests
2022-04-21 17:10:16 +02:00
Benjamin Pasero
12500e46ac
properly skip unit test ( #137853 )
2022-04-11 17:02:34 +02:00
Benjamin Pasero
9a78ee3b1a
unit - skip all tests for test
component in node
2022-04-05 17:27:24 +02:00
Benjamin Pasero
2ada17080c
Use playwright
for desktop smoke tests ( #146692 )
...
* Use `playwright` for desktop smoke tests
* fix distro issues
* tests - enable prefs tests for web
2022-04-04 10:13:08 +02:00
Connor Peet
6fcf02f29a
testing: re-enable possibly fixed tests
2022-04-01 13:20:50 -07:00
Charles Gagnon
8da408454c
Update coverage folder location
...
The coverage folder isn't generated at the root of the workspace, it's put in the `.build` folder currently.
2022-03-21 10:55:03 -07:00
Robo
32d40cf44e
chore: update to electron 17 ( #143223 )
...
* chore: bump electron@17.0.0
* Revert "chore: revert to electron@13 (#143851 )"
This reverts commit df645f1450
.
* chore: bump electron@17.1.0
* Revert "ci: fix build with latest node-gyp"
This reverts commit c3e948aa30
.
* chore: revert ci changes for node v16
* chore: update yarn.lock
* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Robo
df645f1450
chore: revert to electron@13 ( #143851 )
...
* Revert "chore: update to electron 16 (#137241 )"
This reverts commit 01df559c18
.
This reverts commit 46301339b7
* ci: fix remote compiler for sdl-scan
* chore: fix remote/.yarnrc
* chore: fix build/npm/postinstall.js
* chore: rm crash reporter from shared process
* chore: rm crash reporter from ext host
* chore: fix build/lib/layersChecker.ts
* :chore: preserve some more changes
* fix tests
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Benjamin Pasero
b344f43498
Revert "linux: disable crash reporting in CI ( #142572 )"
...
This reverts commit 7dbd7367dc
.
2022-02-15 16:27:08 +01:00
Benjamin Pasero
7dbd7367dc
linux: disable crash reporting in CI ( #142572 )
2022-02-15 08:26:18 +01:00
Benjamin Pasero
f613ab462e
tests - skip some, enable some
2022-02-09 07:14:42 +01:00
Robo
01df559c18
chore: update to electron 16 ( #137241 )
...
* chore: bump electron@15.3.0
* chore: bump node@16.x
* chore: enable render process reuse
* Revert "watcher - use `type` property for crash reporter location"
This reverts commit bfa488dd8f
.
* Revert "watcher - enable crash reports on linux (#136264 )"
This reverts commit af261488f8
.
* chore: enable crashpad on linux
* chore: bump electron@15.3.1
* chore: update api changes
* chore: bump @vscode/sqlite3@5.0.3
* spec: skip non-context aware module unittests
* chore: fix perf hook integration with node environment
* fix: adopt fs api changes
* chore: fix integration tests
* chore: bump electron@15.3.2
* chore: bump electron@16.0.0
* temp(macOS): kill test instances in OSS
* Revert "temp(macOS): kill test instances in OSS"
This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.
* chore: update chromium version for clang downloader
* some 💄 changes
* align with changes
* adopt more fs.rm
* 💄
* chore: bump @vscode/sqlite3@5.0.4
* fix layers check to account for duplicated types from node.js
* update todo for type casts
* smoke - fix compile issue
* chore: update module cache
* watcher - fix unhandled rejection (fix #137416 )
* ci: update node version
* enable stack dumping
* update electron types to 16.x
* chore: bump @vscode/sqlite3@5.0.5
Refs https://github.com/microsoft/vscode/issues/137496
* fix layer issue
* add `AbortSignal` to core types
* chore: update linux compile flags
Refs 797723ec83
* ci: fix linux build
* ci: update github ci cache
* ci: fix remote build in github ci
* ci: better fix for remote build
* chore: bump azure cache
* chore: fix merge conflict
* :chore: update to electron@16.0.2
* chore: bump @vscode/sqlite3@5.0.7
* ci: update to gcc-4.9 for remote
Refs https://github.com/microsoft/vscode/issues/137659
* ci: switch to buster for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: fix build on linux arm64
* ci: fix arm client compiler toolchain
Refs #137927
* chore: bump electron@16.0.3
* ci: fix compile flags for the c toolchain
* chore: bump electron@16.0.4
* Add experimental dark mode flag (#139109 )
* Add experimental dark mode flag
* Apply PR feedback
* chore: bump electron@16.0.6
* chore: bump electron@16.0.7
Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300
* chore: experimental highlight API
* smoke - fix compile issue
* FIXME: custom ELECTRON_RUN_AS_NODE with node worker
* Revert "chore: bump electron@16.0.7"
This reverts commit 5fd01cf37c
.
* Revert "Revert "chore: bump electron@16.0.7""
This reverts commit a7f1b73951
.
* chore: fix github linux workflow
* chore: address review feedback
* chore: bump electron@16.0.8
* ci: revert to stretch distro for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: force build
* chore: update yarn.lock
* address feedback
* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"
This reverts commit 7b48fa3732
.
* ci: fix remote folder build
* chore: fix github linux ci
* 🆙 `versionSpec`
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Alex Dima
cab9713422
Fixes #141994 : Address eslint problems
2022-02-02 13:18:12 +01:00
Alex Dima
1498d0f340
Add explicit layers for editor contributions ( fixes #140995 )
2022-01-21 10:29:55 +01:00