Andrea Mah
9318bcc518
Search Contributions Cleanup ( #165538 )
...
Major cleanup on search contribs/actions, namely:
- converting all `Action` and related registrations to `Action2`
- Converting the `Actionbar` that appears on hover of a search result to `MenuWorkbenchToolBar`
- Overall organization
- Converting any `ICommandHandler` to functions if they don't need to be `ICommandHandler`
- Adding titles to all search commands
2022-11-16 14:37:44 -08:00
Matt Bierner
838b48504c
Pick up TS 4.9 final ( #166509 )
2022-11-16 14:16:36 -08:00
Connor Peet
707f91aaa6
cli: fix 'failed to lookup tunnel' with a name given ( #166507 )
...
Fixes https://github.com/microsoft/vscode-cli/issues/563
If a new tunnel `--name` was provided but the existing tunnel was deleted,
the CLI would error out with a lookup failed message. Instead it now
recreates it like it normally would.
2022-11-16 14:10:49 -08:00
Logan Ramos
a1d42637be
Exempt perf markers from telemetry cleaning ( #166508 )
2022-11-16 14:07:38 -08:00
Daniel Imms
1f50215e1f
Merge pull request #166497 from microsoft/tyriar/166496
...
Fix casing of action widget hover
2022-11-16 11:59:21 -08:00
SteVen Batten
a60b513c45
fix cleaning on windows ( #166498 )
2022-11-16 11:44:45 -08:00
Logan Ramos
8deed65f64
Allow the ability to opt out of cleaning ( #166136 )
...
* Add the ability to opt out of data cleaning
* Comment
* Update to Joh's suggested solution
2022-11-16 11:41:04 -08:00
Logan Ramos
6e3dbd4a91
Bump distro ( #166494 )
2022-11-16 11:20:12 -08:00
Daniel Imms
a61a96ba49
Fix casing of action widget hover
...
Fixes #166496
2022-11-16 11:13:48 -08:00
Johannes Rieken
544f1cab66
Merge pull request #166486 from microsoft/joh/yielding-marten
...
don't use any-cast to access private or protected members
2022-11-16 19:22:03 +01:00
Johannes
76cdb404d8
update all re-declarations of the model-property
2022-11-16 19:06:09 +01:00
Johannes
9b42db9fcb
don't use any-cast to access private or protected members
...
fixes https://github.com/microsoft/vscode/issues/166478
2022-11-16 19:03:39 +01:00
Joyce Er
e6a50551ff
🆙 distro ( #166482 )
2022-11-16 18:50:50 +01:00
Connor Peet
02b5cca0ae
Merge pull request #166411 from microsoft/cli/macos-service-monitoring
...
cli: add service integration for macos, observability
2022-11-16 09:38:17 -08:00
Greg Van Liew
816f31f691
More settings description tuning ( #166429 )
2022-11-16 09:33:33 -08:00
Connor Peet
4c251676ef
clippy fixes
2022-11-16 08:51:47 -08:00
bhavyaus
5f11d2f9a3
Set group size to half width on toSide ( #166421 )
2022-11-16 08:36:23 -08:00
Han
d34224b85f
Move css rules from inPlaceReplace.ts into inPlaceReplace.css ( #166098 )
...
* #165169 Move css rules from inPlaceReplace.ts into inPlaceReplace.css
* #165169 Move css rules from ghostTextWidget.ts into ghostTextWidget.css
* #165169 Move css rules from links.ts into links.css
* #165169 Move css rules from findOptionsWidget.ts into findOptionsWidget.css
* 💄
* supplement missing attributes for findOptionsWidget.css
* 💄
* 💄
* 💄
* Revert "💄 "
This reverts commit 776684dc95
.
* 💄
* rm the wrong assignment
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-11-16 16:12:54 +01:00
João Moreno
ee763408fb
remove codeql gh action ( #166468 )
2022-11-16 07:12:36 -08:00
João Moreno
aa461e19a6
add trace logging to NativePolicyService ( #166462 )
...
related to #163418
2022-11-16 06:19:57 -08:00
bhavyaus
3813f98692
Import gettingStartedColors ( #166402 )
2022-11-16 09:06:29 -05:00
Logan Ramos
39ff7eb93b
Bump distro ( #166459 )
2022-11-16 05:43:29 -08:00
Johannes Rieken
72def61fae
Merge pull request #166126 from microsoft/joh/rewrite-privates
...
TS - mangle private and protected props
2022-11-16 14:42:11 +01:00
Daniel Imms
2d51ceaa32
Batch/defer history service navigation events ( #163845 )
...
* Batch/defer history service navigation events
Part of #161622
* Pass store through Event.accumulate
* Remove duplicate function
* Action feedback
* 💄
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2022-11-16 14:40:34 +01:00
Felix L'Heureux
3444a914e0
Reset value to an empty string when undefined or null ( #165721 )
...
* Reset value to an empty string
* Throw illegalArgument instead of setting the value as ''
Co-authored-by: Félix L'Heureux <felix@Felixs-MacBook-Pro.local>
2022-11-16 14:37:45 +01:00
Han
8df188a390
#165169 Move css rules from hover.ts into hover.css ( #166095 )
...
* #165169 Move css rules from hover.ts into hover.css
* Move hover css rules to the appropriate location
* Delete redundant lines
* add css import
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-11-16 14:29:19 +01:00
Daniel Martinez Olivas
bd32dd5c8f
Moves css rules from links.ts to links.css ( #166258 )
...
moves css rules from links.ts to links.css
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-11-16 13:48:34 +01:00
Johannes
fdc39b56e4
missing JS files
2022-11-16 13:47:07 +01:00
Alexandru Dima
207f26dd13
Merge pull request #166455 from microsoft/alex/pr-155450
...
Separate tab size and indent size (PR #155450 )
2022-11-16 13:31:48 +01:00
Johannes
ea34e747c8
Merge branch 'main' into joh/rewrite-privates
2022-11-16 13:20:57 +01:00
Alex Dima
484e0cbddb
Create a new API proposal with TextEditorOptions.indentSize
2022-11-16 13:01:00 +01:00
Isidor Nikolic
7c466b8e96
Merge pull request #166355 from prashantvc/issue2961
...
Change sessionId with machineId for extension search telemetry
2022-11-16 12:11:28 +01:00
Sandeep Somavarapu
3486612bd0
Merge branch 'main' into issue2961
2022-11-16 11:56:13 +01:00
Sandeep Somavarapu
f65123fd11
fix compilation @hediet ( #166448 )
2022-11-16 02:48:47 -08:00
dependabot[bot]
52e04424d1
Bump loader-utils from 1.4.1 to 1.4.2 ( #166406 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-16 11:29:37 +01:00
Sandeep Somavarapu
414ce915e9
Merge branch 'main' into issue2961
2022-11-16 10:33:36 +01:00
Johannes Rieken
3ffb834054
Merge branch 'main' into joh/rewrite-privates
2022-11-16 10:20:49 +01:00
Matt Bierner
e4b6657f93
Allow editor contributions to mark themselves as instantiated on idle ( #166065 )
...
* Allow editor contributions to mark themselves as instantiated on idle
For #164171
Editor contributions are currently created eagerly when editors are instantiated. In many cases however, the contribution is not needed instantly. A contributed widget for instance may only be shown after a user action, while some info that shows in the editor also does not need to be shown instantly as soon as the editor opens
Contributions like those can be lazily created, but actually adopting lazy instantiation for individual contributions is a lot of work
Instead this PR lets editor contributions tell VS Code that the entire contribution does not need to be eagerly created and can be instead on idle
With `EditorContributionInstantiation.Idle`, the contribution will be created:
- Either when the editor is idle
- Or when the contribution is explicitly requested.
Idle contributions cannot participate in saving and restoring of editor view states
This change will make it easier to lazily create editor contributions and also lets us remove existing code that was added to make individual editor contributions lazy
* Mark as optional
* Addressing comments
* IdleValue should throw again if there's ctor error
2022-11-16 01:07:24 -08:00
Henning Dieterichs
3dd0aea2ee
Merge pull request #165147 from microsoft/hediet/integrated-mule
...
Implements diffing fixture tests. Fixes #165041
2022-11-16 09:54:36 +01:00
Benjamin Pasero
f176ad8e28
workspace.applyEdit drops the TextEdit if there is a RenameFile later #77735 ( fix #166436 ) ( #166439 )
2022-11-16 09:43:07 +01:00
Johannes
42049188bb
Merge branch 'main' into joh/rewrite-privates
2022-11-16 08:55:55 +01:00
Henning Dieterichs
3e19ba91ff
Allows to pass in a custom diffing algorithm when instantiating the monaco diff editor. ( #165179 )
...
* Allows to pass in a custom diffing algorithm when instantiating the monaco diff editor.
* Undo launch.json change
2022-11-16 08:48:39 +01:00
Benjamin Pasero
8bd052125b
Save participants are re-entrant ( fix #166352 ) ( #166434 )
2022-11-15 23:06:10 -08:00
Matt Bierner
3fbbb5b892
Clean up actionWidget ( #166408 )
...
- Reduce number of exports
- Adding private and removing unnused params
- Split out `actionList.ts` to own file
2022-11-16 07:50:27 +01:00
Matt Bierner
5452c6af10
Eagerly delete diagnostic on quick fix ( #166417 )
...
Fixes #166415
2022-11-16 07:43:28 +01:00
Benjamin Pasero
e688782e73
API: createFileSystemWatcher()
doesn't work when relative path ends with /
( fix #162498 ) ( #166372 )
2022-11-15 21:17:46 -08:00
Connor Peet
e996746b14
add observability for windows
2022-11-15 20:38:18 -08:00
Matt Bierner
edccbd1307
Pick up latest markdown language server ( #166404 )
...
Also removes some duplicated files
2022-11-15 18:27:22 -08:00
Peng Lyu
4129bb21c9
Fix #166419 . Simplify single suggested/selected kernel. ( #166420 )
...
* 💄 Extract logic from kernel picker action.
* Fix #166419 .
2022-11-16 12:25:46 +11:00
Matt Bierner
85e1bb0c06
Fix code action list showing disabled code action ( #166418 )
...
Looks like this was introduced when splitting out the action widget
2022-11-15 16:48:40 -08:00