Commit graph

117530 commits

Author SHA1 Message Date
Matt Bierner 8f32885359
Use markdown engine to enable/disable smart paste (#202192)
Fixes #188863
Fixes #188958
Fixes #188868

This is more reliable than using the regular expressions. However the regular expressions are still needed for inline elements
2024-01-10 14:32:58 -08:00
Matt Bierner 0bb69da87c
Add new smartWithSelection option for markdown links (#202183)
This becomes the new default while `smart` always smartly pastes, even with no selection
2024-01-10 20:01:52 +01:00
Johannes Rieken 115155df62
Add test that asserts stream is done when the request is done (#202184)
test that asserts stream is done when the request is done

manifests fixing https://github.com/microsoft/vscode-copilot/issues/3345
2024-01-10 10:48:10 -08:00
Benjamin Pasero 53d7995f47
ENOSPC though no workspace (fix #201923) (#202180) 2024-01-10 10:46:33 -08:00
Connor Peet 7dab57d216
ensureNoDisposables leaked in base/common code (#202175)
* ensureNoDisposables leaked in base/common code

* more
2024-01-10 19:28:26 +01:00
Matt Bierner 39e866b964
Pick up latest markdown-it-katex (#202178) 2024-01-10 19:04:33 +01:00
Connor Peet f5952f92c0
monaco: improve handling of glyph margins (#202102)
* monaco: improve handling of glyph margins

In my previous PR #202048, I added another glyph margin lane. However
I didn't realize in some cases the support I added was incomplete since
the rendering code did not fully handle an unbounded number of lanes.

Also, I noticed in existing issues with hover and click handling because
some parts of VS Code still assume there's at most a single glyph widget
visible. It is hard to determine which glyph widget is interacted with
without checking what classes are applied to the glyph element, which
is what most existing code does. And we probably shouldn't do that in
e.g. the MouseHandler to determine what glyph is being clicked on.

So in this PR I added a `GlyphMarginLanesModel` that contains the
information necessary for rendering. I also want to expose it in a place
that the MouseHandler or MouseTarget can get at, but I wasn't sure the
best way to do that, any suggestions @alexdima?

Implementation-wise I opted for a flag Uint8Array. A 1024 line file with
decorations on the last line, it would take 384 bytes to hold decoration
positions. I also tried out a Range array based implementation, but I
think this is faster (for cases where there are lots of decorations)
and much simpler, in exchange for higher memory usage in edge cases
(very long files with decorations near the end.)

* allow lanes to be persisted to avoid jumping bp icons
2024-01-10 09:07:40 -08:00
Connor Peet 6fced49205
testing: update testingActiveProfile proposal to final implementation (#202116)
* testing: update testingActiveProfile proposal to final implementation

* update tests
2024-01-10 18:07:15 +01:00
Benjamin Pasero 1e9f0887fb
window - push down static method to base (#202162) 2024-01-10 16:03:25 +01:00
Benjamin Pasero 74da22bb03
ENOSPC though no workspace (fix #201923) (#202161) 2024-01-10 15:49:48 +01:00
Benjamin Pasero b6d977789e
Screen cheese when reloading with a notebook in a floating window (fix #201832) (#202159) 2024-01-10 15:48:23 +01:00
Johannes Rieken 8ffbf09e31
Clear edit queue when request errors, tweak Queue/Limiter, tests (#202157)
* don't drag targetWindow all the way across all the layers

* add `ILimiter#clear`, add tests and define onDrain and clear behaviour

* fix compilo

* Queue/Limit - clarify onDrain timing, make sure it fires only once, add whenIdle

* chat - clear edit queue on error, adopt whenIdle

* add test to ensure progress edit stream stop on being cancelled
2024-01-10 15:27:09 +01:00
Benjamin Pasero ff7dcf2974
zoom - fix some issues (#202158) 2024-01-10 15:25:42 +01:00
Benjamin Pasero fc3df618cb
workspace.fs.delete useTrash option is not respected (fix #201742) (#202156) 2024-01-10 15:22:40 +01:00
Louis Lazaris 89eb2de093
Corrected CSS Hover Documentation text (#202142) 2024-01-10 13:42:16 +00:00
Louis Lazaris 314c9891c3
Fixed some CSS terminology (#202125) 2024-01-10 12:44:25 +00:00
Sandeep Somavarapu 572198c07d
add more logging (#202139) 2024-01-10 10:33:49 +01:00
Sandeep Somavarapu ba2f50ca50
fix #71846 (#202132) 2024-01-10 09:27:19 +01:00
Johannes Rieken ad68ddc7aa
allow to set/configure ariaLabel for IButton (#202127)
fixes https://github.com/microsoft/vscode/issues/201527
2024-01-10 13:19:44 +05:30
Sandeep Somavarapu dd7a20db89
fix #142478 (#202126) 2024-01-10 08:39:00 +01:00
Sandeep Somavarapu 6bf996da2b
adopt ensureNoDisposablesAreLeakedInTestSuite (#202121)
#200091 adopt ensureNoDisposablesAreLeakedInTestSuite
2024-01-10 07:32:20 +01:00
Connor Peet ea77026ab9
Merge pull request #166202 from gayanper/wait_for_breakpoint
Add support for breakpoint dependencies
2024-01-09 22:29:02 -08:00
Connor Peet 207197a5e5
one more place 2024-01-09 16:54:55 -08:00
Connor Peet a308dde7c6
wait to resume until breakpoint is set, align vocabulary 2024-01-09 16:51:19 -08:00
Connor Peet c116ed3234
Merge remote-tracking branch 'origin/main' into pr/gayanper/166202-1 2024-01-09 16:32:10 -08:00
Ladislau Szomoru c973ec7673
SCM - fix border radius for checkout/sync actions (#202106) 2024-01-09 14:40:39 -08:00
Henning Dieterichs ad18bb00ce Fixes #199351 2024-01-09 23:40:26 +01:00
Matt Bierner 35579c0b57
De-prioritize markdown link paste in code blocks (#202109) 2024-01-09 14:27:28 -08:00
Henning Dieterichs 05dfba857a
Adopts #199291 for SCM view changes. (#202077) 2024-01-09 22:28:08 +01:00
Henning Dieterichs 0a284dde18 Introduces _workbench.openMultiDiffEditor 2024-01-09 22:13:18 +01:00
Megan Rogge a3445c68a0
handle alerts in audio cue service, add List Alerts command and settings (#201833)
* massive refactor
2024-01-09 21:03:19 +01:00
Connor Peet 801d79e284
Merge pull request #202048 from microsoft/connor4312/test-coverage-decorations-1
testing: add initial editor decorations
2024-01-09 11:20:46 -08:00
Ronak Jain c1bc5415f8
Fix tsserver crashing when using custom node path (#201966)
* use quotes in spawned process name

* Use JSON stringify to handle quotes as well
2024-01-09 11:02:53 -08:00
Aleksandr Kondrashov eae814bef6
Update IExplorerView interface (#201992) 2024-01-09 18:06:59 +00:00
Alex Ross a6659cb883
API feedback for comment reactor (#202098)
Part of #201131
2024-01-09 09:41:54 -08:00
Raymond Zhao fb84f3bcfb
test: skip flaky Settings editor smoke test (#202097) 2024-01-09 18:16:42 +01:00
Sandeep Somavarapu 5b1893b24b
fix #195150 (#202093) 2024-01-09 17:55:55 +01:00
dependabot[bot] 9c2e81f9f6
Bump follow-redirects from 1.15.3 to 1.15.4 in /extensions/github-authentication (#202055)
Bump follow-redirects in /extensions/github-authentication

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-09 08:53:01 -08:00
Alexandru Dima 4ec14ee326
Fix constant expression (#202092) 2024-01-09 17:48:53 +01:00
Martin Aeschlimann 67e16ed45a
Enable lightbulb setting to on (includes empty lines) (#202089)
Enable lightbulb for empty lines (for #200538)
2024-01-09 17:00:55 +01:00
Sandeep Somavarapu 2d01e64a05
do not register command twice (#202088)
#199744 do not register command twice
2024-01-09 16:56:29 +01:00
Johannes Rieken 6bd246028a
some API notes (#202087) 2024-01-09 16:41:03 +01:00
Martin Aeschlimann 1e9f54e202
Linked editing causing uncaught exception (#202085) 2024-01-09 16:21:10 +01:00
Benjamin Simmonds 6d9bf2113d
Fix click focus glitch (#202084)
fix click focus glitch
2024-01-09 16:11:38 +01:00
Alex Ross bbec320f5d
Fix memory leak in tree (#202080)
Part of #200015
2024-01-09 15:48:10 +01:00
Johannes Rieken 77ca6ccd41
Joh/mysterious-octopus (#202079)
* debt - don't use extra buttons for accept/discard hunk

* - inline chat history shouldn't loop
- preserve the initial value and restore it

fixes https://github.com/microsoft/vscode-copilot-release/issues/671
2024-01-09 15:43:26 +01:00
Megan Rogge 66bf39bd4e
Merge pull request #202029 from microsoft/merogge/suggested
improve understanding of follow up question
2024-01-09 08:29:14 -06:00
Henning Dieterichs 70f5e0883a Implements #199291 - Multi Diff Editor: Identify Input With Source, Reload File List Dynamically 2024-01-09 15:06:29 +01:00
Alex Ross 6d9541fff6
Try out a new Go grammar (#202070) 2024-01-09 14:11:19 +01:00
Sandeep Somavarapu 26a486aee8
fix #195436 (#202069) 2024-01-09 12:48:55 +01:00