Commit graph

49973 commits

Author SHA1 Message Date
Matt Bierner 8de74d9255 Extracting common webview elements
Minimizing diff with the iframe based webview branch
2019-06-11 22:45:55 -07:00
malingyan2017 39947c7250 Fix Recent list in dock does not show recent files/folders #74788 (#75108)
* Fix Recent list in dock does not show recent files/folders #74788

macOS only shows recent list with max number based on sytem config. It takes bottom n entries from the list added through Electron app.addRecentDocument. To match macOS dock recent list with VSCode internal recent list, this change add items into macOS recent document list in reverse order of internal recent list.

* remove dock recent entries limit

* add entry of folder (5) back to allow show some files

* fix showsing wrong folders in recentlist

* simplify adding platform RecentDocument in macOS

* update based on bpasero suggestion

* set max entries

* rename macro
2019-06-12 07:29:27 +02:00
Matt Bierner f291714906 Use undefined instead of null for IStatusbarEntryAccessor 2019-06-11 17:14:21 -07:00
Matt Bierner 1b95baa48b Use MutableDisposable for tracking current code actions 2019-06-11 17:03:44 -07:00
Matt Bierner 9c14fecc87 Prevent dispose cycles
For #75304

Make sure we do not get into a loop of tyring to dispose of an object by checking `isDisposed` before calling into dispose again

Also log if you try to register a disposeable on itself
2019-06-11 16:48:55 -07:00
Rachel Macfarlane af39a4d4fb Expose command to open settings page with online services query from gear menu and preferences menu, fixes #75215 2019-06-11 11:34:08 -07:00
Miguel Solorio 94b23bc6c4 Fix #75187, reduce width of find widget text 2019-06-11 10:55:16 -07:00
Sandeep Somavarapu 27c448d032 update distro 2019-06-11 19:27:41 +02:00
Sandeep Somavarapu 59c79b84e3 #75079 Support keybindings resource 2019-06-11 19:27:10 +02:00
Matt Bierner 65f4b4a159 Use MutableDisposable in a few more places 2019-06-11 10:20:31 -07:00
Matt Bierner bf815f4cc2 Adding MutableDisposable
This class can help manage a disposable property that is optional or may be changed. It prevents errors when you forget to release the previously held disposable when setting a new one
2019-06-11 10:20:31 -07:00
Matt Bierner 728ace5370 Use DisposableStore 2019-06-11 10:20:31 -07:00
Matt Bierner 7806b147f5 Highlight example as json in editor 2019-06-11 10:20:31 -07:00
Benjamin Pasero 29dadcc476 debt - ensure to dispose action toolbar of editor group view 2019-06-11 18:41:33 +02:00
Benjamin Pasero ce94c833bf workaround #74872 2019-06-11 18:27:27 +02:00
Matt Bierner 3e99f28ef9 Use clear instead of dispose when resetting disposables
Fixes #75283
2019-06-11 09:15:06 -07:00
Matt Bierner 74496c8a24 Fix monaco build error 2019-06-11 08:55:32 -07:00
Matt Bierner e50e16c9ec Make sure we dispose of marker decorations properly 2019-06-11 08:48:17 -07:00
Matt Bierner 674bb6700b Extend disposable for MenuService 2019-06-11 08:48:17 -07:00
Matt Bierner a662ad1e98 Use disposableStore 2019-06-11 08:48:17 -07:00
Matt Bierner 4a3ed6c71f Use disposableStore for some actions 2019-06-11 08:48:17 -07:00
Matt Bierner 2aa587600d Use disposableStore for activeEditorListeners 2019-06-11 08:48:17 -07:00
Benjamin Pasero 47ce882e77 web - add web-selfhost 2019-06-11 17:48:05 +02:00
Benjamin Pasero 8b1c28e8a9 fix compile 2019-06-11 17:22:16 +02:00
Christof Marti 18cc196461
Back on 2019-06-11 16:47:25 +02:00
Christof Marti ff71251d21
Back on 2019-06-11 16:46:59 +02:00
Sandeep Somavarapu a0184cc541 #75079 Use fileservice for listening to keybindings file changes 2019-06-11 16:34:11 +02:00
Benjamin Pasero 3c1b39ae6b web - add xterm to build dependencies 2019-06-11 16:01:27 +02:00
Benjamin Pasero 73a68c8414 ipc - add channel name to channel error 2019-06-11 16:01:26 +02:00
isidor 0ac3c44cfc explorer: enable dnd for more cases (remote) 2019-06-11 15:56:49 +02:00
Martin Aeschlimann f1e01146be context key: remoteConnectionState 2019-06-11 15:50:17 +02:00
Sandeep Somavarapu a15a126186 update distro 2019-06-11 15:33:14 +02:00
Sandeep Somavarapu fa66271616 #75079 Use URI for machine settings 2019-06-11 15:32:22 +02:00
Benjamin Pasero e983cdbc6f panel - make terminal the default panel 2019-06-11 15:26:13 +02:00
Sandeep Somavarapu cf7b5675fa #75079 Use URI for keybindings path 2019-06-11 13:54:34 +02:00
Sandeep Somavarapu d77341bf14 use URI for appSettingsHome 2019-06-11 13:50:24 +02:00
Isidor Nikolic 18f4630bc5
Merge pull request #75200 from microsoft/isidorn/signservice
Introduce ISignService
2019-06-11 12:57:12 +02:00
isidor 74d99f6b14 Cache the 'vsda' import, because when the same missing module is imported multiple times, The ones after the first will not throw an error. And this will break the contract of the sign method 2019-06-11 12:56:33 +02:00
Martin Aeschlimann 0d30623d10 Close Remote Connection. Fixes https://github.com/microsoft/vscode-remote-release/issues/501 2019-06-11 12:17:55 +02:00
Benjamin Pasero b8c6fbe9d0 debt - lift feedback contrib to browser 2019-06-11 12:15:18 +02:00
Benjamin Pasero ba3016188e web - set a panel as default that exists 2019-06-11 12:09:08 +02:00
Benjamin Pasero 9e2490593c web - cleanup main files 2019-06-11 12:03:08 +02:00
isidor 6f9e9dd077 merge master 2019-06-11 11:47:16 +02:00
Benjamin Pasero f07aa50dc5 web - ensure window focus is true 2019-06-11 11:26:39 +02:00
Sandeep Somavarapu 7cfae38931 use local hash instead of browser hash 2019-06-11 11:21:47 +02:00
Sandeep Somavarapu 87e23c22b5 update distro 2019-06-11 11:11:44 +02:00
Andre Weinand 31c8ff43fb
Merge pull request #75162 from SamB/patch-1
Fix typo: timemout -> timeout
2019-06-11 11:10:40 +02:00
Isidor Nikolic 8a26027b11
Polish as suggested by Ben
Co-Authored-By: Benjamin Pasero <benjamin.pasero@gmail.com>
2019-06-11 10:03:34 +02:00
Benjamin Pasero 7bc29bf67c
debt - fix command alias (#75242) 2019-06-11 10:02:50 +02:00
Benjamin Pasero 0b3a2d9055 fix #75190 2019-06-11 10:01:49 +02:00