Commit graph

5194 commits

Author SHA1 Message Date
Henning Dieterichs 6bbb128304
Merge pull request #178112 from mwerschy/rainbow-indent
Implement indent guide colorization options.
2023-07-05 18:20:29 +02:00
Johannes eeae481e47
set emit-target and libs to ES2022, avoid static-blocks, fix Error#cause conflict
https://github.com/microsoft/vscode/issues/185991
2023-06-30 11:43:19 +02:00
João Moreno 9f6b76bdb5
schedule a non-releasing 7pm build (#186548) 2023-06-28 21:08:44 +02:00
isidor d47a27cfe6 still register workbench.enableExperiments 2023-06-27 15:01:06 +02:00
Isidor Nikolic 4b5db322fd
Merge branch 'main' into isidor/courageous-yak 2023-06-27 10:32:23 +02:00
Tyler James Leonhardt 8245737e93
Use setUsePlainTextEncryption properly and allow control of password-store via argv.json (#186207) 2023-06-26 14:23:30 -07:00
João Moreno 998951e5ed
propagate gh token (#186197) 2023-06-26 20:30:03 +02:00
Robo 9cdd289db0
chore: update node checksums (#186181)
* chore: update node checksums

* chore: bump distro
2023-06-26 18:20:59 +02:00
Jacek Kopecký b97d99f428
Add tabSizingFixedMinWidth setting (#185766) (#186058)
* Add tabSizingFixedMinWidth setting (#185766)

* Add forgotten case for wrapping tabs

* address feedback

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-06-26 14:58:37 +00:00
Isidor Nikolic 6c24374696
Merge branch 'main' into isidor/courageous-yak 2023-06-26 15:46:13 +02:00
Robo 6067bb4ebe
chore: bump electron@22.3.14 (#185983)
* chore: bump electron@22.3.14

* chore: bump distro
2023-06-23 15:43:02 +02:00
ChaseKnowlden b603fcf963
chore: update minimum installable version in inno setup (#175818)
* Drop support for windows versions prior to windows
10

* Prepare for windows 8 eol

* fix typo

* Revert "Prepare for windows 8 eol"

This reverts commit f65a7107280da4328014d4964ba432f3d7462de0.
2023-06-23 22:15:49 +09:00
Johannes 56c917debf
update SWC config to disable useDefineForClassFields 2023-06-23 12:55:32 +02:00
Max Schmitt 9e0f5fb2dd
chore(monaco): make createTrustedTypesPolicy optional (#185454) 2023-06-22 07:23:20 +00:00
Rob Lourens 7f5de39970
Delete old settings search config uploader (#185818) 2023-06-21 17:15:31 -07:00
Benjamin Pasero 7190530d35
readonly - adopt readOnlyMessage for readonly mode (#185756) 2023-06-21 14:40:17 +02:00
João Moreno 636dbcff55
Revert "cli: fix error starting remote tunnels (#185701)" (#185731)
This reverts commit ffe64dab3c.
2023-06-21 09:30:30 +02:00
Connor Peet 2138622b04
build: add watch/compile tasks for CLI (#182344)
* build: add watch/compile tasks for CLI

I spent time this morning working on the 'developer experience' of the
CLI in vscode, mainly getting the CLI to cross-compile chasing our
initial idea of having it auto-build in a devcontainer.

After some effort and disabling tunnels connections (to avoid having to
pull in OpenSSL which is a huge pain to cross compile), I was able to
get it to cross-compile from Linux to Windows, using the mingw linker.
I could probably figure out how to get macOS working as well with more
effort. However, I'm not a big fan of this, effectively it's one more
'platform' of build we need to support and test.

I think a better approach is downloading the latest compiled CLI from
the update server instead, as needed. That's what this PR does. It just
places the CLI where it _would_ normally get compiled to by cargo; so
far we don't need to do anything special outside of that.
A notice is shown to users if this fallback happens.

* update from review
2023-06-20 14:34:11 -07:00
Connor Peet ffe64dab3c
cli: fix error starting remote tunnels (#185701)
* untested wip

* cli: fix error starting remote tunnels

Fixes #185585

Output was prefixed which prevented the lines from being split to detect the tunnel status.
2023-06-20 14:30:07 -07:00
Robo 4dac9b530d
chore: bump electron@22.3.13 (#185687)
* chore: bump electron@22.3.13

* chore: bump distro
2023-06-20 18:55:16 +02:00
isidor 6af591662a remove workbench/contrib/experiments 2023-06-20 14:36:56 +02:00
Henning Dieterichs 085399feff
Merge pull request #185592 from microsoft/hediet/b/horizontal-ladybug
Diff Editor v2 Improvements
2023-06-19 18:53:59 +02:00
Henning Dieterichs 60b19b3dd8
Unchanged collapsed code improvements 2023-06-19 17:25:27 +02:00
Robo 4df3657b4e
chore: add checksum for electron assets (#185568)
* chore: add checksum for electron assets

* chore: bump distro

* chore: add pdb checksums
2023-06-19 23:46:41 +09:00
Henning Dieterichs b975405819
Diff Editor v2: Iterates on collapsed unchanged code feature. (#185499) 2023-06-19 12:41:17 +02:00
Robo 8fb5ea0142
feat: use custom tag instead of custom version for MS electron releases (#181309)
* feat: use custom tag instead of custom version for MS electron releases

* chore: bump @vscode/gulp-electron

* chore: move build id to .yarnrc

* chore: rename enableUNCAccessChecks => restrictUNCAccess

* chore: update electron@22.3.11

* chore: add build info to about dialog

* chore: simplify helper function

* chore: remove unused node.js checksums

* chore: bump nodejs internal version

* chore: bump distro

* fix: revert changes to sign.ts

* chore: bump distro
2023-06-17 03:03:35 +02:00
Johannes Rieken 72e2af69c9
joh/high loon (#185337)
* allow session creation to be cancelled

* define background colors, make sure to reshow after session is ready, reset selection style on hide
2023-06-16 16:45:44 +02:00
Benjamin Pasero 518a183762
eng - add build version of node.js to .yarnrc (#185302)
* eng - add build version of node.js to `.yarnrc`

* 🆙 distro
2023-06-16 09:10:24 +02:00
Matt Bierner aa82bd59b2
Limit worker pool size (#185164)
Fixes #185079

Should fix OOM issues on build machines
2023-06-14 23:57:22 +02:00
Benjamin Pasero 8afb685c9b
eng - add checksum validation support to nodejs and extensions (#184877)
* eng - add `checksum` validation support to `remote`

* eng - wire in more `checksum` support

* eng - renames for remote fetching

* eng - renames for remote fetching

* eng - disable verbose

* eng - always fetch verbose in CI

* eng - 💄

* eng - add checksums for node

* eng - report checksum matches

* eng - fix build

* eng - warn when not being able to check sum

* eng - support checksums for built in extensions

* eng - clear todo

* eng - add nodejs metadata to product.json

* 🆙 version

* 🆙 distro

* update distro

* eng - switch to checksum file

* cleanup alpine

* fix alpine

* fix bug

* eng - fetch all from remote

* eng - 💄

* eng - print checksums

* eng - fix missing import

* 🆙 distro

* undo version change
2023-06-14 16:57:06 +02:00
Benjamin Pasero 4b939d0a0e
unc - fix path traversal bypass (#185048) 2023-06-13 19:56:46 +02:00
Matt Bierner debcf16fcd
Mangle exported symbols (#182935)
* Mangle exported functions

For #180461

This prototype tries to mangle exported functions, saving a further 440kb from the bundle size

* Fix missing call

* Also try mangling top level exported consts too

* Fixing errors

* Don't run on build files

* Skip a few more manglings and revert change to namespace

* Skip a few more monaco files

* Also mangle consts that shadow types

This increases savings up to 3325

* Also mangle exported classes

* Skip mangling more localization functions for now

* Opt out pfs

* Update build script

* Run find locations task in parallel

This should speed up compile

* Cleanup before close

* Limit workers to avoid hitting memory limit

* Limit pool size

* Skip one more mangling

* Exclude entrypoints from mangling

* Try to fix web build and clean up code

* Exempt a few more projects

* Exempt another file

* Also exempt html

* Skip mangling ext entrypoints

* Use prefix that can't be confused with rpc calls

* Fix max call stack error

* Switch prefixes

* Don't mangle ambient declarations

* Use correct way of checking modifier flags

* Workaround getCombinedModifierFlags not doing what I'd expect

Maybe needs the checker to be enabled too? Just check parent chain instead for now

* Clean up code and add logic showing how enum mangling could work

* Remove a few more skipMangles

Use entrypoints instead

* Fix entrypoint name
2023-06-13 08:18:05 +02:00
Raymond Zhao 13e7d80fcd
Bump windows-process-tree (#184759)
Fixes https://github.com/microsoft/vscode/issues/179697
2023-06-12 11:36:56 -07:00
Robo b4dd4d51fa
ci: switch to bionic agents for arm64 and armhf clients (#184906)
* ci: switch to bionic agents for arm64 and armhf clients

* ci: invalidate cache

* ci: fix docker client installation

* chore: update debian dependencies

* chore: update rpm dependencies
2023-06-13 00:50:36 +09:00
Sandeep Somavarapu 46041c9f0e
Implement troubleshoot issue (#184901)
* implement troubleshoot issue action

* move issue troubleshooting to a service

* feedback

* fix stable check
2023-06-12 13:37:50 +02:00
Raymond Zhao d81ca6dfca
Bump windows-registry to 1.1.0 (#184741) 2023-06-09 13:02:58 -07:00
Raymond Zhao 06ae4b61c2
Bump windows-mutex to 0.4.4 (#184366)
Also adds OS-specific .moduleignore files
2023-06-09 09:40:10 -07:00
Benjamin Pasero eac16e9b63
eng - make fetchWithRetry more robust (#184716) 2023-06-09 14:05:38 +02:00
Connor Peet 49535d6a04
build: fix missing param for build (#184660) 2023-06-09 01:10:08 +02:00
Aiday Marlen Kyzy 7dafe5df1d
renaming the CSS variable names and the labels from interactive editor to inline chat 2023-06-08 14:41:41 +02:00
Ladislau Szomoru cad3a1c656
Engineering - skip property mangling in PR builds (#184584) 2023-06-08 12:42:40 +02:00
Johannes Rieken d8dcdb924a
Merge pull request #184575 from microsoft/joh/protective-cicada
joh/protective cicada
2023-06-08 12:15:04 +02:00
Connor Peet e686621e2e
cli: avoid running prepare a second time in ci (#184558) 2023-06-08 02:22:44 +02:00
Connor Peet 9de813729c
build: install clippy when building cli in ci (#184554) 2023-06-07 16:40:30 -07:00
Connor Peet 43742d891d
Run a lint build of the CLI in CI (#184545)
* cli: adopt sccache for speedier cli compilations

* only cache common linux x64 build

* instead, only dev compile/clippy lint in ci
2023-06-07 15:48:55 -07:00
Johannes 978bb08619
add extensions-ci-pr task which does a full build without mangling 2023-06-07 16:36:02 +02:00
Aiday Marlen Kyzy c529638000
renaming the content inside of inlineChat folder from IE to IC 2023-06-07 16:02:34 +02:00
Johannes ac7789cbab
add core-ci-pr task which does a full build without mangling 2023-06-07 15:51:48 +02:00
Benjamin Pasero e615a31faf
eng - increase remote download retries (#184431) 2023-06-06 19:22:56 +02:00
Aaron Munger 693604f7fd
Merge branch 'main' into aamunger/testRenderer 2023-06-06 09:21:12 -07:00
Johannes Rieken f70686c39e
chore - rename interactiveEditor to inlineChat (#184422) 2023-06-06 16:34:55 +02:00
Aaron Munger 5c7b2b89fe add project to build, add integration tests into shell script 2023-06-05 14:19:51 -07:00
Henning Dieterichs aa88e727da
Implements initial version of moved code detection. (#184336)
* Implements initial version of moved code detection.

* Fixes monaco.d.ts

* Fixes tests.
2023-06-05 08:50:55 -07:00
Johannes 946cdaa03c
stub out cropped/expanded as CSS variables 2023-06-05 14:58:04 +02:00
Ladislau Szomoru 15dc0b5af3
Engineering - fix CLI build for Alpine ARM64 (#184309)
* Add task to install yarn

* Move task

* Add condition
2023-06-05 12:05:51 +02:00
Connor Peet eb44b5ef6c
build: don't apply cli 'patches' for merge check (#184210)
* build: don't apply cli 'patches' for merge check

This also needed modules installed. But with the new toml patches, the 'merge' will never fail outright, so there's no need to do a separate merge check for it imo

* reduce duplication in pipelines, cache node_modules
2023-06-02 22:29:48 +02:00
Connor Peet be433ac136
build: install packages for distro mixin (#184207) 2023-06-02 21:44:18 +02:00
Connor Peet 42015fe01c
build: support structured toml patches to reduce build breakage (#184201)
Currently the Cargo.toml patches are git patches, but these can break
easily when surrounding lines are changed. Instead this lets us make
"Cargo.patch.toml" which gets a structured merge.
2023-06-02 12:09:16 -07:00
Connor Peet ccc5e48e92
fix: breakpoints in extension subdirs on windows not working (#184195)
It did not normalize to forward slashes, so the empty sourcemap was
created with a source called `foo\\bar.js`. Then the build process was
adding a new source `foo/bar.js` since it didn't see it already in the
sourcemap, but `foo\\bar.js` was later normalized. This normalized
version came first in the mapping, but didn't have any mapped locations,
so breakpoints never got set.
2023-06-02 20:15:04 +02:00
Alex Dima 1331522372
Avoid using types defined in @types/trusted-types 2023-06-02 12:32:46 +02:00
Robo 0c1e34fa4e
chore: update electron@22.5.5 (#184115) 2023-06-01 21:38:57 -07:00
Alexandru Dima 828118d55e
Allow embedders to intercept trustedTypes.createPolicy calls (#184093) 2023-06-01 15:20:10 -07:00
Martin Aeschlimann 3f5def1cdc
Add logging to node download (#184070)
Add logging to node download. For #182951
2023-06-01 16:42:36 +02:00
Connor Peet 78643b05d5
cli: bump to openssl 1.1.1u (#183828) 2023-05-30 20:44:56 +02:00
Martin Aeschlimann c2a9a86afa
Delete --compatibility=1.63 code from the server (#183738) 2023-05-29 15:24:14 -07:00
Robo c26003f37a
chore: update electron@22.5.4 (#183716) 2023-05-29 16:09:35 +02:00
Henning Dieterichs 46132523d0
Merge branch 'main' into rainbow-indent 2023-05-26 17:57:21 +02:00
Henning Dieterichs 397f2e7c34
First draft of diff editor v2. 2023-05-26 15:26:31 +02:00
Bhavya U 049ee36265
Initial welcome widget commit (#183446)
* Initial welcome widget commit

* Update i18n.resource.json for welcomeDialog

* Clean up code
2023-05-26 00:03:23 +02:00
Joyce Er bc1090cc10
Initial share provider API and UI (#182999)
* Formalize share provider API

* i18n.resources.json

* Don't introduce a generic Success dialog severity
2023-05-22 15:32:43 -07:00
Jacek Kopecký cbbd9220c2
Add settings for fixed-width tabs (#181729)
* Add settings for fixed-width tabs

This is meant at least partially to address #40290 and
is a continuation of the unfinished work from #40750.

* Only apply fixed width when the setting is on

* Implement chrome-like tab width behavior

Tabs shrink uniformly (down to a limit) but stay fixed-width
when the mouse is over the tab bar.

* Rename width setting to max width

* Make the ifs more readable

* Have event handlers only if the option is set

* 🎨

* Handle sizing artifacts present with wrapping tabs

To achieve this, it's best to remove the transition delay.

* Rename setting to apply only for fixed-sized tabs

* Set default fixed max tab width to 160px

* Minor code tweaks from review comments

* formatting

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* Use disposable listeners

* Remove redundant check for last-in-row

* Apply fade gradient from shrink tabSizing to fixed

* Trying to make the code cleaner and understandable

* Remove transition

On advice of @bpasero, removed transition because
the editor doesn't really use transition that much.

* some cleanup

* fix typo

* Simplify workaround for the overflow issue

* 💄

* 💄

* Let the tabs fix their width before closing the editor

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-05-22 15:32:52 +00:00
Robo ced29a4346
chore: update electron@22.3.10 (#183116) 2023-05-22 16:34:36 +02:00
Benjamin Pasero 487a08afe5
Investigate detecting slow network connections (#178553) (#182653) 2023-05-22 14:38:13 +02:00
Daniel Imms adbcbfa5d0
Merge pull request #183005 from microsoft/tyriar/139400
Support fish SI automatic injection
2023-05-19 18:28:39 -07:00
Rob Lourens d052d3190f
More "chat" renames (#182990)
* More "chat" renames

* More renames
2023-05-19 16:14:43 -07:00
Daniel Imms 9d1a210778
Support fish SI automatic injection
Fixes #139400
2023-05-19 15:45:28 -07:00
Martin Aeschlimann 42fcfb8bfc
innosetup to start/stop tunnel service (#180527)
* innosetup to start/stop tunnel service

* better messages for tunnel still running

* fix error

* more logs

* add '/log'

* update

* fix

* update

* add kill & timeout wait

* stop service in PrepareToInstall

* non-background: check for tunnel mutex when wizard starts

* polish tunnel mutex names, prompt if tunnel is still running
2023-05-19 11:07:43 +02:00
Connor Peet 0c94abc4a5
implement sign service for web (#182815)
* signing: implement signing service on the web

* update distro
2023-05-17 16:52:56 -07:00
João Moreno 0f833f26f9
ignore SECURITY.md from vsda (#182780) 2023-05-17 19:00:49 +02:00
Robo 75e38cd91d
chore: remove library entitlements from main helper executable (#182731) 2023-05-17 10:35:11 +02:00
Martin Aeschlimann f1258a5fbe
replace 'got' with 'node-fetch' (#182629)
replace 'got' with 'node-fetch' (for #182624)
2023-05-17 06:20:31 +02:00
SteVen Batten 51b8bdc782
updating tsa options (#182651)
* updating tsa options

* add template
2023-05-16 18:49:25 +02:00
Rob Lourens 2156969dcf
Rename files 2023-05-15 15:54:11 -07:00
Daniel Imms e7a3127217
Integrate xterm-addon-image 2023-05-14 08:09:17 -07:00
Connor Peet d3d9f86116
cli: store cli in user data dir, separate per quality (#182102)
* cli: store cli in user data dir, separate per quality

Fixes #181017

On first run, the `~/.vscode-cli` will be migrated inside the user data dir of the currently running quality.

* use create_dir_all instead

* clippy fixes
2023-05-10 13:09:23 -07:00
Benjamin Pasero 83e7b4dcec
🆙 electron@22.5.2 (#182043) 2023-05-10 13:19:45 +02:00
Benjamin Pasero cc1555625d
debt - stop referring to patched node (#181933) 2023-05-09 20:55:05 +02:00
Sandeep Somavarapu d4632bb740
unc - adopt setting and handling of allow list (#181916)
* unc - adopt setting and handling of allow list (#5)

* unc - adopt setting and handling of allow list

* unc - set allow list on server too

* unc - pick our patched node.js for now

* bump electron

* unc - ignore sync is not needed with machine scope

* unc - use process set directly

* 🆙 22.5.1

* fix compile

---------

Co-authored-by: Benjamin Pasero <Benjamin.Pasero@microsoft.com>
2023-05-09 19:52:08 +02:00
Rob Lourens 27f30a3a5d
Remove items from vscode-known-variables (#181561)
Remove items from vscode
2023-05-04 20:02:21 +02:00
Rob Lourens 2b470d47ee
Fix chat list styles (#181543) 2023-05-04 18:51:57 +02:00
SteVen Batten 92cc596fce
tsaoptions for codeql (#181459) 2023-05-04 08:42:45 -07:00
SteVen Batten baf7119fd7
enable tsa for sdl scan (#181269) 2023-05-01 21:10:44 +02:00
Robo 86b1962b0e
fix: chromium license packaging (#181142)
* Revert "Revert "chore: use chromium license file downloaded from Electron package (#181106)" (#181113)"

This reverts commit 25fc56b4de.

* chore: bump @vscode/gulp-electron

* chore: update distro
2023-04-28 15:14:31 -07:00
Robo 25fc56b4de
Revert "chore: use chromium license file downloaded from Electron package (#181106)" (#181113)
This reverts commit d7da8fc2c9.
2023-04-28 12:52:08 +02:00
Robo d7da8fc2c9
chore: use chromium license file downloaded from Electron package (#181106) 2023-04-28 11:45:00 +02:00
Henning Dieterichs b816a3ffaf Fixes CI 2023-04-26 23:31:20 +02:00
Megan Rogge 4d9332c5bc
Merge pull request #180719 from microsoft/merogge/option
add accessibility verbosity settings, use editor options
2023-04-25 07:03:00 -07:00
João Moreno 14ea89e7ca
build: quieter node module cache logging (#180709) 2023-04-25 08:26:56 +02:00
Matt Bierner 03540d605f
Pick up latest TS for building VS code (#180706) 2023-04-24 20:14:30 +02:00
meganrogge 7c905c6ba0
use editor options 2023-04-24 09:44:08 -07:00
Robo 039fd8980d
chore: update electron@22.4.8 (#180526) 2023-04-21 17:59:30 +02:00
Martin Aeschlimann dad6ca32fc
adopt tunnel mutex name change (#180524) 2023-04-21 17:49:10 +02:00
Alexandru Dima c29e4b0fdb
Revert "add accessibility verbosity settings for terminal and diff editor aria hints" (#180477) 2023-04-21 09:26:33 +02:00
Raymond Zhao ee76f103e1
Use custom node-gyp for SDL pipeline (#179723)
* Use custom node-gyp
* Avoid using relative cd
* Remove ia32 for Linux
* Bump gulp-atom-electron; unblocks downloading PDBs
* Add native-is-elevated to the scan
2023-04-21 09:15:05 +09:00
meganrogge 612c4f17e8
fix issues 2023-04-19 14:19:35 -07:00
Robo d57d7ff4dc
chore: update electron@22.4.7 (#180276) 2023-04-19 04:34:34 +02:00
Robo a24f964ea1
Revert "chore: update electron@22.4.6 (#179947)" (#179991)
This reverts commit 316995c8b6.
2023-04-14 18:37:17 +01:00
Robo 316995c8b6
chore: update electron@22.4.6 (#179947) 2023-04-14 09:45:30 +01:00
Raymond Zhao 6f0421755f
Use custom node-gyp in product build (#179612)
Co-authored-by: Robo <hop2deep@gmail.com>
2023-04-13 08:04:41 -07:00
Robo 1307c7afbe
chore: update electron@22.4.5 (#179857)
* chore: update electron@22.4.5

* chore: avoid replacing ffmpeg
2023-04-13 21:32:24 +09:00
Connor Peet ca9404bd2f
cli: read tunnel lock from product.json (#179800)
Fixes #179265
2023-04-12 18:52:37 +01:00
Raymond Zhao 22ed59eb3d
Bump windows-process-tree with workaround for typings (#179649) 2023-04-11 10:05:56 -07:00
Raymond Zhao 07aec54e2e
Bump spdlog (#179642) 2023-04-11 08:00:57 -07:00
Connor Peet b547b58db6
cli: use win32 app mutex to detect running tunnels and tunnel sevices (#179622)
* cli: fix distro mixin

* cli: use win32 app mutex to detect running tunnels and tunnel sevices

Fixes #179265

* cli: fix distro mixin more

* fix

* fix build
2023-04-10 20:25:14 +01:00
Raymond Zhao 84ac780186
Revert "Bump windows-process-tree" (#179508)
Revert "Bump windows-process-tree (#179176)"

This reverts commit 15cb6b36f8.
2023-04-08 00:47:57 +01:00
Robo 34c8b46830
chore: bump electron@22.3.5 (#179357) 2023-04-06 09:16:54 +02:00
Raymond Zhao 15cb6b36f8
Bump windows-process-tree (#179176)
* Bump windows-process-tree

* Fix compile error

* Add explanation to source

* Add that the types package has been deprecated
2023-04-05 20:51:26 +02:00
Robo 47426871d7
ci: fix symbol download for SDL pipeline (#179030) 2023-04-05 20:43:18 +02:00
Martin Aeschlimann 899cdd5ace
remove request dependency (#179149)
* remove request dependency

* replace gulp-remote-retry-src in build scripts

* fix retry delay & polish
2023-04-05 16:05:16 +02:00
Benjamin Pasero 34d69db22c
server - introduce support for nodejsRepository (#179105)
* server - introduce support for `nodejsRepository`

* fix path

* add auth

* proper download

* extract to utility function

* reuse

* fix compile
2023-04-05 14:36:25 +02:00
João Moreno 19f5801470
fix CI by always installing prebuilt extensions (#179247)
fix CI by installing prebuilt extensions
2023-04-05 14:24:51 +02:00
Ladislau Szomoru d6dae3a640
Engineering - update build agents (#179244)
* Engineering - update build agents

* Update ARM64 agent pool name

* Switch to windows 2019 agents
2023-04-05 12:54:37 +02:00
Martin Aeschlimann e5c82ebdde
update azure dependencies (#179141) 2023-04-05 10:59:59 +02:00
Ladislau Szomoru 59ec5734f1
Engineering - fix job name casing (#179236) 2023-04-05 09:31:29 +02:00
Connor Peet 6b0d9d79e1
build: properly install built-in extensions for tests (#179216)
Uses a cache and GH token to avoid hitting rate limits.

Fixes #179181
2023-04-05 01:53:46 +02:00
Raymond Zhao a1694a8628
Bump windows-mutex (#179196) 2023-04-04 23:36:05 +02:00
Ladislau Szomoru 9d486269f1
Engineering - update agent pool (#179190) 2023-04-04 23:32:22 +02:00
Matt Bierner 3104a4e68c
Remove uses of X-UA-Compatible meta tag (#177739)
* Remove uses of `X-UA-Compatible` meta tag

We no longer support IE

Mainly removing this from the webview html but  figured we should remove the other references to it as well

* Update tests

* Fix test
2023-04-04 13:02:01 -07:00
Benjamin Pasero f481836a89
🆙 esbuild@0.17.14 (#178664) 2023-04-04 12:43:16 +02:00
Robo d317fbf297
chore: revert @vscode/spdlog bump (#179103)
* Revert "chore: update spdlog@0.13.9 (#179087)"

This reverts commit 9eba21c20f.

* Revert "Bump spdlog (#179035)"

This reverts commit 4cc7f76f60.
2023-04-04 10:49:54 +02:00
Ladislau Szomoru 48d3110be1
Engineering - update OSS build agents (#179099)
Update build agents
2023-04-04 10:24:50 +02:00
João Moreno 887b24796e
fix build (#179093) 2023-04-04 09:29:40 +02:00
Raymond Zhao 90089562cc
Bump proxy-agent (#179033) 2023-04-03 15:23:31 -07:00
Raymond Zhao 4cc7f76f60
Bump spdlog (#179035) 2023-04-03 11:18:47 -07:00
João Moreno accffe11a5
automate private build detection (#179011)
* automate private build detection

* debug

* debug

* fixup
2023-04-03 17:10:13 +02:00
Martin Aeschlimann 59608d3aee
Update webpack, css/file & style loaders (#179008) 2023-04-03 16:10:40 +02:00
João Moreno 1ee72c4854
fix vscode scan pipeline (#178997) 2023-04-03 15:31:51 +02:00
Robo e5f61433b5
chore: update to Electron 22 (#177600)
* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* sandbox - cleanup from electron 22 update (#178919)

* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* temp: update distro

* sandbox - cleanup from electron 22 update

* missing comile

* more changes

* fix build

* restore

* 💄

* compile

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
João Moreno 1cbef3e6ce
Fix CI (#178944)
* fixed CI

* to revert: fake VSCODE_CIBUILD

* fix darwin build

* Revert "to revert: fake VSCODE_CIBUILD"

This reverts commit f9d5378c8b.

* why devops

* devops and variables are weird

* fix pr build

* fix macos
2023-04-03 15:14:08 +09:00
João Moreno 2da5a0024f
don't run windows CLI build in ci (#178921) 2023-04-02 10:56:15 +02:00
João Moreno aac80c3f0a
Adopt new distro format (#178689)
* Simplify distro

Also a ton of drive-by fixing around builds:
- simplified many oneliners
- fixed missing custom npm registry call setups
- remove unnecessary and duplicate work during builds
- many many fixes
2023-04-02 09:35:39 +02:00
Benjamin Pasero 95917c1376
eng - throw if minified output contains non-ascii characters (#178590) 2023-03-30 09:26:11 +02:00
Raymond Zhao a442d6a7cb
fix: refresh dependencies lists (#178606)
Reflects node-pty updates
2023-03-29 13:58:08 -07:00
Johannes Rieken 2cce9893ef
Merge pull request #178572 from microsoft/joh/bottom-parrot
joh/bottom parrot
2023-03-29 15:07:05 +02:00
Daniel Imms 278e7e7750
Add hover to i18n.resources 2023-03-28 15:35:44 -07:00
Benjamin Pasero b0b69338e8
debt - further reduce electron-browser layer (#178504)
* debt - move more tests out of `electron-browser`

* move more tests

* move preload script as well

* fix
2023-03-28 10:35:58 -07:00
Johannes 94ce8894c0
remove the box, use background instead, make input part have the shadow 2023-03-28 18:10:52 +02:00
Tyler James Leonhardt 0d5e948d86
Ensure external extensions are in the extensions project (#178283) 2023-03-26 16:55:04 +02:00
Benjamin Pasero 0e530c3e07
debt - do not ship *-dev.html (#178315)
do not ship `-dev.html`
2023-03-25 20:13:59 +01:00
Pouya Kary ✨ e367f30db6
Fixes #177580 (#177581)
fixed the spelling in commentGlyphForground to commentGlyphForeground

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2023-03-24 05:05:14 +00:00
David Dossett c89324c0b9
Reverse background colors on interactive session (#178165)
* Reverse background colors on interactive session

* Only apply borders to requests
2023-03-23 16:28:24 -07:00
João Moreno 6fe3014566
Workaround code signing issues (#178071)
* use dot net 6 for codesigning

* make esrpclienttool use continueOnError

* another one

* fix path

* argh
2023-03-23 10:52:34 +01:00
Paul Köck aa1052b3d8
Oh, it's already 2023 (#172649) 2023-03-23 10:33:54 +01:00
Malte Werschy 439f7e5bcc Implement indent guide colorization options. 2023-03-23 08:19:21 +01:00
Martin Aeschlimann 3f5600c324
Improve stylelint variable checking (#178002) 2023-03-22 14:59:25 +01:00
Johannes Rieken cbfa89a53e
extract dedicated colors (#177992) 2023-03-22 11:36:48 +01:00
João Moreno c6fbb48ec4
Revert "Update webpack (#177265)"
This reverts commit e88eb65966.
2023-03-17 18:55:15 +01:00
João Moreno 5f9bbf37c1
Revert "adopt new module locations (#177472)"
This reverts commit 5b6cd9c3c7.
2023-03-17 18:55:13 +01:00
Aaron Munger 500b217502
Merge pull request #177398 from amunger/aamunger/notebookRendererTests
added notebook output renderer tests
2023-03-17 08:08:29 -07:00
João Moreno 5b6cd9c3c7
adopt new module locations (#177472)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2023-03-17 15:34:17 +01:00
Martin Aeschlimann e88eb65966
Update webpack (#177265)
* update webpack

* update `@types/webpack`

* update copy-webpack-plugin

* update @types/webpack in build

* fix compile error in @types/eslint
2023-03-17 15:07:05 +01:00
aamunger 11c5e141ab
added notebook output renderer tests 2023-03-16 12:10:24 -07:00
Ulugbek Abdullaev 69bb0ad98a
add a new command runCommands that allows to run several commands sequentially (#177104)
add a new command `runCommands` that allows to run several commands sequentially
2023-03-16 15:48:48 +01:00
Johannes Rieken 1db217a0e2
Revert "Introduce share links in more places via a contrib" (#177328)
Revert "Introduce share links in more places via a contrib (#177311)"

This reverts commit e9ff97aa0f.
2023-03-16 11:27:25 +01:00
Joyce Er e9ff97aa0f
Introduce share links in more places via a contrib (#177311)
* Introduce share links in more places via a contrib

* Update `build/lib/i18n.resources.json`
2023-03-16 09:15:15 +01:00
Henning Dieterichs 33c203503d
Merge pull request #177058 from spahnke/left-fish
Expose `EditorZoom` in the monaco API
2023-03-15 17:07:00 +01:00
Henning Dieterichs ebe458556d
Don't mangle fields for the monaco editor, FYI @jrieken (#177223) 2023-03-15 14:46:23 +01:00
Johannes Rieken ddf5399b62
joh/warm pig (#177206)
* move into workbench/contrib, integrate with view

* always preview workspace edits
2023-03-15 12:48:37 +01:00
Logan Ramos a32f38f8ae
Temporarily skip extracting node-debug2 (#177131)
Temporarily skip extracting node-debug-2
2023-03-14 20:52:50 +01:00
Sandeep Somavarapu be755e4237
Merge pull request #176764 from yiliang114/judicial-silkworm
fix typos
2023-03-14 10:41:21 -07:00
Connor Peet 1b5fd140fb
Run tunnels as singleton process (for a --cli-data-dir) (#177002)
* wip on singleton

* wip

* windows support

* wip

* wip

* fix clippy
2023-03-14 08:09:47 -07:00
Sebastian Pahnke 107a4809df Expose EditorZoom in the monaco API 2023-03-14 10:02:19 +01:00
Tyler James Leonhardt bc392ac9ff
Remove stale code & old migration (#176828)
* Remove stale code & old migration

* Removes browserNlsMetadataPath everywhere which was the old attempt to localize the web
* Removes an old migration

* js file
2023-03-13 18:41:59 +01:00
Martin Aeschlimann 780b2f5758
add linter for css variable names (#176769) 2023-03-10 07:33:02 -08:00
yiliang114 ef3dbb5e11 fix: typos 2023-03-10 20:02:01 +08:00
Alexandru Dima 0255bb0b03
If defined, use the runtime configured baseUrl (#176573) 2023-03-09 07:20:15 -07:00
Robo 502ac5b213
ci: switch to core20 for snap (#127320)
* ci: switch to core20 for snap

* chore: update rpath of crashpad handler

* chore: remove unused exports
2023-03-08 18:14:55 -08:00
Henning Dieterichs 2a290b6a72
Move lineRange to editor/common/core and adds editor.experimental.asyncTokenizationLogging (#176408)
* Move lineRange to editor/common/core and adds editor.experimental.asyncTokenizationLogging

* Fixes CI
2023-03-07 18:00:08 +01:00
Tyler James Leonhardt 8ddd3bcf39
Allow pulling in external extension translations from somewhere else (#176090)
allow pulling in external extension translations from somewhere else

This will allow js-debug to push its strings to the extension localization repo and then we will grab the translated strings from there.
2023-03-03 13:15:28 -08:00
Daniel Imms a6c67db750
Add terminalContrib i18n 2023-03-02 13:44:11 -08:00
João Moreno 7e5c00f860
remove unused schedule (#175898) 2023-03-02 16:06:29 +01:00
Johannes Rieken 155cd6db22
More implicit public of protected fields fixing (#175869)
* debt - don't make `_insertSuggestion` force-public

https://github.com/microsoft/vscode/issues/166603

* fix most implict public making

https://github.com/microsoft/vscode/issues/166603

* implict public making causes a build failure

* fix one more violation
2023-03-02 12:56:22 +01:00
Robo 3a11b47eee
chore: revert to Electron 19 (#175851)
* Revert "Update to min supported version of node (#175723)"

This reverts commit f749e6be2d.

* Revert "chore: update min node version for development (#175663)"

This reverts commit f2a822fbe9.

* Revert "electron 22 sandbox - enable for OSS (#175659)"

This reverts commit 2551af21f8.

* Revert "chore: update to Electron 22 (#166430)"

This reverts commit 6e85d2b51e.
2023-03-02 02:58:46 -08:00
Rob Lourens 825e84e144
Implement interactive session provider api (#175810)
Implement interactive session provider
2023-03-01 23:47:18 +01:00
Connor Peet 26fe31fc66
update openssl-prebuild for musl failures (#175731)
* update openssl-prebuild for musl failures

* reapply vendoring

* reapply macos pipeline fix
2023-03-01 08:57:45 +01:00
Connor Peet f8119e9beb
Revert "cli: fix static import of openssl (#175681)" (#175727)
This reverts commit 7014a17b1f.
2023-03-01 07:43:32 +01:00
Connor Peet d4612fb717
cli: fix build for x64 musl (#175700)
try
2023-02-28 14:09:29 -08:00
Bhavya U c43e386ec1 Remove welcomeOverlay and its references 2023-02-28 11:53:27 -08:00
Connor Peet 7014a17b1f
cli: fix static import of openssl (#175681)
* cli: fix static import of openssl

* update dev tunnels
2023-02-28 11:20:58 -08:00
Robo f2a822fbe9
chore: update min node version for development (#175663) 2023-02-28 17:22:33 +01:00
Robo 6e85d2b51e
chore: update to Electron 22 (#166430)
* chore: bump electron@22.0.0-beta.5

* chore: bump electron@22.0.0-beta.7

* chore: update libc++ flags

* chore: switch to c++17

* chore: bump electron@22.0.0

* chore: bump electron@22.0.2

* chore: cleanup build config for linux

* chore: update debian dependencies

* chore: update rpm dependencies

* chore: update electron@22.0.3

* chore: bump electron@22.2.0

* chore: remove deprecated utility process invoker

* chore: bump electron@22.2.1

* chore: remove unused methods

* chore: update internal electron version

* chore: bump electron@22.3.0

* temp: update electron with default PGO

* chore: bump electron@22.3.1

* cleanup

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-02-28 07:04:00 -08:00
Robo a22b77d5e1
chore: bump electron@19.1.11 (#175531)
* chore: bump electron@19.1.11

* chore: update chromium version for security patches
2023-02-27 13:57:52 +01:00
Benjamin Pasero 9bbce647b3
debt - strict layer rules for more services (#175411) 2023-02-25 15:49:47 +01:00
JSJ 3e00dca41f
Fixed OpenWithCodeContextMenu text (#173468)
* Fixed OpenWithCodeContextMenu text

Changed tab to space in OpenWithCodeContextMenu that caused the option to show "missplaced" in the context menu of Windows file explorer.

* Fix encoding
2023-02-21 16:43:21 +00:00
Robo 78cb4eb690
chore: remove cups dependency (#174827) 2023-02-20 12:19:18 +01:00
Robo 20c4065239
chore: bump electron@19.1.10 (#174808) 2023-02-20 08:07:18 +01:00
Tyler James Leonhardt d5277e8e2b
Ensure language packs are installed on the server side (#174622) 2023-02-17 07:23:00 -08:00
Benjamin Pasero 31edbf7ca6
sandbox - move shared process to node layer (#174581) 2023-02-17 10:18:01 +01:00
SteVen Batten 174600ec07
fix build (#174596) 2023-02-16 17:56:20 +01:00
SteVen Batten a28dc84d88
warn on CG alerts (#174591) 2023-02-16 17:30:16 +01:00
João Moreno b4db415a10
cdn: only gzip encode known mimetypes (#174577) 2023-02-16 15:30:46 +01:00
João Moreno d619dcfc77
bump build/npm/gyp deps (#174361) 2023-02-14 17:21:39 +01:00
João Moreno 07a7d71087
Bump to @vscode/policy-watcher (#174354)
* use latest @vscode/policy-watcher

* fix compile

* ooops

* lock new version
2023-02-14 16:53:34 +01:00
dependabot[bot] 9076750961
Bump http-cache-semantics from 4.1.0 to 4.1.1 in /build/npm/gyp (#173400)
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](https://github.com/kornelski/http-cache-semantics/compare/v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-14 16:49:45 +01:00
dependabot[bot] ade2771f50
Bump http-cache-semantics from 4.1.0 to 4.1.1 in /build (#173136)
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](https://github.com/kornelski/http-cache-semantics/commits)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-13 16:43:32 -08:00
João Moreno c7930ca55d
Revert "bump @vscode/policy-watcher (#174063)" (#174072)
This reverts commit 47e3135bda.

Revert "move to @vscode/policy-watcher (#173950)"

This reverts commit a1e73c96a4.
2023-02-10 16:37:50 +01:00
SteVen Batten 49055d2286
add am task to sdl scan (#173954) 2023-02-09 07:45:30 -08:00
João Moreno a1e73c96a4
move to @vscode/policy-watcher (#173950) 2023-02-09 07:12:42 -08:00
Tyler James Leonhardt 31e476ee1e
bump @vscode-internal/openssl-prebuilt (#173827)
* bump @vscode-internal/openssl-prebuilt

* bump windows
2023-02-08 08:59:07 -08:00
Martin Aeschlimann 911f119120
generalize limit indicator and use for color decorators (#173730)
* generalize limit indicator and use for color decorators

* remove updateDebounceInfo max
2023-02-08 07:43:29 +01:00
Johannes Rieken 7e69465303
don't use underscore for native JS things (#173282) 2023-02-03 03:47:51 -08:00
Johannes f7f42dbd63
print/fwd SWC errors properly
https://github.com/microsoft/vscode/issues/173074
2023-02-02 11:57:38 +01:00
Raymond Zhao 7eb6452066
Add appdata.xml to rpm template (#172976)
Fixes #141092
2023-02-02 01:54:43 -08:00
Jean Pierre 22cfea1eb7 Fixes compilation in windows
Related #170767
2023-01-29 17:37:06 -05:00
Matt Bierner d67db9d358
Pick up latest TS for building VS Code (#172033) 2023-01-23 11:39:28 -08:00
Johannes Rieken 3db45fbd42
use normalized path when checking for mangled new contents, (#171964)
* use normalized path when checking for mangled new contents,

https://github.com/microsoft/vscode/issues/170767

* add missing js file
2023-01-23 14:11:36 +01:00
Daniel Imms 70ed6fa10a
Add workbench suggest o i18n.resources.json 2023-01-19 13:22:58 -08:00
João Moreno 5bb0a22e43
fixes bad node_modules cache usage (#171725) 2023-01-19 15:30:50 +01:00
Robo fdb2befac5
chore: update node-pty@0.11.0-beta27 (#171583) 2023-01-19 11:12:46 +01:00
Connor Peet a0562ccdb2
build: fix win32 signed cli archive (#171584) 2023-01-18 09:30:03 +01:00
Connor Peet d5ab02349e rename cli binary to reflect quality 2023-01-17 08:19:36 -08:00
João Moreno e8fa61d2fc
retry terrapin 5 times (#171489)
fixes #170935
2023-01-17 13:48:02 +01:00
Martin Aeschlimann d4237bd8d5
merge ThemeIcon and CSSIcon (#171279) 2023-01-13 20:15:16 +01:00
Tyler James Leonhardt 7c0e51357d
Pull l10n files from build folder for extensions that don't live in source (#171217)
This will allow the l10n build to pick up the bundle.l10n.json inside of js-debug

cc @connor4312
2023-01-13 08:34:14 +01:00
João Moreno 89e427274e
fix darwin universal (#171072) 2023-01-11 17:09:19 +01:00
João Moreno 277e80be94
dynamically find macos signing identity (#171063)
* dynamically find macos signing identity

* debug

* more debug

* argh

* Revert "argh"

This reverts commit 0e0715fb44.

Revert "more debug"

This reverts commit 7632542023.

Revert "debug"

This reverts commit 6f00a3acef.
2023-01-11 23:39:31 +09:00
Robo 2fae780e49
chore: update code signing certificate identity (#171061) 2023-01-11 14:13:50 +01:00
SteVen Batten d11f9ceb6f
better scanning (#170885)
* replace cql task in sdl scan

* fix var format

* switch to 1es-windows image
2023-01-09 20:17:34 +01:00
Connor Peet 314d7b6c47
debug: allow setting breakpoints in plain .js files (#168921)
* debug: allow setting breakpoints in plain .js files

Fixes #159684

* fixup! don't change sourceURLs in build
2023-01-06 09:22:46 +01:00
João Moreno 717d7d62c8
always authenticate to npm (#170437) 2023-01-03 09:27:18 +01:00
dependabot[bot] 6106980525
Bump json5 from 2.2.0 to 2.2.2 in /build (#170244)
Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.2.0...v2.2.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-30 21:50:46 +01:00
João Moreno 7f65f0213c
fix CI when publishing alpine assets (#169917) 2022-12-23 13:23:26 +01:00
João Moreno 326876fa9e
bump vsce (#168071)
* bump vsce

* remainder

* use latest vsce

* compile build output
2022-12-22 17:00:21 +01:00
Ladislau Szomoru f9333a4a16
Revert "Engineering - do not extract node modules archive in the job that keeps the cache warm (#169736)" (#169739)
This reverts commit 2f582604fb.
2022-12-21 13:33:43 +01:00
Ladislau Szomoru 2f582604fb
Engineering - do not extract node modules archive in the job that keeps the cache warm (#169736) 2022-12-21 12:44:30 +01:00
Ladislau Szomoru 574bc61051
Engineering - Windows job use generic node modules cache when quality is OSS (#169727) 2022-12-21 12:02:27 +01:00
Peng Lyu 687cc4fe97
Fix #168070. Filter ipynb output from hygine (#169691) 2022-12-20 23:33:30 +01:00
Ladislau Szomoru 9d5de75930
Engineering - Create Windows job to maintain cache (#169675)
Create Windows job to maintain cache
2022-12-20 21:18:53 +01:00
Ladislau Szomoru e1b6f8f9a5
Engineering - Add Windows test jobs to PR pipeline (#169627)
* Add Windows test jobs

* Comment out Windows smoke tests
2022-12-20 12:30:58 -07:00
Tyler James Leonhardt 0510da84dd
Use new version of @vscode/l10n-dev that uses tree-sitter (#169668)
Use new version of @vscode/l10n-dev

Required a bit more refactoring because an API had to be made async.
2022-12-20 19:53:50 +01:00
João Moreno 983b06e9bf
polish mangler output to align with build (#169388) 2022-12-16 13:20:07 +01:00
João Moreno 1e1da2aed3
build: refactor alpine out of linux (#169368)
* build: refactor alpine out of linux (#169278)

* fix alpine stage with no jobs

* test

* revert test
2022-12-16 08:51:06 +01:00
Joyce Er e408ce88e0 Revert "build: refactor alpine out of linux (#169278)"
This reverts commit 3567fd1145.
2022-12-15 11:47:27 -08:00
João Moreno 3567fd1145
build: refactor alpine out of linux (#169278) 2022-12-15 16:51:12 +01:00
Johannes 0d5f87e9dd
change source map merge logic to be like applying line edits to the typescript source maps (based on the input source maps) 2022-12-14 15:57:55 +01:00
Johannes 59f0d9c20e
fix ts2ts source map generation 2022-12-14 12:22:56 +01:00
Johannes cf8ae4b515
Merge branch 'main' into joh/sourceMaps-mangleProps 2022-12-13 14:18:00 +01:00
João Moreno 90812ba66f
remove unused pipeline (#168567) 2022-12-09 10:45:01 +01:00
Matt Bierner 6e5b663e99
Make sure lib.d.ts is included in build (#168501)
Fixes #168420
2022-12-08 11:36:42 -08:00
dependabot[bot] 7ca99004a5
Bump qs from 6.10.1 to 6.11.0 in /build (#168174)
Bumps [qs](https://github.com/ljharb/qs) from 6.10.1 to 6.11.0.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.10.1...v6.11.0)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-07 09:26:10 +01:00
Sandeep Somavarapu fac2283bf3
fix string.replace (#168169)
fix string.replace #167239
2022-12-06 14:50:23 +01:00
Johannes f73bb21f27
wip 2022-12-02 13:03:16 +01:00
Matt Bierner ce934ff443
Also run cleanNodeModules on extensions/node_modules (#167476)
Also run cleanNodeModules on extensions/node_modules

Fixes #166652
2022-11-29 12:15:09 -08:00
Matt Bierner afd71d8f10
Be more selective about which typescript d.ts files we include (#167477)
Be more selective about which d.ts files we include
2022-11-28 16:27:03 -08:00
Martin Aeschlimann 86ff830c3a
fix string.replace (for #167239) (#167259) 2022-11-25 14:45:57 +00:00
Benjamin Pasero aa961ec5da
String.replace will substitute special patterns (#167239) (#167250) 2022-11-25 14:03:49 +00:00
Johannes Rieken 1e3d0b5c05
mangle polish (#166604)
* mangle polish

* missing js files (again...)
2022-11-24 14:52:10 +01:00
Connor Peet fb53973c5f
cli: pull documentation url from product.json (#166993)
Fixes https://github.com/microsoft/vscode-cli/issues/560
2022-11-22 11:21:41 -08:00
Connor Peet 94ee5f5861
cli: automatically use distro qualities if available (#166961)
A fully-functioning CLI with tunnel capabilities requires product-specific
configuration that is not included in the OSS. This change has the CLI's build
script automatically look for a peer `vscode-distro` folder and, in a debug
build, set its build variables based on that.

It also works to set correct variables if vscode-distro is not found, based on
the OSS product.json (though this is not sufficient to run a fully fledged
tunnel.)
2022-11-22 06:13:16 -08:00
Martin Aeschlimann 0131be02f4
add editorWebUrl to tunnelApplicationConfig (#166872)
* add editorWebUrl to tunnelApplicationConfig

* bump distro & compile 'build'
2022-11-21 09:37:26 -08:00
Johannes Rieken f08feed6f1
Merge pull request #166686 from microsoft/joh/middle-jellyfish
Remove __$__nodeRequire usages
2022-11-21 11:50:02 +01:00
Johannes 0dac468cc0
mark package.json as external module 2022-11-21 11:26:17 +01:00
Connor Peet 796ee2bf3c
chore: pull more strings from the product.json (#166769)
Fixes the bulk of https://github.com/microsoft/vscode-cli/issues/560
2022-11-18 18:52:52 -08:00
Matt Bierner f98ca02f59
Use moduleignore to try excluding unused ts files (#166654)
Use moduleignore to exclude unused ts files

Fixes #166652
2022-11-17 15:53:52 -08:00
Johannes fdc39b56e4
missing JS files 2022-11-16 13:47:07 +01:00
Johannes Rieken 3ffb834054
Merge branch 'main' into joh/rewrite-privates 2022-11-16 10:20:49 +01:00
Henning Dieterichs 3e19ba91ff
Allows to pass in a custom diffing algorithm when instantiating the monaco diff editor. (#165179)
* Allows to pass in a custom diffing algorithm when instantiating the monaco diff editor.

* Undo launch.json change
2022-11-16 08:48:39 +01:00
Matt Bierner d0d28a6295
Reapply building of web server (#166391)
* Reapply building of web server

Revert 8b4642ab23

* Fix critical dep error
2022-11-15 14:55:40 -08:00
Henning Dieterichs b11207c539 Revert "Copy webServer from Typescript to VS Code (#165771)"
This reverts commit cb43019d6a.
2022-11-15 14:45:32 +01:00
Johannes c281755a1b
more missing JS files 2022-11-15 09:45:01 +01:00
Johannes 5912ad3ff1
Merge branch 'main' into joh/rewrite-privates 2022-11-15 09:44:34 +01:00
Johannes 424a88c0ef
missing JS files 2022-11-15 09:05:07 +01:00
Connor Peet c47751948c
cli: add service integration for systemd (#166328)
systemd, like most 'modern' linux components, has a nice dbus API. This uses
that API to register the tunnel as a service of the calling user.

The dbus dependency is temporarily duplicated, until secret-service 3 is
released, where they update to the latest version (should be a week or two).

For https://github.com/microsoft/vscode-cli/issues/367. Next up, macOS,
then it's done :)
2022-11-14 21:39:05 -08:00
Nathan Shively-Sanders cb43019d6a
Copy webServer from Typescript to VS Code (#165771)
* Initial draft.

Not working.
Also not correctly formatted, I'll do that later.

* Various fixes

It works now

* A bit of cleanup

* Move webServer to its own directory

And prepare for getting rid of dynamicImportCompat.js hack

* Remove dynamicImportCompat.js hack

* Revert unrelated change

* Webpac tsserver.web.js with webServer.ts as entrypoint

Instead of using CopyPlugin.

1. Shipping multiple entrypoints in a single file required fixes to
build code.
2. There are a couple of warnings from `require` calls in
tsserverlibrary.js. Those are not relevant since they're in non-web
code, but I haven't figured how to turn them off; they are fully dynamic
so `externals` didn't work.

* Ignore warnings from dynamic import in tsserver

* Add to .vscodeignore files
2022-11-14 10:56:31 -08:00
Johannes aeb79e48a0
free memory when TS2TS mangling is done 2022-11-14 16:54:13 +01:00
Johannes 85c28e5927
improve printing of implicit public cases 2022-11-14 16:15:11 +01:00
Johannes d481999d09
make TS-mangler part of compile-build 2022-11-14 15:55:02 +01:00
Johannes 201e6a3e11
make mangler a class with mangle call, return vinyl instances 2022-11-14 13:51:21 +01:00
Johannes fb8187c953
source maps for build/lib 2022-11-14 11:57:01 +01:00
Johannes 66198056ea
source maps for build/lib 2022-11-14 11:56:32 +01:00
Johannes 58e979f39e
Merge branch 'main' into joh/rewrite-privates 2022-11-14 11:56:16 +01:00
Tyler James Leonhardt 964dc545ab
Pickup bundle.l10n.json (#166169)
For npm modules that have bundled `@vscode/l10n`, they can export their strings to a bundle.l10n.json file which will get picked up by this change and included in the overall bundle for the extension.
2022-11-12 14:42:39 -08:00
Johannes 15cb324f3f
do it all with the language service 2022-11-11 17:16:29 +01:00
Johannes 17737278ae
rename to typescript manger, (mostly) use language service rename feature 2022-11-11 13:48:21 +01:00
Ramón Corominas c9f32595a6
Update messages.es.isl to add context menu hotkey (#166010)
* Update messages.es.isl

Add a hotkey to allow opening with Code from the context menu also in Spanish

* fix encoding

Co-authored-by: Joao Moreno <joao.moreno@microsoft.com>
2022-11-11 01:34:09 -08:00
João Moreno 59814267dd
Use new Key Vault account (#166049)
use separate keyvault
2022-11-11 09:38:36 +01:00
Johannes 696c1cf199
build utils with source map to enable JS debug console 2022-11-10 15:05:47 +01:00
Matt Bierner d950552131
Allow trailing commas while minifying json resources (#165870)
I noticed a few of our built-in extension's json resources were not being minified. The root cause appears to be trailing commas in the json
2022-11-08 14:38:53 -08:00
易良 59faab44cd
Only use string of the remote/web/package.json browser field (#165163)
fix(build): Close #165162, only use string of the package.json `browser` field
2022-11-08 10:30:02 -05:00
Connor Peet 1d4beede78
Merge pull request #165773 from microsoft/connor4312/cli-pin-rust-version
cli: pin rust (and clippy) version for builds
2022-11-07 20:26:26 -08:00
Tyler James Leonhardt a8ae2cedaf
Include JS files in XLF creation for extensions (#165774)
* Bumps @vscode/l10n-dev to a version that supports JS files
* Pulls in JS files (and TSX & JSX) in addition to TS to account for scenarios like Emmet which pulls in @vscode/emmet-helper as an npm package
2022-11-07 19:50:39 -08:00
Connor Peet 63fbcea804
cli: pin rust (and clippy) version for builds 2022-11-07 17:56:35 -08:00
Connor Peet eb7c77c508
cli: only build common platforms in ci
Fixes #165140
2022-11-07 11:08:57 -08:00
Tyler James Leonhardt 0249ba460f
use the actual extension id as the id in the language pack (#165436)
Past behavior caused 404s to be thrown by the unpkg service because core was trying to load:

`${extensionId}` -> `vscode.markdown`

and not what the build creates in the language packs:
`vscode.${extensionFolder}` -> `vscode.markdown-basics`

this aligns build time and runtime.
2022-11-03 15:50:50 -07:00
Matt Bierner e7e403d83f
Bump target for build scripts (#165287) 2022-11-03 12:19:54 -07:00
Logan Ramos c6210c1c58
Reduce loaded web modules (#165369) 2022-11-03 08:36:45 -07:00
Alexandru Dima 4608b378a8
Align cache key across OSes (#165042) 2022-11-03 14:48:47 +01:00
João Moreno b0da2ea781
fix Alpine builds with npm custom registry (#165137)
fixes #165135
2022-11-01 07:28:06 -07:00
João Moreno be022daa1a
add 🚀 build tag to builds which go through publishing (#165145) 2022-11-01 04:15:50 -07:00
João Moreno 0a19bf0e8f
fix inno setup build for non-insider qualities (#165143)
fixes #165142
2022-11-01 03:53:58 -07:00
Matt Bierner d1c401cbde
Pick up latest TS for building VS Code (#165104)
* Pick up latest TS for building VS Code

* Pick up latest node typings

* Bump node types
2022-11-01 02:43:09 -07:00
Tyler James Leonhardt 0a80e31f6f
Sort the keys in order to be more predictable (#164920)
sort the keys in order to be more predictable
2022-10-28 21:16:05 +02:00
Ladislau Szomoru c7647cd307
Engineering - Add quality in the build name (#164855)
Add quality in the build name
2022-10-28 10:01:45 +02:00
Alexandru Dima ba91a81c16
Always patch the npm registry in yarn.lock files and compute the node modules cache key after having patched them (#164795) 2022-10-27 12:31:15 +02:00
Alexandru Dima c3eebaead9
Fix accidental deletion of vscode.proposed.contribNotebookStaticPreloads.d.ts and make sure to include the check in the compile-build gulp task (#164681) 2022-10-26 10:59:54 +02:00
Matt Bierner 0c6cc3a886
Let markdown strings specify a list of commands that they allow (#163915)
* Let markdown strings specify a list of commands that they allow

Fixes #163913

* Fix name
2022-10-24 14:15:44 -07:00
Connor Peet ed54a91fd0
build: parallelize cli build
Put all win and macOS builds on their own machine, since they take a minute.
Build the two GNU ARM builds together on an x64 machine, since they're
faster and can cross-compile in ~5 minutes.

This makes the CompileCLI step take a little less time than the VS Code
"Compile" step.
2022-10-24 12:01:03 -07:00
Johannes Rieken fec87f38cb
Analyse profiles in worker thread (#164468)
- profile renderer returns profile data
- analyse profiles in separate worker thread
- adjust renderer and extension host profiling
- adjust build scripts to build worker file
2022-10-24 17:42:54 +02:00
Ladislau Szomoru b757c8e3ca
Engineering - Pin macOS build agent (#164455)
Pin macOS build agent
2022-10-24 06:38:26 -07:00
João Moreno 8fe6f3e917
Allow custom npm registries at build time (#163629)
* use azure artifacts as new terrapin solution

* debug

* skip npm auth

* bring back

* also configure yarn

* custom npm registry

* oops

* powershell

* use none instead of empty string

* uff
2022-10-24 09:24:44 +02:00
Robo bece5db818
chore: cleanup inno setup for context menu install (#164411) 2022-10-24 06:45:20 +02:00
Martin Aeschlimann f10e84118b
ci: use tunnelApplicationName (#164257)
fix location of tunnel command in CI and in code
2022-10-23 20:12:23 +03:00
Connor Peet b3a0ecc97f
Merge pull request #164270 from microsoft/connor4312/use-packaged-openssl
build: use packages openssl instead of compiling during builds
2022-10-21 11:35:18 -07:00
Robo ebea50afee
feat: bundle sparse package to integrate with windows context menu (#151186)
* chore: bundle and sign explorer appx

* chore: bump vscode-explorer-command@3.0.1

* chore: explorer install/uninstall stage for appx

* chore: fix format for cmd exec

* chore: cmd file path needs triple quotes

* chore: update vscode-explorer-command@3.0.2

* chore: add reg key for new context menu title

* chore: update vscode-explorer-command@3.0.3

* fix: guard behind insider quality

* chore: fix merge conflict

* fix: type mismatch

* chore: restrict context menu related actions for win11

* refactor appx loading/unloading, revert inno updater

* update powershell

* chore: undo inno_updater changes

* fix: appx install script

* fix: perform install after update step

* fix: mv appx install to files section

* chore: additional fixes

- Remove old context menu entries when updating to newer version
- Remove context menu entry when reinstalling without menu action selected.

* chore: update vscode-explorer-command@3.0.4

- Fixes garbled title for system installation

Co-authored-by: Joao Moreno <joao.moreno@microsoft.com>
2022-10-21 20:17:30 +02:00
Connor Peet fff294400b
Merge remote-tracking branch 'origin/main' into connor4312/use-packaged-openssl 2022-10-21 10:55:13 -07:00
Connor Peet c3692c96f6
build: use npm instead of universal for arm compatibility 2022-10-21 10:21:02 -07:00
Sandeep Somavarapu c1ac223c69
fix node-vsce-sign (#164253)
* update distro

* add vsce-sign to asar

* filter node-vsce-sign

* update distro
2022-10-21 08:25:36 -07:00
Abhishek Singh 9509e6f3ef
increase innosetup minversion to win8 (#163040)
* increase innosetup minversion to win8

* Update build/win32/code.iss

Co-authored-by: João Moreno <mail@joaomoreno.com>
2022-10-21 16:54:05 +02:00
Connor Peet abf905e5dd
build: cleanup old cmakes 2022-10-20 18:33:06 -07:00
Connor Peet ddd4431d14
build: fix git auth with cli 2022-10-20 18:25:19 -07:00
Connor Peet 883bac79c4
build: fix
Local debug stuff got onto main
2022-10-20 17:59:16 -07:00
Connor Peet bf36a10c47
cli: use packaged openssl instead of artisanal builds 2022-10-20 17:14:14 -07:00
Connor Peet 0cc08da37a
cli: build the tunnel cli by default 2022-10-20 16:58:02 -07:00
Connor Peet 8ba5882fb8
Merge pull request #163971 from microsoft/connor4312/cli-vcpkg
cli: use vcpkg for everything
2022-10-20 16:45:18 -07:00
Connor Peet c536595a7f
cli: fallback to system installs in the standalone CLI
The standalone CLI should detect and fall back to using and
system-installed VS Code instance, rather than trying to download zips
and manage its own VS Code instances.

There are three approaches used for discovery:

- On Windows, we can easily and quickly read the register to find
  installed versions based on their app ID.
- On macOS, we initially look in `/Applications` and fall back to the
  slow `system_profiler` command to list app .app's if that fails.
- On Linux, we just look in the PATH. I believe all Linux installers
  (snap, dep, rpm) automatically add VS Code to the user's PATH.

Failing this, the user can also manually specify their installation dir,
using the command `code version use stable --install-dir /path/to/vscode`.

Fixes #164159
2022-10-20 10:54:13 -07:00
Connor Peet 8bfd07de06
update client builds to pull the right artifacts 2022-10-18 15:42:31 -07:00
Connor Peet 691ffd27c2
fix missing sudo 2022-10-18 15:05:49 -07:00
Connor Peet 067db8e75b
set linker for armhf correctly 2022-10-18 14:59:21 -07:00
Connor Peet ed0a21eda6
Merge remote-tracking branch 'origin/main' into connor4312/msrustup 2022-10-18 14:25:51 -07:00
Connor Peet 24a51e506f
try using vcpkg for everything 2022-10-18 10:58:50 -07:00
Connor Peet c625ff80d3
Merge pull request #161658 from microsoft/connor4312/cli-self-update
cli: implement correct self-updating
2022-10-18 08:38:28 -07:00
Martin Aeschlimann c83eff40dd
Remove too many folding regions notification (#163854)
* Remove too many folding regions notification

* remove duplicate folding limit item for JSON/JSONC

* polish

* fix test
2022-10-17 14:42:02 -07:00
Connor Peet b987cb47f4
fix integrated cli check 2022-10-17 13:53:06 -07:00
Connor Peet 4e9bdbd44f
make self-update work on Linux 2022-10-17 13:38:52 -07:00
Connor Peet 7c3740a7e7
update prepare scripts, license, lockfile 2022-10-17 11:50:49 -07:00
Connor Peet 75dfb8993e
Merge branch 'main' into connor4312/cli-self-update 2022-10-17 11:15:23 -07:00
Connor Peet cb1b7ec10b
temporarily disable secret-service pending update 2022-10-17 11:13:51 -07:00
Connor Peet 450f8e65b6
run cli tests on pr 2022-10-17 09:56:15 -07:00
Connor Peet 84439a87f6
wip 2022-10-14 15:46:49 -07:00
Connor Peet 84a929b8b7
Merge remote-tracking branch 'origin/main' into connor4312/cli-self-update 2022-10-14 14:23:41 -07:00
João Moreno ac9aff3521
reenable terrapin (#163622)
* drop npx for terrapin

* enable terrapin by default
2022-10-14 01:35:15 -07:00
Tyler James Leonhardt 4502088b10
fix empty check for json (#163576) 2022-10-13 11:01:05 -07:00
Tyler James Leonhardt 77d14a4711
use size to check if any files were added (#163571)
use size
2022-10-13 09:54:57 -07:00
Martin Aeschlimann 17c7a08962
Add cli & command to run the code server on the desktop (#163546)
Add cli & command to run the code server on the desktop
2022-10-13 15:02:42 +02:00
Tyler James Leonhardt a8108049ab
Allow extensions to use new API and it get included in Language Packs (#163493)
* Allow extensions to use new API and it get included in Language Packs

This leverages the l10n-dev package to analyze ts files for `l10n.t` calls.

* delete console.logs
2022-10-12 17:28:34 -07:00
Connor Peet a5e9b83d65
ci: fix wrong file in cli tests 2022-10-12 17:05:41 -07:00
Tyler James Leonhardt 342aa9c59a
Improvements to i18n (#163372)
* remove dead code from Transifex

* use @vscode/l10n-dev for XLF operations for extensions

* generated files

* more generated files

* remove dead code

* move l10n-dev to where gulp is

* generated
2022-10-12 14:10:57 -07:00
Connor Peet 6353f80f3d
Merge pull request #161640 from microsoft/build-integrated-cli
Update build process to include integrated CLI
2022-10-12 08:59:37 -07:00
Alexandru Dima 72a982d0d3
Fix typo in regex (#163404) 2022-10-12 00:08:09 -07:00
Tyler James Leonhardt 3e4e351816
Enforce ILocalizedString usage with f1 property via types (#162991)
* Enforce ILocalizedString usage with f1 property via types

* complete comment

* Visit all symbols when encountering a union type

* use ILocalizedString

* fix tests

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-10-11 21:24:43 -07:00