development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't mangle fields for the monaco editor, FYI @jrieken (#177223)

Browse source
This commit is contained in:
Henning Dieterichs 2023-03-15 14:46:23 +01:00 committed by GitHub
parent 72b1ad9f24
commit ebe458556d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
build/gulpfile.editor.js
View file

@ -85,7 +85,8 @@ const extractEditorSrcTask = task.define('extract-editor-src', () => {
});
});
const compileEditorAMDTask = task.define('compile-editor-amd', compilation.compileTask('out-editor-src', 'out-editor-build', true));
// Disable mangling for the editor, as it complicates debugging & quite a few users rely on private/protected fields.
const compileEditorAMDTask = task.define('compile-editor-amd', compilation.compileTask('out-editor-src', 'out-editor-build', true, { disableMangle: true }));
const optimizeEditorAMDTask = task.define('optimize-editor-amd', optimize.optimizeTask(
{

6
build/lib/compilation.js
View file

File diff suppressed because one or more lines are too long

4
build/lib/compilation.ts
View file

@ -106,7 +106,7 @@ export function transpileTask(src: string, out: string, swc: boolean): () => Nod
};
}
export function compileTask(src: string, out: string, build: boolean): () => NodeJS.ReadWriteStream {
export function compileTask(src: string, out: string, build: boolean, options: { disableMangle?: boolean } = {}): () => NodeJS.ReadWriteStream {
return function () {
@ -123,7 +123,7 @@ export function compileTask(src: string, out: string, build: boolean): () => Nod
// mangle: TypeScript to TypeScript
let mangleStream = es.through();
if (build) {
if (build && !options.disableMangle) {
let ts2tsMangler = new Mangler(compile.projectPath, (...data) => fancyLog(ansiColors.blue('[mangler]'), ...data));
const newContentsByFileName = ts2tsMangler.computeNewFileContents(new Set(['saveState']));
mangleStream = es.through(function write(data: File & { sourceMap?: RawSourceMap }) {