Commit graph

108996 commits

Author SHA1 Message Date
David Freer 89636b9b4c
PHP Snippets Quality of Life and Continuity (#174889)
* QoL & continuity update to existing php snippets

- Sorted snippets by snippet title for discoverability
- Removed all doc comments from non 'doc_' prefixed snippets
- Added doc_trait for continuity with other patterns
- Updated snippet prefixes
	- Add kvp to keyval
	- Prefixed fun with class_
	- Changed doc_param to doc_var
	- Qualified 'con' to 'constructor' to not be confused with const
- Updated class snippet to default the 'class' placeholder to the file's base name
- Add snippet choices for private, public, protected where appropriate
- Add an additional tab stop to end of functions for additional args/params
- Remove array kvps since arrays can be associative or just values

* Add try catch finally php snippet

* Add param php snippet

* Add php func snippets

- Add fun for a general function out of scope of class
- Add fun_anonymous for anonymous functions
- Add fun_arrow for arrow functions

* Add promotion style constructor to php snippets

* Add property snippet to php snippets

* Add spaceship snippet to php snippets

* Add goto snippet to php snippets

* Add class_const snippet to php snippets

* Add here/now doc snippets to php snippets

* Add namespace related snippets to php snippets

* Add superglobal snippets to php snippets

* Add php 8 snippets

- Add match expression
- Add Attribute snippets
  - Add sensitive parameter
  - Add attribute target
  - Add attribute with target
- Rename class_const to const
- Add Dynamic Property Class snippet
- Add enum snippets
  - Basic Enum
  - Backed Enum
  - foreach enum

* Merge master to resolve conflict

* Remove php snippets as candidates

- Remove heredoc
- Remove nowdoc
- Remove php super global snippets
- Remove namespace_path
- Remove ethis (echo $this->)
- Remove try/catch finally

* Trim snippets

---------

Co-authored-by: Rob Lourens <roblourens@gmail.com>
2023-05-18 14:46:36 -07:00
Greg Van Liew ce903f336a
Fix typo "shadown" (#182916) 2023-05-18 14:40:20 -07:00
Matt Bierner b11a3f7f87
Disable flaky test (#182814)
Fixes #182489
2023-05-18 13:17:51 -07:00
Megan Rogge 01680658ad
Merge pull request #182904 from microsoft/merogge/pty-kill
revert change to terminal process kill signal
2023-05-18 12:41:50 -07:00
Kartik Raj a1cccc5fa4
Merge pull request #182238 from microsoft/kartik/puzzled-harrier
Updates to environment collection workspace API
2023-05-18 12:36:05 -07:00
meganrogge ddce114af3
revert change to terminal process kill signal 2023-05-18 12:19:33 -07:00
Kartik Raj c2df3b75a7 Undo unnecessary cast 2023-05-18 19:09:40 +00:00
Kartik Raj 64ee37a32d Change how we get variable map 2023-05-18 18:56:05 +00:00
Kartik Raj db774adddd Simplify 2023-05-18 18:54:02 +00:00
Kartik Raj 616fa578c8 Revert "Temporarily finalize getScopedEnvironmentVariableCollection"
This reverts commit 88799ca215.
2023-05-18 18:40:29 +00:00
Kartik Raj 5749e3d9ff Revert "Fix error"
This reverts commit affca3b3f1.
2023-05-18 18:40:24 +00:00
Kartik Raj 0874a6a714 Do not use spread 2023-05-18 18:34:33 +00:00
Kartik Raj affca3b3f1 Fix error 2023-05-18 18:12:19 +00:00
Matt Bierner 728197deb8
Remove some completions logic specific to old TS versions (#182894)
Removes workarounds added for TS versions that are many years old at this point
2023-05-18 11:10:31 -07:00
Kartik Raj 88799ca215 Temporarily finalize getScopedEnvironmentVariableCollection 2023-05-18 18:05:47 +00:00
Kartik Raj 3a4c2b151a Comment out the proposal to fix compile errors 2023-05-18 17:54:22 +00:00
Megan Rogge c2e40c8e2c
Merge pull request #182891 from microsoft/merogge/fix-bug
rm part of help message for chat
2023-05-18 10:39:11 -07:00
Michael Lively 2fbd1ae848
Support for notebook-cell level CodeActions (#182799)
* issues with isort not scoring on notebook save

* add single cell edit check

* add setting for `notebook.codeActionsOnSave`

* break loop if error, skip codeaction

* update message.

---------

Co-authored-by: Peng Lyu <penlv@microsoft.com>
2023-05-18 10:28:06 -07:00
meganrogge ac85343939
rm entirely 2023-05-18 10:19:49 -07:00
meganrogge d0ced2d025
rm part of help message for chat 2023-05-18 10:18:17 -07:00
Joyce Er 0880f76765
Improvements to canonical URI API (#182667)
* Improve API names

* Allow requesting a specific scheme

* Implement ile uri support
2023-05-18 09:23:27 -07:00
Daniel Imms c2b15febd7
Merge pull request #182874 from microsoft/tyriar/181081
Elaborate on how the scrollback setting is used
2023-05-18 09:05:53 -07:00
Daniel Imms 8baa1345de
Update src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Co-authored-by: Megan Rogge <merogge@microsoft.com>
2023-05-18 08:39:37 -07:00
Daniel Imms 6e9b89c745
Elaborate on how the scrollback setting is used
Part of #181081
2023-05-18 08:07:49 -07:00
Rob Lourens 2ca206a703
Make sure the debug hover doesn't break if the tree throws (#182820) 2023-05-18 05:54:19 -07:00
Matt Bierner 1c954911d9
Adopt ext host restart for custom editors (#182558)
* Adopt ext host restart for custom editors

For #180514

* Show notification when restart is vetoed
2023-05-18 08:20:41 +02:00
Megan Rogge 2946b1ee55
Merge pull request #182351 from microsoft/merogge/interactive-editor-help
add interactive editor session help menu
2023-05-17 19:02:22 -07:00
Connor Peet 0c94abc4a5
implement sign service for web (#182815)
* signing: implement signing service on the web

* update distro
2023-05-17 16:52:56 -07:00
Rob Lourens 751fdcb904
Try to lay debug hover out correctly with scrollbar (#182817)
Fix #173980
2023-05-17 16:51:12 -07:00
Daniel Imms c54b191fce
Merge pull request #180451 from jeanp413/fix-180018
Fixes ITerminalService#getActiveOrCreateInstance returns a disposed terminal
2023-05-17 16:36:33 -07:00
Gabriela Araujo Britto 8457aa24b2
[typescript-language-features] Use original filterText if present (#172866)
* use original filter text, if present

* update comment
2023-05-17 22:37:11 +00:00
Matt Bierner 4d59b19b73
Enable project wide JS/TS intellisense on web by default (#182812)
Fixes #170920

Enables this feature by default but also disables semantic errors. This is needed to avoid lots of annoying false positive errors for external modules. We plan to remove this limitation once type downloading support is enabled
2023-05-18 00:06:00 +02:00
Matt Bierner adddf406d0
Simplify buffer enums (#182811) 2023-05-18 00:01:06 +02:00
Jean Pierre de78d5ebd3
Fix cannot read properties of undefined (reading 'searchInput') (#181989)
Fixes #181948
2023-05-17 14:14:19 -07:00
Jean Pierre a9142bb2b2
Fixes search progress icon doesn't go away after canceling replace (#182004)
Fixes #181931
2023-05-17 14:14:05 -07:00
Bhavya U 80b873adf7
Prevent welcome page from stealing focus (#182796)
* Prevent welcome page from stealing focus

* Fix comment
2023-05-17 13:03:38 -07:00
Rob Lourens 4c6e0b5eee
Fix progressive rendering for quick questions (#182792) 2023-05-17 20:30:16 +02:00
meganrogge c7fdd95d8c
formatting 2023-05-17 11:22:44 -07:00
meganrogge 09294e1c97
fix bug 2023-05-17 11:19:43 -07:00
meganrogge b78747c297
use context key 2023-05-17 11:13:17 -07:00
meganrogge 69eda6d4d6
tweak id, use updateOptions 2023-05-17 11:09:26 -07:00
vadimcn 4869f071a6
Preserve breakpoint ids in workspace state (#182704) 2023-05-17 17:47:08 +00:00
Johannes Rieken 1c8bc27525
only terminate session when content change moves all cursors outside of whole range, don't use change range for this (#182786) 2023-05-17 19:22:59 +02:00
Jean Pierre 3077a78072
Merge branch 'main' into fix-180018 2023-05-17 12:18:16 -05:00
Rob Lourens 4b71b8e359
Don't throw when chat viewpane's saveState is called before render (#182778)
Fix #182767
2023-05-17 10:17:21 -07:00
Daniel Imms 77b45bdb11
Merge pull request #182781 from microsoft/tyriar/delimiter
Support : in values for VSCODE_ENV_* variables
2023-05-17 10:11:11 -07:00
João Moreno 0f833f26f9
ignore SECURITY.md from vsda (#182780) 2023-05-17 19:00:49 +02:00
Daniel Imms a24009072c
Use encoded x3a to represent colon in pwsh 2023-05-17 09:52:54 -07:00
Daniel Imms 3dd1cc256e
Use encoded x3a to represent colon in zsh/fish 2023-05-17 09:48:43 -07:00
meganrogge ee9bcff019
make AccessibilityVerbositySettingId enum 2023-05-17 09:40:53 -07:00