isidor
6f75e0bb91
line and column information should be shown in status bar even if screen reader present
...
#94677
2020-04-09 10:57:11 +02:00
Sandeep Somavarapu
2225d77536
fix tests
2020-04-09 10:51:18 +02:00
isidor
906931eecb
centere editor layout: more precise check
2020-04-09 10:11:10 +02:00
Jackson Kearl
379e732c79
Refactor to only use untitled search editors and transparently convert to disk format on save/load. Ref #89268 .
2020-04-08 23:40:06 -07:00
Sandeep Somavarapu
a88044003a
Fix #94292
2020-04-09 08:15:00 +02:00
Matt Bierner
7ae7343973
Fix some strict null errors revealed by change to emitter
2020-04-08 18:06:24 -07:00
Matt Bierner
d4ce7148dd
New custom editor API proposal
...
For #77131
Fixes #93963
Fixes #94515
Fixes #94517
Fixes #94527
Fixes #94509
Fixes #94514
Fixes #93996
Fixes #93913
This removes explicit edits from the API and reshapes the API to more closely match VS Code's internal API. The change also tries to better express the lifecycle of backups
2020-04-08 17:53:39 -07:00
Matt Bierner
1ed9dcda26
Always require data for EventEmitter.fire
...
Fixes #93875
The data field should not be optional as this breaks strict null typings. With `EventEmitter<void>`, you can still call `.fire()` with no arguments
2020-04-08 17:53:39 -07:00
rebornix
3bec9a342e
Center layout validate can be earlier than widget creation.
2020-04-08 17:52:23 -07:00
SteVen Batten
43ae69de18
fixes #94724
2020-04-08 16:04:16 -07:00
Rob Lourens
78cbcc5cc0
Fix tests
2020-04-08 15:42:00 -07:00
Rob Lourens
d1fdc9636e
Fix tests
2020-04-08 15:42:00 -07:00
Gaurav Makhecha
d91ca067ca
Spell fix ( #94687 )
2020-04-08 15:10:57 -07:00
Rob Lourens
ba08874f33
Remove redundant line
2020-04-08 14:58:26 -07:00
Rob Lourens
6f2b989c3a
Use RemotePathService.userHome instead of EnvironmentService - #94506
...
Would be better to make the querybuilder async but that has a huge downstream impact
2020-04-08 14:56:27 -07:00
Rachel Macfarlane
8ff268e598
Ignore 'item already exists' keychain errors for now, fixes ##94005
2020-04-08 14:51:14 -07:00
Gustavo Cassel
e57b91ce77
Developed setting to loop search from the beginning or end of document in Find Widget ( #92243 )
...
* Improved documentation of 'title' property on OpenDialogOptions and SaveDialogOptions
* Developed setting which controls whether the search automatically restarts from the beginning (or the end) when no further matches can be found
* Removed needless condition to update Find Widget buttons
* Delete launch.json
File has been unintentionally committed.
Co-authored-by: Gustavo Cassel <GustavoASC@users.noreply.github.com>
Co-authored-by: Peng Lyu <penlv@microsoft.com>
2020-04-08 14:04:17 -07:00
Matt Bierner
32929fbbb8
Always prefer the extract constant refactoring with the lowest scope
...
Fixes #94717
Previously we hardcoded a check to scope_0
2020-04-08 13:48:03 -07:00
Matt Bierner
74b4540bd1
Prioritize implement interface over remove unused in JS/ts
...
Fixes #94212
If both `implement interface` and `remove unused` are possible, only mark `implement interface` as prefered.
Also changes our core code action sorting logic to prioritize autofixes
2020-04-08 13:05:44 -07:00
Matt Bierner
7c49df64ec
Move editorAssociations to own file
2020-04-08 13:05:44 -07:00
Matt Bierner
d07de2a7a4
Move contributed custom editors into common
2020-04-08 13:05:43 -07:00
Matt Bierner
46d13db531
Webview -> Custom Editors
2020-04-08 13:05:43 -07:00
Matt Bierner
7744a5a2ae
Move extensionPoint into common
2020-04-08 13:05:43 -07:00
Matt Bierner
11722ba26b
Split out contributed custom editors values to own file
2020-04-08 13:05:43 -07:00
Matt Bierner
363aedd191
Rename webview editor to custom editor
2020-04-08 13:05:43 -07:00
Matt Bierner
60c79717c8
Provide intellisense for viewtypes in custom editors setting
...
Fixes #93857
2020-04-08 13:05:39 -07:00
SteVen Batten
c173ec392f
update public logs
2020-04-08 12:47:28 -07:00
Peng Lyu
0d0b69a725
Merge pull request #94696 from microsoft/rebornix/no-center-layout-diff-editor
...
Quit centered layout mode when opening a diff editor. Fix #94574 .
2020-04-08 12:37:19 -07:00
rebornix
2c0ba64b16
Re #93332 . Save state for find widget ctrl enter warning for syncing.
2020-04-08 12:36:14 -07:00
Jackson Kearl
16a06751fe
Fixup on open
2020-04-08 11:59:55 -07:00
Jackson Kearl
61f6bf348e
Fixup onlabel
2020-04-08 11:59:20 -07:00
Christof Marti
7266bd8fd9
Dispose Emitters ( fixes #89008 )
2020-04-08 20:58:23 +02:00
Jackson Kearl
6e88cfb29d
Tune workspace search aria labels. Closes #94359
2020-04-08 11:57:31 -07:00
Jackson Kearl
0facba3df8
Coelece actions
2020-04-08 11:47:47 -07:00
isidor
51edf4892b
status bar use status role
...
#94677
2020-04-08 20:24:28 +02:00
rebornix
77d6451620
Quit centered layout mode when opening a diff editor. Fix #94574 .
2020-04-08 09:23:28 -07:00
Sandeep Somavarapu
6a76b30a85
fix tests
2020-04-08 18:09:32 +02:00
Rob Lourens
0858074c28
Always quit after exporting config.json, even when it fails
2020-04-08 08:52:35 -07:00
Rob Lourens
1417e1b53a
Check for duplicate registered settings
2020-04-08 08:52:35 -07:00
Sandeep Somavarapu
393aaa408b
Fix #94665
2020-04-08 17:44:57 +02:00
rebornix
c28c5b891c
Fix #92892 .
2020-04-08 08:30:25 -07:00
rebornix
e08b6e885a
Fix infinite loop triggered by mutation observer
2020-04-08 08:30:25 -07:00
rebornix
68923d1a88
space and enter support for add code/markdown buttons
2020-04-08 08:30:25 -07:00
Sandeep Somavarapu
23d2f7b822
fix layer breakage
2020-04-08 17:02:23 +02:00
Sandeep Somavarapu
a27ba1d6cd
#93332 Sync extension recommendations
2020-04-08 17:00:25 +02:00
Sandeep Somavarapu
959dd65e8a
#94599 Separate recommendations
2020-04-08 16:37:49 +02:00
Rob Lourens
3a4d158969
Bump node2
2020-04-08 06:30:29 -07:00
Christof Marti
11ac098428
Dispose Emitters ( fixes #89008 )
2020-04-08 12:02:22 +02:00
João Moreno
bedacf4ee0
enable monaco editor in ci workflow
2020-04-08 11:49:28 +02:00
Christof Marti
060e23075c
Fix QuickInput result types ( fixes #91877 )
2020-04-08 11:40:34 +02:00
