Commit graph

226 commits

Author SHA1 Message Date
Johannes 0f648cd7db
add eslint rule to disallow look behind regex feature, ignore in git and markdown fyi @lszomoru, @mjbvz 2022-03-22 16:02:19 +01:00
Matt Bierner bfc026b97a
Drop into text editor api proposal (#143334)
* Add drop into editor api proposal

For #142990

* Use AsyncEmitter
2022-03-18 11:32:11 -07:00
Matt Bierner e2fb656182
Fix comment 2022-02-11 13:21:49 -08:00
Matt Bierner dbb563c14d
Use 'vscode-notebook-renderer' types for our webview prelaods
This ensures we match the public apis
2022-02-09 15:36:46 -08:00
Alex Dima 00d619e6fe
Enforce import rule to avoid new imports (#141921) 2022-02-03 12:44:20 +01:00
Johannes Rieken 4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Johannes Rieken 7ccb868835
make sure to use .eslintignore when running yarn eslint, this will ensure that cli failure and editor squiggles are always equal 2022-02-02 12:37:29 +01:00
Alex Dima 71a20bb216
Disallow importing workbench/api in workbench/services (fixes #141003) 2022-02-01 00:00:25 +01:00
Alex Dima 172e83e470
Remove no longer necessary rule (#140989) 2022-01-25 22:56:03 +01:00
Alex Dima 283f478fc3
Avoid * and spell out all allowed node modules to have squiggles when importing vscode by accident 2022-01-25 21:28:38 +01:00
Alex Dima 46e068c506
Move common imports to .eslintrc.json 2022-01-25 21:28:37 +01:00
Benjamin Pasero 0f89762b4b
Rename workbench.web.api.* to workbench.web.main.* (#141263)
* web - rename entry file

* web - rename entry file also for server

* rename main entry in copy
2022-01-24 12:45:49 +01:00
Benjamin Pasero afb3140beb
welcome - introduce dedicated top level folders (#141138)
* welcome - introduce dedicated top level folders

* Remove special rules for `contrib/welcome`

* fix svgs

* fix layers lint

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-01-22 09:21:56 +01:00
Benjamin Pasero 67c35d0f4c
Merge branch 'main' into ben/web-api-layers 2022-01-21 14:13:34 +01:00
Alex Dima 1498d0f340
Add explicit layers for editor contributions (fixes #140995) 2022-01-21 10:29:55 +01:00
Benjamin Pasero 2e96be84e2
web - update layer rules 2022-01-21 10:20:23 +01:00
Benjamin Pasero 06f4700ce4
web - remove workbench.web.main 2022-01-21 10:12:44 +01:00
Alex Dima 3269deea2b
Move server code to vs/server/node 2022-01-20 17:18:10 +01:00
Alex Dima 41688566cb
Add tests for parseConnectionToken 2022-01-20 17:05:35 +01:00
Alex Dima 43d18c529c
Merge remote-tracking branch 'origin/main' into alex/issue-140997 2022-01-20 14:46:08 +01:00
Alex Dima 3c3e3cadfa
Remove no longer needed exceptions (#140993) 2022-01-20 14:20:36 +01:00
Alex Dima 45633f34a9
Add rules for server entry points 2022-01-20 10:11:08 +01:00
rebornix 29b03e8c1b
fix #140992. 2022-01-19 11:20:22 -08:00
Alex Dima 62b0d5cb81
Add /~ as a layer template, adopt it, simplify and align code import rules (#140857) 2022-01-18 18:27:34 +01:00
Alex Dima aa86df2561
For each target, allow importing itself 2022-01-18 18:27:34 +01:00
Alex Dima 0ae845536b
Avoid leading ** 2022-01-17 21:21:38 +01:00
Alex Dima 4aed6e1fd1
Ensure all files are covered by code-import-patterns (fixes #140857) 2022-01-17 17:55:45 +01:00
Alex Dima d018132104
Move defaultWorkerFactory.ts to /browser/ (#140857) 2022-01-17 17:23:31 +01:00
Alex Dima bc1e738569
Add rules for some missing folders (#140857) 2022-01-17 15:06:39 +01:00
Benjamin Pasero 9be2757019
🆙 playwright@1.18 (#140767)
* tests - use `@playwright/test@1.18.0-rc1`

* fix bad dependency

* clear more weird ts dependencies
2022-01-15 09:35:39 +01:00
Benjamin Pasero eecbd962ef
debt - rename iconv-lite-umd package (#140650) 2022-01-14 07:28:41 +01:00
Alex Ross 4d1d73f6ef
Revert "Add timestamps to comments proposal (#139849)"
This reverts commit b978d7150c.
2022-01-12 15:51:57 +01:00
Alex Ross b978d7150c
Add timestamps to comments proposal (#139849) 2022-01-12 14:41:23 +01:00
Dirk Baeumer 7ebb51f5ac
Remove delimiter rule since it causes lots of build failures 2022-01-11 10:51:01 +01:00
Dirk Baeumer 87b3230323
Fixes #140391: Missing semicolon 2022-01-11 10:42:04 +01:00
Alex Dima 23f72a0aa7
Properly dispose emitter when last listener is removed 2021-12-28 14:49:36 +01:00
Matt Bierner e7b3724e0c
Enable no-case-declarations in codebase (#139243)
Fixes #139236

This can catch tricky programming mistakes that cause a runtime error. See 7e266b2c42 as an example of the type of bug this can prevent
2021-12-15 17:15:35 -08:00
Daniel Imms c65c8738f9 Copy and use IWindowDriver in PlaywrightDriver 2021-11-12 06:11:18 -08:00
Daniel Imms 634dae736e Merge remote-tracking branch 'origin/main' into tyriar/smoke_test_improvements 2021-11-12 05:45:20 -08:00
Johannes Rieken a4d426a1c2
split vscode.proposed.d.ts into a file per proposal, https://github.com/microsoft/vscode/issues/131165 2021-11-12 09:48:17 +01:00
Daniel Imms 6a6a1b65df Use handles in playwright driver 2021-11-10 08:03:22 -08:00
Logan Ramos 78ea034530
Initial assignment service work (#136238)
* Initial assignment service work

* Modify useragent for experiment

* minor refactor

* remove extraneous comment

Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2021-11-01 15:35:12 -04:00
Johannes Rieken fc420cb9cb
add custom rule to prevent test.only 2021-11-01 16:37:13 +01:00
Johannes Rieken 08a9a544e1
Revert "add mocha-no-only lint rule"
This reverts commit 538c4932b6.
2021-11-01 15:53:51 +01:00
Johannes Rieken 538c4932b6
add mocha-no-only lint rule 2021-11-01 15:18:10 +01:00
Alex Dima 5f226a990c
Remove special rules for src/vs/server 2021-10-21 09:52:40 +02:00
Benjamin Pasero 3cda269c80 ESlint: enable no-async-promise-executor (#134873) 2021-10-12 10:50:44 +02:00
Benjamin Pasero 85c5eb7281 Enable parcel-watcher as new default watcher (#132483) 2021-10-11 11:17:05 +02:00
Henning Dieterichs c0cc785861
Disables header eslint-rule for src/vs/server/* 2021-08-12 18:04:53 +02:00
Benjamin Pasero b794b9223c
:chore: sqlite3 module (#130654) 2021-08-12 09:37:55 +02:00
Logan Ramos e6f667d3e0
Revert "Revert "Remove telemetry appender from embedder API""
This reverts commit e516cefa43.
2021-07-21 17:04:02 -04:00
Logan Ramos e516cefa43
Revert "Remove telemetry appender from embedder API"
This reverts commit 889fc9ed82.
2021-07-21 17:03:01 -04:00
Logan Ramos 889fc9ed82
Remove telemetry appender from embedder API 2021-07-21 12:55:50 -04:00
Tyler James Leonhardt 8f88009816
Initial support for language detection (#128708)
* initial language detection

* add configuration and extra event on UntitedTextEditorService

* check isWeb, use beter mode API, include model in unpacked

* typo in path
2021-07-16 16:43:23 -07:00
Henning Dieterichs 2a0c4cc1c3
Uses eslint-plugin-header to enforce license headers. Features quick fix to add license header. 2021-07-09 18:20:17 +02:00
Henning Dieterichs 00123b32a7
Updates sinon from 1.17 to 11.1. 2021-06-09 10:03:46 +02:00
Matt Bierner 97b5db8dba
'vs code' -> 'the editor' in d.ts
Fixes #124361

Also adds a lint rule for this
2021-06-08 11:35:42 -07:00
Benjamin Pasero ad60f647d9 web - implemented indexedDB based storage service 2021-06-06 08:27:13 +02:00
Benjamin Pasero 5d1370af49
file editors - move the input to the editor (browser) 2021-05-10 11:34:52 +02:00
SteVen Batten a9f70f7919 finalize basic workspace trust api 2021-04-21 09:56:35 -07:00
Connor Peet 808266d4de
Allow tests to be loaded asynchronously (#119537)
* initial wip in the extension host

* wip

* wip

* wip

* continued progress

* update api from discussion

* update for new proposal

* wip

* update to lastest testing api, almost everything working

Refs https://github.com/microsoft/vscode/issues/115089
Design https://gist.github.com/connor4312/73f1883d720654834b7fd40550d3b6e0

* re-wire retirement state

* update actions to new async test structure

* minor cleanup

* remove unused es2018 that failed build
2021-03-22 18:08:13 -07:00
Johannes Rieken 98a22a957a
declare cancellation support for openNotebook and wire it up, exempt notebook content provider from provider naming rules 2021-03-09 12:40:37 +01:00
Johannes Rieken 7222dfcffb exempt AuthenticationProvider from provider-naming rule 2021-02-23 08:38:37 +01:00
Benjamin Pasero 05922f8a26 storage - add tests for all services 2021-02-13 10:44:21 +01:00
Benjamin Pasero 883b862945 debt - prevent vs/code dependency from vs/server 2021-02-10 08:15:46 +01:00
Benjamin Pasero 3b456a2857 debt - do not allow platform layer to reach into code layer 2021-02-10 08:04:15 +01:00
Connor Peet 3d4cabb608
testing: refactor to new runState API
Fixes: https://github.com/microsoft/vscode/issues/115101.
See issue for details.

- Adopts the new API
- Test results now persist across reloads (last 64 runs).
- Removed state grouping in favor of sorting option.
- Code lenses are disabled for now
2021-02-09 16:12:37 -08:00
Johannes Rieken dbd4ede23f add api lint rule for region comments 2021-01-21 17:42:33 +01:00
Johannes Rieken 845a4d4268 add new rule to enforce Thenable over Promise, adopt in vscode.d.ts and vscode.proposed.d.ts 2021-01-20 13:08:04 +01:00
João Moreno a78fffbdb0
remove unused eslint mocha 2021-01-07 14:55:03 +01:00
João Moreno 5e673678eb
Merge branch 'joao/build/single-compile-job' 2021-01-07 10:59:12 +01:00
João Moreno d944b91cd1
remove no-exclusive-tests 2021-01-07 10:18:00 +01:00
Johannes Rieken 0319fedae1 add lint rule for missing cancellation token in resolve and provide methods, fyi @alexr00 please remove surpression comment 2021-01-05 18:48:13 +01:00
Johannes Rieken fee7cdacf7 add provider naming rule 2021-01-04 20:02:05 +01:00
Alexandru Dima 9945754a62
Add editor smoke test (ported from monaco-editor) 2020-12-28 21:44:42 +01:00
Connor Peet d1280418d7
testing: initial api implementation
* wip

* wip

* wip

* wip

* wip

* wip
2020-11-20 08:31:35 -08:00
Sandeep Somavarapu 88144f6d31 Fix #80698
- Inline semver
2020-10-26 12:12:07 +01:00
Sandeep Somavarapu 43bc8349d8 remove semver dependency 2020-10-26 08:45:58 +00:00
Sandeep Somavarapu 6a47ef2de5 consider version while merging extension state 2020-10-25 18:48:44 +01:00
Benjamin Pasero 3bbcbfa19d debt - add and enable mocha/no-exclusive-tests rule 2020-10-15 09:57:38 +02:00
SteVen Batten 92a30ed265
Move tas-client to umd version and adopt in web (#106904)
* adopt tas-client-umd

* adopt in web

* fix whitespace

* adding tas-client to webignore

* upgrade tas-client-umd

* move svc imort to common

* remove unnecessary ignore
2020-09-18 10:00:39 -07:00
Benjamin Pasero ea830ff2ac sandbox - lift themes.test.contribution 2020-09-18 13:35:35 +02:00
rebornix 509bc25f02 notebook editor worker service. 2020-08-20 10:53:42 -07:00
Evgeny Gryaznov 3c4a261d5f
Add missing code-import-patterns for files and directories targeting web. (#102961) 2020-07-21 07:45:44 +02:00
Sandeep Somavarapu 41f32e0bd6 support managing web extensions
- Allow installing extensions with web resource asset type
- Allow uninstalling
2020-06-25 19:25:49 +02:00
Fedor Nezhivoi 24e0a82229
Move encoding to common for #79275 (#100539)
* move encoding.ts to common for #79275

* load iconv-lite-umd and jschardet in web version for #79275

* move EncodingOracle to the AbstractTextFileService for #79275

* review

* update to new iconv-lite-umd

* add workaround for jschardet types

* fix indentation

* add iconv-lite-umd and jschardet to workbench.html

* fix paths for modules

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2020-06-20 10:47:29 +02:00
Matt Bierner 5fe78a13a4 Update eslint versions
The class-name-casing rule has also been replaced by the configurable `naming-convention` rule
2020-06-05 14:09:41 -07:00
Benjamin Pasero 76590a7764 Merge branch 'master' into ben/electron-sandbox 2020-05-26 09:39:17 +02:00
Alex Dima 7c045e7f07
Add more undo-redo tests 2020-05-25 17:46:24 +02:00
Benjamin Pasero dc8f291781 sandbox - let workspaces service use sandboxed IPC 2020-05-23 08:05:47 +02:00
Benjamin Pasero 3514e96bf5 sandbox - add rules for new electron-sandbox layer 2020-05-22 12:21:25 +02:00
rebornix d321061c8c merge moveEvent into CellsChangeEvent. 2020-05-20 11:03:30 -07:00
rebornix cc151dd103 notebook tests for notebook content change events. 2020-05-19 14:46:14 -07:00
rebornix 0dea13a46a Notebook document events. 2020-05-19 12:05:21 -07:00
Alex Dima 6654073e14
Adopt new package name (vscode-oniguruma) 2020-04-24 17:58:08 +02:00
Alex Dima a6e59815c8
Adopt vscode-oniguruma-wasm 2020-04-23 11:16:21 +02:00
Benjamin Pasero eaff4c5dee debt - fix import layer rules 2020-04-07 10:29:20 +02:00
Benjamin Pasero b644d803d1 debt - extract node pieces to node layer (window) 2020-04-06 09:17:00 +02:00
Benjamin Pasero a949694b25 debt - reduce usage of explicit any 2020-02-28 11:33:55 +01:00
Matt Bierner 99d5733e5f New iteration of webview editor API proposal
For #77131

**Motivation**
While our existing webview editor API proposal more or less works, building an editable webview editor is fairly tricky using it! This is especially true for simple text based editors.

It'd also be nice if we could get bi-directional live editing for text files. For example, if I open the same file in a webview editor and in VS Code's normal editor, edits on either side should be reflected in the other. While this can sort of be implemented using the existing API, it has some big limitations

**Overview of changes**
To address these problems, we've decided have two types of webview editors:

- Text based webview editors. These editors used a `TextDocument` as their data model, which considerably simplifies implementing an editable webview. In almost all cases, this should be what you use for text files

- Complex webview editors. This is basically the existing proposed API. This gives extension hooks into all the VS Code events, such as `save`, `undo`, and so on. These should be used for binary files or in very complex text editor cases.

Both editor types now have an explicit model layer based on documents. Text editor use `TextDocument` for this, while custom editors use `WebviewEditorCustomDocument`. This replaces the delegate based approach previously used.
2020-02-21 16:26:01 -08:00
Sandeep Somavarapu 440e910ccc allow platform common tests use bas/parts/common 2020-02-13 18:25:10 +01:00
Daniel Imms 8a4cd00f8f Move terminal tests to common and browser 2020-02-07 08:52:37 -08:00
Benjamin Pasero 4be3cc8846 test - convert web integration to TS 2020-02-07 12:41:12 +01:00
Johannes Rieken b7ab10b8a8 move most API tests to browser-layer 2020-02-05 15:09:32 +01:00
Johannes Rieken 8342b3ada9 add some lint rules that enforce our api-guidelines 2020-01-31 12:10:58 +01:00
Benjamin Pasero 2c92f67ec5 eslint - add a few more for no-restricted-globals rule 2020-01-06 15:16:17 +01:00
Benjamin Pasero 8708d6e4dd
eslint - add rule to restrict certain globals (#88123) 2020-01-06 10:24:40 +01:00
Johannes Rieken 125ba4a8a6 enable custom/forked no-unused-expressions rule 2020-01-03 09:32:40 +01:00
Johannes Rieken 12eb715644 (re)enable no-extra-semi rule 2020-01-02 21:12:03 +01:00
Johannes Rieken d18119e288 enable jsdoc/no-types rule for TS files 2020-01-02 21:00:27 +01:00
Johannes Rieken e22be576d6 add disabled rules for being more complete with our tslint config... 2019-12-31 12:55:41 +01:00
Johannes Rieken e27d7cafa1 only one double-qoute string rule 2019-12-31 09:14:07 +01:00
Johannes Rieken a61f38eee5 migrate no-unexternalized-strings rule (have two variants) 2019-12-30 17:48:21 +01:00
Johannes Rieken b05b481265 migrate no-standalone-editor rule 2019-12-30 11:23:53 +01:00
Johannes Rieken 2ea9132cab migrate no-nls-in-standalone-editor rule 2019-12-30 11:19:24 +01:00
Johannes Rieken a3bd604627 migrate translation remind rule 2019-12-30 11:09:38 +01:00
Johannes Rieken 54d20309fa tweak rules and excludes 2019-12-30 10:51:58 +01:00
Johannes Rieken 291ee0058a add no-buffer-ctor rule 2019-12-30 10:06:37 +01:00
Johannes Rieken 9819da68ab migrate import-patterns rule to eslint 2019-12-30 10:03:52 +01:00
Johannes Rieken b0d38052b5 use rulesdir instead of rules-module 2019-12-30 09:46:58 +01:00
Johannes Rieken a1047421ff use single eslintrc-file for extensions/ and src/, no type check rules 2019-12-24 16:11:51 +01:00
Johannes Rieken 31d049f329 use (most of) generated eslintrc-file 2019-12-24 13:51:11 +01:00
Johannes Rieken ce0d7058a6 add package.json script 2019-12-24 13:23:57 +01:00
Johannes Rieken 556475c71f add eslint-rules "module" and use it in eslintrc-file 2019-12-24 13:07:59 +01:00
Kevin Ji 6d27e68892 eslintrc: Mark as root config 2018-09-10 11:51:23 -04:00
Manoel Lobo b4fc62b9c5 Add .eslintrc extension 2018-08-22 10:23:45 -03:00
Renamed from .eslintrc (Browse further)