Commit graph

226 commits

Author SHA1 Message Date
Johannes 415bc174ea
refine lint config, add missing jsdoc and jsdoc-tag corrections 2023-09-01 14:23:16 +02:00
Johannes ebfe7fabfb
wip - define jsdoc lint rules for vscode.d.ts 2023-08-30 11:37:44 +02:00
Daniel Imms 67a99e361e
TerminalExecuteCommandEvent proposal
Part of #145234
2023-08-24 07:58:22 -07:00
Robo ea490e5545
chore: update to Electron 25 (#188268)
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-08-07 21:46:27 +09:00
Alex Ross 34442b8b39
Warn on async suites (#188378)
Part of #187718
2023-07-28 17:04:23 +01:00
Johannes 8c19d3f0e7
add lint rule for AMD node imports 2023-07-04 11:31:36 +02:00
Johannes Rieken 69cd1439e5
from ESM land bring over amdX-util and bring over one of its usages (#186748)
* from ESM land bring over amdX-util and bring over one of its usages

* fix tsec violation

* one more exemption

* grrrr

* last try, fingers crossed
2023-06-30 09:05:06 -07:00
Johannes Rieken 654c61dcb1
add lint-rule to discourage native private fields (#186735) 2023-06-30 06:13:18 -07:00
Robo 10cf7f040a
chore: add distro info to telemetry on linux (#185261) 2023-06-16 14:55:59 +02:00
Daniel Imms e7a3127217
Integrate xterm-addon-image 2023-05-14 08:09:17 -07:00
Johannes Rieken 89b615d105
add lint rule to prevent type discrimination properties in API types (#180829)
re https://github.com/microsoft/vscode/issues/63943 and other
2023-04-25 11:22:28 -07:00
Raymond Zhao 22ed59eb3d
Bump windows-process-tree with workaround for typings (#179649) 2023-04-11 10:05:56 -07:00
Raymond Zhao 07aec54e2e
Bump spdlog (#179642) 2023-04-11 08:00:57 -07:00
Raymond Zhao 84ac780186
Revert "Bump windows-process-tree" (#179508)
Revert "Bump windows-process-tree (#179176)"

This reverts commit 15cb6b36f8.
2023-04-08 00:47:57 +01:00
Raymond Zhao 15cb6b36f8
Bump windows-process-tree (#179176)
* Bump windows-process-tree

* Fix compile error

* Add explanation to source

* Add that the types package has been deprecated
2023-04-05 20:51:26 +02:00
Robo d317fbf297
chore: revert @vscode/spdlog bump (#179103)
* Revert "chore: update spdlog@0.13.9 (#179087)"

This reverts commit 9eba21c20f.

* Revert "Bump spdlog (#179035)"

This reverts commit 4cc7f76f60.
2023-04-04 10:49:54 +02:00
Raymond Zhao 90089562cc
Bump proxy-agent (#179033) 2023-04-03 15:23:31 -07:00
Raymond Zhao 4cc7f76f60
Bump spdlog (#179035) 2023-04-03 11:18:47 -07:00
Robo e5f61433b5
chore: update to Electron 22 (#177600)
* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* sandbox - cleanup from electron 22 update (#178919)

* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* temp: update distro

* sandbox - cleanup from electron 22 update

* missing comile

* more changes

* fix build

* restore

* 💄

* compile

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
João Moreno 5f9bbf37c1
Revert "adopt new module locations (#177472)"
This reverts commit 5b6cd9c3c7.
2023-03-17 18:55:13 +01:00
João Moreno 5b6cd9c3c7
adopt new module locations (#177472)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2023-03-17 15:34:17 +01:00
Rob Lourens cd1d31179d
Add event fired when the user performs actions on interactive session responses (#176829)
* Add an id to responses that comes from the provider

* Add event fired when the user performs actions on interactive session responses

* Only show user action buttons when the provider has added a response ID
2023-03-10 21:48:37 -08:00
Daniel Imms 4d95bc1be6
Sort out layering/lint problems 2023-03-02 13:02:35 -08:00
Daniel Imms 1dced629d3
Restrict terminal contrib imports from main code 2023-03-02 10:56:52 -08:00
Daniel Imms ea61e55769
Build out terminal contributions, fix link providers 2023-03-02 08:49:57 -08:00
Daniel Imms 862cb75a68
Move terminal contribs into own folder 2023-03-01 15:42:27 -08:00
João Moreno 07a7d71087
Bump to @vscode/policy-watcher (#174354)
* use latest @vscode/policy-watcher

* fix compile

* ooops

* lock new version
2023-02-14 16:53:34 +01:00
João Moreno c7930ca55d
Revert "bump @vscode/policy-watcher (#174063)" (#174072)
This reverts commit 47e3135bda.

Revert "move to @vscode/policy-watcher (#173950)"

This reverts commit a1e73c96a4.
2023-02-10 16:37:50 +01:00
João Moreno a1e73c96a4
move to @vscode/policy-watcher (#173950) 2023-02-09 07:12:42 -08:00
Johannes Rieken 98546b2287
eslint: add a new rule to enforce declare _serviceBrand: undefined (#165396) 2022-11-03 10:32:37 -07:00
Benjamin Pasero 3b29b43074
web - only export types not interfaces (#161609)
* web - only export types not interfaces

* fix compile
2022-09-23 19:23:39 +02:00
Matt Bierner 5e92794be6
Re-enable running our eslint rules using ts-node (#159495)
Resubmission of #157532 with the following changes:

- Use `eslint-plugin-local` instead of `yarn` link to run our plugins
- Move our plugins to a top level `.eslintplugin` dir (as required by `eslint-plugin-local`)
- Update all names to `local/`
2022-08-30 08:40:04 +02:00
Matt Bierner 9e5248072a
Fix ts-node for eslint (#159483)
Bumps the cachesalt to make sure ts-node is installed
2022-08-29 20:51:12 +02:00
Matt Bierner 5b21c7f28b
Run our custom eslint rules using ts-node (#157532)
* Run our custom eslint rules using ts-node

Use `ts-node` to run our custom eslint rules.  This lets us delete the pre-compiled js. It also means you can don't have to compile the rules while editing them

As part of this change, I've also switched us to using an eslint plugin instead of a rulesDir. This is now the preferred way to ship custom rules

* Fix two more disables

* Move ts-node to project root

* Enable transpileOnly
2022-08-29 09:39:09 -07:00
Daniel Imms 2f72682e5d
Add canvas renderer addon 2022-08-01 09:29:26 -07:00
Logan Ramos d6114a70be
Remove app insights (#154296)
* Remove app insights

* Update product service to remove asimovKey
2022-07-06 22:23:30 -04:00
Benjamin Pasero f4f1b04d87
Add a setting to enable sandbox: true for windows (#154062)
* sandbox - allow enabled sandbox in a full build

* sandbox - reduce `electron-browser` in workbench

* sandbox - reduce `electron-browser` in platform

* sandbox - add a setting to enable sandbox mode for window

* fix lint

* Revert "sandbox - reduce `electron-browser` in workbench"

This reverts commit 36a5167cf9.

* Revert "sandbox - reduce `electron-browser` in platform"

This reverts commit 6f49d704a5.

* fix layer issue

* fix some js errors
2022-07-05 09:54:28 +02:00
Logan Ramos 0edb88f3b5
1DS appender for the web (#152489)
* 1ds web appender

* Start testing web
2022-06-17 15:10:04 -04:00
Alexandru Dima 252c65540d
Adopt the same export patterns in vs/css as in vs/nls and bring over tests (#152396)
* Adopt the same export patterns in `vs/css` as in `vs/nls` and bring over tests

* Fix problem with loading nodejs modules
2022-06-17 17:12:27 +02:00
Alexandru Dima 9db5a3674e
Bring the nls loader plugin into our sources (#152338) 2022-06-16 22:01:19 +02:00
Logan Ramos e8f28ac3ac
Refactor location of web app insights appender (#152358)
* Refactor location of web app insights appender

* Play around with eslintrc

* Eslint json update

* Try and fix monaco editor check

* Remove extra trailing comma
2022-06-16 18:26:06 +00:00
Alexandru Dima d132489cd0
Bring the css loader plugin into our sources (#152205) 2022-06-15 16:53:02 +02:00
Logan Ramos d791322812
Bring back 1DS SDK (#151810)
* Revert "Revert "Initial adoption of 1DS Sdk (#151531)""

This reverts commit 09bab84672.

* Testing CI

* More tests

* Add back core config to see if test fails

* Add an if true test

* Make sure we're not instantiating 1ds for tests

* Try async import of post plugin

* Bring back other imports
2022-06-13 10:53:07 -04:00
Daniel Imms 09bab84672
Revert "Initial adoption of 1DS Sdk (#151531)"
This reverts commit b0a239379b.
2022-06-10 13:22:58 -07:00
Logan Ramos b0a239379b
Initial adoption of 1DS Sdk (#151531)
* Start with implementing 1DS

* Add part a flag

* Fix byte mask

* Add internal testing in shared process

* Update AI

* Update XHR Override

* Update to only call unload

* small changes

* Move key to rpoduct.json

* Fix endpoint

Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2022-06-10 09:14:29 -07:00
Johannes 0f6f41890b
split manual work into managable chunks and (again) disable const-destructuring unless all are const 2022-06-09 09:30:36 +02:00
Johannes aa23a0dbb7
use prefer-const default config 2022-06-08 17:46:25 +02:00
Johannes 13b60e192d
prefer-const, ignore mixed destructuring statements for now 2022-06-08 11:16:24 +02:00
Johannes 19f96d6ed1
add prefer-const lint rule 2022-06-08 10:59:14 +02:00
João Moreno d90d07adef
wip: policy 2022-05-16 17:46:39 +02:00
Johannes 0f648cd7db
add eslint rule to disallow look behind regex feature, ignore in git and markdown fyi @lszomoru, @mjbvz 2022-03-22 16:02:19 +01:00
Matt Bierner bfc026b97a
Drop into text editor api proposal (#143334)
* Add drop into editor api proposal

For #142990

* Use AsyncEmitter
2022-03-18 11:32:11 -07:00
Matt Bierner e2fb656182
Fix comment 2022-02-11 13:21:49 -08:00
Matt Bierner dbb563c14d
Use 'vscode-notebook-renderer' types for our webview prelaods
This ensures we match the public apis
2022-02-09 15:36:46 -08:00
Alex Dima 00d619e6fe
Enforce import rule to avoid new imports (#141921) 2022-02-03 12:44:20 +01:00
Johannes Rieken 4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Johannes Rieken 7ccb868835
make sure to use .eslintignore when running yarn eslint, this will ensure that cli failure and editor squiggles are always equal 2022-02-02 12:37:29 +01:00
Alex Dima 71a20bb216
Disallow importing workbench/api in workbench/services (fixes #141003) 2022-02-01 00:00:25 +01:00
Alex Dima 172e83e470
Remove no longer necessary rule (#140989) 2022-01-25 22:56:03 +01:00
Alex Dima 283f478fc3
Avoid * and spell out all allowed node modules to have squiggles when importing vscode by accident 2022-01-25 21:28:38 +01:00
Alex Dima 46e068c506
Move common imports to .eslintrc.json 2022-01-25 21:28:37 +01:00
Benjamin Pasero 0f89762b4b
Rename workbench.web.api.* to workbench.web.main.* (#141263)
* web - rename entry file

* web - rename entry file also for server

* rename main entry in copy
2022-01-24 12:45:49 +01:00
Benjamin Pasero afb3140beb
welcome - introduce dedicated top level folders (#141138)
* welcome - introduce dedicated top level folders

* Remove special rules for `contrib/welcome`

* fix svgs

* fix layers lint

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-01-22 09:21:56 +01:00
Benjamin Pasero 67c35d0f4c
Merge branch 'main' into ben/web-api-layers 2022-01-21 14:13:34 +01:00
Alex Dima 1498d0f340
Add explicit layers for editor contributions (fixes #140995) 2022-01-21 10:29:55 +01:00
Benjamin Pasero 2e96be84e2
web - update layer rules 2022-01-21 10:20:23 +01:00
Benjamin Pasero 06f4700ce4
web - remove workbench.web.main 2022-01-21 10:12:44 +01:00
Alex Dima 3269deea2b
Move server code to vs/server/node 2022-01-20 17:18:10 +01:00
Alex Dima 41688566cb
Add tests for parseConnectionToken 2022-01-20 17:05:35 +01:00
Alex Dima 43d18c529c
Merge remote-tracking branch 'origin/main' into alex/issue-140997 2022-01-20 14:46:08 +01:00
Alex Dima 3c3e3cadfa
Remove no longer needed exceptions (#140993) 2022-01-20 14:20:36 +01:00
Alex Dima 45633f34a9
Add rules for server entry points 2022-01-20 10:11:08 +01:00
rebornix 29b03e8c1b
fix #140992. 2022-01-19 11:20:22 -08:00
Alex Dima 62b0d5cb81
Add /~ as a layer template, adopt it, simplify and align code import rules (#140857) 2022-01-18 18:27:34 +01:00
Alex Dima aa86df2561
For each target, allow importing itself 2022-01-18 18:27:34 +01:00
Alex Dima 0ae845536b
Avoid leading ** 2022-01-17 21:21:38 +01:00
Alex Dima 4aed6e1fd1
Ensure all files are covered by code-import-patterns (fixes #140857) 2022-01-17 17:55:45 +01:00
Alex Dima d018132104
Move defaultWorkerFactory.ts to /browser/ (#140857) 2022-01-17 17:23:31 +01:00
Alex Dima bc1e738569
Add rules for some missing folders (#140857) 2022-01-17 15:06:39 +01:00
Benjamin Pasero 9be2757019
🆙 playwright@1.18 (#140767)
* tests - use `@playwright/test@1.18.0-rc1`

* fix bad dependency

* clear more weird ts dependencies
2022-01-15 09:35:39 +01:00
Benjamin Pasero eecbd962ef
debt - rename iconv-lite-umd package (#140650) 2022-01-14 07:28:41 +01:00
Alex Ross 4d1d73f6ef
Revert "Add timestamps to comments proposal (#139849)"
This reverts commit b978d7150c.
2022-01-12 15:51:57 +01:00
Alex Ross b978d7150c
Add timestamps to comments proposal (#139849) 2022-01-12 14:41:23 +01:00
Dirk Baeumer 7ebb51f5ac
Remove delimiter rule since it causes lots of build failures 2022-01-11 10:51:01 +01:00
Dirk Baeumer 87b3230323
Fixes #140391: Missing semicolon 2022-01-11 10:42:04 +01:00
Alex Dima 23f72a0aa7
Properly dispose emitter when last listener is removed 2021-12-28 14:49:36 +01:00
Matt Bierner e7b3724e0c
Enable no-case-declarations in codebase (#139243)
Fixes #139236

This can catch tricky programming mistakes that cause a runtime error. See 7e266b2c42 as an example of the type of bug this can prevent
2021-12-15 17:15:35 -08:00
Daniel Imms c65c8738f9 Copy and use IWindowDriver in PlaywrightDriver 2021-11-12 06:11:18 -08:00
Daniel Imms 634dae736e Merge remote-tracking branch 'origin/main' into tyriar/smoke_test_improvements 2021-11-12 05:45:20 -08:00
Johannes Rieken a4d426a1c2
split vscode.proposed.d.ts into a file per proposal, https://github.com/microsoft/vscode/issues/131165 2021-11-12 09:48:17 +01:00
Daniel Imms 6a6a1b65df Use handles in playwright driver 2021-11-10 08:03:22 -08:00
Logan Ramos 78ea034530
Initial assignment service work (#136238)
* Initial assignment service work

* Modify useragent for experiment

* minor refactor

* remove extraneous comment

Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2021-11-01 15:35:12 -04:00
Johannes Rieken fc420cb9cb
add custom rule to prevent test.only 2021-11-01 16:37:13 +01:00
Johannes Rieken 08a9a544e1
Revert "add mocha-no-only lint rule"
This reverts commit 538c4932b6.
2021-11-01 15:53:51 +01:00
Johannes Rieken 538c4932b6
add mocha-no-only lint rule 2021-11-01 15:18:10 +01:00
Alex Dima 5f226a990c
Remove special rules for src/vs/server 2021-10-21 09:52:40 +02:00
Benjamin Pasero 3cda269c80 ESlint: enable no-async-promise-executor (#134873) 2021-10-12 10:50:44 +02:00
Benjamin Pasero 85c5eb7281 Enable parcel-watcher as new default watcher (#132483) 2021-10-11 11:17:05 +02:00
Henning Dieterichs c0cc785861
Disables header eslint-rule for src/vs/server/* 2021-08-12 18:04:53 +02:00
Benjamin Pasero b794b9223c
:chore: sqlite3 module (#130654) 2021-08-12 09:37:55 +02:00