Commit graph

49608 commits

Author SHA1 Message Date
Daniel Imms 7553a904a9
Merge pull request #74685 from microsoft/tyriar/74181
Fix possible crash in winpty
2019-05-31 10:30:29 -07:00
Peng Lyu c042dabe2b Fix #74641. Update viewzone afterline when position changes. 2019-05-31 10:27:56 -07:00
Daniel Imms bd08ccfc32 Actually fix the issue
typeof NaN is number :/
2019-05-31 10:07:20 -07:00
Daniel Imms e698d0d889 Fix possible crash in winpty
Fixes #74181
2019-05-31 10:01:31 -07:00
Johannes Rieken c653508f85 don't decode %2f when parsing uris 2019-05-31 18:38:01 +02:00
Miguel Solorio b00f75af22 Fix #74659, make sync icon smaller 2019-05-31 08:41:13 -07:00
Sandeep Somavarapu 1cf4cd9ba3
Merge pull request #74679 from microsoft/sandy081/fix74123
Use file service to update content
2019-05-31 17:11:07 +02:00
Johannes Rieken fd96e80a7b Merge branch 'master' into joh/uri-query 2019-05-31 15:42:55 +02:00
Johannes Rieken acb1e2cb3a
Merge pull request #74672 from microsoft/joh/fix74670
Honor command enablement in keybindings
2019-05-31 13:12:26 +02:00
Benjamin Pasero 827bd5f735 fix #74548 2019-05-31 13:11:21 +02:00
Johannes Rieken 59794815ce when adding contributed keybindings check if a command with enablement-clause exists 2019-05-31 12:39:40 +02:00
Johannes Rieken 96a0265a85 fix #74566 2019-05-31 09:30:15 +02:00
Matt Bierner b3b483a15a Don't retrigger empty code actions menu
Fixes #74649
2019-05-30 18:37:50 -07:00
Matt Bierner 76e774e4bd Add arrays.empty
This helps with `a === b` checks  in arrays.equals
2019-05-30 17:22:38 -07:00
Matt Bierner 015f1c7909 Use array prototype instead of creating instance 2019-05-30 17:13:10 -07:00
Matt Bierner a8a0fa763f Use every for equals 2019-05-30 17:01:10 -07:00
Matt Bierner 55d6317a4f Don't update js/ts diagnostics if they have not changed
Fixes #74633

This was the indirect cause of  #74633. See that issue for an explaination of why it was problematic.  In summary, updating diagnostics can retrigger code actions even if the user facing diagnostics have not actually changed
2019-05-30 16:59:32 -07:00
Peng Lyu 2d0e087ecb oss 1.35 2019-05-30 16:19:28 -07:00
Logan Ramos 2737cde4fa
Inconsistent GDPR Comments (#74292)
* Cleans up vs-typescript temp directoy upon VS code close

* Fixed typing errors preventing build from succeeding

* Moved deletion to the deactivate method. Added folders per extension host

* Removed yarn watch script used in testing

* Fixed inconsistencies in GDPR comments
2019-05-30 18:26:38 -04:00
Peng Lyu 5c65d9bfa4 Fix #74589. 2019-05-30 14:38:34 -07:00
SteVen Batten df41e1b6cc ref #71580 2019-05-30 21:37:11 +00:00
SteVen Batten 226b611867 fixes #74617 2019-05-30 21:04:30 +00:00
Matt Bierner 483e48d875 Fix sorting of source code actions being reversed
Fixes #73344
2019-05-30 11:30:45 -07:00
SteVen Batten 8cd962e841
Merge pull request #74591 from sbatten/commonRemoteAuthority
add common.remoteAuthority
2019-05-29 22:00:18 -07:00
Matt Bierner e9c5066315 Pick up TS 3.5.1 final 2019-05-29 21:41:46 -07:00
Rob Lourens d42fe4c1cc Fix #74590 2019-05-29 17:33:55 -07:00
Rob Lourens acdefbb846 Fix #72938 2019-05-29 17:24:09 -07:00
SteVen Batten 683b80aa28 use + 2019-05-29 17:20:30 -07:00
SteVen Batten 68e458ff64 remove 2019-05-29 17:19:34 -07:00
SteVen Batten 10f17714ce fix 2019-05-29 17:17:08 -07:00
SteVen Batten e12f9df61c add common.remoteAuthority 2019-05-29 16:49:39 -07:00
Matt Bierner e14492ab96 Add conditional guards when accessing webview element
It's currently possible to hit a null exception if some of these callback are invoked on a disposed `WebviewElement`. This is a fairly rare condition and does not seem to cause problems, but we should not allow this to happen
2019-05-29 16:23:16 -07:00
Rob Lourens 2706c32c50 Fix microsoft/vscode-remote-release#279 2019-05-29 16:05:56 -07:00
Matt Bierner 143bebfbb4 Use em for code font size instead of rem
This fixes some cases where a user style sheet may be setting a weird base font-size.
2019-05-29 15:44:48 -07:00
Matt Bierner 53d33cafb2 Note that document link auto-includes instructions for tooltip
For https://github.com/microsoft/vscode/issues/74311#issuecomment-497127291
2019-05-29 15:19:26 -07:00
Matt Bierner c62a6aa38a Set extract kind for type alias refactoring
This lets you set up a single keybinding that applies to both extract constant and extract type
2019-05-29 14:22:45 -07:00
Martin Aeschlimann ecf9a9f764 code.sh: add datafolder 2019-05-29 23:18:50 +02:00
Rob Lourens 0a7ec36603 Hide machine-scoped settings from User tab in remote window
Fix microsoft/vscode-remote-release#2
2019-05-29 14:10:59 -07:00
Miguel Solorio 36ba1d3ea8
Update distro 2019-05-29 14:03:46 -07:00
Daniel Imms cceeceb155 Remove logs 2019-05-29 13:00:51 -07:00
Martin Aeschlimann a68a2de088 update distro 2019-05-29 21:23:23 +02:00
Martin Aeschlimann 98b8848002
Merge pull request #74550 from microsoft/aeschli/bin-path
add bin path on server
2019-05-29 21:20:19 +02:00
Daniel Imms 0e39c152f7 Correctly splice from bg terminal list
Fixes #74487
2019-05-29 12:01:16 -07:00
Daniel Imms 3b95e8ed97
Merge pull request #74519 from microsoft/joao/cleanup-native-modules
Tighten native node modules cleanup rules
2019-05-29 11:19:51 -07:00
Matt Bierner 8870d8e742
Merge pull request #74546 from tony-xia/use-const
Use "const" instead of "let" in uint
2019-05-29 11:01:33 -07:00
Peng Lyu 4df618ddd4 Fix #74562. update menu registration key in comments. 2019-05-29 10:21:16 -07:00
Peng Lyu 3bf7c92093 Fix #74561. Update resource name to uri. 2019-05-29 10:12:32 -07:00
Rachel Macfarlane 2185280ed5 Update commentThread/context and comment/context contribution descriptions, fixes #74552 2019-05-29 09:59:36 -07:00
Miguel Solorio 9d14aa15f1
Merge pull request #74569 from microsoft/misolori/octicons-update
Update vscode-octicons-font to 1.3
2019-05-29 09:17:52 -07:00
Miguel Solorio 063ddf03e7 Update vscode-octicons-font to 1.3 2019-05-29 09:02:49 -07:00