Actually fix the issue

typeof NaN is number :/
This commit is contained in:
Daniel Imms 2019-05-31 10:07:20 -07:00
parent e698d0d889
commit bd08ccfc32

View file

@ -200,7 +200,7 @@ export class TerminalProcess implements ITerminalChildProcess, IDisposable {
if (this._isDisposed) {
return;
}
if (typeof cols !== 'number' || typeof rows !== 'number') {
if (typeof cols !== 'number' || typeof rows !== 'number' || isNaN(cols) || isNaN(rows)) {
return;
}
// Ensure that cols and rows are always >= 1, this prevents a native