Commit graph

107892 commits

Author SHA1 Message Date
Ladislau Szomoru 5ea57c3b48
GitHub - leveral repository rules for branch protection (#180416)
* WIP - switching to use repository ruleset information

* Handle includes

* Refactor to add support for exclusion

* Fix exclude condition

* Fix request string

* Add logging

* Update setting description
2023-04-20 16:43:42 +02:00
Henning Dieterichs 3f6a54de51
Merge pull request #180403 from microsoft/hediet/b/ideological-wasp
Removes unneeded additionalReservedLineCount from GhostText
2023-04-20 16:00:02 +02:00
Henning Dieterichs 239849f575
Removes unneeded additionalReservedLineCount from GhostText 2023-04-20 12:18:14 +02:00
Johannes Rieken dbf4b14dfa
use diff information to size and crop live previews views (#180341)
also fixes https://github.com/microsoft/vscode-internalbacklog/issues/3874
2023-04-20 18:49:33 +10:00
Henning Dieterichs c28ca0b1e8
Cleanup (#180393) 2023-04-20 10:17:57 +02:00
John Murray b02700ce73
Set a max-height on comments and add vertical scrolling (#174629) (#180044)
* Set a max-height on comments and add vertical scrolling (#174629)

* Move `max-height` to stylesheet

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
2023-04-20 07:54:07 +00:00
Joyce Er 061041479c
Fix incorrectly stringified workspace folder URI (#180380) 2023-04-20 07:50:50 +02:00
Tyler James Leonhardt 208bbb0d78
Have issue reporter use service injection (#180373)
* Have issue reporter use service injection

The main part of this change is pulling out the IssueReporter class into its own file and then having the Main.ts file be all about initialization.

This will be easier to register remote services (to help get rid of all the raw IPC)

* add external for clarity
2023-04-19 20:05:37 -07:00
Rob Lourens 917baefded
Persist chat editors when the window is reloaded (#180367)
* Persist chat editors when the window is reloaded

* Fix tset
2023-04-19 20:05:06 -07:00
Joyce Er b5e90fd0b1
Support dedicated lane for breakpoint decorations (#180013)
* Add fast path for margin decoration access

* Support glyph margin decoration lanes

* Do not center extension-contributed decorations

* Show breakpoints in dedicated right lane

* Only recompute lane count if glyph margin was affected

* Add explicit type for className / zIndex pair and fix problems in other consumers of `DedupOverlay`

* Avoid arrays of arrays

* Figure out if two lanes are needed in O(N)

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2023-04-19 16:26:20 -07:00
Tyler James Leonhardt 0724039270
Initial IssueUriRequestHandler proposed API (#180363) 2023-04-19 23:18:44 +02:00
Kartik Raj bc0bdd3c68
Merge pull request #180356 from microsoft/violent-sturgeon
Update distro
2023-04-19 13:31:53 -07:00
Logan Ramos fb90df7693
Fix checking for object property when no prototype exists (#180226)
* Fix property check when there is no prototype

* Fix issue with checking for property w/o prototype

* Try different method for test pass
2023-04-19 12:52:56 -07:00
Alexandru Dima 05304f024c
Fix problem with accepting a deletion (#180357)
Fixes #179268: Fix problem with accepting a deletion
2023-04-19 12:52:33 -07:00
First 1021c80dc1 Oops 2023-04-19 12:28:14 -07:00
First 5045e6ec88 Update distro 2023-04-19 12:15:47 -07:00
Sandeep Somavarapu 9c4d6d2957
support loading profile in web (#180331)
* support loading profile in web
- embedder api to pass profile and contents
- initialise the profile

* fix typo
2023-04-19 20:56:39 +02:00
Sandeep Somavarapu 446426b005
handle 403 and remove sign in error prompt (#180351) 2023-04-19 20:46:43 +02:00
Matt Bierner 6a9c24cbd0
Update importModuleSpecifierEnding to mention .ts (#180349)
Makes the `importModuleSpecifierEnding` settings mention that it can include `.js` or `.ts`
2023-04-19 20:43:53 +02:00
Aiday Marlen Kyzy b1bfb0f471
Merge pull request #180297 from microsoft/aiday/changeRunOfInterativeWindow
Modifying the run method of the interactive window
2023-04-19 19:36:55 +02:00
SteVen Batten 4dbb5dcb65
bump tas-client-umd 0.1.8 (#180345)
* bump tas-client-umd 0.1.8

* undo accidental spdlog addition
2023-04-19 19:34:35 +02:00
Matt Bierner 3273501a5a
Address drop UX feedback (#180343)
- Reduce margin on button
- Change icon to insert
- Try to align styling to match other editor widgets
- Use capital casing on entries
2023-04-19 19:05:56 +02:00
Tom Heaton 86528d8df2
Fix collapseAll command when no folder is open (#180330)
* check view is not null before casting to `ExplorerView`

* explicit `null` check
2023-04-19 09:42:11 -07:00
Matt Bierner 2f07466dfc
Allow dropping images into notebook cells to create attachments (#180256)
* Allow dropping images into notebook to create attachments

Fixes #157577

This allows you to drag and drop image files or image data into a notebook cell to create an attachment

As part of this work, I also updated the paste attachment logic so that we can:

- Create multiple attachments in a single operation
- Create attachments of other mime types besides `image/png`
- Create attachments for images that have spaces in the filename

* Also allow pasting uri lists to create attachments

* Fix indent

* Add id
2023-04-19 09:39:04 -07:00
Sandeep Somavarapu 4c78cda80c
update distro (#180314) 2023-04-19 17:53:57 +02:00
Matt Bierner 4cbcece24d
Document VSDataTransfer and fix size (#180333) 2023-04-19 17:32:11 +02:00
Aiday Marlen Kyzy 77ae83433e
adding check on arg being defined 2023-04-19 17:03:59 +02:00
Aiday Marlen Kyzy 4026e4b617
cleaning the code 2023-04-19 16:54:22 +02:00
Henning Dieterichs 7395a78d08
Fixes #164583. Renames diffAlgo name smart to legacy and experimental to advanced. (#180310) 2023-04-19 16:04:23 +02:00
Aiday Marlen Kyzy de29c80297
cleanign the code 2023-04-19 14:29:01 +02:00
Aiday Marlen Kyzy e05bd20ccc
type checking 2023-04-19 13:13:45 +02:00
Aiday Marlen Kyzy 04beb6de9c
Merge pull request #178242 from microsoft/aiday/issue52364
Making a standalone color picker appear for inserting colors
2023-04-19 12:39:39 +02:00
Benjamin Pasero e07fa8f374
Failed to open workspace settings file under empty workspace (fix #177639) (#180308) 2023-04-19 12:31:01 +02:00
Henning Dieterichs 24ff5abc77
Merge pull request #180307 from microsoft/hediet/b/eerie-elephant
Adds changes2: LineRangeMapping[] to IDiffComputationResult
2023-04-19 12:01:47 +02:00
Aiday Marlen Kyzy 6f36f46c3f
further code simplification 2023-04-19 11:51:35 +02:00
Henning Dieterichs 476ef2dab4
Improves range handling (#180306) 2023-04-19 11:50:49 +02:00
Johannes Rieken fdca214e4c
disable overview ruler, use experimental diffing (#180304) 2023-04-19 11:46:59 +02:00
Henning Dieterichs 6d4aaec420
Adds changes2: LineRangeMapping[] to IDiffComputationResult 2023-04-19 11:42:25 +02:00
Aiday Marlen Kyzy 2badd4030d
simple refactoring 2023-04-19 11:10:15 +02:00
Aiday Marlen Kyzy 833c1dd452
removing the ||= 2023-04-19 11:07:51 +02:00
Aiday Marlen Kyzy 4b0839c59a
cleaning the code 2023-04-19 11:05:11 +02:00
Ladislau Szomoru 1bb47a1c60
SCM - polish scm input validation message layout (#180299) 2023-04-19 11:00:56 +02:00
Aiday Marlen Kyzy a147c1a247
cleaning the code 2023-04-19 10:54:01 +02:00
Matt Bierner edf0b737f3
Prefer installed drop providers over builtin providers (#179336)
Fixes #156384

Makes the languageFeature order providers from extension before built-in providers if they would otherwise score the same

This is useful for drop because if you install an extension, you likely want it to be used by default on drop

Longer term, I plan to add an option to switch which provider is used after the drop is made and potentially also allow configuring the default provider. However I find this new behavior is a good default
2023-04-19 09:42:01 +02:00
Aiday Marlen Kyzy 147512c2c8
setting the input to be of type string or undefined 2023-04-19 09:36:54 +02:00
Sandeep Somavarapu 1d0fec3221
remove duplicate test (#180248) 2023-04-19 09:20:50 +02:00
Peng Lyu 737eec2f5d
Re #179224. Customize action for save error. (#179727)
* Cache view type provider for missing extension restore.

* Re #179224. Customize action for save error.

* polish

* No delay for persisting view type memento

* Use log service instead of console

* dispose listener if extension installation/enablement fails

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-04-19 07:32:46 +02:00
Matt Bierner 63dfe7c355
Split built-in uri-list drop provider into two (#180277)
Split uri-list drop provider into two

This splits the built-in uri list drop providers into two: one that inserts relative paths and one that inserts full paths/uris

Also improves the labels for these drop edits
2023-04-19 07:09:12 +02:00
Matt Bierner 545d981034
Align drop and paste providers handling of mimetypes (#180279)
Makes sure that both drop and paste providers support wildcard matching and can also use the special `files` type to indicate that they should be invoked if there are any files
2023-04-18 20:38:13 -07:00
Robo d57d7ff4dc
chore: update electron@22.4.7 (#180276) 2023-04-19 04:34:34 +02:00