Commit graph

99483 commits

Author SHA1 Message Date
Robo 5d796f32ea
smoke(electron): wait for page navigation to commit before using driver (#157106)
* smoke(electron): wait for page navigation to commit before using driver

* chore: only use window event in Electron

* chore: implement load event for web

* 💄

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2022-08-09 09:31:12 +02:00
Benjamin Simmonds b41684837f
Merge pull request #157516 from microsoft/benibenj/disabledTreeItem
Show TreeItem as disabled when command enablement is false
2022-08-09 09:14:03 +02:00
Daniel Imms 5cf4a848f9
Finalize VS Code shell integration sequences in code (#157571) 2022-08-08 19:56:39 -07:00
Megan Rogge 62bf2bfb89
skip task terminals when startup kind is not reload (#157560) 2022-08-08 19:56:08 -07:00
Andrea Mah 026a2ce3ae
Error in editor when dismissing all search results (#157170)
Fixes #157116
2022-08-08 17:20:41 -07:00
Raymond Zhao e57cba9fe4
Add check for language tag settings (#157583)
Fixes #157581
2022-08-08 16:51:29 -07:00
Joyce Er 1c82bb3c6d
Merge pull request #157582 from microsoft/dev/joyceerhl/digital-mink
Avoid corrupting stored image data in edit sessions
2022-08-08 16:34:07 -07:00
Peng Lyu 6fa78714d1
Use theme color for process explorer scrollbar. (#157579) 2022-08-08 16:28:48 -07:00
Joyce Er 950d2106ad
Update edit session view to show decoded working changes
Previously edit sessions only accounted for text files, so a `TextModelContentProvider` was sufficient, but now we need to register a file system provider because image data is handled by extensions and we don't own the model for that
2022-08-08 16:18:34 -07:00
Joyce Er cd477d6fa1
Allow read operations for file system providers implementing readFile 2022-08-08 16:16:18 -07:00
Matt Bierner c4aa585d22
Fix notebook links with empty hashes (#157575)
Fixes #153032

This fixes our handling of `href="#"` on links in notebooks
2022-08-09 01:14:03 +02:00
Joyce Er af87992aa5
Support images in edit sessions by base64 encoding file contents 2022-08-08 16:12:29 -07:00
Matt Bierner 52b6278e73
Add readonly to notebookMessaging types (#157562) 2022-08-08 16:01:22 -07:00
ChaseKnowlden 19d0675506
Add offline_access to list of default scopes (#157453)
Add a new scope to default scopes
2022-08-08 14:55:13 -07:00
Michael Lively 9225503c85
Support for pasting images into markdown notebook cells (#156847)
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* document paste additions

* update condition to re-render cells, now includes metadata changes

* paste API working, debugging command added

* paste working with metadata. needs numbering, and cleaning upon delete

* paste screenshot works fully

* remove debugging command. Cleaning.

* notebook cells now re-render upon metadata changes

* changed name validity checking, remove unneeded function

* use _document for cell data, use snippet choice, dto fix

* return subscription, for loop, uri fix, alter metadata in-place, better snippet

* metadata fix, object.equals, fix cellAttRenderer metadata call

* added comment with source of encodeBase64

* gate mkdn image paste behind experimental setting
2022-08-08 13:57:49 -07:00
Daniel Imms 28c025e45d
Merge pull request #157377 from pingren/fix/terminal-cwd-unicode
Add env for terminalProcess getCwd Unicode path on macOS
2022-08-08 13:55:53 -07:00
Matt Bierner 0103536a60
Apply editor-font-family to all code in notebooks (#157554)
Apply editor-font-family to all `code` in notebook

Fixes #146696

This matches what we do in the markdown preview
2022-08-08 20:59:16 +02:00
Daniel Imms 13429c254b
Merge pull request #157535 from microsoft/tyriar/157524
Use %s to format % chars instead of sed to sanitize
2022-08-08 11:50:05 -07:00
avi-gitkraken 68f83f0fc8
#157310 Fix typo (minimum -> maximum) in splitview.ts comment (#157311)
Fix typo (minimum -> maximum) in splitview.ts comment
2022-08-08 11:27:28 -07:00
Megan Rogge 9395d5e43f
handle debug traps with [[ specially (#157544)
* fix #154189

* add comment
2022-08-08 19:54:56 +02:00
Peng Lyu ff1d2abb84
Fix #148390. Update markup cell decoration css rules. (#157539) 2022-08-08 10:49:05 -07:00
Logan Ramos 4b8660f7ad
Add comment for verification-steps-needed (#157518) 2022-08-08 10:11:05 -07:00
Daniel Imms 324c3e7eea
Use %s to format % chars instead of sed to sanitize
Fixes #157524
2022-08-08 09:59:33 -07:00
Megan Rogge edce02d186
check if it is restarting before removing persistent task (#157531) 2022-08-08 09:59:07 -07:00
Daniel Imms 029b9bcc1c
Merge branch 'main' into fix/terminal-cwd-unicode 2022-08-08 09:47:17 -07:00
Tyler James Leonhardt d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 (#157530)
* rev version of vscode-nls to 5.1.0

* and yarn lock
2022-08-08 18:43:45 +02:00
Benjamin Simmonds 09e3dd2fc9
Set color of label text instead of opacity 2022-08-08 18:35:51 +02:00
Tyler James Leonhardt 49394cc44d
Enable translations for extension code for the web (#155355)
* Initial attempt

* alex feedback
2022-08-08 09:11:16 -07:00
Peng Lyu 12b1f7ceb4
Polish #154913. Set current find match based on notebook selection. (#157337)
* Polish #154913. Set current find match based on notebook selection.

* update current match when query is seeded from selection.

* update test
2022-08-08 08:29:36 -07:00
Daniel Imms f3d5abc497
Merge pull request #157505 from microsoft/tyriar/157417
Avoid null coalescing operator for pwsh 6 support
2022-08-08 07:53:27 -07:00
Megan Rogge fc4871b50b
remove persistent task key when task terminates (#157519)
* remove persitent task key when task terminates

* Update src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
2022-08-08 07:51:47 -07:00
Sandeep Somavarapu c23afced7d
Merge pull request #157509 from microsoft/sandy081/subtle-halibut
make userdata sync store client profile aware
2022-08-08 16:14:27 +02:00
Benjamin Pasero b1446a6693
Add saved files to "Open Recent" (fix #153275) (#157503)
Add saved files to "Open Recent" (fix #153275)
2022-08-08 15:59:11 +02:00
Benjamin Simmonds b7ec785de0
disable TreeItem 2022-08-08 15:44:43 +02:00
Daniel Imms 23a31cb18d
Merge pull request #156071 from MonadChains/selection-bug
Fix selection when reach boundaries of the terminal
2022-08-08 06:29:32 -07:00
Daniel Imms dae1f74098
Merge branch 'main' into selection-bug 2022-08-08 06:14:27 -07:00
Sandeep Somavarapu c54e8a0f36
make store profile aware 2022-08-08 14:54:34 +02:00
Daniel Imms 0e6f46aa0b
Avoid null coalescing operator for pwsh 6 support
Fixes #157417
2022-08-08 05:38:55 -07:00
Isidor Nikolic 34f184263d
Merge pull request #157487 from microsoft/isidorn/hissing-chinchilla
Cleaner updateAriaLabel in ActionViewItems
2022-08-08 11:29:25 +02:00
isidor df1b57cdb4
react to @bpasero feedback 2022-08-08 10:59:45 +02:00
Rob Lourens f1c5243126
"input" variables prevent compound configuration from launching more than one session (#157355)
Fixes #141514
2022-08-08 09:20:55 +02:00
Megan Rogge b0895f9fcc
wait for terminal reconnection to restore tasks (#157307) 2022-08-07 20:06:36 -07:00
Daniel Imms afbe9605e5
Merge pull request #156486 from gjsjohnmurray/fix-156481
Don't link to deprecated `terminal.integrated.automationShell.*` settings (#156481)
2022-08-07 16:43:59 -07:00
John Murray 66aef7979d
Merge branch 'main' into fix-156481 2022-08-06 21:55:58 +01:00
Benjamin Pasero e58c66c819
Issue reporter fails to report when sandbox is enabled (#157368)
issue repoter misses data
2022-08-06 10:37:34 -07:00
Daniel Imms 60f1e28df6
Merge pull request #157330 from microsoft/tyriar/reattach
Improved reconnection logging and throw when attaching to orphan processes
2022-08-06 08:01:03 -07:00
pingren 5168a1a7d7 Add env for terminalProcess getCwd unicode path on macOS
Fixes https://github.com/microsoft/vscode/issues/83496
2022-08-06 15:41:14 +08:00
Daniel Imms cb79d01555
Merge pull request #157350 from microsoft/tyriar/fix_ps1_tests
Fix pwsh shell integration tests
2022-08-05 16:48:00 -07:00
Daniel Imms 938ad8b418
Merge pull request #157272 from microsoft/tyriar/157226
Escape % in bash shell integration
2022-08-05 16:42:03 -07:00
Daniel Imms b01f24b6f9
Merge pull request #157348 from microsoft/merogge/z
reset `ZDOTDIR` to user's for non-login shells
2022-08-05 16:41:20 -07:00