development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-19 18:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
43905 commits 1079 branches 296 tags 1.3 GiB
Commit graph

43905 commits

This branch
This branch
All branches
Author SHA1 Message Date
Benjamin Pasero 4149fc4e53 💄 2018-12-20 08:45:24 +01:00
Matt Bierner 5a2363c242 Fix some simple strict null errors in snippet 2018-12-19 22:50:23 -08:00
Matt Bierner 4e45bc2e49 Fix simple strict null errors in window.ts 2018-12-19 22:40:50 -08:00
Matt Bierner 1123caa5cc Strict null check feedback 2018-12-19 22:32:52 -08:00
Rob Lourens f903e6d226 Clean up unused settings editor toolbar 2018-12-19 22:12:18 -08:00
Matt Bierner 18d2ff160c Fix strict null type errors in tests 2018-12-19 22:10:55 -08:00
Matt Bierner 4743190f77 Sort strict null check file 2018-12-19 22:00:51 -08:00
Matt Bierner d2b050911c Fixed strict null check in test 2018-12-19 21:58:47 -08:00
Chris Ganga 11b943278a enable strict null check (#65444) 2018-12-19 21:54:24 -08:00
Oleg Voloshin 1da710b9c5 Enable strict null checking for workspaceStats test (#65429) 2018-12-19 21:53:08 -08:00
Ashwin Ramaswami 8ca7829768 Strict null checks for windowsKeyboardMapper.test.ts (#65423) 2018-12-19 21:52:54 -08:00
Kermit Xuan 48bd6f8b4e Enable strict null checking for String test (#65449) 2018-12-19 21:52:05 -08:00
Chris Ganga 11bbd0569b enable strict null check for src/vs/base/test/common/async.test.ts (#65442) 2018-12-19 21:51:33 -08:00
Matt Bierner 76182e637b Fix error where cancelled paramter hint request would still count as a retrigger 2018-12-19 21:43:12 -08:00
Matt Bierner cf9e62d373 Merge update and cancel events to a single change event 2018-12-19 20:37:25 -08:00
Matt Bierner 5e2ec87c62 Don't double fire cancel 2018-12-19 20:32:36 -08:00
Matt Bierner 7854596caf Use constants for states 2018-12-19 20:31:39 -08:00
Matt Bierner 1310ea6eff Fix import path casing 2018-12-19 19:26:38 -08:00
Matt Bierner 25cbe685bc Fix null check 2018-12-19 19:07:38 -08:00
Matt Bierner 48cc02be6e Extract setIgnoreMenuShortcuts 2018-12-19 18:34:03 -08:00
Matt Bierner 3cdcfa8574 Prevent currentSignature and activeSignature from getting out of state 
Use modes.SignatureHelp as source of truth for activeSignature
 2018-12-19 18:05:49 -08:00
Matt Bierner 6b39891d73 Use less state in parameter hints widget 
Use the model to track state and active parameter instead of tracking this in the widget itself. This enforces a cleaner boundary between model and view
 2018-12-19 17:53:35 -08:00
Matt Bierner c9735f865c Use union type to track state 
This allows us to store additional data on the state, such as the active parameter
 2018-12-19 17:36:48 -08:00
Matt Bierner 054eb85bd6 Remove unused triggerCharactersListeners field 2018-12-19 17:23:44 -08:00
Matt Bierner 574e06eb4b Use a single state value to track parameter hint state 
The parameter hints model can only be in a single state at a time. Use a single state variable to better track this
 2018-12-19 17:21:48 -08:00
Matt Bierner 6422adaffe Remove redundant type annotations for generic emitter properties 
Code like:

```
private readonly _onDidEncounterLanguage: Emitter<LanguageId> = new Emitter<LanguageId>();
```

Does not need to repeat the `Emitter<LanguageId>` type annotation
 2018-12-19 17:10:39 -08:00
Matt Bierner 60e788cda1 Extract paramterHintsModel to own file 2018-12-19 14:57:37 -08:00
Matt Bierner 5f40bbf67f Use shorthand instead of extra nesting 2018-12-19 14:51:00 -08:00
Matt Bierner ac812433df Remove not null assertions 2018-12-19 14:48:59 -08:00
Matt Bierner dbeaaa6890 Remove commented out code 2018-12-19 14:42:54 -08:00
Matt Bierner 8a58c3e7a6 Try to disable menu keyboard shortcuts on macos when executing command inside of webview 
Fixes #64724

Should prevent double dispatch of keyboard events in most cases
 2018-12-19 14:20:13 -08:00
Matt Bierner 23508cf1a0 Update markdown dependencies 2018-12-19 13:40:54 -08:00
Matt Bierner aa301e3435 Update js/ts grammar 2018-12-19 13:40:54 -08:00
Alexander 33ed0d8cf8 Enable strict null checking for quickOpenScorer test (#65299) 
* Enable strict null checking for quickOpenScorer test

* Changing as any to Exclamation mark
 2018-12-19 13:40:34 -08:00
Alexandru Dima 24d357a4ad
Merge pull request #64228 from Microsoft/alex/35225 
Detect menu items invoked via keybinding and dispatch keybinding on renderer
 2018-12-19 20:35:27 +01:00
Alexander 85dcbf72d2 Enable strict null checking for Notifications test (#65291) 
* Enable strict null checking for Notirications test

* Changing as any to Exclamation mark
 2018-12-19 11:09:56 -08:00
Prabhanjan S Koushik 55ebf93842 fix-65287 Added webviewManager.refresh() (#65396) 2018-12-19 11:05:57 -08:00
Benjamin Pasero 3e78e05f79 electron 3.0.x - --no-untrusted-code-mitigations does not seem to do anything 2018-12-19 19:24:45 +01:00
Benjamin Pasero 2d0492fd3b labels - lift some event handling up 2018-12-19 19:22:15 +01:00
Benjamin Pasero 51582b9dfe
Merge pull request #65408 from Microsoft/ben/labels 
introduce ResourceLabels
 2018-12-19 19:08:53 +01:00
Benjamin Pasero 43e502affa labels - 💄 2018-12-19 19:08:28 +01:00
Benjamin Pasero d9bfe033f5 labels - visibility 2018-12-19 18:55:28 +01:00
Johannes Rieken 48e30655e8 lazy - more delayed services 2018-12-19 18:33:00 +01:00
Pine Wu e489f935a2 Ensure no spaces when working on html LS 2018-12-19 09:14:49 -08:00
Pine Wu a04ddffb9d No forcing tabsize on users 2018-12-19 09:10:53 -08:00
Johannes Rieken 9b4ae10715 update ref-viewlet extension 2018-12-19 18:06:39 +01:00
SteVen Batten 15e3946654
only dismiss editor context menu when scrollTop has changed (#65111) 2018-12-19 09:03:05 -08:00
Christof Marti 40ff57e055 Set defaultPort (#65118) 2018-12-19 17:24:29 +01:00
Benjamin Pasero db535e02ea labels - clear() is not needed when the label is set right after 2018-12-19 17:10:32 +01:00
Benjamin Pasero b07f007596 labels - cleanup click handler 2018-12-19 17:06:58 +01:00