Commit Graph

1693 Commits

Author SHA1 Message Date
Benjamin Pasero
def1c0dc47
smoke test - try to unblock CI (#175382)
* smoke test - try to fix runs

* comment
2023-02-24 21:35:41 +01:00
Raymond Zhao
7b6b6869e8
Add en as fallback osLocale (#175039) 2023-02-21 17:26:37 -08:00
Tyler James Leonhardt
4e32196835
Fix locale and language handling (#174779)
* Use language to get config and fix smoke test

* better check

* not

* fix a lot of mistakes

* skip test on linux
2023-02-19 08:17:04 +01:00
Martin Aeschlimann
dc619de8d9
Icons in problems view show black when not focused (#174487)
* Icons in problems view show black when not focused

* update smoke test
2023-02-15 22:34:14 +01:00
Rob Lourens
be54d2be91
Check notebook URIs in BulkCellEdits (#169669)
* Revert "Disallow cell URIs with NotebookEdit"

This reverts commit d7576eea81.

* Check notebook URIs in BulkCellEdits
Fix #146690
2023-01-07 17:35:25 -08:00
Benjamin Pasero
689624e401
tests - fix web integration tests to fail creating a page (#170613) 2023-01-05 02:54:56 -08:00
Alexandru Dima
06b97f6be7
Add more logging and perf markers around resolving the connection token and the socket factory (#170490)
* Add more logging and perf markers around resolving the connection token and the socket factory

* set `exposeFunction` earlier

* bla windows

* also expose function for unit tests beofre opening

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-01-05 10:17:19 +01:00
Matt Bierner
57dd298b47
Add typings for test runner scripts (#169196) 2022-12-15 02:19:24 +01:00
Connor Peet
812ef50afe
smoke: adopt new vscode test version (#168373)
Has timeout logic that fixes #166092
2022-12-08 01:14:41 +01:00
Connor Peet
0899758dae
ipc: use vql for uint types (#167407)
* ipc: use vql for uint types

On the plane I was reverse-engineering ipc.ts to implement it in Rust
and see if we could have a "service mode" for the CLI that we could
interact with like any other vscode process.

In doing so, I noticed that numbers in the protocol--which are used at
least twice in the message header and ID--were encoded as JSON. I was
curious what benefits we'd get from encoding them as variable-length
integers instead.

It makes the message shorter, as expected. Encode/decode time are very,
very slightly lower. I'm not sure it's worth the extra complexity, but
I have included it here for your consideration.

* fixup tests
2022-12-02 15:54:36 -08:00
Ladislau Szomoru
96d05578ac
Test - update minimatch (#167101) 2022-11-23 21:33:27 +00:00
Johannes
d555777b1a
simplify _VSCODE_NODE_MODULES util 2022-11-18 09:42:32 +01:00
Johannes
824c70b275
fix node tests 2022-11-18 09:42:15 +01:00
Johannes
8dd8d214d8
don't use __$__nodeRequire to fetch product configuration 2022-11-18 09:41:51 +01:00
Johannes
2d6ad4be88
* add global for node_modules access
* remove most usages of require.__$__nodeRequire
* stop using require.nodeRequire
2022-11-18 09:41:43 +01:00
Raymond Zhao
9feaed8f51
Revert "joh/representative canidae" (#166641) 2022-11-17 13:53:17 -08:00
Johannes
6dd2726c73
simplify _VSCODE_NODE_MODULES util 2022-11-17 17:58:51 +01:00
Johannes
1a0223da3f
fix node tests 2022-11-17 17:19:29 +01:00
Johannes
93c3f3202b
don't use __$__nodeRequire to fetch product configuration 2022-11-17 15:41:23 +01:00
Johannes
0824db3bad
* add global for node_modules access
* remove most usages of require.__$__nodeRequire
* stop using require.nodeRequire
2022-11-17 12:09:14 +01:00
Matt Bierner
f945df1b2d
Enable strict mode and bump target for test/smoke (#165296) 2022-11-02 19:23:58 -07:00
Matt Bierner
4efa993b13
Bump targets for test/automation and test/integration (#165298)
Also enables strict mode for test/integration since it only had strict null checks previously
2022-11-02 17:10:12 -07:00
Matt Bierner
3a8b7e4276
Highlight label should not create extra span nodes (#164657)
* Highlight label should not create extra empty dom nodes

I noticed that the `HighlightedLabel` class creates extra `span` elements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the document

I also related the conditional spread with a longer version that uses a simple call to push. This is worth doing since `HighlightedLabel` is so widely used in the editor

* Update tests

* Update smoke test selector

* Update css
2022-11-01 08:00:38 -07:00
João Moreno
a2e787228f
smoketests should not fail by bumping version in package.json (#165132)
related to #165118
2022-11-01 07:12:43 -07:00
Matt Bierner
d1c401cbde
Pick up latest TS for building VS Code (#165104)
* Pick up latest TS for building VS Code

* Pick up latest node typings

* Bump node types
2022-11-01 02:43:09 -07:00
Matt Bierner
99e126b0b2
Pick up latest TS version for building VS Code (#162786)
Pick up latest TS for building VS Code
2022-10-06 12:08:45 -07:00
Andrea Mah
f8aa3a7c04
improve search smoke test (#161652)
* improve search smoke test
* prevent text to show when clearing results
2022-10-05 08:52:39 -07:00
Johannes
15b8f56574
fix rendering/UI for ./scripts/test.sh --dev 2022-10-04 14:51:58 +02:00
Robo
94ec9025ea
build: use swiftshader on macOS CI (#162568) 2022-10-03 14:35:58 +02:00
Rob Lourens
39d13fed77
Disable notebook smoke tests again (#160942)
#140575
2022-09-14 15:09:05 -07:00
Rob Lourens
c717237d7c
Reenable a couple notebook smoketests (#159521)
* Remove vscode-notebook-tests in favor of an .ipynb in vscode-smoketest-express

* Update build folder

* Add build task to correct platform

* Build for smoke tests on other platforms

* Fix repo url and remove comment

* Just -media?

* Update darwin/win32 as well
2022-09-14 13:22:16 -07:00
Alexandru Dima
a68f9da5fe
There is no need to pass in nodeMain when passing in baseUrl (#160893) 2022-09-14 13:04:14 +02:00
Benjamin Pasero
c8dd96f73b
smoke - fix log and retry exitApplication (#160244) 2022-09-07 07:17:04 +02:00
Daniel Imms
d0186508a1
Re-enable terminal profiles tests
It passed a loop of 50x tests so it looks like the flakiness is gone

Fixes #156961
2022-09-06 08:37:47 -07:00
Matt Bierner
5e92794be6
Re-enable running our eslint rules using ts-node (#159495)
Resubmission of #157532 with the following changes:

- Use `eslint-plugin-local` instead of `yarn` link to run our plugins
- Move our plugins to a top level `.eslintplugin` dir (as required by `eslint-plugin-local`)
- Update all names to `local/`
2022-08-30 08:40:04 +02:00
Matt Bierner
9e5248072a
Fix ts-node for eslint (#159483)
Bumps the cachesalt to make sure ts-node is installed
2022-08-29 20:51:12 +02:00
Matt Bierner
5b21c7f28b
Run our custom eslint rules using ts-node (#157532)
* Run our custom eslint rules using ts-node

Use `ts-node` to run our custom eslint rules.  This lets us delete the pre-compiled js. It also means you can don't have to compile the rules while editing them

As part of this change, I've also switched us to using an eslint plugin instead of a rulesDir. This is now the preferred way to ship custom rules

* Fix two more disables

* Move ts-node to project root

* Enable transpileOnly
2022-08-29 09:39:09 -07:00
Matt Bierner
07025f0b0d
Remove notebook editor edit api (#158988)
Fixes #149181
2022-08-29 09:34:57 -07:00
Johannes Rieken
1857d6c076
for test runinng, use --dev instead of --debug (#159040)
fixes https://github.com/microsoft/vscode/issues/159011
2022-08-24 07:54:39 -04:00
Benjamin Pasero
9d0c0b769e
Smoke test driver.exitApplication sometimes does not work (#157979) (#158479) 2022-08-18 09:03:44 -04:00
Benjamin Pasero
f8ad3a16bd
smoke tests mitigation for issue 157979 (#157980) 2022-08-12 11:44:57 +02:00
Matt Bierner
abc84e0735
Bump webview fallback commit (#157959)
For #157222
2022-08-11 16:40:05 -07:00
Robo
5d796f32ea
smoke(electron): wait for page navigation to commit before using driver (#157106)
* smoke(electron): wait for page navigation to commit before using driver

* chore: only use window event in Electron

* chore: implement load event for web

* 💄

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2022-08-09 09:31:12 +02:00
Connor Peet
39e77d74ca
fix: parse errors in coverage command (#156837)
Fixes #155615
2022-08-05 18:27:40 +02:00
Daniel Imms
740ba5c3d4
Fix tests after codicon changes 2022-08-04 09:49:21 -07:00
Benjamin Pasero
0a7226e9ad
Revert "Increase timeout of web unit tests" (#157065)
Revert "Increase timeout of web unit tests (#156894)"

This reverts commit f86beb18e8.
2022-08-04 11:52:56 +02:00
Benjamin Pasero
f86beb18e8
Increase timeout of web unit tests (#156894)
* Windows: some Firefox web tests are timing out randomly (#155760)

See if this is a fundamental issue or really Firefox is slower.

* mention issue
2022-08-03 06:55:58 +02:00
Megan Rogge
ba30d11869
skip flaky tests to investigate (#156906) 2022-08-02 19:38:05 +02:00
Benjamin Pasero
86e7410278
unit tests - help diagnose test failure reason for web tests (#155967) 2022-07-22 18:50:34 +02:00
Daniel Imms
d2f3f7555b
Allow continuing on when term kill all doesn't succeed
Fixes #155817
2022-07-21 16:32:25 -07:00
Benjamin Pasero
5ae2a59a6d
smoke test - only warn when treekill fails (#155577) 2022-07-19 14:19:02 +02:00
Johannes Rieken
6f6e26fcdf
fix assumptions about action-bar title structure (#155292) 2022-07-15 10:23:03 +00:00
Megan Rogge
ff31a8c6fd
disable decorations (#154430) 2022-07-13 10:17:01 -07:00
Daniel Imms
3b9cd9812a
Re-enable profiles smoke tests
Fixes #154811
2022-07-12 05:35:36 -07:00
Daniel Imms
b358062d36
Temporarily disable some profile tests
Part of #154811
2022-07-11 12:32:14 -07:00
Megan Rogge
1076bf59dd
add task quick pick smoke tests (#154532) 2022-07-11 11:38:08 -07:00
Tyler James Leonhardt
3b3469da06
reenable localization smoke tests (#153397) 2022-06-27 15:59:29 -07:00
dependabot[bot]
c52dd348a7
Bump shell-quote from 1.7.2 to 1.7.3 in /test/smoke (#152842)
Bumps [shell-quote](https://github.com/substack/node-shell-quote) from 1.7.2 to 1.7.3.
- [Release notes](https://github.com/substack/node-shell-quote/releases)
- [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md)
- [Commits](https://github.com/substack/node-shell-quote/compare/v1.7.2...1.7.3)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2022-06-26 19:27:19 +00:00
Daniel Imms
9bdcdadfa5
Clean settings between suites 2022-06-21 10:38:19 -07:00
Daniel Imms
bcb2c6f8ee
Create a regular profile to work better on CI 2022-06-21 07:17:14 -07:00
Daniel Imms
cb0bbcc8c4
Document and remove unneeded command 2022-06-21 06:34:15 -07:00
Daniel Imms
d0ca1d2110
Always create DecorationAddon, synthetic data tests 2022-06-20 10:30:41 -07:00
Daniel Imms
8575a26b4e
Merge pull request #152490 from microsoft/tyriar/152451_2
Use new method for settings in terminal split cwd smoke test
2022-06-20 07:14:14 -07:00
Alexandru Dima
5dd9d5d491
Fix port argument (#152541) (#152617) 2022-06-20 10:32:27 +02:00
Daniel Imms
8e29aa44f7
Use new method for settings in terminal split cwd smoke test
I doubt this will fix the flake, but it's the right way to do things now.

Part of #152451
2022-06-17 08:44:31 -07:00
Daniel Imms
1ca9725a3b
Disable terminal smoke tests on desktop/remote
Fixes #152451
2022-06-17 08:18:49 -07:00
Robo
dd0d79406e
fix: OOM crash with linux smoke tests (#152440) 2022-06-17 03:04:20 -07:00
Daniel Imms
09d0431d20
Merge pull request #152278 from microsoft/tyriar/150478_4
Enable shell integration smoke tests (Linux/macOS) and terminal smoke tests on desktop
2022-06-16 10:03:14 -07:00
Alexandru Dima
3530e85ba8
Properly return a non 0 exit code in case a test times out and fix tests which used to time out (#152329) 2022-06-16 13:02:37 +00:00
Daniel Imms
463a1e5765
Run shell integration tests a single time and revert timeout 2022-06-15 21:01:26 -07:00
Daniel Imms
d4e06aaa2b
Disable windows shell integration tests only 2022-06-15 20:29:32 -07:00
Daniel Imms
1b0d0d00d4
Enable terminal tests on desktop 2022-06-15 19:22:40 -07:00
Daniel Imms
87a99dba09
Speed up shell integration tests and improve reliability 2022-06-15 18:50:34 -07:00
Daniel Imms
18408b9090
Allow tests to run multiple times 2022-06-15 12:35:53 -07:00
Daniel Imms
7548fed110
after -> afterEach 2022-06-15 11:30:24 -07:00
Daniel Imms
e4c3bca7a2
Kill all terminals after each shell integration test 2022-06-15 11:28:46 -07:00
Daniel Imms
1f5dc6a572
Run shell integration tests 100 times in CI
Part of #150478
2022-06-15 06:59:40 -07:00
Benjamin Pasero
1ba0e7b601
smoke - enable crash reporter (#152041)
* smoke - enable crash reporter

* nix da only!
2022-06-14 12:52:29 +00:00
Daniel Imms
d3ff1569e7
Wait for split to init before changing icon
Fixes #151710
2022-06-10 07:17:24 -07:00
deepak1556
c3077080ec Merge remote-tracking branch 'origin' into electron-18.x.y 2022-06-10 18:29:22 +09:00
Connor Peet
0f29ffbfe1
test: update vscode-test for error handling (#151698) 2022-06-10 08:35:16 +00:00
Johannes
0656d21d11
auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
deepak1556
9f56a2f166 Merge remote-tracking branch 'origin' into electron-18.x.y 2022-06-02 17:10:31 +09:00
Daniel Imms
d22292129e
Disable shell integration smoke tests
Part of #150478
2022-06-01 11:45:35 -07:00
Daniel Imms
d30748b76d
Disable shell integration error test
Part of #150742
2022-05-31 06:19:35 -07:00
deepak1556
1044556d8b chore: bump electron@18.0.0-beta.4 2022-05-31 08:25:29 +09:00
Benjamin Pasero
66092b1cde
enable stable smoke tests (#150532) 2022-05-27 09:16:34 -04:00
Daniel Imms
e02bca0890
Disable linux shell integration smoke tests
Part of #150478
2022-05-26 13:53:30 -07:00
Daniel Imms
8723d109a5
Skip error shell integration tests on Linux
Part of #150478
2022-05-26 11:25:33 -07:00
Daniel Imms
8873e262c6
Merge pull request #150192 from microsoft/tyriar/149324
Create bash explicitly on linux/mac in shell integration smoke tests
2022-05-26 07:48:48 -07:00
Megan Rogge
22806eaa8e
re-enable terminal tabs test (#148966) 2022-05-25 12:54:31 -07:00
Daniel Imms
d4f428940f
Merge branch 'main' into tyriar/149324 2022-05-25 06:35:27 -07:00
Tyler James Leonhardt
61861d7043
skip localization test until localized strings are present (#150326) 2022-05-25 00:28:33 +00:00
Daniel Imms
96479074a4
Create bash explicitly on linux/mac in shell integration smoke tests
Part of #149324
2022-05-23 07:22:15 -07:00
Daniel Imms
351b4a914e
Re-enable shell integration tests for macOS
Fixes #149757
2022-05-20 11:41:17 -07:00
Matt Bierner
17c75e1180
Allow reusing webview origins across reloads (#149950)
* Allow reusing webview origins across reloads

Currently webviews are always loaded into a unique origin. This keeps them isolated but also means that we can't benefit from caching across window reloads

This change adds a new `origin` option that you can pass to webviews which controls the origin they use. If this origin is not provided, we use a random one instead

We then save off this origin for webview panels and restore it on window reloads. Webviews restore a little faster on window reload

* Update webview fallback version
2022-05-19 16:07:14 -07:00
Daniel Imms
ca4db53d71
Skip shell integration smoke tests on mac as well
Part of #149757
2022-05-17 12:14:54 -07:00
Daniel Imms
9c29becfad
Disable shell integration smoke tests on Linux (#149376) 2022-05-13 16:47:10 +02:00
Ladislau Szomoru
2a9f19d36f
Engineering - create pull request pipeline (#149171) 2022-05-11 03:08:54 -07:00
Rob Lourens
9a7a7b6191
Re-skip smoke test (#149113) 2022-05-09 19:28:14 +00:00
Rob Lourens
7da792ae7c Reenable smoke test
Fixes #137195
2022-05-06 14:41:07 -06:00
Daniel Imms
6aaa63d4be
Merge pull request #148918 from microsoft/tyriar/146700_2
Fix, re-enable or disable skipped terminal smoke tests
2022-05-06 12:14:15 -07:00
Megan Rogge
5357dcfc04
fine tune shell integration messaging (#148856) 2022-05-06 09:26:12 -07:00
Daniel Imms
de7062f173
Re-enable retries 2022-05-06 08:13:19 -07:00
Daniel Imms
a5f0a29527
Fix, re-enable or disable skipped terminal smoke tests
Fixes #146700
2022-05-06 08:11:50 -07:00
Megan Rogge
bbf3142a89
use describe.skip for windows (#148580) 2022-05-02 14:23:55 -07:00
Ladislau Szomoru
b033e551c5
Fix #147036 2022-05-02 21:25:18 +02:00
Benjamin Pasero
f90dd46fc3
smoke - fail early if cloning fails 2022-05-02 08:38:03 +02:00
Benjamin Pasero
c6bd448948
debt - bring @types/mocha up to date with version 9.x 2022-05-02 08:30:27 +02:00
Megan Rogge
032d8ce4c6
shell integration smoke tests (#148056) 2022-04-25 14:53:55 -07:00
Benjamin Pasero
fb8dc11d58
Failed IPC communication with playwright smoke tests from preload script (for #146785) 2022-04-21 18:58:44 +02:00
Benjamin Pasero
08ac1bb67c
tests - improve exclusion handling for node.js tests 2022-04-21 17:10:16 +02:00
Benjamin Pasero
a9010d094a
smoke - support retryWithRestart in web too 2022-04-19 09:03:17 +02:00
Benjamin Pasero
06e26c7a57
Do not attempt to reopen files that lead to a crash in previous session (fix #114844) 2022-04-19 07:38:32 +02:00
Benjamin Pasero
ac6b490b2d
retr (#147442) 2022-04-14 11:34:22 +02:00
Benjamin Pasero
55759234d7
preload - revert retry logic which does not seem to help 2022-04-14 08:14:40 +02:00
Benjamin Pasero
c4cdb552a5
Remove legacy smoke test driver (#147393)
* wip

* fix imports

* more lipstick

* fix?

* fix
2022-04-13 19:19:58 +02:00
Benjamin Pasero
675b8c3da0
smoke - fix compile 2022-04-13 17:37:52 +02:00
Benjamin Pasero
98d2ea4444
smoke - restore workaround for #146785 2022-04-13 17:21:40 +02:00
Benjamin Pasero
a7cdd9a391
preload - and and use invokeWithRetry (#146785) 2022-04-13 13:06:22 +02:00
Benjamin Pasero
fa8d1063f6
🆙 1.21.0 (#147348)
* 🆙 `playwright`

* fix install

* adopt latest apis

* comment
2022-04-13 08:43:17 +02:00
Benjamin Pasero
d215bada5e
smoke - more logging for shared process 2022-04-12 11:13:19 +02:00
Benjamin Pasero
9967cf2782
smoke 💄 2022-04-12 08:17:52 +02:00
Benjamin Pasero
12500e46ac
properly skip unit test (#137853) 2022-04-11 17:02:34 +02:00
Benjamin Pasero
84d6b4a12a
smoke - enable more logging for #146800 2022-04-11 10:34:47 +02:00
Benjamin Pasero
497a035770
smoke - properly pick suite name 2022-04-10 10:13:07 +02:00
Benjamin Pasero
e358a02a35
smoke - also screenshot on failure 2022-04-09 13:55:56 +02:00
Benjamin Pasero
d9db5d10ec
smoke - try to fix terminal tests and partition logs path per suite 2022-04-09 13:38:59 +02:00
Benjamin Pasero
7e5180fb34
Remote extension host does not respect trace log (fix #146897) 2022-04-08 19:36:12 +02:00
Benjamin Pasero
9a8fa5f014
revert 2022-04-08 19:12:34 +02:00
Benjamin Pasero
af6bfd1352
smoke - bring back ext tests with retry for now to have coverage (#146800) 2022-04-08 12:33:52 +02:00
Martin Aeschlimann
cc47c60e96
testresolver: set log level with TESTRESOLVER_LOG_LEVEL. For #146897 2022-04-08 10:41:36 +02:00
Benjamin Pasero
b6fc6eae3b
skip terminal tests (#147063) 2022-04-08 10:32:00 +02:00
Benjamin Pasero
80c13ff14f
smoke - try to mitigate hanging close (#146803) 2022-04-07 17:48:59 +02:00
Benjamin Pasero
acc4c50ffa
smoke - skip flaky tests (#146800) 2022-04-06 19:36:17 +02:00
Benjamin Pasero
8e8b3026fc
tests - reduce spam and work 2022-04-06 19:34:41 +02:00
Benjamin Pasero
18377e6ee2
smoke - allow to enable verbose vscode logs and enable for now 2022-04-06 10:41:22 +02:00
Benjamin Pasero
fd7efbee45
smoke - cleanup some file names 2022-04-05 19:21:29 +02:00
Benjamin Pasero
16b97e6846
smoke - better use of tree-kill 2022-04-05 19:08:33 +02:00
Benjamin Pasero
7c31267b20
smoke - mitigate #146785 2022-04-05 18:03:36 +02:00
Benjamin Pasero
66c9155d93
smoke - skip install and enable vscode-smoketest-check extension in remote (#146800) 2022-04-05 17:31:10 +02:00
Benjamin Pasero
9a78ee3b1a
unit - skip all tests for test component in node 2022-04-05 17:27:24 +02:00
Benjamin Pasero
690a9c0f8d
smoke - adopt repo changes 2022-04-05 17:19:53 +02:00
Benjamin Pasero
2684fb1e00
smoke - logging 💄 2022-04-05 13:22:46 +02:00
Benjamin Pasero
e58cad64a9
smoke - add refs to #146811 2022-04-05 11:49:52 +02:00
Benjamin Pasero
a90f57b4a9
smoke - skip terminal tests in desktop 2022-04-05 11:47:29 +02:00
Benjamin Pasero
6508a29d23
smoke - more verbose logging on windows 2022-04-05 09:17:17 +02:00
Benjamin Pasero
a99a8711af
skip flaky terminal smoke test (#146796) 2022-04-05 08:40:07 +02:00
Benjamin Pasero
17a7edb8bb
smoke - remove some unused methods from driver 2022-04-05 08:04:40 +02:00
Inclusive Coding Bot
4983226088
Switch to gender neutral terms (#146371)
* Switch to gender neutral terms

* Update testrunner.js

* Update fileSearchManager.ts

* Update fileSearch.ts

* Update fileSearch.ts

Co-authored-by: inclusive-coding-bot <inclusive-coding-bot@github.com>
2022-04-04 16:22:09 -07:00