Commit graph

7014 commits

Author SHA1 Message Date
Alex Ross 810a54ddef Fix gulp global path for tasks and remove quotes in favor of community PR 2019-02-12 15:57:58 +01:00
Alex Ross 4cfbdcda77 Revert "Fix incorrect gulp path"
This reverts commit eca12e44fa.
2019-02-12 11:25:23 +01:00
Alex Ross eca12e44fa Fix incorrect gulp path 2019-02-12 11:00:48 +01:00
Alex Ross c7813f6da3 Allow spaces in gulp.cmd path
Fixes #68413
2019-02-12 11:00:05 +01:00
Matt Bierner a8216d42a4 Make the typescript plugins contribution point dynamic
Part of #67575
2019-02-11 16:41:59 -08:00
Johannes Rieken 52d134aacb update proposed api to have multiple positions, #41838 2019-02-11 12:08:27 +01:00
Matthew Kwiecien 45f686fadc Refactoring the wrap with abbrev unit test class to be less repetitive. 2019-02-10 10:11:48 -06:00
Matthew Kwiecien 0b3c33b801 Adding unit tests to check for className when file is jsx. 2019-02-10 10:09:56 -06:00
Matthew Kwiecien 7221f92ee2 Get syntax from arguments and document editor language when wrapping. 2019-02-09 12:59:16 -06:00
Johannes Rieken c110d84460 fix integration test 2019-02-08 18:03:56 +01:00
Matt Bierner 1cb2f5500a Support TypeScript's explicit "auto" quotePreference
Fixes #68185
2019-02-07 17:31:25 -08:00
Alex Dima f15a6faaca Try to fix Markdown 2019-02-07 09:53:52 +01:00
Benjamin Pasero e2d1fd06d1 debt - update extensions node dependency to 10.x 2019-02-07 08:49:36 +01:00
Matt Bierner 6ca137730b Extract 2019-02-06 14:04:24 -08:00
Matt Bierner 198e6a55e7 Make sure we dispose of event emitters properly 2019-02-06 14:04:24 -08:00
Matt Bierner 6b8b1b7bea Improve naming 2019-02-06 14:04:24 -08:00
Pine dc5bb48efe
Merge branch 'master' into octref/no-ionic-angular 2019-02-06 10:57:08 -08:00
Alex Ross da82ae40c8
Merge pull request #67921 from fadeevab/makefile-update
Makefile colorizing tests - handling variable expansion in a variable name
2019-02-06 15:54:55 +01:00
Alex Ross b0b6dc6c2e Update grammars to pick up make changes
and fix hashes.
2019-02-06 15:16:49 +01:00
Matt Bierner 038e8d3904 Make markdown extension points dynamic
For #67574

Blocked by #67958
2019-02-05 17:45:11 -08:00
Matt Bierner 8f10101dd4 Create base class for disposable objects 2019-02-05 17:45:11 -08:00
Matt Bierner 476d7fe0ab Refactor markdown contributions
Reducing code duplication and reducing state
2019-02-05 16:56:45 -08:00
Daniel Imms 111c704e2a
Merge pull request #67919 from Microsoft/tyriar/55718_terminal_dimensions
Add Terminal.dimensions and window.onDidChangeTerminalDimensions proposed APIs
2019-02-05 05:06:32 -08:00
Alexandr Fadeev e911796b8a Makefile colorizing tests - handling variable expansion in a variable name in assignment: var-$(another-var) := value 2019-02-05 14:57:06 +02:00
Daniel Imms 98eb895141 Implement onDidChangeTerminalDimensions
Fixes #55718
2019-02-05 04:44:13 -08:00
Martin Aeschlimann 7484e90bf0
Merge pull request #67861 from johnbillion/fix/composer-lock-json
Treat Composer lock files as JSON by default
2019-02-05 08:46:05 +01:00
Alex Ross 6e968190df Update grammars 2019-02-04 16:35:48 +01:00
John Blackbourn b46c77b7ad Treat Composer lock files as JSON by default. Fixes #67859. 2019-02-04 15:45:08 +01:00
Alexandr Fadeev f3552ec84d Makefile grammar updating: tests are updated about the handling of @, - and +. (#65629)
1. @, - and + in the beginning of recipes are colored.
2. Shell in recipes is not colored by shellscript extension anymore:
improper colorizing of Makefile variables, low suitability.
2019-02-04 11:11:03 +01:00
Matt Bierner c79a8bf7eb Remove stray log
:)
2019-02-01 14:45:26 -08:00
Matt Bierner e43830645b Pick up TS 3.3.1 final
Fixes #66175
2019-01-31 16:39:54 -08:00
Pine Wu 1bcf2c77ca [CSS] Update Service 2019-01-31 16:13:14 -08:00
Pine Wu ef0f902787 Fix custom data capitalization 2019-01-31 10:44:46 -08:00
Matt Bierner 9a766eaa38 Make sure we update tag closing registration when the document's language changes
Fixes #67613
2019-01-30 18:50:41 -08:00
Pine Wu 4833debfe0 Update css grammar. Fix #66775 2019-01-30 14:27:40 -08:00
Matt Bierner 10c3fcb4fc Fixes #67430 2019-01-30 12:58:11 -08:00
Pine Wu b9a116e11b [HTML] Update language service 2019-01-30 12:57:02 -08:00
Pine Wu af57ecdf9d Fix #67544 2019-01-30 11:59:02 -08:00
Matt Bierner ed8af3b1bd
Merge pull request #67535 from dtinth/patch-1
Use jsonc.parse instead of JSON.parse when parsing tsconfig.json, fixing bug where `-b` flag is not activated when tsconfig.json contains comments.
2019-01-30 11:50:35 -08:00
Pine Wu 6787bd1f25 Update html/css custom data config schema for #67544 2019-01-30 11:46:57 -08:00
Thai Pangsakulyanont 84424c84fd
Use jsonc parser to parse a config file
This fixes a problem where the `typescript` VSCode task runs `tsc` with `-p`
when it should run `-b` when `tsconfig.json` has the `"references"` property.

```js
{
  "extends": "./tsconfig.app.json",
  // meow
  "references": [{ "path": "./tsconfig.lib.json" }]
}
```

This bug happens because while `tsconfig.json` file allows comment, the
parsing logic here uses vanilla `JSON.parse` which cannot parse comments.

This commit fixes it by using `jsonc.parse` instead.
2019-01-30 17:46:45 +07:00
강동윤 6b314dc984 treat .swcrc file as json 2019-01-30 14:24:59 +09:00
Greg Van Liew 6f1cb19909 Fix jSDocCompletion deprecation message 2019-01-29 10:51:13 -08:00
Pine Wu bb96111b32 [HTML] Update language service 2019-01-29 10:37:23 -08:00
Matt Bierner c37d497f2b Mark add missing async as auto fixable 2019-01-28 18:12:32 -08:00
Matt Bierner 13aff1eff2 Add workaround for TS not supporting providePrefixAndSuffixTextForRename not being supported per-file
Workaround for https://github.com/Microsoft/TypeScript/issues/29585
2019-01-28 17:16:49 -08:00
Pine Wu e9708716f2 Move html/css custom data contribution to experimental 2019-01-28 17:14:28 -08:00
Pine Wu 81b9b09cd3 Update HTML language service for NPE 2019-01-28 17:12:24 -08:00
Pine Wu 0abf8dcbd0 Fix typo 2019-01-28 15:58:55 -08:00
Matt Bierner c1c3e5eab0 Properly encode markdown file path for open links
Fixes #59523

Double encode the path so that `Uri.parse`'s decoding only strips out the first level of encoding
2019-01-28 15:45:42 -08:00
Matt Bierner 52fb9079e9
Merge pull request #67148 from RomainMuller/master
Fix the "tsc watch" task when references are used
2019-01-28 15:32:21 -08:00
Martin Aeschlimann 3af611c759 make jsonValidation dynamic (for #66574) 2019-01-28 23:56:43 +01:00
Martin Aeschlimann 89275bcf59 Add preserve-aligned to the UI settings for html.format.wrapAttributes. Fixes #66644 2019-01-28 23:50:02 +01:00
Matt Bierner b15877def6 Handle some edge cases of #18131 2019-01-28 14:46:29 -08:00
Matt Bierner 807759ecff Rename jsDocCompletion.enabled to javascript.suggest.completeJsDocs and typescript.suggest.completeJsDocs
Fixes #67146
2019-01-28 14:46:29 -08:00
Martin Aeschlimann 58d3dade0e [html] update service (new formatter) 2019-01-28 23:36:11 +01:00
Martin Aeschlimann 85119f3faf Language features not supported for ".pyi" python type files. Fixes #66652 2019-01-28 22:59:54 +01:00
Pine Wu 4c89a268f5 Fix CSS imports 2019-01-28 13:55:55 -08:00
Matt Bierner a70b1317a1 Removing languageServiceEnabled check
After further discussion with the TS team, we determined that we do not need to stop sending  semantic commands when the language service disables itself
2019-01-28 13:40:27 -08:00
Matt Bierner ef25b181ea Move ServerResponse into namespace 2019-01-28 13:40:27 -08:00
Matt Bierner ccb5a625c2 Mark extract constant as a preferred refactoring
https://github.com/Microsoft/TypeScript/issues/29587
2019-01-28 13:40:27 -08:00
Pine Wu 81e2ef1be1 Update services 2019-01-28 13:29:36 -08:00
Martin Aeschlimann 1972f79077 client: semantic selection registration 2019-01-28 18:24:12 +01:00
Martin Aeschlimann 21585312c2 [json] enable semantic selection 2019-01-28 16:05:18 +01:00
Joao Moreno 37fbae08a4 Merge commit 'refs/pull/64826/head' of github.com:Microsoft/vscode into pr/64826 2019-01-28 15:34:23 +01:00
Pine Wu 33783baaa1 Fix #64022 2019-01-27 23:23:52 -08:00
Pine Wu 0ba2b1d078 Update css-service to fix NPE exceptions 2019-01-27 23:05:13 -08:00
Pine Wu 3815bb15fd Update service and adopt HTML provider interface 2019-01-27 22:22:50 -08:00
Pine Wu aad260bc7d Adopt new css provider interface 2019-01-27 19:03:09 -08:00
Matt Bierner 4fe1cdc4df
Merge pull request #66958 from flurmbo/detect-md-image-link
Detect md image link
2019-01-25 17:46:47 -08:00
Phil Marshall 4c2d33559f lazy quantifiers for linkPattern regex 2019-01-25 19:07:45 -06:00
Phil Marshall ef66e5fab1 tweaked linkPattern regex to pass new tests 2019-01-25 18:55:42 -06:00
Phil Marshall a7c88d79a2 updated test for switched order and new tests for image link 2019-01-25 18:46:28 -06:00
Phil Marshall 9070abedaf image link should be pushed to results before other link 2019-01-25 18:45:06 -06:00
Matt Bierner 770beca118 Update js/ts grammars 2019-01-25 15:36:17 -08:00
Matt Bierner ff58f5083f Pull in updated coffeescript grammar
Fixes #67138
2019-01-25 15:36:17 -08:00
Matt Bierner 7f1745027b Re-use options from markdown engine instead of creating new options object
Fixes https://github.com/mjbvz/vscode-markdown-mermaid/issues/26
2019-01-25 11:48:25 -08:00
Matt Bierner b36fddfc1f Experimentally marking a few more quick fixes as preferred 2019-01-25 11:48:25 -08:00
Phil Marshall 5fdc5c2675 factor documentlink extraction into separate function 2019-01-24 17:25:09 -06:00
Matt Bierner 0927975565 Mark more quick fixes as preferred
#62110
https://github.com/Microsoft/TypeScript/issues/29450
2019-01-24 12:00:40 -08:00
Matt Bierner 4a39da971e Extend disposable in more places 2019-01-24 12:00:40 -08:00
Matt Bierner e6f93f3074 Extract isPreferredFix 2019-01-24 12:00:40 -08:00
Dipen Ved b80da8bb5a Show the folder path a file is in, in title of the window (#66746)
* Add active folder feature

* use urilabel instead

* use resource instead of path

* show empty instead for activeFolderShort
2019-01-24 18:37:57 +01:00
Pine Wu f053101c41 CSS semantic selection. Fix #65925 2019-01-23 16:10:56 -08:00
Pine Wu 0c579d7ac8 Run safe for html selectionRange 2019-01-23 15:10:12 -08:00
Pine fc0002cb66
Merge pull request #67014 from Microsoft/octref/html-selection
Html semantic selection. Part of #65925
2019-01-23 12:16:09 -08:00
Pine Wu c47d3d4d46 Update service 2019-01-23 12:15:20 -08:00
Pine Wu d3c14cf0af Move logic to service 2019-01-23 12:11:29 -08:00
Matt Bierner f4cd44f635
Merge pull request #66997 from aeyerstaylor/more-lgtm-fixes
Fix another LGTM.com warning
2019-01-23 11:51:10 -08:00
alexet 16d3d13c5b Remove pointless conjucntion in documentTracker 2019-01-23 15:46:23 +00:00
Martin Aeschlimann c798b53596 revert unintended change 2019-01-23 13:57:58 +01:00
Martin Aeschlimann 6ded24bc60 make color contribution point dynamic 2019-01-23 12:41:40 +01:00
Phil Marshall b1de159292 added test for markdown image link underline 2019-01-22 18:46:55 -06:00
Phil Marshall d372fa0697 md extension should underline images used as link description 2019-01-22 18:46:46 -06:00
Matt Bierner 7b095ea781 Pick up TS 3.3 rc
#66175
2019-01-22 15:23:29 -08:00
Matt Bierner 508f43166b Rename source.autoFix to source.fixAll
Part of #62110

`autoFix` is a confusing term since we have a `auto fix` command now. Using `fix all` as this term is used by many linters for this type of operation
2019-01-22 14:34:43 -08:00
Matt Bierner 73dfd92e65 Fix spelling 2019-01-22 14:34:43 -08:00
Matt Bierner c800831ffc Update js/ts grammar 2019-01-22 14:34:43 -08:00
Pine Wu d1690ad706 Improve granularity 2019-01-22 11:25:41 -08:00
Pine Wu 82aab5a16e HTML selections 2019-01-21 22:15:39 -08:00
Matt Bierner f929531dfb Add CodeActionKind.intersects
Fixes #66881
2019-01-21 18:04:01 -08:00
Matt Bierner c994fc20fa Apply auto fix on save actions sequentially and make sure we request fixes of the specific type we are interested in 2019-01-21 17:16:06 -08:00
Matt Bierner ee65a242a9 Gate auto fix for TS to use an undocumented experimental TS setting
We likely do not want to enable autofixes until we have proper TS support: https://github.com/Microsoft/TypeScript/issues/29452
2019-01-21 17:16:06 -08:00
Matt Bierner 4e6bd4aedd Prototype autofix source code action
Part of #62110

* Adds a new `CodeActionKind`: `source.autoFix`.
* Implements a simple auto fix provider for typescript. This provider can auto fix `implement interface` and `spelling` errors (provided there is only a single valid fix listed)

The provider is likely not something we actually want to check it (especially in its current state), we should ask TS for proper autoFix support
2019-01-21 17:16:06 -08:00
Matt Bierner 4f8d546aa7 De-duplicate "fix all" quick fixes across requests for multiple diagnostics in selection range
For https://github.com/Microsoft/typescript-tslint-plugin/issues/49
2019-01-21 17:15:49 -08:00
Romain Marcadier-Muller ea59a710ca
Fix the "tsc watch" task when references are used
Moves the `--watch` option at the end of the `tsc` invocation, as `--build`
is required to be the first option on the call.

Fixes #66875
2019-01-21 17:14:11 -08:00
Matt Bierner 59ce7f3b28 Fix markdown preview code highlighting
Fixes #66772
2019-01-21 14:09:30 -08:00
Matt Bierner bcc2281e45 Rename CodeAction.canAutoApply -> CodeAction.preferred
Part of #62110

Use the more generic name as suggested in https://github.com/Dart-Code/Dart-Code/issues/1393. This makes the intent of the field more clear and also allows us to extend the concept of preferred code actions to refactorings and other classes of code actions

Experimentally also allows a `preferred` value for `apply` when configuring code aciton keyboard shortcuts. This applies the preferred code action returned from the list of code actions returned
2019-01-21 14:09:30 -08:00
Pine Wu 02b7e03b72 Update service 2019-01-18 11:16:20 -08:00
Pine Wu 9a3ef8c4b2 Load html data using new API per Microsoft/vscode-html-languageservice#45 2019-01-18 11:09:34 -08:00
Benjamin Pasero af010d9cf7
Merge branch 'master' into regex-fixes 2019-01-18 12:37:18 +01:00
Pine Wu e0a3f26e07 Emmet dependency for #66013 2019-01-17 13:18:22 -08:00
Martin Aeschlimann 54adadd72c fix lgtm warnings 2019-01-17 20:53:18 +01:00
Ubuntu 35eae99ec3 Fix more lgtm.com issues 2019-01-17 18:06:23 +00:00
Pine Wu 926cfe1c4a Update css language service for #66519 and #66637 2019-01-16 18:36:11 -08:00
Matt Bierner 1904cd8d84 Prototype auto fixable quick fixes
Part of #62110

- Adds a new field `canAutoApply` to code actions. This field indicates that a code action can be applied without additional user input. For quick fixes, this should be set if the fix properly addresses the error

- Enable auto fixes for TS spelling errors

- Added a `editor.action.autoFix` command to triggers auto fixes at the current cursor position
2019-01-16 17:56:22 -08:00
Pine Wu ba0d1454e7 Update emmet-helper for #65455 2019-01-16 15:40:30 -08:00
Pine Wu 5ac02a0910 Update emmet-helper for #63384 and #62855 2019-01-16 11:13:25 -08:00
alexet 0798d13f10 Remove duplicate character from regex class 2019-01-16 17:56:17 +00:00
alexet 651f624f06 Remove spurious pipes from regexes 2019-01-16 17:40:47 +00:00
João Moreno 65fcf3180b
Merge pull request #66416 from Microsoft/rebornix/git-blame
add git blame api
2019-01-16 09:17:44 +01:00
rebornix f27183be67 add error code for git blame 2019-01-15 11:56:48 -08:00
Matt Bierner 2ab82c12ed Make sure we opt in to new TS user preferences for enabling rename features
Fixes #66176
2019-01-11 15:42:03 -08:00
Matt Bierner d3d16d2b34 Don't return symbolic columns for webview panels
Fixes #56097

When a symbolic column is used while creating a webview panel, instead set the `viewColum` as `undefined` and then resolve it once we know the real (non-symbolic) column
2019-01-11 15:32:15 -08:00
Matt Bierner adb4b04bfd Fix type error 2019-01-11 14:40:17 -08:00
Matt Bierner beef295f9a Normalize the TS server path in logged TS server errors 2019-01-11 14:23:29 -08:00
Matt Bierner e730375b7a Don't make semantic requests against the TS server when the languageService has been disabled 2019-01-11 14:23:29 -08:00
Matt Bierner 6682006c8b Use more explicit state for TS server states
Try to prevent the tracked server state from getting into weird invalid states and make the state more explicit
2019-01-11 14:23:29 -08:00
rebornix e5a596be29 add git blame api 2019-01-11 13:10:54 -08:00
Pine Wu 2b0cee0eba contributes.css.customData for #66414 2019-01-11 12:21:25 -08:00
Pine 3e8028e5d8
Merge pull request #66228 from Microsoft/octref/customCSSData
css.experimental.customData
2019-01-11 11:57:26 -08:00
Pine Wu 67973726b6 Upgrade css service version 2019-01-11 11:20:47 -08:00
Pine c42df918e5
Merge pull request #66306 from Microsoft/octref/html-workspace-folders
Handle workspace folder reading for custom HTML data
2019-01-11 11:18:02 -08:00
Matt Bierner 2f5d88899d Make NoContentResponse an constant instead of a class 2019-01-11 11:04:58 -08:00
Matt Bierner 60f232b246 Include TypeScript version in errors logged to dev tools
Fixes #66368
2019-01-11 11:04:58 -08:00
Matt Bierner 3da39a64dd Improve logging of TypeScript server errors
Fixes #66366
Fixes #66367

Avoid printing the error twice in the trace

Make sure we show helpful error information in the VS Code dev tools when a TS server error occurrs
2019-01-11 11:04:57 -08:00
Matt Bierner d2a8ca946f Use isCancellationRequested 2019-01-11 11:04:57 -08:00
Matt Bierner 66511a0bdb Interup geterror during rename
Rename is a user triggered operation and should interupt long run error computations
2019-01-11 11:04:57 -08:00
SteVen Batten ccdd2997a6
update AI module (#66370)
fixes #64849
2019-01-10 17:43:25 -08:00
Martin Aeschlimann ed48143239
Merge pull request #66072 from mathiasvr/patch-2
HTML Snippet: Consistent void tags
2019-01-10 15:58:17 +01:00
Matt Bierner 344f4fa361 Make sure we update the markdown document on config changes 2019-01-09 19:32:53 -08:00
Matt Bierner 758280cc47 Extract TokenCache 2019-01-09 19:27:41 -08:00
Matt Bierner 5496ba7617 Prevent possible race while initilizing markdown engine 2019-01-09 19:18:23 -08:00
Matt Bierner 1bbc0e3b4d Deprecate the previewFrontMatter setting
Switch to always hiding the frontmatter and then allowing markdown-it plugins to render it properly if they wish. `previewFrontMatter: "show"` is also not very useful since it usually results in a jumble of text at the top of the file

This is required with the new performance work to avoid re-tokenizing the document  multiple times during rendering
2019-01-09 19:05:55 -08:00
Matt Bierner e325cce9bc Fixing markdown unit tests 2019-01-09 18:15:34 -08:00
Matt Bierner 9140285092
Merge pull request #65953 from skprabhanjan/fix-65575
Fix-65575 MarkdownIt plugins (or Rules) called multiple times for one input
2019-01-09 17:41:47 -08:00
Matt Bierner 3580109d05 Pick up new TS version 2019-01-09 17:37:41 -08:00
Pine Wu 177b805150 Handle workspace folder reading 2019-01-09 16:16:04 -08:00
Pine Wu 9efac59949 Improve custom data reading 2019-01-09 15:55:55 -08:00
Matt Bierner 7e86998ef9 Fixes #66247
Allow markdown comments to match blocks that contain extra docs on first line
2019-01-09 12:58:20 -08:00
Pine Wu 70696746b0 Address feedback 2019-01-09 12:43:51 -08:00
Matt Bierner 299997228d Don't include object key types in completeFunctionCalls
Fixes #66297
2019-01-09 11:52:02 -08:00
Matt Bierner e44801f2b3 Fix inserting of duplicate calls when using typescript.suggest.completeFunctionCalls
Fixes #18131
2019-01-08 16:25:07 -08:00
Pine Wu b0e04e04c5 Remove outdated ionic/angular support in HTML 2019-01-08 16:20:38 -08:00
Matt Bierner f49c40947e Add test for completeFunctionCalls 2019-01-08 16:07:40 -08:00
Matt Bierner 6eeb11ecf2 Extract updateConfig 2019-01-08 15:53:11 -08:00
Pine Wu 9d8216aecd Remove extra settings.json 2019-01-08 12:43:12 -08:00
Pine Wu f7894236ee css.experimental.customData 2019-01-08 11:42:52 -08:00
Martin Aeschlimann 20906c33c4 [json] IntelliSense doesn't work for scoped packages in package.json. Fixes #62377 2019-01-08 17:42:52 +01:00
pkoushik a6b761b033 fix-65575 Updated tokenize method - Returns cached token if exists or newly created token and cache it 2019-01-08 15:22:29 +05:30
Matt Bierner d9e2246c9b Temporarily revert using word range for TS completions due to #66187 2019-01-07 17:49:58 -08:00
Ilya Biryukov 04c3dde6e4 Address PR feedback on Git provide APIs 2019-01-07 11:38:33 -08:00
Alex Dima 7a835ad264 Fixes #63407 2019-01-07 15:28:23 +01:00
Joao Moreno ff157f90a0 add unshallow as an option for git pull 2019-01-07 11:22:26 +01:00
Joao Moreno bba335ab63 Merge commit 'refs/pull/65786/head' of github.com:Microsoft/vscode into pr/65786 2019-01-07 11:15:18 +01:00
Joao Moreno c4a1b80e48 fix git settings scope 2019-01-07 09:58:34 +01:00
Matt Bierner 9d2787e42e Accepting a member completion should result in valid code
Fixes #58597

Default to replacing the word range in js/ts. This is a change in core behavior so  we'll need to see what the feedback is like for it.
2019-01-04 18:09:48 -08:00
Matt Bierner 7a4944fb64 Add pinning test for paren accept character on bracket completion 2019-01-04 18:08:17 -08:00
Matt Bierner 6494c1c513 Adding pinning test for function treating paren as commit character 2019-01-04 18:01:01 -08:00
Matt Bierner 24cb22200e Move wait to setup block 2019-01-04 17:33:08 -08:00
Matt Bierner 6366adf510 Add pinning test for period treated as bracket trigger character 2019-01-04 17:30:26 -08:00
Mathias Rasmussen fd638edefd
HTML Snippet: Consistent void tags 2019-01-05 02:18:35 +01:00
Matt Bierner b166d5896f Add basic pinning test for commit character var completion 2019-01-04 16:56:42 -08:00
Matt Bierner 483adec7a5 Add simple pinning test for basic completion 2019-01-04 16:49:40 -08:00
Matt Bierner df2d0c0fee Add pinning test for #53962 2019-01-04 16:29:19 -08:00
Matt Bierner 873fc8fc38 Enable tslint number-literal-format 2019-01-04 15:45:28 -08:00
Matt Bierner a131278f4a Enabling no-redundant-jsdoc for tslint 2019-01-04 15:34:50 -08:00
Matt Bierner c109d319fe Second pass converting for index based looping to for-of loops
More manual conversion of index based for loops to for-of loops
2019-01-04 12:03:23 -08:00
Martin Aeschlimann 6aa8f50d63 [xml] Don't report *.config files as XML. Fixes #63462 2019-01-04 17:26:43 +01:00
Martin Aeschlimann d72bc587c3 [themes] fix commit hash for themes copied from Colorsublime/Colorsublime-Themes 2019-01-04 17:08:20 +01:00
Martin Aeschlimann 6be20f4f76 [seti] script to update commitHash in cgmanifest 2019-01-04 17:08:20 +01:00
Joao Moreno 2f82209adf 💄 cleanup git input validation rules
#60407
2019-01-04 17:03:11 +01:00
Joao Moreno e6878ce54f Merge commit 'refs/pull/60407/head' of github.com:Microsoft/vscode into pr/60407 2019-01-04 16:51:22 +01:00
Joao Moreno a8aa85192a Merge branch 'master', commit 'refs/pull/60387/head' of github.com:Microsoft/vscode into pr/60387 2019-01-04 16:40:21 +01:00
Joao Moreno 3d928bbb27 💄 auto fetch period 2019-01-04 16:38:12 +01:00
Joao Moreno 32d22dbace Merge commit 'refs/pull/59988/head' of github.com:Microsoft/vscode into pr/59988 2019-01-04 16:30:25 +01:00
Joao Moreno a1279d336b Merge remote-tracking branch 'origin/master' 2019-01-04 16:24:52 +01:00
Joao Moreno 507a3508a5 💄 2019-01-04 16:24:14 +01:00
Alex Ross 272c6827f1 Prefer global gulp install over local
Prevents console.log in gulp files from being interpreted as tasks. Fixes #11699
2019-01-04 16:22:22 +01:00
Joao Moreno 579b962ae1 Merge commit 'refs/pull/59974/head' of github.com:Microsoft/vscode into pr/59974 2019-01-04 16:22:03 +01:00
Joao Moreno dcb3c339c8 preserve user input when creating branch from checkout
fixes #60895
2019-01-04 16:08:12 +01:00
pkoushik eabf436c07 fix-65575 tokenize method cache update bug fixed 2019-01-04 20:13:27 +05:30
pkoushik 661d191638 fix-65575 tokenize method added 2019-01-04 20:07:21 +05:30
Joao Moreno 133e999097 💄 2019-01-04 15:16:45 +01:00
Joao Moreno cf107f3c3d Merge commit 'refs/pull/59078/head' of github.com:Microsoft/vscode into pr/59078 2019-01-04 15:02:46 +01:00
Joao Moreno 3a2c97c5d6 refactor autostash behaviour 2019-01-04 14:58:44 +01:00
Joao Moreno 5c8c42e886 remove unnecessary operation run 2019-01-04 14:41:45 +01:00
Joao Moreno 9b88d30734 Merge commit 'refs/pull/59849/head' of github.com:Microsoft/vscode into pr/59849 2019-01-04 14:34:28 +01:00
Benjamin Pasero 83232ef060 fonts - remove HelveticaNeue-Light from list 2019-01-04 10:11:04 +01:00
Martin Aeschlimann 7c908a936d add .vscodeignore syntax highlighting. FIxes #64960 2019-01-04 09:53:47 +01:00
Pine Wu bae6c84d46 Update service for #66002 2019-01-03 21:14:50 -08:00
Matt Bierner b4964bcf35 Replace some common index based for loops with for-of loops
Replaces many loops of the form:

```js
for (let i = 0; i < elements.length; ++i) {
    const i = elements[i];
   ...
}
```

with:

```js
for (const element of elements) {
    ...
}
```

Mix of a horrible regex based find/replace and manual touch ups
2019-01-03 19:11:18 -08:00
Matt Bierner 5cc00861fc Enable no-var-keyword tslint rule 2019-01-03 18:02:48 -08:00
Matt Bierner 3f8579f96a Avoid some common type casts
Casts can hide some type errors
2019-01-03 17:44:14 -08:00
Rob Lourens fb0d022d8a Fix PHP colorization test from #65649 2019-01-03 16:46:05 -08:00
Rob Lourens 509d693aa7 Fix #65649 - fix injection patching in update-grammar.js 2019-01-03 16:24:11 -08:00
Rob Lourens ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Alex Ross 154ba178c2 Update make grammar 2019-01-03 16:08:09 +01:00
Joao Moreno fe6e62674c remove 100 change limit 2019-01-03 09:20:20 +01:00
pkoushik 1ef045875d fix-65575 Added CachedToken and implementation to use it 2019-01-03 11:56:11 +05:30
Matt Bierner 5ed55a8606 Don't treat dom properties as special for syntax highlighting
See https://github.com/Microsoft/TypeScript-TmLanguage/issues/691

Assuming that properties named `label` or `name` are dom properties is incorrect and causes a lot of false positives. This results in weirdly inconsistent colorization
2019-01-02 17:33:50 -08:00
Matt Bierner 5631529791 Update js/ts grammar 2019-01-02 17:22:27 -08:00
Matt Bierner 02ba1e9fb7 Pick up TS 3.3 insiders 2019-01-02 17:04:09 -08:00
Matt Bierner 3e7bb120c7 Use label text indexes to mark active paramter for js/ts
Fixes #65513
2019-01-02 14:53:21 -08:00
Matt Bierner cba84fba5e Take progress within element into account for markdown scroll sync
Fixes #65504
2019-01-02 14:36:16 -08:00
Matt Bierner 44b5a77632 Use TS's document highlight API instead of references api to get highlights
Fixes #65921
Fixes #65051
2019-01-02 11:56:39 -08:00
Matt Bierner 7086fb76ec Take document as parameter instead document components 2019-01-02 11:56:39 -08:00
Rob Lourens d34a1244b2 Add periods to setting descriptions 2018-12-31 15:52:14 -08:00
Peng Lyu 94a04621dd Fix microsoft/vscode-pull-request-github#612. Allow fetching with limited depths 2018-12-28 12:02:28 -08:00
Matt Bierner 494e5e8509 Fix bug for completing function name parameters if function name contained special snippet syntax 2018-12-23 22:22:38 -06:00
davidwu226 2e877e280a Fix invalid JSON. (#65447) 2018-12-23 20:19:29 -08:00
Pine Wu b0cf047d8e Fix #62325 2018-12-21 11:36:19 -08:00
Alex Ross 1386fba3be Don't show the output panel in jake and grunt extensions
Fixes #64900
2018-12-20 14:54:55 +01:00
Joao Moreno 6de43eec8d Merge commit 'refs/pull/59163/head' of github.com:Microsoft/vscode into pr/59163 2018-12-20 12:51:58 +01:00
Joao Moreno 6d31c16989 💄 2018-12-20 12:37:04 +01:00
Joao Moreno cdb8a86fd0 git ignore: save after apply edit 2018-12-20 11:33:01 +01:00
Joao Moreno 349b0d454e fix git.openDiffOnClick scope 2018-12-20 10:17:26 +01:00
Matt Bierner 23508cf1a0 Update markdown dependencies 2018-12-19 13:40:54 -08:00
Matt Bierner aa301e3435 Update js/ts grammar 2018-12-19 13:40:54 -08:00
Prabhanjan S Koushik 55ebf93842 fix-65287 Added webviewManager.refresh() (#65396) 2018-12-19 11:05:57 -08:00
Pine Wu e489f935a2 Ensure no spaces when working on html LS 2018-12-19 09:14:49 -08:00
João Moreno 034ff33eb4
Merge pull request #64305 from Microsoft/misolori/open-change-icons
Update "Open changes" icons to better reflect diff changes
2018-12-19 08:43:09 +01:00
Matt Bierner 04cb6a4c77 Prevent example jsdoc highlighting block from potentially leaking
Fixes #65181
2018-12-17 16:22:52 -08:00
Matt Bierner 21d29aeb45 Update js/ts grammar 2018-12-17 15:50:25 -08:00
Matt Bierner 8ac2c23fdc Don't force convert fixable diagnostics to numbers
Fixes #64848 for the VS Code side
2018-12-14 14:57:37 -08:00
Matt Bierner 45c34a2c51 Remove extra Array.from 2018-12-14 14:57:37 -08:00
Matt Bierner 7632e0133e Use clear 2018-12-14 14:57:37 -08:00
Matt Bierner 83ce38f6de Make fixPathPrefixes a bit more resiliant 2018-12-14 14:57:36 -08:00
Pine Wu 9b5795b0fe Fix #64993 2018-12-14 14:19:05 -08:00
Prabhanjan S Koushik 0f5b2d14e7 Fix #64253 - Support ~/ paths for typescript.tsdk (#64892)
* fix-64253 Added fixPathPrefixes

* fix-64253 Removed  and handled ~/path
2018-12-14 14:18:24 -08:00
Matt Bierner a87dc2b62f Interup getError for refactor and updatePaths on rename
These are user triggered operations that should interupt the background getError requests
2018-12-14 13:48:53 -08:00
Matt Bierner d02be78457 Show progress during update JS/TS imports
Fixes #64986
2018-12-14 13:29:57 -08:00
Matt Bierner 90f36693c9 Extend disposable 2018-12-14 12:54:07 -08:00
Matt Bierner bb8fc43f72 Remove un-needed cast 2018-12-14 12:52:48 -08:00
Alex Ross edd216eb0c Gulp task detection shouldn't open output
Fixes #64900
2018-12-14 16:03:52 +01:00
Matt Bierner 6b89247875 Allow extension contributed TS plugins to be loaded for workspace versions of TS
Fixes #65031

Adds a `enableForWorkspaceTypeScriptVersions` flag (default false) to the plugins contributions that  allows a contributed plugin to be loaded for workspace versions of ts
2018-12-13 14:29:32 -08:00
Matt Bierner 5dc52f0617 Extract getCodeLensLabel 2018-12-12 18:07:37 -08:00
Matt Bierner c36794253c Update css features engines version
The current version generates a warning in our build
2018-12-12 18:07:37 -08:00
Matt Bierner 54386cc1f4 Fix word pattern
Too much escaping :0
2018-12-12 15:30:49 -08:00
Matt Bierner 66e07e14a4 Fix regexp 2018-12-12 15:18:46 -08:00