development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 13:29:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
49999 commits 1048 branches 294 tags 1.3 GiB
Commit graph

49999 commits

This branch
This branch
All branches
Author SHA1 Message Date
Miguel Solorio 673295580a Fix #75192 2019-06-10 09:14:56 -07:00
isidor 77de8faba5 ISignService 2019-06-10 15:31:55 +02:00
Isidor Nikolic f3ea637528
Merge pull request #75043 from jeanp413/fix-70331 
Call revealLastElement within runAtThisOrScheduleAtNextAnimationFrame in repl
 2019-06-10 14:30:59 +02:00
jeanp413 002ac09795 Improve the provisional height computation of repl elements. Fixes #70331 2019-06-10 06:42:25 -05:00
Samuel Bronson 1e0753d73a
Fix typo: timemout -> timeout 2019-06-09 18:14:48 -04:00
SteVen Batten 81d7885dc2 fix main proc launch config for windows 2019-06-07 21:51:50 -07:00
Miguel Solorio c802a84ccd Update open change icon, include it in SCM actions 2019-06-07 18:51:05 -07:00
Miguel Solorio 77b250d4d6 Fix #74978, Update initialize icon 2019-06-07 18:50:47 -07:00
Miguel Solorio a2ce8bed5a Target only SCM icons in the viewlet toolbar 2019-06-07 18:46:48 -07:00
Matt Bierner 714691abd6 Fixing another DisposableStore issue in referencesWidget 
Should use clear to reset, not dispose. `readonly` can help catch errors like this
 2019-06-07 18:32:06 -07:00
Matt Bierner d27fd54828 Have more inferface / classes that are disposable extend IDisposable 
This makes it easier to track which objects are disposable, since we can use findAllReferences on them
 2019-06-07 18:26:19 -07:00
Matt Bierner 1e9fae2fba Partial fix for ExtHost CodeLenses registering commands after they have already been disposed of 
For #75105

This change ensures that we do not try registering a command while resolving a code lens. However it does not fix the issue where we can end up trying to invoke a command that has already been disposed of
 2019-06-07 18:26:19 -07:00
Matt Bierner f16e33cf13 ReferenceWidget should call clear to reset itself when the model changes 2019-06-07 18:26:19 -07:00
Matt Bierner 79aace1b39 Better funciton name 2019-06-07 18:26:19 -07:00
Matt Bierner a074400eef Log stack when registering disposable on already disposed object 
This should help track down issues
 2019-06-07 18:26:19 -07:00
Matt Bierner 50a85fa123 Working on re-structuring code action logic: 
- The oracle should only handle triggering
- The model should manage code action requests
- The controller should handle presenting data from the model
 2019-06-07 18:26:19 -07:00
Matt Bierner 729943d8ff 💄 2019-06-07 18:26:19 -07:00
Matt Bierner 9678a18c12 Use delegate instead of event to link QuickFixController to codeActionWidget 2019-06-07 18:26:19 -07:00
Matt Bierner 3a62fd8df9 Rename 2019-06-07 18:26:19 -07:00
SteVen Batten cd424b65a1 nix need for menubarservice in websimpleservices 2019-06-08 00:21:38 +00:00
Miguel Solorio 1d067cac75 Fix #74977, make debug icons a little thicker 2019-06-07 14:20:00 -07:00
Miguel Solorio 916f6bf9e8 Add icon for going to settings UI and keyboard shortcuts 2019-06-07 13:34:53 -07:00
Miguel Solorio c45b2fa5de Make preview icon the same height as the split icon 2019-06-07 13:34:00 -07:00
Miguel Solorio b3ed222a5f Shrink refresh icons 2019-06-07 13:04:53 -07:00
Daniel Imms 4a502054ef Move refreshActiveTab to common 2019-06-07 12:58:57 -07:00
Miguel Solorio b27befb519 Fix #75067, fill lightbulb icons 2019-06-07 12:54:05 -07:00
Christof Marti d3e0bc3263
Temporarily turn off. 2019-06-07 21:17:36 +02:00
Matt Bierner 6bb1d00526 Fix monaco error 2019-06-07 11:48:03 -07:00
Matt Bierner dc2245f164 Use readonlyArray for diagnostics 2019-06-07 11:25:16 -07:00
Matt Bierner dc8e21138f Extend disposable 2019-06-07 11:23:14 -07:00
Matt Bierner 69a7b7ef24 Extract areLanguageDiagnosticSettingsEqual 2019-06-07 11:22:06 -07:00
Matt Bierner a87c73527e Remove extra work in DiagnosticSettings ctor 
The langauges map is written so that it is lazy. We do not need to pre-populate it
 2019-06-07 11:21:22 -07:00
Matt Bierner 5b01e094c2 Use includes instead of indexOf 2019-06-07 11:12:54 -07:00
Matt Bierner 62beb9030b Export CodeActionSet interface instead of implementation 2019-06-07 10:32:35 -07:00
Matt Bierner f8c8531e78
Merge pull request #75048 from mjbvz/add-lifecyle-for-code-actions 
Replace heapservice with lifecycle for code actions
 2019-06-07 10:28:05 -07:00
Matt Bierner 9f6de388ea Use ReadonlyArray for a few more lists of IActions 
Also changes processService to not modify its input actions, which seems like unexpected behavior
 2019-06-07 10:26:00 -07:00
Matt Bierner e78f05a7dc Use ReadonlyArrays for IActions used in notifications 
These arrays of actions should not be modified by the caller. Mark them as readonly to prevent this. This also let me eliminate a number of not null supressions that had been introduced during the strict null migration

One small code change was required in `showError`. However I believe this was actually a bug since modifying the input array was likely not what would be expected (in practice, we usually just passed in array literals so I don't think we hit this one)
 2019-06-07 10:26:00 -07:00
Matt Bierner f79e1ea8b7 Use readonlyArray for composite actions 
These lists of actions should not be modified by callers
 2019-06-07 10:26:00 -07:00
Matt Bierner 219fadc70a Use readonly array to track actions in a few more palces in menus 
The actions being passed around are generally not expected to be modified. Use ReadonlyArray to prevent this
 2019-06-07 10:26:00 -07:00
Sandeep Somavarapu d0c593ec45 #75079 remove process dependency 2019-06-07 19:22:24 +02:00
Sandeep Somavarapu 85e2b3b6a8 #75079 Move preferences to browser 2019-06-07 19:22:23 +02:00
Miguel Solorio a85b5f0f95 Fix compare icon render bug 2019-06-07 10:12:19 -07:00
Miguel Solorio bc08915b86 Fix #75056, use up and down arrows for next/prev 2019-06-07 10:11:59 -07:00
Miguel Solorio 7a5f15aec1 Fix #75066, align breacrumbs in quick outline view 2019-06-07 10:07:23 -07:00
Miguel Solorio a0b03f1941 Fix #75055 2019-06-07 09:58:01 -07:00
Miguel Solorio 48674801d3 Fix #75065, hide chevrons in breadcrumbs when tabs are hidden 2019-06-07 09:56:34 -07:00
Sandeep Somavarapu 45bf95acad update distro 2019-06-07 18:49:12 +02:00
Sandeep Somavarapu 70d9efeac2 #75079 Use URI for settings 2019-06-07 18:44:32 +02:00
Miguel Solorio 50e1c61cbb Actually fix the tree icon issue 2019-06-07 09:43:26 -07:00
Sandeep Somavarapu 3e1c60cd73 #75079 Populate workbench environment service in main 2019-06-07 18:29:47 +02:00