Commit graph

80610 commits

Author SHA1 Message Date
Daniel Imms 128c666879
Don't override keybinding for split 2021-04-21 07:10:47 -07:00
Daniel Imms 827d9284bf
Fix change icon/rename ctx menu
Fixes #121827
2021-04-21 07:10:14 -07:00
Daniel Imms 84e63b1d13
Create new command IDs for kill/split instance
Fixes #121823
2021-04-21 07:01:30 -07:00
Daniel Imms f973736737
Revert "fix #109765."
This reverts commit 0ef0d2d65a.

Fixes #115396
2021-04-21 06:55:50 -07:00
João Moreno fd88b56ab9
improve messages, web: showSaveDialog 2021-04-21 15:44:40 +02:00
João Moreno f80d55121f
web: pickFileToSave 2021-04-21 15:44:39 +02:00
João Moreno 091b1f5a6e
web: showOpenDialog 2021-04-21 15:44:39 +02:00
Daniel Imms 415a43f04d
Remove has text log 2021-04-21 06:26:20 -07:00
Daniel Imms 37789e4695
Remove logs 2021-04-21 06:10:51 -07:00
Daniel Imms 28fbb99921
Merge pull request #121774 from microsoft/tyriar/121483
Allow ThemeIcons to be used as decorations
2021-04-21 06:10:16 -07:00
Benjamin Pasero 13302253b5
editors - respect override option in openEditors 2021-04-21 15:04:39 +02:00
João Moreno 034157dea8
gh auth: back to prod auth 2021-04-21 15:00:24 +02:00
Daniel Imms e6a7081333
Action feedback 2021-04-21 05:55:39 -07:00
Benjamin Pasero 5b7a28c43f
text file tracker - open editors without going through override 2021-04-21 14:52:00 +02:00
Daniel Imms a165ee92c5
Remove old new terminal panel action when showTabs is false
Fixes #121815
2021-04-21 05:39:53 -07:00
Benjamin Pasero 1efbb32036
editor service - cleanup isOpened() 2021-04-21 14:33:42 +02:00
Daniel Imms 14720cbc52 Remove configure term, replace with change icon+rename
Fixes #121736
2021-04-21 05:25:00 -07:00
Daniel Imms 010267d737 Handle cwd inside _convertProfileToShellLaunchConfig 2021-04-21 05:08:06 -07:00
Benjamin Pasero e09f0ecfcf
editors - require typeId for some methods that are otherwise unspecific 2021-04-21 12:38:53 +02:00
Sandeep Somavarapu 832a699c00
move keybinding label computation to activity action item 2021-04-21 11:31:19 +02:00
Benjamin Pasero 89684626f2
editor service - 💄 API 2021-04-21 11:24:20 +02:00
João Moreno e350c258db
fix build 2021-04-21 10:54:34 +02:00
João Moreno d60dbbf646
gh auth: fetch json 2021-04-21 10:48:01 +02:00
João Moreno 186897d756
distro 2021-04-21 10:48:01 +02:00
Ladislau Szomoru 9e8377d8cd
TestWorkspaceTrustRequestService 2021-04-21 10:18:52 +02:00
João Moreno 3668a573ad
gh auth: fix staging server selection 2021-04-21 10:06:26 +02:00
isidor 479a224741
disable compare action when no active file, no need for notification
#119463
2021-04-21 09:56:48 +02:00
isidor 853f917190
notification updates: #119463 2021-04-21 09:41:03 +02:00
João Moreno 141ecfb798
mac specific actions should not respect web 2021-04-21 09:36:20 +02:00
João Moreno 820e70a460
gh auth: don't reach out to product.json 2021-04-21 09:31:06 +02:00
Matt Bierner 3236b8dd70
Revert "Enable the notebook renderer on web"
This reverts commit 7d9dcaca45.
2021-04-21 00:21:50 -07:00
Matt Bierner 9bacf617b2
Use clearer variable names 2021-04-21 00:21:48 -07:00
Johannes Rieken 625dcc3412
add enum-set for alternative commands and check the command type is a symbol navigation command 2021-04-21 08:43:14 +02:00
Johannes Rieken 07013ef4a3
update ref viewlet 2021-04-21 08:26:12 +02:00
Logan Ramos fc19174983
Move quick pick into editor override service (#121666)
* Move quick pick into editor override service

* Fix unspecified overrides

* Add the conflicting default logic

* grammar

* More verbose comment

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>

* Ensure sidebyside

* Add clarification comment

* Fix tests

* Update notification wording

* Cleanup interface

* Fix failing notebook test and ugly casting

* Cleanup find editors

* Add group.findEditors test

* Make detail optional as suggested by @roblourens

* Rename active -> describes

* Add override service to openEditors

* Cleaner open editors code

* just some 💄

* fix openEditors to resolve overrides properly

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2021-04-21 08:25:47 +02:00
Benjamin Pasero 7095f4706c
unit tests (electron) - avoid sending circular structures over 2021-04-21 08:13:08 +02:00
Miguel Solorio 23a2409675
Update debug-auto-attach ext icon (refs #81760) 2021-04-20 21:58:33 -07:00
meganrogge e815d28785
fix #121655 2021-04-20 20:38:37 -07:00
Rob Lourens 27cf6a3807 Implement workspace trust for php-language-features 2021-04-20 19:52:34 -07:00
Rob Lourens 643756788f Allow running builtin php validation with a relative path configured to the php binary.
This was previously allowed, but the fix to use 'which' was too strict
2021-04-20 19:52:33 -07:00
Megan Rogge 609e717d75
Merge pull request #121704 from microsoft/merogge/menus
Context menus and move tabs buttons to the panel
2021-04-20 19:47:58 -07:00
meganrogge 21ae0ca0d4
fix #121736 2021-04-20 19:19:37 -07:00
Rob Lourens 91ee63fd0a Fix missing run buttons
Update kernel context when editor model changes
2021-04-20 18:00:46 -07:00
meganrogge 7947c4d3f8
tweak split view width work 2021-04-20 17:30:31 -07:00
meganrogge 1eb2a93ef3
fix #121631 2021-04-20 17:26:12 -07:00
Connor Peet 1d951484ed
testing: bump distro and make document polyfill work again 2021-04-20 17:03:37 -07:00
Rachel Macfarlane c67ac5d083
Remove path from github-authentication 2021-04-20 16:49:23 -07:00
Matt Bierner 1d54cdf54a
Avoid extra call to reveal if the editor is already active 2021-04-20 16:14:49 -07:00
Matt Bierner 9b8d52ded3
Fix calls to reveal for webviews that are inside of diff editors
Fixes #118764

When you call `.reveal` on a webview panel that is inside of an editor input, we should reveal the diff editor instead of the individual webview
2021-04-20 16:07:07 -07:00
Rachel Macfarlane 24c6f586dd
Add requireTrust to comments.openPanel setting 2021-04-20 15:34:18 -07:00