development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add AccessibilitySignal.terminalCommandSucceeded and success.mp3 (issue #178989) (#204430)

Browse source
This commit is contained in:
Miguel Medina Ballesteros 2024-05-15 20:17:09 +02:00 committed by GitHub
parent e206bcb922
commit f8ee0378c0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/vs/platform/accessibilitySignal/browser/accessibilitySignalService.ts
View file

@ -280,6 +280,7 @@ export class Sound {
public static readonly error = Sound.register({ fileName: 'error.mp3' });
public static readonly warning = Sound.register({ fileName: 'warning.mp3' });
public static readonly success = Sound.register({ fileName: 'success.mp3' });
public static readonly foldedArea = Sound.register({ fileName: 'foldedAreas.mp3' });
public static readonly break = Sound.register({ fileName: 'break.mp3' });
public static readonly quickFixes = Sound.register({ fileName: 'quickFixes.mp3' });
@ -468,6 +469,13 @@ export class AccessibilitySignal {
settingsKey: 'accessibility.signals.terminalCommandFailed',
});
public static readonly terminalCommandSucceeded = AccessibilitySignal.register({
name: localize('accessibilitySignals.terminalCommandSucceeded', 'Terminal Command Succeeded'),
sound: Sound.success,
announcementMessage: localize('accessibility.signals.terminalCommandSucceeded', 'Command Succeeded'),
settingsKey: 'accessibility.signals.terminalCommandSucceeded',
});
public static readonly terminalBell = AccessibilitySignal.register({
name: localize('accessibilitySignals.terminalBell', 'Terminal Bell'),
sound: Sound.terminalBell,

14
src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts
View file

@ -364,6 +364,20 @@ const configuration: IConfigurationNode = {
},
}
},
'accessibility.signals.terminalCommandSucceeded': {
...signalFeatureBase,
'description': localize('accessibility.signals.terminalCommandSucceeded', "Plays a signal - sound (audio cue) and/or announcement (alert) - when a terminal command succeeds (zero exit code) or when a command with such an exit code is navigated to in the accessible view."),
'properties': {
'sound': {
'description': localize('accessibility.signals.terminalCommandSucceeded.sound', "Plays a sound when a terminal command succeeds (zero exit code) or when a command with such an exit code is navigated to in the accessible view."),
...soundFeatureBase
},
'announcement': {
'description': localize('accessibility.signals.terminalCommandSucceeded.announcement', "Announces when a terminal command succeeds (zero exit code) or when a command with such an exit code is navigated to in the accessible view."),
...announcementFeatureBase
},
}
},
'accessibility.signals.terminalQuickFix': {
...signalFeatureBase,
'description': localize('accessibility.signals.terminalQuickFix', "Plays a signal - sound (audio cue) and/or announcement (alert) - when terminal Quick Fixes are available."),

2
src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts
View file

@ -230,6 +230,8 @@ export class DecorationAddon extends Disposable implements ITerminalAddon {
this.registerCommandDecoration(command);
if (command.exitCode) {
this._accessibilitySignalService.playSignal(AccessibilitySignal.terminalCommandFailed);
} else {
this._accessibilitySignalService.playSignal(AccessibilitySignal.terminalCommandSucceeded);
}
}));
// Command invalidated

2
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
View file

@ -193,6 +193,8 @@ export class TerminalAccessibleViewContribution extends Disposable implements IT
}
if (command.exitCode) {
this._accessibilitySignalService.playSignal(AccessibilitySignal.terminalCommandFailed);
} else {
this._accessibilitySignalService.playSignal(AccessibilitySignal.terminalCommandSucceeded);
}
}