development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-11-05 18:29:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Hide warnings for settings groups that have dynamically registered settings

Browse source 
Fix #113747
This commit is contained in:
Rob Lourens 2021-01-12 19:17:49 -08:00
parent d7d5f20047
commit 7f489f589d
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/vs/workbench/contrib/preferences/browser/settingsTree.ts
View file

@ -315,6 +315,12 @@ function _resolveSettingsTree(tocData: ITOCEntry<string>, allSettings: Set<ISett
};
}
const knownDynamicSettingGroups = [
/^settingsSync\..*/,
/^sync\..*/,
/^workbench.fontAliasing$/,
];
function getMatchingSettings(allSettings: Set<ISetting>, pattern: string, logService: ILogService): ISetting[] {
const result: ISetting[] = [];
@ -325,7 +331,7 @@ function getMatchingSettings(allSettings: Set<ISetting>, pattern: string, logSer
}
});
if (!result.length) {
if (!result.length && !knownDynamicSettingGroups.some(r => r.test(pattern))) {
logService.warn(`Settings pattern "${pattern}" doesn't match any settings`);
}