From 7f489f589d85946f90a5e0f9503eaaef762ae2ae Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Tue, 12 Jan 2021 19:17:49 -0800 Subject: [PATCH] Hide warnings for settings groups that have dynamically registered settings Fix #113747 --- .../workbench/contrib/preferences/browser/settingsTree.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts index 087b596822e..5b50e8b1f60 100644 --- a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts +++ b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts @@ -315,6 +315,12 @@ function _resolveSettingsTree(tocData: ITOCEntry, allSettings: Set, pattern: string, logService: ILogService): ISetting[] { const result: ISetting[] = []; @@ -325,7 +331,7 @@ function getMatchingSettings(allSettings: Set, pattern: string, logSer } }); - if (!result.length) { + if (!result.length && !knownDynamicSettingGroups.some(r => r.test(pattern))) { logService.warn(`Settings pattern "${pattern}" doesn't match any settings`); }