Remove TabKind.other

src/vs/workbench/api/browser/mainThreadEditorTabs.ts

@@ -47,7 +47,6 @@ export class MainThreadEditorTabs {
 	 * @returns A tab object
 	 */
 	private _buildTabObject(group: IEditorGroup, editor: EditorInput, editorIndex: number): IEditorTabDto {
-		// Even though the id isn't a diff / sideBySide on the main side we need to let the ext host know what type of editor it is
 		const editorId = editor.editorId;
 		const tabKind = editor instanceof DiffEditorInput ? TabKind.Diff : editor instanceof SideBySideEditorInput ? TabKind.SidebySide : TabKind.Singular;
 		const tab: IEditorTabDto = {

src/vs/workbench/api/common/extHost.protocol.ts

@@ -628,8 +628,7 @@ export interface IEditorTabGroupDto {
 export enum TabKind {
 	Singular = 0,
 	Diff = 1,
-	SidebySide = 2,
-	Other = 3
+	SidebySide = 2
 }
 
 export interface IEditorTabDto {

src/vs/workbench/api/test/browser/extHostEditorTabs.test.ts

@@ -40,7 +40,7 @@ suite('ExtHostEditorTabs', function () {
 			label: 'label1',
 			viewColumn: 0,
 			additionalResourcesAndViewTypes: [],
-			kind: TabKind.Other
+			kind: TabKind.Singular
 		};
 
 		extHostEditorTabs.$acceptEditorTabModel([{

src/vscode-dts/vscode.proposed.tabs.d.ts

@@ -10,8 +10,7 @@ declare module 'vscode' {
 	export enum TabKind {
 		Singular = 0,
 		Diff = 1,
-		SidebySide = 2,
-		Other = 3
+		SidebySide = 2
 	}
 
 	/**