From 6837589569e7d2dc6ad4de991ed2df6e422144ae Mon Sep 17 00:00:00 2001 From: Logan Ramos Date: Mon, 14 Mar 2022 14:55:00 -0400 Subject: [PATCH] Remove TabKind.other --- src/vs/workbench/api/browser/mainThreadEditorTabs.ts | 1 - src/vs/workbench/api/common/extHost.protocol.ts | 3 +-- src/vs/workbench/api/test/browser/extHostEditorTabs.test.ts | 2 +- src/vscode-dts/vscode.proposed.tabs.d.ts | 3 +-- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/api/browser/mainThreadEditorTabs.ts b/src/vs/workbench/api/browser/mainThreadEditorTabs.ts index c6d956194f3..3b4fef9a358 100644 --- a/src/vs/workbench/api/browser/mainThreadEditorTabs.ts +++ b/src/vs/workbench/api/browser/mainThreadEditorTabs.ts @@ -47,7 +47,6 @@ export class MainThreadEditorTabs { * @returns A tab object */ private _buildTabObject(group: IEditorGroup, editor: EditorInput, editorIndex: number): IEditorTabDto { - // Even though the id isn't a diff / sideBySide on the main side we need to let the ext host know what type of editor it is const editorId = editor.editorId; const tabKind = editor instanceof DiffEditorInput ? TabKind.Diff : editor instanceof SideBySideEditorInput ? TabKind.SidebySide : TabKind.Singular; const tab: IEditorTabDto = { diff --git a/src/vs/workbench/api/common/extHost.protocol.ts b/src/vs/workbench/api/common/extHost.protocol.ts index 73db462b209..d4419a85614 100644 --- a/src/vs/workbench/api/common/extHost.protocol.ts +++ b/src/vs/workbench/api/common/extHost.protocol.ts @@ -628,8 +628,7 @@ export interface IEditorTabGroupDto { export enum TabKind { Singular = 0, Diff = 1, - SidebySide = 2, - Other = 3 + SidebySide = 2 } export interface IEditorTabDto { diff --git a/src/vs/workbench/api/test/browser/extHostEditorTabs.test.ts b/src/vs/workbench/api/test/browser/extHostEditorTabs.test.ts index 3a6be40a699..359ecb35c55 100644 --- a/src/vs/workbench/api/test/browser/extHostEditorTabs.test.ts +++ b/src/vs/workbench/api/test/browser/extHostEditorTabs.test.ts @@ -40,7 +40,7 @@ suite('ExtHostEditorTabs', function () { label: 'label1', viewColumn: 0, additionalResourcesAndViewTypes: [], - kind: TabKind.Other + kind: TabKind.Singular }; extHostEditorTabs.$acceptEditorTabModel([{ diff --git a/src/vscode-dts/vscode.proposed.tabs.d.ts b/src/vscode-dts/vscode.proposed.tabs.d.ts index 7cc8d4acbf8..1affd362f79 100644 --- a/src/vscode-dts/vscode.proposed.tabs.d.ts +++ b/src/vscode-dts/vscode.proposed.tabs.d.ts @@ -10,8 +10,7 @@ declare module 'vscode' { export enum TabKind { Singular = 0, Diff = 1, - SidebySide = 2, - Other = 3 + SidebySide = 2 } /**