Commit graph

28411 commits

Author SHA1 Message Date
Billy Griffin b1018d19f4
Update changelog.json 2021-01-14 06:44:29 -07:00
Billy Griffin 979db4772f
Update changelog.json 2021-01-14 06:44:24 -07:00
Billy Griffin 2223e925de
Update changelog.json 2021-01-14 06:44:18 -07:00
Markus Olsson b6c2beced1 Bump version and initial changelog 2021-01-14 14:02:42 +01:00
Markus Olsson 9129407d50
Merge pull request #11394 from desktop/bump-to-dugite-1.94.0
Bump dugite to 1.94.0
2021-01-14 13:53:38 +01:00
Markus Olsson 598678b767 Bump dugite 2021-01-14 13:32:42 +01:00
Markus Olsson bbd9015894
Merge pull request #11368 from desktop/git-error-combined-output
Improve git error API to show the combined stdout and stderr outputs
2021-01-12 14:02:08 +01:00
Sergio Padrino 8ecb2b16cb More feedback review, more cleanup!! ❤️
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-12 13:40:14 +01:00
Markus Olsson 435f1cc682
Merge pull request #11371 from desktop/fix-windows-menu-crash
Fix crash clicking menus on Windows: disable FocusTrap for menus
2021-01-12 11:00:40 +01:00
Sergio Padrino 3f7352607d Rename focusTrapActive to enableFocusTrap 😌
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-11 19:08:06 +01:00
Sergio Padrino f7efae7564 Cleanup commit code in AppStore 2021-01-11 18:57:59 +01:00
Sergio Padrino 01423ab9ee Reuse isRawGitError in renderErrorMessage
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-11 18:23:07 +01:00
Sergio Padrino f7ac9e58e1 Fix commit test by using the right error 2021-01-11 16:56:26 +01:00
Sergio Padrino cbcd366be5 Disable FocusTrap for menus on Windows
The problem is menu items are not focusable using tab, so FocusTrap just makes the app crash. D'oh!
2021-01-11 15:48:49 +01:00
Sergio Padrino 8c840a54a4 Add comment to clarify the new raw-git-error CSS class 2021-01-11 12:49:59 +01:00
Sergio Padrino 7d471c2510 Make isRawGitError private 2021-01-11 12:48:29 +01:00
Sergio Padrino c6fc7d8be3 Add missing await and fix committing 😆 2021-01-11 11:57:34 +01:00
Markus Olsson 1c488e94f5
Merge pull request #11332 from desktop/update-fork-behavior
Update repository after changing fork behavior
2021-01-11 11:37:12 +01:00
Sergio Padrino 80bfc9e34e Review feedback: add comments, rename things…
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-11 11:16:25 +01:00
Sergio Padrino 95bdda5563 Use split2 to split git output in lines
This is needed because byline splits not only by \n and \r\n, but also by \r.
2021-01-11 10:45:09 +01:00
Sergio Padrino c03e910eae Extra cleanup after removing logCommitError 2021-01-08 18:15:20 +01:00
Sergio Padrino 87c3bcd7a3 Increase max width of error dialog for raw git errors
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-08 18:03:02 +01:00
Sergio Padrino 450fc4f4da Get rid of logCommitError and clean up
This function becomes redundant once we create an error message combining stdout and stderr.

That also allows us to remove some `| undefined` from other function signatures :_D

Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-08 18:03:02 +01:00
Sergio Padrino ecdb58b3b3 Improve git error API to show the combined stdout and stderr outputs
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-08 18:03:02 +01:00
Markus Olsson 43c7e3acde
Merge pull request #11345 from desktop/clear-after-commit-fix
Fix summary & description fields deleting user's text (sometimes) after a commit
2021-01-08 17:43:20 +01:00
Markus Olsson c4406cdc82
Merge pull request #11280 from desktop/track-launches-from-downloads
Add dimension to track app launches from the Applications folder
2021-01-08 11:59:43 +01:00
Sergio Padrino db2a11b032 Re-render changes list also when isCommitting changed #7251 2021-01-08 11:02:50 +01:00
Sergio Padrino 8482e5cc48 Keep isCommitting=true until repository and changes have been refreshed. Fixes #7251 2021-01-08 10:46:21 +01:00
Sergio Padrino 5f43628b0f Add comment and use nice TS tricks 🤓
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2021-01-07 19:17:34 +01:00
Sergio Padrino c207c309be Track when the app is launched from the Applications folder on macOS 2021-01-07 18:41:25 +01:00
Sergio Padrino 094a88ba51 Revert "Add measure to track app launches from the Downloads folder"
This reverts commit 229c43f213.
2021-01-07 18:24:26 +01:00
Sergio Padrino f4677bede2 Create hashes in a more type-safe way and fix Repository hash 2021-01-07 18:11:35 +01:00
Sergio Padrino cff1fec0ee Revert "Improve repository change detection. Fixes #11327"
This reverts commit a8f6198b1b.
2021-01-07 17:49:48 +01:00
Sergio Padrino b3c211b9b9 Revert "Improve comment"
This reverts commit b9d5e2c12e.
2021-01-07 17:49:43 +01:00
Markus Olsson d008892180
Merge pull request #11279 from kawarimidoll/patch-1
Fix installation instructions in README.md
2021-01-07 17:33:51 +01:00
Markus Olsson 9a69bb6870
Merge pull request #11278 from desktop/its-a-focus-trap
Contain focus in dropdowns using FocusTrap
2021-01-07 17:32:06 +01:00
Sergio Padrino b9d5e2c12e Improve comment 2021-01-07 10:09:17 +01:00
Sergio Padrino a8f6198b1b Improve repository change detection. Fixes #11327
We also need to consider repositories as changed when their workflow preferences change.
2021-01-05 17:45:11 +01:00
Sergio Padrino 58368d81aa
Merge pull request #11274 from desktop/releases/2.6.2-beta2 2021-01-04 11:46:23 +01:00
Sergio Padrino 229c43f213 Add measure to track app launches from the Downloads folder 2020-12-23 14:10:59 +01:00
カワリミ人形 348c561458
Update README.md
Calling brew cask install is disabled
2020-12-23 21:54:08 +09:00
Sergio Padrino 92eded4604 Contain focus in dropdowns using FocusTrap 2020-12-23 12:11:44 +01:00
Sergio Padrino beb45b7e28
Improve release notes. Thanks @niik !!
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2020-12-23 11:58:09 +01:00
Markus Olsson 3cef97f340
Merge pull request #11263 from yurikoles/sublime-text-dev
Add detection of Sublime Text 4 and 2 as editor on macOS.
2020-12-23 10:43:26 +01:00
Sergio Padrino 3b5c7fe5d0 Fix release note about VSCodium support 2020-12-22 17:40:55 +01:00
Sergio Padrino 01825a270b Bump version to 2.6.2-beta2 and update changelog 2020-12-22 17:32:06 +01:00
Sergio Padrino a81615a399
Merge pull request #11266 from desktop/prune-actually-unused-remotes 2020-12-22 17:22:52 +01:00
Sergio Padrino c05fe81ec1 Format git-store.ts properly
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2020-12-22 16:58:17 +01:00
Sergio Padrino c58cb81551 Tweaks from review feedback Thanks @niik !!
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2020-12-22 16:51:54 +01:00
Sergio Padrino bcfd2b7279
Merge pull request #11160 from desktop/the-abstractest-of-abstractions 2020-12-22 15:28:46 +01:00