development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-18 07:32:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
36191 commits 301 branches 696 tags 363 MiB
Commit graph

845 commits

Author SHA1 Message Date
Sergio Padrino ee9d828cf3
Merge pull request #14025 from desktop/substr-substring-substitution 
Stop using substr, part one
 2022-03-03 13:36:09 +01:00
Sergio Padrino 47adedd909
Merge pull request #14051 from desktop/use-the-execfile-luke 
Replace custom spawn implementations with promisified exexFile
 2022-03-03 13:33:41 +01:00
Markus Olsson 9ff1015827 Let's not do this cleanup in this PR 2022-03-02 09:42:10 +01:00
Markus Olsson ef312b74a6 Add helper method for executing shell commands in scripts 2022-03-01 13:25:22 +01:00
Markus Olsson 09f16b4184 Search and replace for the straightforward cases 
substr(X) can be substituted for substring(X)
substr(0, X) can be substituted for substring(0, X)
 2022-02-28 15:26:36 +01:00
Markus Olsson aa604d6ecb Use execFile instead of custom spawn method 
They do pretty much the exact same thing and we can save on some code that we nee to maintain
 2022-02-28 13:44:40 +01:00
Sergio Padrino 784378f621 Merge branch 'development' into bump-webpack 2022-02-23 10:43:46 +01:00
Sergio Padrino 89103f406f I still don't know what I'm doing… 
…but at least it builds!
 2022-02-15 17:33:17 +01:00
tidy-dev b50cc952d2 Update iconURL path 2022-02-15 09:08:15 -05:00
Markus Olsson 9169feff3d Fix TS 4.5 errors 2022-01-28 10:18:40 +01:00
Markus Olsson 9a91638124 Clean up and prepare for TS 4.5 2022-01-28 10:18:07 +01:00
Markus Olsson fc05c87a0a Merge branch 'development' into pr/10874 2021-12-06 13:21:43 +01:00
Sergio Padrino 0d86e5b82d Delete WebView2Loader.dll from Windows builds 
That file cannot be signed and makes our builds fail. More info: https://github.com/microsoft/Git-Credential-Manager-Core/issues/462
 2021-09-22 10:58:08 +02:00
Sergio Padrino d2072a89d4 Don't copy ssh-wrapper on non-dev builds 2021-08-18 14:11:13 +02:00
Sergio Padrino 42182c782d Copy ssh-wrapper in macOS builds 2021-08-18 14:11:13 +02:00
Sergio Padrino 24d89a8007
Merge pull request #12572 from shiftkey/port-custom-tslint-to-eslint 
port custom TSLint rules to ESLint
 2021-08-12 13:31:45 +02:00
tidy-dev 7f449635e8 Remove dead code block 2021-08-03 11:05:07 -04:00
tidy-dev 580bf78df1 Cut out deployment if ensure container fails 2021-08-03 08:49:08 -04:00
tidy-dev 02679bdc43 Nest upload result 2021-08-02 17:29:09 -04:00
tidy-dev e49c2a349c Switch to upload to Azure 2021-08-02 09:43:36 -04:00
Sergio Padrino 2d5e6d3fa1 Specify type for Octicon symbols 2021-07-27 18:41:20 +02:00
Sergio Padrino 8bba43f99a Merge branch 'development' into tree-shake-octoicons 2021-07-27 17:51:49 +02:00
Brendan Forster d3f27cd5db remove scripts and setup that handles transpiling tslint-rules directory 2021-07-06 12:41:56 -03:00
Sergio Padrino a09b8d6509 Rename old getArchitecture function to getDistArchitecture 2021-04-27 11:17:36 +02:00
Sergio Padrino 6bad4540ca Add the architecture as path component of the updates URL 2021-04-23 11:10:24 +02:00
Sergio Padrino 8b75aaa97c Allow Windows releases to not have a delta nuget package 2021-04-09 10:03:46 +02:00
Sergio Padrino dce4e0acea Behind a feature flag, update x64 macOS users to the arm64 build when possible 2021-04-08 16:21:45 +02:00
Sergio Padrino ba4c0dbb9e Fix upload of nuget packages 2021-04-08 16:12:17 +02:00
Sergio Padrino dcd1848c1c Use the architecture as suffix instead of path for artifacts 2021-04-08 16:12:13 +02:00
Sergio Padrino 7621c25c20 Fix more build issues 2021-04-06 17:11:00 +02:00
Sergio Padrino 760c89325e Disable updating from x64 under Rosetta to arm64 2021-04-06 16:23:31 +02:00
Sergio Padrino d56b12af7a Remove unused import 2021-04-06 14:07:05 +02:00
Sergio Padrino 03c9d77585 First batch of changes to support deploying arm64 builds 2021-04-06 13:56:05 +02:00
Dennis Ameling 69882e844e Merge remote-tracking branch 'upstream/development' into windows-arm-support 2021-02-19 09:17:27 +01:00
Sergio Padrino f353373e41 Merge branch 'development' into trampoline-server-playground 2021-02-17 11:36:51 +01:00
Dennis Ameling a452402fd1 Merge remote-tracking branch 'upstream/development' into windows-arm-support 2021-02-11 14:40:07 +01:00
Sergio Padrino d0d95c1b3c (WIP) Cleanup and other changes to trampoline server 2021-02-02 12:10:57 +01:00
Dennis Ameling 14141a73ba First work for Electron 11 upgrade 2020-12-22 12:04:48 +01:00
Jip Sterk 9c7868b176
Merge branch 'development' into resolve-json-module 2020-12-16 07:02:13 +01:00
Dennis Ameling cc52125343 Fix linting 2020-11-19 10:49:50 +01:00
Dennis Ameling 45e8d526a1 Cleanup & optimizations 2020-11-19 10:48:13 +01:00
Dennis Ameling c7f486582c Change the assumption of a x64 host to OS arch 2020-11-19 10:40:38 +01:00
Dennis Ameling 3172a87f58 Download Windows arm64 node lib in CI 2020-11-19 10:29:56 +01:00
Dennis Ameling ed8f1e88be Default to NodeJS current arch 2020-11-19 10:29:56 +01:00
Dennis Ameling 004f76057f Add support for Windows ARM 2020-11-19 10:29:54 +01:00
Olivier 5665d97076
Fix typo 2020-11-18 12:42:20 -05:00
Olivier 5082630613
Fix typo 2020-11-17 23:44:06 -05:00
Jip Sterk a0489be563
resolve json modules 2020-10-20 00:55:14 +02:00
Markus Olsson 2a7cef4764 Merge branch 'development' into tree-shake-octoicons 2020-09-30 11:23:47 +02:00
Brendan Forster ccbf45f01f cleanup some unneeded CircleCI checks 2020-08-25 10:14:40 -03:00
Brendan Forster f80c54737b use existing value for isPublishable() 2020-08-25 10:14:40 -03:00
Brendan Forster a5df2f1df4 remove deprecated isRunningOnFork code 2020-08-25 10:14:35 -03:00
Brendan Forster baec8f6051 replace isRunningOnFork usages with isPublishable 2020-08-25 10:14:34 -03:00
Markus Olsson edac8e0f5e Merge branch 'development' into upgrade-octicons 2020-08-21 13:00:23 +02:00
Markus Olsson f2594f34ba Get a little bit more logging out of publish/package step 2020-08-17 13:42:36 +02:00
Markus Olsson 3e817b8651 Merge branch 'development' into upgrade-octicons 2020-08-17 10:38:51 +02:00
Markus Olsson 2d63447841 Merge branch 'development' into tree-shake-octoicons 2020-08-11 18:48:22 +02:00
Markus Olsson f862081f74 Merge branch 'development' into upgrade-octicons 2020-08-11 18:43:37 +02:00
Markus Olsson 114ce6f408 Merge branch 'development' into remove-requires 2020-08-11 18:43:23 +02:00
Markus Olsson e26d8db3ff Merge branch 'development' into remove-requires 2020-08-10 12:43:18 +02:00
Markus Olsson 229fc60256 Merge branch 'development' into spike/actions-win32 2020-08-07 10:53:36 +02:00
rafeca 78e048fbdd
Merge branch 'development' into electron-9 2020-08-06 16:03:37 +02:00
rafeca cc223c173a
fillRule -> fr 2020-08-06 15:22:12 +02:00
rafeca f6c1875c9f
Copy fill-rule attribute from octoicons' SVGs 2020-08-06 15:10:55 +02:00
Markus Olsson 2a5aed6fb2
Merge branch 'development' into upgrade-octicons 2020-08-05 18:51:25 +02:00
Markus Olsson c8663b60c2 Merge branch 'development' into spike/actions-win32 2020-08-05 17:45:00 +02:00
Markus Olsson e8cba5b82f Merge branch 'development' into chore/only-custom-tslint-rules 2020-08-05 15:46:14 +02:00
Markus Olsson 636382b0eb Merge branch 'development' into electron-9 2020-08-04 11:23:12 +02:00
Rafael Oleza 726db12bec
Guard against empty value env variables in GitHub Actions 2020-07-22 20:16:17 +02:00
Rafael Oleza 91f2187be3
Return SHA for github actions 2020-07-22 20:16:17 +02:00
Rafael Oleza 598e4168fc
Calculate the release branch name correctly on GitHub Actions 2020-07-22 20:16:16 +02:00
Rafael Oleza 7e9b84b514
Update generate-octicons script to generate named exports 
With named exports for each of the octicons we can leverage WebPack tree shaking capabilities to get rid of unused octicons in the bundle
 2020-07-21 10:12:47 +02:00
Rafael Oleza 4bf7673f7c
Update generate-icons script to use the new data 
The data structure returned by octicons has changed in v10.0.0 (see dbf02d1bb8/CHANGELOG.md (breaking-changes--1)).

Now we need to get the SVG paths from a specific size from the sizes array.
 2020-07-17 16:47:50 +02:00
Rafael Oleza 761d6ac927
Upgrade electron-debug and electron-devtools-installer packages 2020-07-16 17:17:16 +02:00
Rafael Oleza 4f94999984
Use import for to-camel-case and xml2js 2020-07-14 16:32:49 +02:00
Rafael Oleza 3ca6b4867b
Use import for front-matter module 2020-07-14 16:32:49 +02:00
Rafael Oleza 6c9fce3db8
Remove export = 2020-07-10 21:22:20 +02:00
Markus Olsson c109b5a8ec Simpler path 2020-07-09 22:47:41 +02:00
Markus Olsson 573ae7b61f Try getting the actual failure position 2020-07-09 22:43:11 +02:00
Markus Olsson 29c3dcd195 Get rid of debug log 2020-07-09 20:39:38 +02:00
Markus Olsson ac0eb1d166 omg 2020-07-09 20:31:57 +02:00
Markus Olsson b01b903adb Debug forever 2020-07-09 20:15:20 +02:00
Markus Olsson a5a409f9f7 We don't have jest-unit any more 2020-07-09 20:10:43 +02:00
Markus Olsson d652608f35 Test reporting test errors 2020-07-09 19:28:28 +02:00
Markus Olsson c30863134f GitHub Actions can build on darwin as well 2020-07-09 14:17:24 +02:00
Markus Olsson 4d10b0d0df We can build on Windows on GH actions as well 2020-07-09 14:09:09 +02:00
Markus Olsson cc9e4b2adb Get whether we're on a fork in an action 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
 2020-07-09 14:09:00 +02:00
Markus Olsson 134beecda3 Get SHA on GitHub Actions 2020-07-09 14:08:49 +02:00
Rafael Oleza 1a9848af7f
Enable importHelpers TypeScript compiler option 
This avoids inlining the TypeScript helpers and instead imports them from tslib, saving bundle size
 2020-07-08 17:40:20 +02:00
Rafael Oleza a3f21ac29b
Enable esModuleInterop in TypeScript configuration 2020-07-08 17:40:20 +02:00
Markus Olsson 5374f9330a This no longer exists in eslint core 2020-07-02 16:45:49 +02:00
Andrew Casey 3c541dc92d Fix lint and prettier issues 2020-06-24 18:28:06 +00:00
Rafael Oleza 71d3945b6e
Merge pull request #10025 from amcasey/TS39 
Upgrade to TypeScript 3.9.5
 2020-06-24 17:11:33 +02:00
Markus Olsson b221a8c434 Notarization is complaining about syntax error on line 8, this is the only thing I can think of 2020-06-23 14:03:26 +02:00
Andrew Casey b6d92328ef Update script/post-install.ts 
Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey 6da50096de Update script/post-install.ts 
Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey a781f20afd Update script/post-install.ts 
Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey 398bd28d21 Update script/post-install.ts 
Better default exit status.

Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey 6de4d61e85 Upgrade @types/node to 12.12.24 to match electron 2020-06-22 19:36:29 +00:00
Andrew Casey 964697201c Fix TypeScript 3.9 errors 
Mostly, code flow analysis improvements have made `assertNever`s
unnecessary.
 2020-06-22 19:36:29 +00:00
Bill Cole 64b5c66efd
Added key per Issue #9050 2020-05-31 23:21:31 -04:00
Bill Cole 1a99b50afb
Update entitlements.plist 2020-05-31 23:13:56 -04:00
Bill Cole 660e0edc75
Add entitlement for BBEdit. See Issue #9050 2020-05-31 23:13:31 -04:00
evelyn masso a39c3cfe10 restructure to allow option to add "blank" release 2020-03-25 17:02:29 -07:00
evelyn masso a50f4c4fae add more console output 2020-03-25 16:36:07 -07:00
evelyn masso 6823bc6833 explicitly check for beta 2020-03-25 16:25:00 -07:00
evelyn masso e9982eab0a fix up types, obj construction 2020-03-02 09:23:24 -08:00
evelyn masso 4ecf850e31 move log 2020-03-02 09:23:24 -08:00
evelyn masso 4c2c139c44 inline logic 2020-03-02 09:23:24 -08:00
evelyn masso 3a4e44636f more cleanup 2020-03-02 09:23:24 -08:00
evelyn masso 54ce5e92a4 comments! 2020-03-02 09:23:24 -08:00
evelyn masso 25e1b055ed cleanup 2020-03-02 09:23:24 -08:00
evelyn masso cb5f3f99cb Update run.ts 2020-03-02 09:23:24 -08:00
evelyn masso 950d3e2dea cleanup steps 2020-03-02 09:23:24 -08:00
evelyn masso f4c77ba953 clean up makeNewChangelog 2020-03-02 09:23:24 -08:00
evelyn masso 10fc3b49c9 add catchers 2020-03-02 09:23:24 -08:00
evelyn masso 642ef70cbe rewrite draft-release task 2020-03-02 09:23:23 -08:00
evelyn masso 68de54f4db fix changelog updating 2020-03-02 09:23:23 -08:00
evelyn masso 8ad2911520 trying this out 2020-03-02 09:23:23 -08:00
Katrina Uychaco 8edf26f14c
Merge branch 'development' into chore/cleanup-draft-notes-task 2020-02-07 10:27:05 -08:00
Katrina Uychaco cab5d14ce3
Merge branch 'development' into format-notes-yarn-task 2020-02-06 15:08:48 -08:00
evelyn masso 9c7705a0c1 no need to stringify a string 2020-02-04 14:40:41 -08:00
evelyn masso 521423b950 code comments 2020-02-04 14:40:41 -08:00
evelyn masso 4c843171d7 clarify filters 2020-02-04 14:40:41 -08:00
evelyn masso 63ca4324fb remove duplicate-ish changelog task 2020-01-31 15:21:30 -05:00
evelyn masso 6efd97e8e6 Revert "remove old changelog validate script" 
This reverts commit 58d41f6789.
 2020-01-31 15:21:30 -05:00
evelyn masso 58d41f6789 remove old changelog validate script 2020-01-29 15:58:58 -05:00
evelyn masso 7e4e08cd2c extract release note tag order docs 2020-01-29 10:19:21 -05:00
Markus Olsson 7b92e178d2 Use SHA256 as the file digest algorithm 2020-01-13 08:43:26 +01:00
evelyn masso 347853d565 refactor icon path into helper function 2019-12-05 16:14:19 -08:00
Ed Luff f56d478173
Merge branch 'development' into patch-1 2019-11-06 20:17:20 +00:00
evelyn masso 4305dc38fa preserve previous logic under a clearer name 2019-11-05 10:01:34 -08:00
evelyn masso 5b3a9953a4 wow, that's in important ! 2019-11-04 10:59:13 -08:00
evelyn masso 87465683d5 refactor release channel + publishing logic 2019-11-04 10:41:06 -08:00
evelyn masso ab8fb64f36 Revert "don't fall back to NODE_ENV for determining release channel" 
This reverts commit e06f29662d.
 2019-11-04 10:40:21 -08:00
evelyn masso e06f29662d don't fall back to NODE_ENV for determining release channel 
if it's not a release branch we should fall back to 'development'
 2019-11-04 09:56:30 -08:00
Ed Luff e9d567971c
Merge branch 'development' into patch-1 2019-11-04 16:39:21 +00:00
evelyn masso eb00ee4f42 remove unneeded identity config field 2019-11-04 08:30:49 -08:00
evelyn masso 3b8675f5cb override type to avoid @ts-ignore 2019-11-04 08:08:54 -08:00
evelyn masso ecae21ac24 Update build.ts 2019-11-03 15:09:59 -08:00
evelyn masso 4f48267003 don't need these native entitlements 2019-11-03 15:08:54 -08:00
evelyn masso 86aae6ab77 unneeded entitlement 2019-11-03 15:04:29 -08:00
evelyn masso c7467b1420 remove sub-entitlement 
com.apple.security.cs.allow-unsigned-executable-memory includes com.apple.security.cs.allow-jit and more
 2019-11-03 15:01:38 -08:00
evelyn masso 39d336e50e remove dyld entitlement 2019-11-03 14:53:36 -08:00
evelyn masso 59e745fef0 remove media entitlements 2019-11-03 14:53:23 -08:00
evelyn masso f027c4fbcd this version opt is ignored 2019-11-03 14:48:14 -08:00
evelyn masso 6ae40a5d87 customize signing type and specify electron version 2019-11-03 14:03:25 -08:00
evelyn masso 831efce4cd always use hardenedRuntime 2019-11-03 14:01:59 -08:00
evelyn masso 8d19d844bb add entitlements 2019-11-03 14:01:44 -08:00
evelyn masso ed0a147314 only notarize when distributing 2019-11-03 13:59:36 -08:00