development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-08-24 18:57:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete WebView2Loader.dll from Windows builds

Browse source 
That file cannot be signed and makes our builds fail. More info: https://github.com/microsoft/Git-Credential-Manager-Core/issues/462
This commit is contained in:
Sergio Padrino 2021-09-21 18:19:54 +02:00
parent ea46d9cd7f
commit 0d86e5b82d
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
script/build.ts
View file

@ -40,6 +40,7 @@ import {
getExecutableName,
isPublishable,
getIconFileName,
getDistArchitecture,
} from './dist-info'
import { isCircleCI, isGitHubActions } from './build-platforms'
@ -376,9 +377,11 @@ function copyDependencies() {
'Microsoft.Vsts.Authentication.dll',
'git-askpass.exe',
'git-credential-manager.exe',
'WebView2Loader.dll',
]
const gitCoreDir = path.join(gitDir, 'mingw64', 'libexec', 'git-core')
const mingwFolder = getDistArchitecture() === 'x64' ? 'mingw64' : 'mingw32'
const gitCoreDir = path.join(gitDir, mingwFolder, 'libexec', 'git-core')
for (const file of files) {
const filePath = path.join(gitCoreDir, file)