development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-19 08:02:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
28394 commits 302 branches 696 tags 363 MiB
Commit graph

28394 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sergio Padrino 8ecb2b16cb More feedback review, more cleanup!! ❤️ 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2021-01-12 13:40:14 +01:00
Sergio Padrino f7efae7564 Cleanup commit code in AppStore 2021-01-11 18:57:59 +01:00
Sergio Padrino 01423ab9ee Reuse isRawGitError in renderErrorMessage 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2021-01-11 18:23:07 +01:00
Sergio Padrino f7ac9e58e1 Fix commit test by using the right error 2021-01-11 16:56:26 +01:00
Sergio Padrino 8c840a54a4 Add comment to clarify the new raw-git-error CSS class 2021-01-11 12:49:59 +01:00
Sergio Padrino 7d471c2510 Make isRawGitError private 2021-01-11 12:48:29 +01:00
Sergio Padrino c6fc7d8be3 Add missing await and fix committing 😆 2021-01-11 11:57:34 +01:00
Sergio Padrino 95bdda5563 Use split2 to split git output in lines 
This is needed because byline splits not only by \n and \r\n, but also by \r.
 2021-01-11 10:45:09 +01:00
Sergio Padrino c03e910eae Extra cleanup after removing logCommitError 2021-01-08 18:15:20 +01:00
Sergio Padrino 87c3bcd7a3 Increase max width of error dialog for raw git errors 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2021-01-08 18:03:02 +01:00
Sergio Padrino 450fc4f4da Get rid of logCommitError and clean up 
This function becomes redundant once we create an error message combining stdout and stderr.

That also allows us to remove some `| undefined` from other function signatures :_D

Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2021-01-08 18:03:02 +01:00
Sergio Padrino ecdb58b3b3 Improve git error API to show the combined stdout and stderr outputs 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2021-01-08 18:03:02 +01:00
Markus Olsson 43c7e3acde
Merge pull request #11345 from desktop/clear-after-commit-fix 
Fix summary & description fields deleting user's text (sometimes) after a commit
 2021-01-08 17:43:20 +01:00
Markus Olsson c4406cdc82
Merge pull request #11280 from desktop/track-launches-from-downloads 
Add dimension to track app launches from the Applications folder
 2021-01-08 11:59:43 +01:00
Sergio Padrino db2a11b032 Re-render changes list also when isCommitting changed #7251 2021-01-08 11:02:50 +01:00
Sergio Padrino 8482e5cc48 Keep isCommitting=true until repository and changes have been refreshed. Fixes #7251 2021-01-08 10:46:21 +01:00
Sergio Padrino 5f43628b0f Add comment and use nice TS tricks 🤓 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2021-01-07 19:17:34 +01:00
Sergio Padrino c207c309be Track when the app is launched from the Applications folder on macOS 2021-01-07 18:41:25 +01:00
Sergio Padrino 094a88ba51 Revert "Add measure to track app launches from the Downloads folder" 
This reverts commit 229c43f213.
 2021-01-07 18:24:26 +01:00
Markus Olsson d008892180
Merge pull request #11279 from kawarimidoll/patch-1 
Fix installation instructions in README.md
 2021-01-07 17:33:51 +01:00
Markus Olsson 9a69bb6870
Merge pull request #11278 from desktop/its-a-focus-trap 
Contain focus in dropdowns using FocusTrap
 2021-01-07 17:32:06 +01:00
Sergio Padrino 58368d81aa
Merge pull request #11274 from desktop/releases/2.6.2-beta2 2021-01-04 11:46:23 +01:00
Sergio Padrino 229c43f213 Add measure to track app launches from the Downloads folder 2020-12-23 14:10:59 +01:00
カワリミ人形 348c561458
Update README.md 
Calling brew cask install is disabled
 2020-12-23 21:54:08 +09:00
Sergio Padrino 92eded4604 Contain focus in dropdowns using FocusTrap 2020-12-23 12:11:44 +01:00
Sergio Padrino beb45b7e28
Improve release notes. Thanks @niik !! 
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
 2020-12-23 11:58:09 +01:00
Markus Olsson 3cef97f340
Merge pull request #11263 from yurikoles/sublime-text-dev 
Add detection of Sublime Text 4 and 2 as editor on macOS.
 2020-12-23 10:43:26 +01:00
Sergio Padrino 3b5c7fe5d0 Fix release note about VSCodium support 2020-12-22 17:40:55 +01:00
Sergio Padrino 01825a270b Bump version to 2.6.2-beta2 and update changelog 2020-12-22 17:32:06 +01:00
Sergio Padrino a81615a399
Merge pull request #11266 from desktop/prune-actually-unused-remotes 2020-12-22 17:22:52 +01:00
Sergio Padrino c05fe81ec1 Format git-store.ts properly 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2020-12-22 16:58:17 +01:00
Sergio Padrino c58cb81551 Tweaks from review feedback ✨ Thanks @niik !! 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2020-12-22 16:51:54 +01:00
Sergio Padrino bcfd2b7279
Merge pull request #11160 from desktop/the-abstractest-of-abstractions 2020-12-22 15:28:46 +01:00
Markus Olsson ecae3c41d8 Less tricks, moar clarity 2020-12-22 14:11:27 +01:00
Markus Olsson a051e65de8 Merge branch 'development' into prune-actually-unused-remotes 2020-12-22 12:26:02 +01:00
Markus Olsson 6e4ab3511f Less tricks, more clarity 2020-12-22 12:22:08 +01:00
Markus Olsson 83483a1872 🎨 don't subscribe if we've got what we need 2020-12-22 12:14:55 +01:00
Markus Olsson 29867c5cc2 Call the callback if we've got a value cached 2020-12-22 12:13:26 +01:00
Markus Olsson f3698cba68 📖 2020-12-22 12:11:46 +01:00
Yurii Kolesnykov e499d35dd0
Add detection of Sublime Text 4 and 2 as editor on macOS. 
Signed-off-by: Yurii Kolesnykov <root@yurikoles.com>
 2020-12-22 13:11:36 +02:00
Markus Olsson 75cb07b0dc 📖 2020-12-22 12:07:41 +01:00
Markus Olsson c82639dd1f Merge fail 2020-12-22 12:02:43 +01:00
Markus Olsson ceffeee9d1 Merge remote-tracking branch 'origin/development' into the-abstractest-of-abstractions 2020-12-22 12:02:03 +01:00
Markus Olsson 89aa4df560
Merge pull request #11162 from AndreiMaga/development 
Fix starting as maximized
 2020-12-22 11:58:02 +01:00
Markus Olsson 2578bd39dc
Merge pull request #11267 from desktop/once-more-unto-the-breach 
Fix "Couldn't find branch" error when checking out a PR from a fork
 2020-12-22 11:57:29 +01:00
Markus Olsson 829c2ccb09
Skip explicit type annotation and provide hint to this PR 2020-12-22 11:22:55 +01:00
Markus Olsson d100a69f3c
Merge pull request #11264 from yurikoles/update-nvmrc 
Update .nvmrc
 2020-12-22 11:19:33 +01:00
Markus Olsson 784e5fa670
Update app/src/lib/stores/helpers/ahead-behind-updater.ts 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2020-12-22 11:14:28 +01:00
Markus Olsson 267e881fd5 🎨 book 
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
 2020-12-22 11:07:36 +01:00
Markus Olsson f66cfe1795
Merge pull request #11268 from desktop/powershell-initial-path 
Change how initial path is set when launching PowerShell (Core) terminals
 2020-12-22 11:02:55 +01:00