Commit graph

35105 commits

Author SHA1 Message Date
Markus Olsson
784114944e Merge branch 'development' into stats-cleanup 2023-10-05 12:03:24 +02:00
Sergio Padrino
282a8d6acf
Merge pull request #17488 from desktop/branch-filter-aria-label
Add `aria-label` to "compare" filter textbox
2023-10-05 11:32:44 +02:00
Markus Olsson
4c62ff85d6 🎨 cleanup 2023-10-05 11:29:46 +02:00
Markus Olsson
40c9cf3211 Not directly async 2023-10-05 11:22:16 +02:00
Markus Olsson
df91626390
Merge pull request #17494 from desktop/yarn-why
Remove unused dependencies
2023-10-05 10:51:26 +02:00
Markus Olsson
87049f6e57 Remove unused dependencies
electron-debug and devtron haven't been updated in years. Electron-devtools main function is adding keyboard shortcuts in dev mode to open devtools and the element selector. We use neither of these
2023-10-05 09:19:19 +02:00
Sergio Padrino
2aaf1a9335
Merge pull request #17479 from desktop/generic-error-alertdialog
Add `role="alertdialog"` to generic app error dialog
2023-10-05 08:45:43 +02:00
Sergio Padrino
eab913ab83
Merge pull request #17483 from desktop/dialog-h1-to-h2
Use `h2` for dialog titles
2023-10-05 08:43:36 +02:00
Sergio Padrino
756b259f05 Add aria-label to "compare" filter textbox 2023-10-04 18:32:57 +02:00
Sergio Padrino
c4c0035349 Remove unused CSS for merge dialogs
The dialog with `id="merge"` was deleted in cadc38cc15
2023-10-03 18:09:00 +02:00
Sergio Padrino
330da3aed2 Remove unused CSS for rebase dialogs
The dialog with `id="rebase"` was deleted in ec29beab23
2023-10-03 18:05:58 +02:00
Sergio Padrino
3d316564e7 Adjust specific CSS of different dialog headers 2023-10-03 18:01:43 +02:00
Sergio Padrino
11a9c3de07 Adjust general CSS for dialog header 2023-10-03 18:01:21 +02:00
Sergio Padrino
b54da0255f Use h2 instead of h2 for dialog header title 2023-10-03 18:00:59 +02:00
Sergio Padrino
7fb2ea4fea
Merge pull request #17478 from desktop/abort-rebase-alertdialog
Add `alertdialog` role to the abort multi-commit operation confirmation dialog
2023-10-03 16:29:42 +02:00
Sergio Padrino
6313995225
Merge pull request #17472 from desktop/fix-commit-scrollbar
Fix left panel scrollbar when pasting long text in commit summary
2023-10-03 15:26:36 +02:00
Sergio Padrino
036aa67f24
Merge pull request #17464 from desktop/show-toggle-coauthors-msg-on-focus
Show toggle co-authors button text when it's focused via keyboard navigation
2023-10-03 15:15:08 +02:00
tidy-dev
268c190c01
Merge pull request #17461 from desktop/remove-checkrun-logs
Remove getting/parsing check run jobs completely
2023-10-03 07:54:45 -04:00
Sergio Padrino
48a65c80fd Add role="alertdialog" to generic app error dialog 2023-10-03 11:32:28 +02:00
Sergio Padrino
8723a41b89 Add alertdialog role to the abort multi-commit operation confirm dialog 2023-10-03 11:07:58 +02:00
Sergio Padrino
b0b11e7281
Merge pull request #17463 from bjorntechCarl/dev-add-cursor-support-macosx
Added cursor support
2023-10-03 09:16:55 +02:00
Sergio Padrino
20d9b524f3
Update app/src/lib/editors/darwin.ts 2023-10-03 08:56:00 +02:00
Sergio Padrino
55e8089fb7 Add comment to CSS change for more clarity 2023-10-02 08:40:27 +02:00
Sergio Padrino
9605e5c279 Don't overflow input text when invisible caret is out of bounds 2023-10-02 08:35:47 +02:00
Sergio Padrino
a8d81d63bd Update the caret position when the user scrolls within the textbox 2023-10-02 08:33:20 +02:00
Sergio Padrino
1900a72e5a Show toggle co-authors button text when it's focused via keyboard navigation 2023-09-29 17:41:59 +02:00
bjorntechCarl
cbe5f69899 Added editor-integration.md entry 2023-09-29 10:53:18 +02:00
bjorntechCarl
7f1bfbbba9 Added cursor support 2023-09-29 10:44:17 +02:00
Sergio Padrino
0984198ff4
Merge pull request #17448 from desktop/describedby-for-merge-button
Add aria-describedby to merge/rebase/squash button
2023-09-29 09:06:25 +02:00
tidy-dev
4c306600f3 Remove getting/parsing check run jobs completely 2023-09-28 11:33:59 -04:00
tidy-dev
c27b88545b
Merge pull request #17441 from desktop/update-accessibiliyt-linter
Update A11y Linter
2023-09-28 09:45:15 -04:00
Sergio Padrino
f8a4db9290
Merge pull request #17454 from desktop/releases/3.3.4-beta1
Release 3.3.4-beta1
2023-09-28 08:25:27 +02:00
tidy-dev
377f145bed Mock DOMreact and ResizeObserver for app render test 2023-09-27 15:44:25 +00:00
tidy-dev
5a49354177
Already in 3.3.3-beta1 2023-09-27 11:12:47 -04:00
tidy-dev
a1cc26ae0d
Already in beta 3.3.3-beta1 2023-09-27 11:11:50 -04:00
tidy-dev
25fe486ee7
Already in beta 3.3.3-beta1 2023-09-27 11:09:30 -04:00
Sergio Padrino
7392ba1304
Remove changes from last beta
Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
2023-09-27 17:08:47 +02:00
tidy-dev
b5cf5ec9ee linter 2023-09-27 14:53:40 +00:00
tidy-dev
20cdf036e2 Make control button tooltips more visible 2023-09-27 14:51:54 +00:00
tidy-dev
ebc0033a52 Switch to our Button component to use tooltips 2023-09-27 14:49:23 +00:00
Sergio Padrino
856b12dc1c Bump changelog and version to 3.3.4-beta1 2023-09-27 16:35:15 +02:00
Sergio Padrino
71c6efa578
Merge pull request #17408 from desktop/electron-26-2-1
Bump Electron to version 26.2.1
2023-09-27 16:21:41 +02:00
Sergio Padrino
937a55e5dd Fix required Electron version for prod builds (24.8.3) 2023-09-27 14:03:22 +02:00
Sergio Padrino
3ad30a2702 Revert "Bump node version to v18.16.1"
This reverts commit 1a4f3050ce.
2023-09-27 13:59:17 +02:00
tidy-dev
e3d5dd81f3
Use valueMap variable
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2023-09-27 06:23:28 -04:00
Markus Olsson
a101ccd1b8
Merge pull request #17442 from desktop/fancy-dialog-headers-take-one-thousand
Clickable close button in release notes dialog and fall(ing confetti) cleanup
2023-09-27 10:30:50 +02:00
Sergio Padrino
4a31dfe5ef Do not touch aria-describedby with tooltips unless strictly necessary 2023-09-27 08:26:10 +02:00
Sergio Padrino
6c6bd55fbe Make our tooltip a bit more aria-describedby friendly 😂
Before this change, the tooltip would override (setting or removing) whatever the target element had set as `aria-describedby`.

This was evident when trying to set a custom `aria-describedby` to an element with a tooltip: the `aria-describedby` attribute wouldn't make it to the DOM 😑

With this change, the tooltip will add or remove itself, respecting whatever was in there before.
2023-09-26 19:13:39 +02:00
Sergio Padrino
ee34681ed2 Add aria-describedby info to merge button 2023-09-26 19:04:21 +02:00
tidy-dev
f954662def Use new tooltips instead of titles 2023-09-26 11:33:43 -04:00