Jose Cortinas
0220b24505
Remove overflow hidden styles for focus outline
...
Without removing some overflow styles, the focus outline for elements inside of the banner is cut off and difficult to see.
2023-10-23 12:34:52 -05:00
Jose Cortinas
71fc7ddfe2
Add focus based dismissal
2023-10-23 12:31:42 -05:00
Jose Cortinas
eb9ccdb5bc
Missed a button tag
2023-10-23 12:19:13 -05:00
Jose Cortinas
27bcb1e5eb
Manually move focus to close or the first anchor
2023-10-17 17:23:27 -05:00
Jose Cortinas
c9e9d3b21d
Add fake cherry pick banner dev menu item
2023-10-17 17:22:52 -05:00
Jose Cortinas
7a81e5aa6a
Revert test buttons to LinkButton components
2023-10-17 14:45:05 -05:00
Jose Cortinas
e3b1b85930
Remove auto timeout and content suffix
2023-10-17 14:44:44 -05:00
Jose Cortinas
868a57db55
Convert links to button for autofocus
2023-10-11 12:01:03 -05:00
Jose Cortinas
e650fc44f5
Try aria-atomic and modifying content
2023-10-11 12:00:46 -05:00
Jose Cortinas
a44fdba232
Add alert role to banner component
2023-10-10 14:37:20 -05:00
Jose Cortinas
4030a0903c
Add dev menu items for showing fake banners
2023-10-10 14:35:33 -05:00
Sergio Padrino
57180aa893
Merge pull request #17505 from imkylecat/development
...
fix: JetBrains PhpStorm Capitalization
2023-10-06 17:07:46 +02:00
Kyle
89e1aa679d
fix: JetBrains PhpStorm Capitalization
2023-10-05 15:56:29 -04:00
tidy-dev
8d987788d1
Merge pull request #17501 from desktop/releases/3.3.4-beta2
...
Release 3.3.4-beta2
2023-10-05 13:58:02 -04:00
tidy-dev
1d08d0334e
Use familiar language
2023-10-05 10:48:14 -04:00
tidy-dev
1fe7179626
Add tab character fix
2023-10-05 10:46:56 -04:00
tidy-dev
044a556340
Merge branch 'development' into releases/3.3.4-beta2
2023-10-05 10:45:49 -04:00
Sergio Padrino
6c214b86a0
Merge pull request #17428 from desktop/render-tab-characters-correctly
...
Render tab characters properly in diffs
2023-10-05 16:45:33 +02:00
tidy-dev
200b76eb06
Order..
2023-10-05 10:23:39 -04:00
tidy-dev
99b9730e93
Release 3.3.4-beta2
2023-10-05 10:20:40 -04:00
Markus Olsson
89a832e9c6
Merge pull request #17496 from desktop/lower-dash
...
Avoid importing all of lodash
2023-10-05 15:44:56 +02:00
Markus Olsson
099fc60e79
Make sure we import lodash from app, not from ambient node_modules
2023-10-05 11:35:02 +02:00
Sergio Padrino
282a8d6acf
Merge pull request #17488 from desktop/branch-filter-aria-label
...
Add `aria-label` to "compare" filter textbox
2023-10-05 11:32:44 +02:00
Markus Olsson
df91626390
Merge pull request #17494 from desktop/yarn-why
...
Remove unused dependencies
2023-10-05 10:51:26 +02:00
Markus Olsson
5de0e89df4
Don't import all of lodash
2023-10-05 09:36:07 +02:00
Markus Olsson
903785a9d2
Import escapeReExp directly
2023-10-05 09:29:18 +02:00
Markus Olsson
87049f6e57
Remove unused dependencies
...
electron-debug and devtron haven't been updated in years. Electron-devtools main function is adding keyboard shortcuts in dev mode to open devtools and the element selector. We use neither of these
2023-10-05 09:19:19 +02:00
Sergio Padrino
2aaf1a9335
Merge pull request #17479 from desktop/generic-error-alertdialog
...
Add `role="alertdialog"` to generic app error dialog
2023-10-05 08:45:43 +02:00
Sergio Padrino
eab913ab83
Merge pull request #17483 from desktop/dialog-h1-to-h2
...
Use `h2` for dialog titles
2023-10-05 08:43:36 +02:00
Sergio Padrino
756b259f05
Add aria-label
to "compare" filter textbox
2023-10-04 18:32:57 +02:00
Sergio Padrino
c4c0035349
Remove unused CSS for merge dialogs
...
The dialog with `id="merge"` was deleted in cadc38cc15
2023-10-03 18:09:00 +02:00
Sergio Padrino
330da3aed2
Remove unused CSS for rebase dialogs
...
The dialog with `id="rebase"` was deleted in ec29beab23
2023-10-03 18:05:58 +02:00
Sergio Padrino
3d316564e7
Adjust specific CSS of different dialog headers
2023-10-03 18:01:43 +02:00
Sergio Padrino
11a9c3de07
Adjust general CSS for dialog header
2023-10-03 18:01:21 +02:00
Sergio Padrino
b54da0255f
Use h2 instead of h2 for dialog header title
2023-10-03 18:00:59 +02:00
Sergio Padrino
7fb2ea4fea
Merge pull request #17478 from desktop/abort-rebase-alertdialog
...
Add `alertdialog` role to the abort multi-commit operation confirmation dialog
2023-10-03 16:29:42 +02:00
Sergio Padrino
6313995225
Merge pull request #17472 from desktop/fix-commit-scrollbar
...
Fix left panel scrollbar when pasting long text in commit summary
2023-10-03 15:26:36 +02:00
Sergio Padrino
036aa67f24
Merge pull request #17464 from desktop/show-toggle-coauthors-msg-on-focus
...
Show toggle co-authors button text when it's focused via keyboard navigation
2023-10-03 15:15:08 +02:00
tidy-dev
268c190c01
Merge pull request #17461 from desktop/remove-checkrun-logs
...
Remove getting/parsing check run jobs completely
2023-10-03 07:54:45 -04:00
Sergio Padrino
48a65c80fd
Add role="alertdialog"
to generic app error dialog
2023-10-03 11:32:28 +02:00
Sergio Padrino
8723a41b89
Add alertdialog
role to the abort multi-commit operation confirm dialog
2023-10-03 11:07:58 +02:00
Sergio Padrino
b0b11e7281
Merge pull request #17463 from bjorntechCarl/dev-add-cursor-support-macosx
...
Added cursor support
2023-10-03 09:16:55 +02:00
Sergio Padrino
20d9b524f3
Update app/src/lib/editors/darwin.ts
2023-10-03 08:56:00 +02:00
Sergio Padrino
55e8089fb7
Add comment to CSS change for more clarity
2023-10-02 08:40:27 +02:00
Sergio Padrino
9605e5c279
Don't overflow input text when invisible caret is out of bounds
2023-10-02 08:35:47 +02:00
Sergio Padrino
a8d81d63bd
Update the caret position when the user scrolls within the textbox
2023-10-02 08:33:20 +02:00
Sergio Padrino
1900a72e5a
Show toggle co-authors button text when it's focused via keyboard navigation
2023-09-29 17:41:59 +02:00
bjorntechCarl
cbe5f69899
Added editor-integration.md entry
2023-09-29 10:53:18 +02:00
bjorntechCarl
7f1bfbbba9
Added cursor support
2023-09-29 10:44:17 +02:00
Sergio Padrino
0984198ff4
Merge pull request #17448 from desktop/describedby-for-merge-button
...
Add aria-describedby to merge/rebase/squash button
2023-09-29 09:06:25 +02:00