mirror of
https://github.com/desktop/desktop
synced 2024-09-18 07:32:01 +00:00
Apply suggestions from code review
Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
This commit is contained in:
parent
021c324385
commit
11dc95eab9
|
@ -2218,11 +2218,6 @@ export class AppStore extends TypedBaseStore<IAppState> {
|
|||
PullRequestSuggestedNextAction
|
||||
) ?? defaultPullRequestSuggestedNextAction
|
||||
|
||||
// Users who have never saved this preference should get the default of true
|
||||
if (getBoolean(underlineLinksKey) === undefined) {
|
||||
setBoolean(underlineLinksKey, true)
|
||||
}
|
||||
|
||||
// Always false if the feature flag is disabled.
|
||||
this.underlineLinks = enableLinkUnderlines()
|
||||
? getBoolean(underlineLinksKey, underlineLinksDefault)
|
||||
|
|
|
@ -26,8 +26,9 @@ export class Accessibility extends React.Component<
|
|||
this.props.underlineLinks ? CheckboxValue.On : CheckboxValue.Off
|
||||
}
|
||||
onChange={this.onUnderlineLinksChanged}
|
||||
ariaDescribedBy="underline-setting-description"
|
||||
/>
|
||||
<p className="git-settings-description">
|
||||
<p id="underline-setting-description" className="git-settings-description">
|
||||
When enabled, GitHub Desktop will underline links in commit
|
||||
messages, comments, and other text fields. This can help make links
|
||||
easier to distinguish. {this.renderExampleLink()}
|
||||
|
|
Loading…
Reference in a new issue