From 11dc95eab96aaf35542a5d08cea0615b80652af6 Mon Sep 17 00:00:00 2001
From: Jose Cortinas <jacortinas@gmail.com>
Date: Tue, 27 Feb 2024 11:20:00 -0600
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
---
 app/src/lib/stores/app-store.ts          | 5 -----
 app/src/ui/preferences/accessibility.tsx | 3 ++-
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/app/src/lib/stores/app-store.ts b/app/src/lib/stores/app-store.ts
index d8e3087403..3198647b20 100644
--- a/app/src/lib/stores/app-store.ts
+++ b/app/src/lib/stores/app-store.ts
@@ -2218,11 +2218,6 @@ export class AppStore extends TypedBaseStore<IAppState> {
         PullRequestSuggestedNextAction
       ) ?? defaultPullRequestSuggestedNextAction
 
-    // Users who have never saved this preference should get the default of true
-    if (getBoolean(underlineLinksKey) === undefined) {
-      setBoolean(underlineLinksKey, true)
-    }
-
     // Always false if the feature flag is disabled.
     this.underlineLinks = enableLinkUnderlines()
       ? getBoolean(underlineLinksKey, underlineLinksDefault)
diff --git a/app/src/ui/preferences/accessibility.tsx b/app/src/ui/preferences/accessibility.tsx
index bfc9ffd45f..f140435d2a 100644
--- a/app/src/ui/preferences/accessibility.tsx
+++ b/app/src/ui/preferences/accessibility.tsx
@@ -26,8 +26,9 @@ export class Accessibility extends React.Component<
               this.props.underlineLinks ? CheckboxValue.On : CheckboxValue.Off
             }
             onChange={this.onUnderlineLinksChanged}
+            ariaDescribedBy="underline-setting-description"
           />
-          <p className="git-settings-description">
+          <p id="underline-setting-description" className="git-settings-description">
             When enabled, GitHub Desktop will underline links in commit
             messages, comments, and other text fields. This can help make links
             easier to distinguish. {this.renderExampleLink()}