development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-13 21:31:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
This commit is contained in:
Jose Cortinas 2024-02-27 11:20:00 -06:00 committed by GitHub
parent 021c324385
commit 11dc95eab9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/src/lib/stores/app-store.ts
View file

@ -2218,11 +2218,6 @@ export class AppStore extends TypedBaseStore<IAppState> {
PullRequestSuggestedNextAction
) ?? defaultPullRequestSuggestedNextAction
// Users who have never saved this preference should get the default of true
if (getBoolean(underlineLinksKey) === undefined) {
setBoolean(underlineLinksKey, true)
}
// Always false if the feature flag is disabled.
this.underlineLinks = enableLinkUnderlines()
? getBoolean(underlineLinksKey, underlineLinksDefault)

3
app/src/ui/preferences/accessibility.tsx
View file

@ -26,8 +26,9 @@ export class Accessibility extends React.Component<
this.props.underlineLinks ? CheckboxValue.On : CheckboxValue.Off
}
onChange={this.onUnderlineLinksChanged}
ariaDescribedBy="underline-setting-description"
/>
<p className="git-settings-description">
<p id="underline-setting-description" className="git-settings-description">
When enabled, GitHub Desktop will underline links in commit
messages, comments, and other text fields. This can help make links
easier to distinguish. {this.renderExampleLink()}