mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
t/chainlint: add chainlint "specialized" test cases
The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
1f718b0b78
commit
950079b7b6
10
t/chainlint/bash-array.expect
Normal file
10
t/chainlint/bash-array.expect
Normal file
|
@ -0,0 +1,10 @@
|
|||
(
|
||||
foo &&
|
||||
bar=(gumbo stumbo wumbo) &&
|
||||
baz
|
||||
>) &&
|
||||
(
|
||||
foo &&
|
||||
bar=${#bar[@]} &&
|
||||
baz
|
||||
>)
|
12
t/chainlint/bash-array.test
Normal file
12
t/chainlint/bash-array.test
Normal file
|
@ -0,0 +1,12 @@
|
|||
(
|
||||
foo &&
|
||||
# LINT: ")" in Bash array assignment not misinterpreted as subshell-closing ")"
|
||||
bar=(gumbo stumbo wumbo) &&
|
||||
baz
|
||||
) &&
|
||||
(
|
||||
foo &&
|
||||
# LINT: Bash array length operator not misinterpreted as comment
|
||||
bar=${#bar[@]} &&
|
||||
baz
|
||||
)
|
4
t/chainlint/p4-filespec.expect
Normal file
4
t/chainlint/p4-filespec.expect
Normal file
|
@ -0,0 +1,4 @@
|
|||
(
|
||||
p4 print -1 //depot/fiddle#42 >file &&
|
||||
foobar
|
||||
>)
|
5
t/chainlint/p4-filespec.test
Normal file
5
t/chainlint/p4-filespec.test
Normal file
|
@ -0,0 +1,5 @@
|
|||
(
|
||||
# LINT: Perforce revspec in filespec not misinterpreted as in-line comment
|
||||
p4 print -1 //depot/fiddle#42 >file &&
|
||||
foobar
|
||||
)
|
Loading…
Reference in a new issue