mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
t/chainlint: add chainlint "complex" test cases
The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
24c8618064
commit
1f718b0b78
4
t/chainlint/close-nested-and-parent-together.expect
Normal file
4
t/chainlint/close-nested-and-parent-together.expect
Normal file
|
@ -0,0 +1,4 @@
|
|||
(
|
||||
cd foo &&
|
||||
(bar &&
|
||||
>>> baz))
|
3
t/chainlint/close-nested-and-parent-together.test
Normal file
3
t/chainlint/close-nested-and-parent-together.test
Normal file
|
@ -0,0 +1,3 @@
|
|||
(cd foo &&
|
||||
(bar &&
|
||||
baz))
|
10
t/chainlint/complex-if-in-cuddled-loop.expect
Normal file
10
t/chainlint/complex-if-in-cuddled-loop.expect
Normal file
|
@ -0,0 +1,10 @@
|
|||
(
|
||||
for i in a b c; do
|
||||
if test "$(echo $(waffle bat))" = "eleventeen" &&
|
||||
test "$x" = "$y"; then
|
||||
:
|
||||
else
|
||||
echo >file
|
||||
fi
|
||||
> done) &&
|
||||
test ! -f file
|
11
t/chainlint/complex-if-in-cuddled-loop.test
Normal file
11
t/chainlint/complex-if-in-cuddled-loop.test
Normal file
|
@ -0,0 +1,11 @@
|
|||
# LINT: 'for' loop cuddled with "(" and ")" and nested 'if' with complex
|
||||
# LINT: multi-line condition; indented with spaces, not tabs
|
||||
(for i in a b c; do
|
||||
if test "$(echo $(waffle bat))" = "eleventeen" &&
|
||||
test "$x" = "$y"; then
|
||||
:
|
||||
else
|
||||
echo >file
|
||||
fi
|
||||
done) &&
|
||||
test ! -f file
|
12
t/chainlint/if-in-loop.expect
Normal file
12
t/chainlint/if-in-loop.expect
Normal file
|
@ -0,0 +1,12 @@
|
|||
(
|
||||
for i in a b c
|
||||
do
|
||||
if false
|
||||
then
|
||||
?!AMP?! echo "err"
|
||||
exit 1
|
||||
?!AMP?! fi
|
||||
foo
|
||||
?!AMP?! done
|
||||
bar
|
||||
>)
|
15
t/chainlint/if-in-loop.test
Normal file
15
t/chainlint/if-in-loop.test
Normal file
|
@ -0,0 +1,15 @@
|
|||
(
|
||||
for i in a b c
|
||||
do
|
||||
if false
|
||||
then
|
||||
# LINT: missing "&&" on 'echo'
|
||||
echo "err"
|
||||
exit 1
|
||||
# LINT: missing "&&" on 'fi'
|
||||
fi
|
||||
foo
|
||||
# LINT: missing "&&" on 'done'
|
||||
done
|
||||
bar
|
||||
)
|
12
t/chainlint/loop-in-if.expect
Normal file
12
t/chainlint/loop-in-if.expect
Normal file
|
@ -0,0 +1,12 @@
|
|||
(
|
||||
if true
|
||||
then
|
||||
while true
|
||||
do
|
||||
?!AMP?! echo "pop"
|
||||
echo "glup"
|
||||
?!AMP?! done
|
||||
foo
|
||||
?!AMP?! fi
|
||||
bar
|
||||
>)
|
15
t/chainlint/loop-in-if.test
Normal file
15
t/chainlint/loop-in-if.test
Normal file
|
@ -0,0 +1,15 @@
|
|||
(
|
||||
if true
|
||||
then
|
||||
while true
|
||||
do
|
||||
# LINT: missing "&&" on 'echo'
|
||||
echo "pop"
|
||||
echo "glup"
|
||||
# LINT: missing "&&" on 'done'
|
||||
done
|
||||
foo
|
||||
# LINT: missing "&&" on 'fi'
|
||||
fi
|
||||
bar
|
||||
)
|
Loading…
Reference in a new issue