mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
t/chainlint: add chainlint "cuddled" test cases
The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
ebcbbe060f
commit
24c8618064
7
t/chainlint/cuddled-if-then-else.expect
Normal file
7
t/chainlint/cuddled-if-then-else.expect
Normal file
|
@ -0,0 +1,7 @@
|
|||
(
|
||||
if test -z ""; then
|
||||
echo empty
|
||||
else
|
||||
echo bizzy
|
||||
> fi) &&
|
||||
echo foobar
|
7
t/chainlint/cuddled-if-then-else.test
Normal file
7
t/chainlint/cuddled-if-then-else.test
Normal file
|
@ -0,0 +1,7 @@
|
|||
# LINT: 'if' cuddled with "(" and ")"; indented with spaces, not tabs
|
||||
(if test -z ""; then
|
||||
echo empty
|
||||
else
|
||||
echo bizzy
|
||||
fi) &&
|
||||
echo foobar
|
5
t/chainlint/cuddled-loop.expect
Normal file
5
t/chainlint/cuddled-loop.expect
Normal file
|
@ -0,0 +1,5 @@
|
|||
(
|
||||
while read x
|
||||
do foobar bop || exit 1
|
||||
> done <file ) &&
|
||||
outside subshell
|
7
t/chainlint/cuddled-loop.test
Normal file
7
t/chainlint/cuddled-loop.test
Normal file
|
@ -0,0 +1,7 @@
|
|||
# LINT: 'while' loop cuddled with "(" and ")", with embedded (allowed)
|
||||
# LINT: "|| exit {n}" to exit loop early, and using redirection "<" to feed
|
||||
# LINT: loop; indented with spaces, not tabs
|
||||
( while read x
|
||||
do foobar bop || exit 1
|
||||
done <file ) &&
|
||||
outside subshell
|
21
t/chainlint/cuddled.expect
Normal file
21
t/chainlint/cuddled.expect
Normal file
|
@ -0,0 +1,21 @@
|
|||
(
|
||||
cd foo &&
|
||||
bar
|
||||
>) &&
|
||||
|
||||
(
|
||||
?!AMP?!cd foo
|
||||
bar
|
||||
>) &&
|
||||
|
||||
(
|
||||
cd foo &&
|
||||
> bar) &&
|
||||
|
||||
(
|
||||
cd foo &&
|
||||
> bar) &&
|
||||
|
||||
(
|
||||
?!AMP?!cd foo
|
||||
> bar)
|
23
t/chainlint/cuddled.test
Normal file
23
t/chainlint/cuddled.test
Normal file
|
@ -0,0 +1,23 @@
|
|||
# LINT: first subshell statement cuddled with opening "("; for implementation
|
||||
# LINT: simplicity, "(..." is split into two lines, "(" and "..."
|
||||
(cd foo &&
|
||||
bar
|
||||
) &&
|
||||
|
||||
# LINT: same with missing "&&"
|
||||
(cd foo
|
||||
bar
|
||||
) &&
|
||||
|
||||
# LINT: closing ")" cuddled with final subshell statement
|
||||
(
|
||||
cd foo &&
|
||||
bar) &&
|
||||
|
||||
# LINT: "(" and ")" cuddled with first and final subshell statements
|
||||
(cd foo &&
|
||||
bar) &&
|
||||
|
||||
# LINT: same with missing "&&"
|
||||
(cd foo
|
||||
bar)
|
Loading…
Reference in a new issue