2007-11-08 00:33:19 +00:00
|
|
|
Like other projects, we also have some guidelines to keep to the
|
2015-04-13 12:54:14 +00:00
|
|
|
code. For Git in general, a few rough rules are:
|
2007-11-08 00:33:19 +00:00
|
|
|
|
|
|
|
- Most importantly, we never say "It's in POSIX; we'll happily
|
|
|
|
ignore your needs should your system not conform to it."
|
|
|
|
We live in the real world.
|
|
|
|
|
|
|
|
- However, we often say "Let's stay away from that construct,
|
|
|
|
it's not even in POSIX".
|
|
|
|
|
|
|
|
- In spite of the above two rules, we sometimes say "Although
|
|
|
|
this is not in POSIX, it (is so convenient | makes the code
|
|
|
|
much more readable | has other good characteristics) and
|
|
|
|
practically all the platforms we care about support it, so
|
|
|
|
let's use it".
|
|
|
|
|
|
|
|
Again, we live in the real world, and it is sometimes a
|
|
|
|
judgement call, the decision based more on real world
|
|
|
|
constraints people face than what the paper standard says.
|
|
|
|
|
2014-04-30 21:23:26 +00:00
|
|
|
- Fixing style violations while working on a real change as a
|
|
|
|
preparatory clean-up step is good, but otherwise avoid useless code
|
|
|
|
churn for the sake of conforming to the style.
|
|
|
|
|
|
|
|
"Once it _is_ in the tree, it's not really worth the patch noise to
|
|
|
|
go and fix it up."
|
2017-05-05 10:08:03 +00:00
|
|
|
Cf. http://lkml.iu.edu/hypermail/linux/kernel/1001.3/01069.html
|
2014-04-30 21:23:26 +00:00
|
|
|
|
2022-01-27 19:02:58 +00:00
|
|
|
- Log messages to explain your changes are as important as the
|
|
|
|
changes themselves. Clearly written code and in-code comments
|
|
|
|
explain how the code works and what is assumed from the surrounding
|
|
|
|
context. The log messages explain what the changes wanted to
|
|
|
|
achieve and why the changes were necessary (more on this in the
|
|
|
|
accompanying SubmittingPatches document).
|
|
|
|
|
2013-02-06 19:49:01 +00:00
|
|
|
Make your code readable and sensible, and don't try to be clever.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
|
|
|
As for more concrete guidelines, just imitate the existing code
|
|
|
|
(this is a good guideline, no matter which project you are
|
2009-01-26 08:32:22 +00:00
|
|
|
contributing to). It is always preferable to match the _local_
|
2013-01-21 19:17:53 +00:00
|
|
|
convention. New code added to Git suite is expected to match
|
2009-01-26 08:32:22 +00:00
|
|
|
the overall style of existing code. Modifications to existing
|
|
|
|
code is expected to match the style the surrounding code already
|
|
|
|
uses (even if it doesn't match the overall style of existing code).
|
|
|
|
|
2022-04-21 08:45:15 +00:00
|
|
|
But if you must have a list of rules, here are some language
|
|
|
|
specific ones. Note that Documentation/ToolsForGit.txt document
|
|
|
|
has a collection of tips to help you use some external tools
|
|
|
|
to conform to these guidelines.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
|
|
|
For shell scripts specifically (not exhaustive):
|
|
|
|
|
2010-12-03 16:47:35 +00:00
|
|
|
- We use tabs for indentation.
|
|
|
|
|
2014-04-30 21:24:08 +00:00
|
|
|
- Case arms are indented at the same depth as case and esac lines,
|
|
|
|
like this:
|
|
|
|
|
|
|
|
case "$variable" in
|
|
|
|
pattern1)
|
|
|
|
do this
|
|
|
|
;;
|
|
|
|
pattern2)
|
|
|
|
do that
|
|
|
|
;;
|
|
|
|
esac
|
2010-12-03 16:47:35 +00:00
|
|
|
|
2012-02-24 23:12:57 +00:00
|
|
|
- Redirection operators should be written with space before, but no
|
|
|
|
space after them. In other words, write 'echo test >"$file"'
|
|
|
|
instead of 'echo test> $file' or 'echo test > $file'. Note that
|
|
|
|
even though it is not required by POSIX to double-quote the
|
|
|
|
redirection target in a variable (as shown above), our code does so
|
|
|
|
because some versions of bash issue a warning without the quotes.
|
|
|
|
|
2014-04-30 21:24:24 +00:00
|
|
|
(incorrect)
|
|
|
|
cat hello > world < universe
|
|
|
|
echo hello >$world
|
|
|
|
|
|
|
|
(correct)
|
|
|
|
cat hello >world <universe
|
|
|
|
echo hello >"$world"
|
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- We prefer $( ... ) for command substitution; unlike ``, it
|
|
|
|
properly nests. It should have been the way Bourne spelled
|
|
|
|
it from day one, but unfortunately isn't.
|
|
|
|
|
2012-02-24 23:12:58 +00:00
|
|
|
- If you want to find out if a command is available on the user's
|
|
|
|
$PATH, you should use 'type <command>', instead of 'which <command>'.
|
2019-11-05 17:07:20 +00:00
|
|
|
The output of 'which' is not machine parsable and its exit code
|
2012-02-24 23:12:58 +00:00
|
|
|
is not reliable across platforms.
|
|
|
|
|
2010-10-13 18:15:14 +00:00
|
|
|
- We use POSIX compliant parameter substitutions and avoid bashisms;
|
|
|
|
namely:
|
2007-11-08 00:33:19 +00:00
|
|
|
|
2010-10-13 18:15:14 +00:00
|
|
|
- We use ${parameter-word} and its [-=?+] siblings, and their
|
|
|
|
colon'ed "unset or null" form.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
2010-10-13 18:15:14 +00:00
|
|
|
- We use ${parameter#word} and its [#%] siblings, and their
|
|
|
|
doubled "longest matching" form.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
2010-10-13 18:15:14 +00:00
|
|
|
- No "Substring Expansion" ${parameter:offset:length}.
|
2010-09-22 19:15:37 +00:00
|
|
|
|
2010-10-13 18:15:14 +00:00
|
|
|
- No shell arrays.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
2010-10-13 18:15:14 +00:00
|
|
|
- No pattern replacement ${parameter/pattern/string}.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
2010-10-13 18:15:14 +00:00
|
|
|
- We use Arithmetic Expansion $(( ... )).
|
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- We do not use Process Substitution <(list) or >(list).
|
|
|
|
|
2012-08-15 17:06:01 +00:00
|
|
|
- Do not write control structures on a single line with semicolon.
|
|
|
|
"then" should be on the next line for if statements, and "do"
|
|
|
|
should be on the next line for "while" and "for".
|
|
|
|
|
2014-04-30 21:24:52 +00:00
|
|
|
(incorrect)
|
|
|
|
if test -f hello; then
|
|
|
|
do this
|
|
|
|
fi
|
|
|
|
|
|
|
|
(correct)
|
|
|
|
if test -f hello
|
|
|
|
then
|
|
|
|
do this
|
|
|
|
fi
|
|
|
|
|
2018-10-05 21:54:02 +00:00
|
|
|
- If a command sequence joined with && or || or | spans multiple
|
|
|
|
lines, put each command on a separate line and put && and || and |
|
|
|
|
operators at the end of each line, rather than the start. This
|
|
|
|
means you don't need to use \ to join lines, since the above
|
|
|
|
operators imply the sequence isn't finished.
|
|
|
|
|
|
|
|
(incorrect)
|
|
|
|
grep blob verify_pack_result \
|
|
|
|
| awk -f print_1.awk \
|
|
|
|
| sort >actual &&
|
|
|
|
...
|
|
|
|
|
|
|
|
(correct)
|
|
|
|
grep blob verify_pack_result |
|
|
|
|
awk -f print_1.awk |
|
|
|
|
sort >actual &&
|
|
|
|
...
|
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- We prefer "test" over "[ ... ]".
|
|
|
|
|
|
|
|
- We do not write the noiseword "function" in front of shell
|
|
|
|
functions.
|
|
|
|
|
2014-04-30 21:25:11 +00:00
|
|
|
- We prefer a space between the function name and the parentheses,
|
|
|
|
and no space inside the parentheses. The opening "{" should also
|
|
|
|
be on the same line.
|
|
|
|
|
|
|
|
(incorrect)
|
|
|
|
my_function(){
|
|
|
|
...
|
|
|
|
|
|
|
|
(correct)
|
|
|
|
my_function () {
|
|
|
|
...
|
2012-08-15 17:06:01 +00:00
|
|
|
|
2008-03-02 02:18:16 +00:00
|
|
|
- As to use of grep, stick to a subset of BRE (namely, no \{m,n\},
|
2014-03-31 22:11:44 +00:00
|
|
|
[::], [==], or [..]) for portability.
|
2008-03-02 02:18:16 +00:00
|
|
|
|
|
|
|
- We do not use \{m,n\};
|
|
|
|
|
2014-03-31 22:11:44 +00:00
|
|
|
- We do not use ? or + (which are \{0,1\} and \{1,\}
|
2008-03-02 02:18:16 +00:00
|
|
|
respectively in BRE) but that goes without saying as these
|
|
|
|
are ERE elements not BRE (note that \? and \+ are not even part
|
|
|
|
of BRE -- making them accessible from BRE is a GNU extension).
|
|
|
|
|
i18n: add infrastructure for translating Git with gettext
Change the skeleton implementation of i18n in Git to one that can show
localized strings to users for our C, Shell and Perl programs using
either GNU libintl or the Solaris gettext implementation.
This new internationalization support is enabled by default. If
gettext isn't available, or if Git is compiled with
NO_GETTEXT=YesPlease, Git falls back on its current behavior of
showing interface messages in English. When using the autoconf script
we'll auto-detect if the gettext libraries are installed and act
appropriately.
This change is somewhat large because as well as adding a C, Shell and
Perl i18n interface we're adding a lot of tests for them, and for
those tests to work we need a skeleton PO file to actually test
translations. A minimal Icelandic translation is included for this
purpose. Icelandic includes multi-byte characters which makes it easy
to test various edge cases, and it's a language I happen to
understand.
The rest of the commit message goes into detail about various
sub-parts of this commit.
= Installation
Gettext .mo files will be installed and looked for in the standard
$(prefix)/share/locale path. GIT_TEXTDOMAINDIR can also be set to
override that, but that's only intended to be used to test Git itself.
= Perl
Perl code that's to be localized should use the new Git::I18n
module. It imports a __ function into the caller's package by default.
Instead of using the high level Locale::TextDomain interface I've
opted to use the low-level (equivalent to the C interface)
Locale::Messages module, which Locale::TextDomain itself uses.
Locale::TextDomain does a lot of redundant work we don't need, and
some of it would potentially introduce bugs. It tries to set the
$TEXTDOMAIN based on package of the caller, and has its own
hardcoded paths where it'll search for messages.
I found it easier just to completely avoid it rather than try to
circumvent its behavior. In any case, this is an issue wholly
internal Git::I18N. Its guts can be changed later if that's deemed
necessary.
See <AANLkTilYD_NyIZMyj9dHtVk-ylVBfvyxpCC7982LWnVd@mail.gmail.com> for
a further elaboration on this topic.
= Shell
Shell code that's to be localized should use the git-sh-i18n
library. It's basically just a wrapper for the system's gettext.sh.
If gettext.sh isn't available we'll fall back on gettext(1) if it's
available. The latter is available without the former on Solaris,
which has its own non-GNU gettext implementation. We also need to
emulate eval_gettext() there.
If neither are present we'll use a dumb printf(1) fall-through
wrapper.
= About libcharset.h and langinfo.h
We use libcharset to query the character set of the current locale if
it's available. I.e. we'll use it instead of nl_langinfo if
HAVE_LIBCHARSET_H is set.
The GNU gettext manual recommends using langinfo.h's
nl_langinfo(CODESET) to acquire the current character set, but on
systems that have libcharset.h's locale_charset() using the latter is
either saner, or the only option on those systems.
GNU and Solaris have a nl_langinfo(CODESET), FreeBSD can use either,
but MinGW and some others need to use libcharset.h's locale_charset()
instead.
=Credits
This patch is based on work by Jeff Epler <jepler@unpythonic.net> who
did the initial Makefile / C work, and a lot of comments from the Git
mailing list, including Jonathan Nieder, Jakub Narebski, Johannes
Sixt, Erik Faye-Lund, Peter Krefting, Junio C Hamano, Thomas Rast and
others.
[jc: squashed a small Makefile fix from Ramsay]
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-11-17 23:14:42 +00:00
|
|
|
- Use Git's gettext wrappers in git-sh-i18n to make the user
|
|
|
|
interface translatable. See "Marking strings for translation" in
|
|
|
|
po/README.
|
|
|
|
|
2014-05-20 18:12:02 +00:00
|
|
|
- We do not write our "test" command with "-a" and "-o" and use "&&"
|
|
|
|
or "||" to concatenate multiple "test" commands instead, because
|
|
|
|
the use of "-a/-o" is often error-prone. E.g.
|
|
|
|
|
|
|
|
test -n "$x" -a "$a" = "$b"
|
|
|
|
|
|
|
|
is buggy and breaks when $x is "=", but
|
|
|
|
|
|
|
|
test -n "$x" && test "$a" = "$b"
|
|
|
|
|
|
|
|
does not have such a problem.
|
|
|
|
|
2021-05-03 05:23:24 +00:00
|
|
|
- Even though "local" is not part of POSIX, we make heavy use of it
|
|
|
|
in our test suite. We do not use it in scripted Porcelains, and
|
|
|
|
hopefully nobody starts using "local" before they are reimplemented
|
|
|
|
in C ;-)
|
|
|
|
|
2023-06-14 21:31:45 +00:00
|
|
|
- Use octal escape sequences (e.g. "\302\242"), not hexadecimal (e.g.
|
|
|
|
"\xc2\xa2") in printf format strings, since hexadecimal escape
|
|
|
|
sequences are not portable.
|
|
|
|
|
2014-05-20 18:12:02 +00:00
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
For C programs:
|
|
|
|
|
|
|
|
- We use tabs to indent, and interpret tabs as taking up to
|
|
|
|
8 spaces.
|
|
|
|
|
|
|
|
- We try to keep to at most 80 characters per line.
|
|
|
|
|
2016-02-25 08:42:22 +00:00
|
|
|
- As a Git developer we assume you have a reasonably modern compiler
|
|
|
|
and we recommend you to enable the DEVELOPER makefile knob to
|
|
|
|
ensure your patch is clear of all compiler warnings we care about,
|
|
|
|
by e.g. "echo DEVELOPER=1 >>config.mak".
|
|
|
|
|
2013-01-21 19:17:53 +00:00
|
|
|
- We try to support a wide range of C compilers to compile Git with,
|
2022-10-10 20:37:56 +00:00
|
|
|
including old ones. As of Git v2.35.0 Git requires C99 (we check
|
|
|
|
"__STDC_VERSION__"). You should not use features from a newer C
|
2019-07-16 17:21:20 +00:00
|
|
|
standard, even if your compiler groks them.
|
2012-12-16 19:36:00 +00:00
|
|
|
|
2022-10-10 20:37:56 +00:00
|
|
|
New C99 features have been phased in gradually, if something's new
|
|
|
|
in C99 but not used yet don't assume that it's safe to use, some
|
|
|
|
compilers we target have only partial support for it. These are
|
|
|
|
considered safe to use:
|
2019-07-16 17:21:20 +00:00
|
|
|
|
CodingGuidelines: mention dynamic C99 initializer elements
The first use of variables in initializer elements appears to have
been 2b6854c863a (Cleanup variables in cat-file, 2007-04-21) released
with v1.5.2.
Some of those caused portability issues, and e.g. that "cat-file" use
was changed in 66dbfd55e38 (Rewrite dynamic structure initializations
to runtime assignment, 2010-05-14) which went out with v1.7.2.
But curiously 66dbfd55e38 missed some of them, e.g. an archive.c use
added in d5f53d6d6f2 (archive: complain about path specs that don't
match anything, 2009-12-12), and another one in merge-index.c (later
builtin/merge-index.c) in 0077138cd9d (Simplify some instances of
run_command() by using run_command_v_opt()., 2009-06-08).
As far as I can tell there's been no point since 2b6854c863a in 2007
where a compiler that didn't support this has been able to compile
git. Presumably 66dbfd55e38 was an attempt to make headway with wider
portability that ultimately wasn't completed.
In any case, we are thoroughly reliant on this syntax at this point,
so let's update the guidelines, see
https://lore.kernel.org/git/xmqqy1tunjgp.fsf@gitster.g/ for the
initial discussion.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2022-10-10 20:37:57 +00:00
|
|
|
. since around 2007 with 2b6854c863a, we have been using
|
|
|
|
initializer elements which are not computable at load time. E.g.:
|
|
|
|
|
|
|
|
const char *args[] = {"constant", variable, NULL};
|
2019-07-16 17:21:20 +00:00
|
|
|
|
|
|
|
. since early 2012 with e1327023ea, we have been using an enum
|
|
|
|
definition whose last element is followed by a comma. This, like
|
|
|
|
an array initializer that ends with a trailing comma, can be used
|
2019-11-05 17:07:20 +00:00
|
|
|
to reduce the patch noise when adding a new identifier at the end.
|
2019-07-16 17:21:20 +00:00
|
|
|
|
|
|
|
. since mid 2017 with cbc0f81d, we have been using designated
|
|
|
|
initializers for struct (e.g. "struct t v = { .val = 'a' };").
|
|
|
|
|
|
|
|
. since mid 2017 with 512f41cf, we have been using designated
|
|
|
|
initializers for array (e.g. "int array[10] = { [5] = 2 }").
|
|
|
|
|
C99: remove hardcoded-out !HAVE_VARIADIC_MACROS code
Remove the "else" branches of the HAVE_VARIADIC_MACROS macro, which
have been unconditionally omitted since 765dc168882 (git-compat-util:
always enable variadic macros, 2021-01-28).
Since were always omitted, anyone trying to use a compiler without
variadic macro support to compile a git since version
git v2.31.0 or later would have had a compilation error. 10 months
across a few releases since then should have been enough time for
anyone who cared to run into that and report the issue.
In addition to that, for anyone unsetting HAVE_VARIADIC_MACROS we've
been emitting extremely verbose warnings since at least
ee4512ed481 (trace2: create new combined trace facility,
2019-02-22). That's because there is no such thing as a
"region_enter_printf" or "region_leave_printf" format, so at least
under GCC and Clang everything that includes trace.h (almost every
file) emits a couple of warnings about that.
There's a large benefit to being able to have a hard dependency rely
on variadic macros, the code surrounding usage.c is hard to maintain
if we need to write two implementations of everything, and by relying
on "__FILE__" and "__LINE__" along with "__VA_ARGS__" we can in the
future make error(), die() etc. log where they were called from. We've
also recently merged d67fc4bf0ba (Merge branch 'bc/require-c99',
2021-12-10) which further cements our hard dependency on C99.
So let's delete the fallback code, and update our CodingGuidelines to
note that we depend on this. The added bullet-point starts with
lower-case for consistency with other bullet-points in that section.
The diff in "trace.h" is relatively hard to read, since we need to
retain the existing API docs, which were comments on the code used if
HAVE_VARIADIC_MACROS was not defined.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2022-02-21 16:05:27 +00:00
|
|
|
. since early 2021 with 765dc168882, we have been using variadic
|
|
|
|
macros, mostly for printf-like trace and debug macros.
|
|
|
|
|
2022-10-10 20:37:58 +00:00
|
|
|
. since late 2021 with 44ba10d6, we have had variables declared in
|
|
|
|
the for loop "for (int i = 0; i < 10; i++)".
|
2019-07-16 17:21:20 +00:00
|
|
|
|
2022-10-10 20:37:59 +00:00
|
|
|
New C99 features that we cannot use yet:
|
|
|
|
|
|
|
|
. %z and %zu as a printf() argument for a size_t (the %z being for
|
|
|
|
the POSIX-specific ssize_t). Instead you should use
|
|
|
|
printf("%"PRIuMAX, (uintmax_t)v). These days the MSVC version we
|
|
|
|
rely on supports %z, but the C library used by MinGW does not.
|
|
|
|
|
2022-10-10 20:38:00 +00:00
|
|
|
. Shorthand like ".a.b = *c" in struct initializations is known to
|
|
|
|
trip up an older IBM XLC version, use ".a = { .b = *c }" instead.
|
|
|
|
See the 33665d98 (reftable: make assignments portable to AIX xlc
|
|
|
|
v12.01, 2022-03-28).
|
2019-07-16 17:21:20 +00:00
|
|
|
|
|
|
|
- Variables have to be declared at the beginning of the block, before
|
|
|
|
the first statement (i.e. -Wdeclaration-after-statement).
|
|
|
|
|
2012-12-16 19:36:00 +00:00
|
|
|
- NULL pointers shall be written as NULL, not as 0.
|
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- When declaring pointers, the star sides with the variable
|
|
|
|
name, i.e. "char *string", not "char* string" or
|
|
|
|
"char * string". This makes it easier to understand code
|
|
|
|
like "char *string, c;".
|
|
|
|
|
2014-02-28 06:17:25 +00:00
|
|
|
- Use whitespace around operators and keywords, but not inside
|
|
|
|
parentheses and not around functions. So:
|
|
|
|
|
|
|
|
while (condition)
|
|
|
|
func(bar + 1);
|
|
|
|
|
|
|
|
and not:
|
|
|
|
|
|
|
|
while( condition )
|
|
|
|
func (bar+1);
|
|
|
|
|
2020-05-08 17:51:21 +00:00
|
|
|
- Do not explicitly compare an integral value with constant 0 or '\0',
|
|
|
|
or a pointer value with constant NULL. For instance, to validate that
|
|
|
|
counted array <ptr, cnt> is initialized but has no elements, write:
|
|
|
|
|
|
|
|
if (!ptr || cnt)
|
|
|
|
BUG("empty array expected");
|
|
|
|
|
|
|
|
and not:
|
|
|
|
|
|
|
|
if (ptr == NULL || cnt != 0);
|
|
|
|
BUG("empty array expected");
|
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- We avoid using braces unnecessarily. I.e.
|
|
|
|
|
|
|
|
if (bla) {
|
|
|
|
x = 1;
|
|
|
|
}
|
|
|
|
|
2017-01-17 20:05:04 +00:00
|
|
|
is frowned upon. But there are a few exceptions:
|
|
|
|
|
|
|
|
- When the statement extends over a few lines (e.g., a while loop
|
|
|
|
with an embedded conditional, or a comment). E.g.:
|
|
|
|
|
|
|
|
while (foo) {
|
|
|
|
if (x)
|
|
|
|
one();
|
|
|
|
else
|
|
|
|
two();
|
|
|
|
}
|
|
|
|
|
|
|
|
if (foo) {
|
|
|
|
/*
|
|
|
|
* This one requires some explanation,
|
|
|
|
* so we're better off with braces to make
|
|
|
|
* it obvious that the indentation is correct.
|
|
|
|
*/
|
|
|
|
doit();
|
|
|
|
}
|
|
|
|
|
|
|
|
- When there are multiple arms to a conditional and some of them
|
|
|
|
require braces, enclose even a single line block in braces for
|
|
|
|
consistency. E.g.:
|
|
|
|
|
|
|
|
if (foo) {
|
|
|
|
doit();
|
|
|
|
} else {
|
|
|
|
one();
|
|
|
|
two();
|
|
|
|
three();
|
|
|
|
}
|
2007-11-08 00:33:19 +00:00
|
|
|
|
2014-04-30 21:25:47 +00:00
|
|
|
- We try to avoid assignments in the condition of an "if" statement.
|
2008-05-22 23:26:09 +00:00
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- Try to make your code understandable. You may put comments
|
|
|
|
in, but comments invariably tend to stale out when the code
|
|
|
|
they were describing changes. Often splitting a function
|
|
|
|
into two makes the intention of the code much clearer.
|
|
|
|
|
2013-10-12 00:45:46 +00:00
|
|
|
- Multi-line comments include their delimiters on separate lines from
|
|
|
|
the text. E.g.
|
|
|
|
|
|
|
|
/*
|
|
|
|
* A very long
|
|
|
|
* multi-line comment.
|
|
|
|
*/
|
|
|
|
|
2014-04-18 17:48:08 +00:00
|
|
|
Note however that a comment that explains a translatable string to
|
|
|
|
translators uses a convention of starting with a magic token
|
C style: use standard style for "TRANSLATORS" comments
Change all the "TRANSLATORS: [...]" comments in the C code to use the
regular Git coding style, and amend the style guide so that the
example there uses that style.
This custom style was necessary back in 2010 when the gettext support
was initially added, and was subsequently documented in commit
cbcfd4e3ea ("i18n: mention "TRANSLATORS:" marker in
Documentation/CodingGuidelines", 2014-04-18).
GNU xgettext hasn't had the parsing limitation that necessitated this
exception for almost 3 years. Since its 0.19 release on 2014-06-02
it's been able to recognize TRANSLATOR comments in the standard Git
comment syntax[1].
Usually we'd like to keep compatibility with software that's that
young, but in this case literally the only person who needs to be
using a gettext newer than 3 years old is Jiang Xin (the only person
who runs & commits "make pot" results), so I think in this case we can
make an exception.
This xgettext parsing feature was added after a thread on the Git
mailing list[2] which continued on the bug-gettext[3] list, but we
never subsequently changed our style & styleguide, do so.
There are already longstanding changes in git that use the standard
comment style & have their TRANSLATORS comments extracted properly
without getting the literal "*"'s mixed up in the text, as would
happen before xgettext 0.19.
Commit 7ff2683253 ("builtin-am: implement -i/--interactive",
2015-08-04) added one such comment, which in commit df0617bfa7 ("l10n:
git.pot: v2.6.0 round 1 (123 new, 41 removed)", 2015-09-05) got picked
up in the po/git.pot file with the right format, showing that Jiang
already runs a modern xgettext.
The xgettext parser does not handle the sort of non-standard comment
style that I'm amending here in sequencer.c, but that isn't standard
Git comment syntax anyway. With this change to sequencer.c & "make
pot" the comment in the pot file is now correct:
#. TRANSLATORS: %s will be "revert", "cherry-pick" or
-#. * "rebase -i".
+#. "rebase -i".
1. http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=10af7fe6bd
2. <2ce9ec406501d112e032c8208417f8100bed04c6.1397712142.git.worldhello.net@gmail.com>
(https://public-inbox.org/git/2ce9ec406501d112e032c8208417f8100bed04c6.1397712142.git.worldhello.net@gmail.com/)
3. https://lists.gnu.org/archive/html/bug-gettext/2014-04/msg00016.html
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-11 21:20:12 +00:00
|
|
|
"TRANSLATORS: ", e.g.
|
2014-04-18 17:48:08 +00:00
|
|
|
|
C style: use standard style for "TRANSLATORS" comments
Change all the "TRANSLATORS: [...]" comments in the C code to use the
regular Git coding style, and amend the style guide so that the
example there uses that style.
This custom style was necessary back in 2010 when the gettext support
was initially added, and was subsequently documented in commit
cbcfd4e3ea ("i18n: mention "TRANSLATORS:" marker in
Documentation/CodingGuidelines", 2014-04-18).
GNU xgettext hasn't had the parsing limitation that necessitated this
exception for almost 3 years. Since its 0.19 release on 2014-06-02
it's been able to recognize TRANSLATOR comments in the standard Git
comment syntax[1].
Usually we'd like to keep compatibility with software that's that
young, but in this case literally the only person who needs to be
using a gettext newer than 3 years old is Jiang Xin (the only person
who runs & commits "make pot" results), so I think in this case we can
make an exception.
This xgettext parsing feature was added after a thread on the Git
mailing list[2] which continued on the bug-gettext[3] list, but we
never subsequently changed our style & styleguide, do so.
There are already longstanding changes in git that use the standard
comment style & have their TRANSLATORS comments extracted properly
without getting the literal "*"'s mixed up in the text, as would
happen before xgettext 0.19.
Commit 7ff2683253 ("builtin-am: implement -i/--interactive",
2015-08-04) added one such comment, which in commit df0617bfa7 ("l10n:
git.pot: v2.6.0 round 1 (123 new, 41 removed)", 2015-09-05) got picked
up in the po/git.pot file with the right format, showing that Jiang
already runs a modern xgettext.
The xgettext parser does not handle the sort of non-standard comment
style that I'm amending here in sequencer.c, but that isn't standard
Git comment syntax anyway. With this change to sequencer.c & "make
pot" the comment in the pot file is now correct:
#. TRANSLATORS: %s will be "revert", "cherry-pick" or
-#. * "rebase -i".
+#. "rebase -i".
1. http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=10af7fe6bd
2. <2ce9ec406501d112e032c8208417f8100bed04c6.1397712142.git.worldhello.net@gmail.com>
(https://public-inbox.org/git/2ce9ec406501d112e032c8208417f8100bed04c6.1397712142.git.worldhello.net@gmail.com/)
3. https://lists.gnu.org/archive/html/bug-gettext/2014-04/msg00016.html
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-11 21:20:12 +00:00
|
|
|
/*
|
|
|
|
* TRANSLATORS: here is a comment that explains the string to
|
|
|
|
* be translated, that follows immediately after it.
|
|
|
|
*/
|
2014-04-18 17:48:08 +00:00
|
|
|
_("Here is a translatable string explained by the above.");
|
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- Double negation is often harder to understand than no negation
|
|
|
|
at all.
|
|
|
|
|
2014-04-30 21:26:23 +00:00
|
|
|
- There are two schools of thought when it comes to comparison,
|
|
|
|
especially inside a loop. Some people prefer to have the less stable
|
|
|
|
value on the left hand side and the more stable value on the right hand
|
|
|
|
side, e.g. if you have a loop that counts variable i down to the
|
|
|
|
lower bound,
|
|
|
|
|
|
|
|
while (i > lower_bound) {
|
|
|
|
do something;
|
|
|
|
i--;
|
|
|
|
}
|
|
|
|
|
|
|
|
Other people prefer to have the textual order of values match the
|
|
|
|
actual order of values in their comparison, so that they can
|
|
|
|
mentally draw a number line from left to right and place these
|
|
|
|
values in order, i.e.
|
|
|
|
|
|
|
|
while (lower_bound < i) {
|
|
|
|
do something;
|
|
|
|
i--;
|
|
|
|
}
|
|
|
|
|
|
|
|
Both are valid, and we use both. However, the more "stable" the
|
|
|
|
stable side becomes, the more we tend to prefer the former
|
|
|
|
(comparison with a constant, "i > 0", is an extreme example).
|
|
|
|
Just do not mix styles in the same part of the code and mimic
|
|
|
|
existing styles in the neighbourhood.
|
|
|
|
|
2014-05-02 20:42:39 +00:00
|
|
|
- There are two schools of thought when it comes to splitting a long
|
|
|
|
logical line into multiple lines. Some people push the second and
|
|
|
|
subsequent lines far enough to the right with tabs and align them:
|
|
|
|
|
|
|
|
if (the_beginning_of_a_very_long_expression_that_has_to ||
|
|
|
|
span_more_than_a_single_line_of ||
|
|
|
|
the_source_text) {
|
|
|
|
...
|
|
|
|
|
|
|
|
while other people prefer to align the second and the subsequent
|
|
|
|
lines with the column immediately inside the opening parenthesis,
|
|
|
|
with tabs and spaces, following our "tabstop is always a multiple
|
|
|
|
of 8" convention:
|
|
|
|
|
|
|
|
if (the_beginning_of_a_very_long_expression_that_has_to ||
|
|
|
|
span_more_than_a_single_line_of ||
|
|
|
|
the_source_text) {
|
|
|
|
...
|
|
|
|
|
|
|
|
Both are valid, and we use both. Again, just do not mix styles in
|
|
|
|
the same part of the code and mimic existing styles in the
|
|
|
|
neighbourhood.
|
|
|
|
|
|
|
|
- When splitting a long logical line, some people change line before
|
|
|
|
a binary operator, so that the result looks like a parse tree when
|
|
|
|
you turn your head 90-degrees counterclockwise:
|
|
|
|
|
|
|
|
if (the_beginning_of_a_very_long_expression_that_has_to
|
|
|
|
|| span_more_than_a_single_line_of_the_source_text) {
|
|
|
|
|
|
|
|
while other people prefer to leave the operator at the end of the
|
|
|
|
line:
|
|
|
|
|
|
|
|
if (the_beginning_of_a_very_long_expression_that_has_to ||
|
|
|
|
span_more_than_a_single_line_of_the_source_text) {
|
|
|
|
|
|
|
|
Both are valid, but we tend to use the latter more, unless the
|
|
|
|
expression gets fairly complex, in which case the former tends to
|
|
|
|
be easier to read. Again, just do not mix styles in the same part
|
|
|
|
of the code and mimic existing styles in the neighbourhood.
|
|
|
|
|
|
|
|
- When splitting a long logical line, with everything else being
|
|
|
|
equal, it is preferable to split after the operator at higher
|
|
|
|
level in the parse tree. That is, this is more preferable:
|
|
|
|
|
|
|
|
if (a_very_long_variable * that_is_used_in +
|
|
|
|
a_very_long_expression) {
|
|
|
|
...
|
|
|
|
|
|
|
|
than
|
|
|
|
|
|
|
|
if (a_very_long_variable *
|
|
|
|
that_is_used_in + a_very_long_expression) {
|
|
|
|
...
|
|
|
|
|
2007-11-08 00:33:19 +00:00
|
|
|
- Some clever tricks, like using the !! operator with arithmetic
|
|
|
|
constructs, can be extremely confusing to others. Avoid them,
|
|
|
|
unless there is a compelling reason to use them.
|
|
|
|
|
|
|
|
- Use the API. No, really. We have a strbuf (variable length
|
|
|
|
string), several arrays with the ALLOC_GROW() macro, a
|
2008-07-21 18:03:49 +00:00
|
|
|
string_list for sorted string lists, a hash map (mapping struct
|
2007-11-08 00:33:19 +00:00
|
|
|
objects) named "struct decorate", amongst other things.
|
|
|
|
|
2018-09-28 16:50:14 +00:00
|
|
|
- When you come up with an API, document its functions and structures
|
|
|
|
in the header file that exposes the API to its callers. Use what is
|
|
|
|
in "strbuf.h" as a model for the appropriate tone and level of
|
|
|
|
detail.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
2015-01-15 23:20:09 +00:00
|
|
|
- The first #include in C files, except in platform specific compat/
|
2023-02-24 00:09:20 +00:00
|
|
|
implementations and sha1dc/, must be either "git-compat-util.h" or
|
|
|
|
one of the approved headers that includes it first for you. (The
|
2023-05-16 06:33:57 +00:00
|
|
|
approved headers currently include "builtin.h",
|
2023-02-24 00:09:20 +00:00
|
|
|
"t/helper/test-tool.h", "xdiff/xinclude.h", or
|
|
|
|
"reftable/system.h"). You do not have to include more than one of
|
|
|
|
these.
|
2015-01-15 23:20:09 +00:00
|
|
|
|
|
|
|
- A C file must directly include the header files that declare the
|
|
|
|
functions and the types it uses, except for the functions and types
|
|
|
|
that are made available to it by including one of the header files
|
|
|
|
it must include by the previous rule.
|
2007-11-08 00:33:19 +00:00
|
|
|
|
|
|
|
- If you are planning a new command, consider writing it in shell
|
|
|
|
or perl first, so that changes in semantics can be easily
|
2013-01-21 19:17:53 +00:00
|
|
|
changed and discussed. Many Git commands started out like
|
2007-11-08 00:33:19 +00:00
|
|
|
that, and a few are still scripts.
|
|
|
|
|
2013-01-21 19:17:53 +00:00
|
|
|
- Avoid introducing a new dependency into Git. This means you
|
2007-11-08 00:33:19 +00:00
|
|
|
usually should stay away from scripting languages not already
|
2013-01-21 19:17:53 +00:00
|
|
|
used in the Git core command set (unless your command is clearly
|
2007-11-08 00:33:19 +00:00
|
|
|
separate from it, such as an importer to convert random-scm-X
|
2013-01-21 19:17:53 +00:00
|
|
|
repositories to Git).
|
2009-02-09 20:54:06 +00:00
|
|
|
|
|
|
|
- When we pass <string, length> pair to functions, we should try to
|
|
|
|
pass them in that order.
|
2010-11-04 17:12:48 +00:00
|
|
|
|
i18n: add infrastructure for translating Git with gettext
Change the skeleton implementation of i18n in Git to one that can show
localized strings to users for our C, Shell and Perl programs using
either GNU libintl or the Solaris gettext implementation.
This new internationalization support is enabled by default. If
gettext isn't available, or if Git is compiled with
NO_GETTEXT=YesPlease, Git falls back on its current behavior of
showing interface messages in English. When using the autoconf script
we'll auto-detect if the gettext libraries are installed and act
appropriately.
This change is somewhat large because as well as adding a C, Shell and
Perl i18n interface we're adding a lot of tests for them, and for
those tests to work we need a skeleton PO file to actually test
translations. A minimal Icelandic translation is included for this
purpose. Icelandic includes multi-byte characters which makes it easy
to test various edge cases, and it's a language I happen to
understand.
The rest of the commit message goes into detail about various
sub-parts of this commit.
= Installation
Gettext .mo files will be installed and looked for in the standard
$(prefix)/share/locale path. GIT_TEXTDOMAINDIR can also be set to
override that, but that's only intended to be used to test Git itself.
= Perl
Perl code that's to be localized should use the new Git::I18n
module. It imports a __ function into the caller's package by default.
Instead of using the high level Locale::TextDomain interface I've
opted to use the low-level (equivalent to the C interface)
Locale::Messages module, which Locale::TextDomain itself uses.
Locale::TextDomain does a lot of redundant work we don't need, and
some of it would potentially introduce bugs. It tries to set the
$TEXTDOMAIN based on package of the caller, and has its own
hardcoded paths where it'll search for messages.
I found it easier just to completely avoid it rather than try to
circumvent its behavior. In any case, this is an issue wholly
internal Git::I18N. Its guts can be changed later if that's deemed
necessary.
See <AANLkTilYD_NyIZMyj9dHtVk-ylVBfvyxpCC7982LWnVd@mail.gmail.com> for
a further elaboration on this topic.
= Shell
Shell code that's to be localized should use the git-sh-i18n
library. It's basically just a wrapper for the system's gettext.sh.
If gettext.sh isn't available we'll fall back on gettext(1) if it's
available. The latter is available without the former on Solaris,
which has its own non-GNU gettext implementation. We also need to
emulate eval_gettext() there.
If neither are present we'll use a dumb printf(1) fall-through
wrapper.
= About libcharset.h and langinfo.h
We use libcharset to query the character set of the current locale if
it's available. I.e. we'll use it instead of nl_langinfo if
HAVE_LIBCHARSET_H is set.
The GNU gettext manual recommends using langinfo.h's
nl_langinfo(CODESET) to acquire the current character set, but on
systems that have libcharset.h's locale_charset() using the latter is
either saner, or the only option on those systems.
GNU and Solaris have a nl_langinfo(CODESET), FreeBSD can use either,
but MinGW and some others need to use libcharset.h's locale_charset()
instead.
=Credits
This patch is based on work by Jeff Epler <jepler@unpythonic.net> who
did the initial Makefile / C work, and a lot of comments from the Git
mailing list, including Jonathan Nieder, Jakub Narebski, Johannes
Sixt, Erik Faye-Lund, Peter Krefting, Junio C Hamano, Thomas Rast and
others.
[jc: squashed a small Makefile fix from Ramsay]
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-11-17 23:14:42 +00:00
|
|
|
- Use Git's gettext wrappers to make the user interface
|
|
|
|
translatable. See "Marking strings for translation" in po/README.
|
|
|
|
|
2018-02-08 21:38:06 +00:00
|
|
|
- Variables and functions local to a given source file should be marked
|
|
|
|
with "static". Variables that are visible to other source files
|
|
|
|
must be declared with "extern" in header files. However, function
|
|
|
|
declarations should not use "extern", as that is already the default.
|
|
|
|
|
2019-05-28 19:07:29 +00:00
|
|
|
- You can launch gdb around your program using the shorthand GIT_DEBUGGER.
|
|
|
|
Run `GIT_DEBUGGER=1 ./bin-wrappers/git foo` to simply use gdb as is, or
|
|
|
|
run `GIT_DEBUGGER="<debugger> <debugger-args>" ./bin-wrappers/git foo` to
|
|
|
|
use your own debugger and arguments. Example: `GIT_DEBUGGER="ddd --gdb"
|
|
|
|
./bin-wrappers/git log` (See `wrap-for-bin.sh`.)
|
|
|
|
|
2013-02-06 19:49:01 +00:00
|
|
|
For Perl programs:
|
|
|
|
|
|
|
|
- Most of the C guidelines above apply.
|
|
|
|
|
|
|
|
- We try to support Perl 5.8 and later ("use Perl 5.008").
|
|
|
|
|
|
|
|
- use strict and use warnings are strongly preferred.
|
|
|
|
|
|
|
|
- Don't overuse statement modifiers unless using them makes the
|
|
|
|
result easier to follow.
|
|
|
|
|
|
|
|
... do something ...
|
|
|
|
do_this() unless (condition);
|
|
|
|
... do something else ...
|
|
|
|
|
|
|
|
is more readable than:
|
|
|
|
|
|
|
|
... do something ...
|
|
|
|
unless (condition) {
|
|
|
|
do_this();
|
|
|
|
}
|
|
|
|
... do something else ...
|
|
|
|
|
|
|
|
*only* when the condition is so rare that do_this() will be almost
|
|
|
|
always called.
|
|
|
|
|
|
|
|
- We try to avoid assignments inside "if ()" conditions.
|
|
|
|
|
|
|
|
- Learn and use Git.pm if you need that functionality.
|
|
|
|
|
2013-01-30 20:47:32 +00:00
|
|
|
For Python scripts:
|
|
|
|
|
|
|
|
- We follow PEP-8 (http://www.python.org/dev/peps/pep-0008/).
|
|
|
|
|
2020-06-07 10:21:06 +00:00
|
|
|
- As a minimum, we aim to be compatible with Python 2.7.
|
2013-01-30 20:47:32 +00:00
|
|
|
|
|
|
|
- Where required libraries do not restrict us to Python 2, we try to
|
|
|
|
also be compatible with Python 3.1 and later.
|
|
|
|
|
2021-12-02 22:31:10 +00:00
|
|
|
|
|
|
|
Program Output
|
|
|
|
|
|
|
|
We make a distinction between a Git command's primary output and
|
|
|
|
output which is merely chatty feedback (for instance, status
|
|
|
|
messages, running transcript, or progress display), as well as error
|
|
|
|
messages. Roughly speaking, a Git command's primary output is that
|
|
|
|
which one might want to capture to a file or send down a pipe; its
|
|
|
|
chatty output should not interfere with these use-cases.
|
|
|
|
|
|
|
|
As such, primary output should be sent to the standard output stream
|
|
|
|
(stdout), and chatty output should be sent to the standard error
|
|
|
|
stream (stderr). Examples of commands which produce primary output
|
|
|
|
include `git log`, `git show`, and `git branch --list` which generate
|
|
|
|
output on the stdout stream.
|
|
|
|
|
|
|
|
Not all Git commands have primary output; this is often true of
|
|
|
|
commands whose main function is to perform an action. Some action
|
|
|
|
commands are silent, whereas others are chatty. An example of a
|
|
|
|
chatty action commands is `git clone` with its "Cloning into
|
|
|
|
'<path>'..." and "Checking connectivity..." status messages which it
|
|
|
|
sends to the stderr stream.
|
|
|
|
|
|
|
|
Error messages from Git commands should always be sent to the stderr
|
|
|
|
stream.
|
|
|
|
|
|
|
|
|
2014-06-16 12:55:57 +00:00
|
|
|
Error Messages
|
|
|
|
|
|
|
|
- Do not end error messages with a full stop.
|
|
|
|
|
2021-04-14 23:51:17 +00:00
|
|
|
- Do not capitalize the first word, only because it is the first word
|
|
|
|
in the message ("unable to open %s", not "Unable to open %s"). But
|
|
|
|
"SHA-3 not supported" is fine, because the reason the first word is
|
|
|
|
capitalized is not because it is at the beginning of the sentence,
|
|
|
|
but because the word would be spelled in capital letters even when
|
|
|
|
it appeared in the middle of the sentence.
|
2014-06-16 12:55:57 +00:00
|
|
|
|
|
|
|
- Say what the error is first ("cannot open %s", not "%s: cannot open")
|
|
|
|
|
|
|
|
|
2015-01-27 20:26:03 +00:00
|
|
|
Externally Visible Names
|
|
|
|
|
|
|
|
- For configuration variable names, follow the existing convention:
|
|
|
|
|
|
|
|
. The section name indicates the affected subsystem.
|
|
|
|
|
|
|
|
. The subsection name, if any, indicates which of an unbounded set
|
|
|
|
of things to set the value for.
|
|
|
|
|
|
|
|
. The variable name describes the effect of tweaking this knob.
|
|
|
|
|
|
|
|
The section and variable names that consist of multiple words are
|
|
|
|
formed by concatenating the words without punctuations (e.g. `-`),
|
|
|
|
and are broken using bumpyCaps in documentation as a hint to the
|
|
|
|
reader.
|
|
|
|
|
|
|
|
When choosing the variable namespace, do not use variable name for
|
|
|
|
specifying possibly unbounded set of things, most notably anything
|
|
|
|
an end user can freely come up with (e.g. branch names). Instead,
|
|
|
|
use subsection names or variable values, like the existing variable
|
|
|
|
branch.<name>.description does.
|
|
|
|
|
|
|
|
|
2010-11-04 17:12:48 +00:00
|
|
|
Writing Documentation:
|
|
|
|
|
2013-05-07 17:39:46 +00:00
|
|
|
Most (if not all) of the documentation pages are written in the
|
|
|
|
AsciiDoc format in *.txt files (e.g. Documentation/git.txt), and
|
|
|
|
processed into HTML and manpages (e.g. git.html and git.1 in the
|
|
|
|
same directory).
|
2013-03-21 21:17:32 +00:00
|
|
|
|
2013-08-01 18:49:54 +00:00
|
|
|
The documentation liberally mixes US and UK English (en_US/UK)
|
|
|
|
norms for spelling and grammar, which is somewhat unfortunate.
|
|
|
|
In an ideal world, it would have been better if it consistently
|
|
|
|
used only one and not the other, and we would have picked en_US
|
|
|
|
(if you wish to correct the English of some of the existing
|
|
|
|
documentation, please see the documentation-related advice in the
|
|
|
|
Documentation/SubmittingPatches file).
|
|
|
|
|
2021-07-15 16:25:27 +00:00
|
|
|
In order to ensure the documentation is inclusive, avoid assuming
|
|
|
|
that an unspecified example person is male or female, and think
|
|
|
|
twice before using "he", "him", "she", or "her". Here are some
|
|
|
|
tips to avoid use of gendered pronouns:
|
|
|
|
|
|
|
|
- Prefer succinctness and matter-of-factly describing functionality
|
|
|
|
in the abstract. E.g.
|
|
|
|
|
|
|
|
--short:: Emit output in the short-format.
|
|
|
|
|
|
|
|
and avoid something like these overly verbose alternatives:
|
|
|
|
|
|
|
|
--short:: Use this to emit output in the short-format.
|
|
|
|
--short:: You can use this to get output in the short-format.
|
|
|
|
--short:: A user who prefers shorter output could....
|
|
|
|
--short:: Should a person and/or program want shorter output, he
|
|
|
|
she/they/it can...
|
|
|
|
|
|
|
|
This practice often eliminates the need to involve human actors in
|
|
|
|
your description, but it is a good practice regardless of the
|
|
|
|
avoidance of gendered pronouns.
|
|
|
|
|
|
|
|
- When it becomes awkward to stick to this style, prefer "you" when
|
2022-09-11 10:23:20 +00:00
|
|
|
addressing the hypothetical user, and possibly "we" when
|
2021-07-15 16:25:27 +00:00
|
|
|
discussing how the program might react to the user. E.g.
|
|
|
|
|
|
|
|
You can use this option instead of --xyz, but we might remove
|
|
|
|
support for it in future versions.
|
|
|
|
|
|
|
|
while keeping in mind that you can probably be less verbose, e.g.
|
|
|
|
|
|
|
|
Use this instead of --xyz. This option might be removed in future
|
|
|
|
versions.
|
|
|
|
|
|
|
|
- If you still need to refer to an example person that is
|
|
|
|
third-person singular, you may resort to "singular they" to avoid
|
|
|
|
"he/she/him/her", e.g.
|
|
|
|
|
|
|
|
A contributor asks their upstream to pull from them.
|
|
|
|
|
|
|
|
Note that this sounds ungrammatical and unnatural to those who
|
|
|
|
learned that "they" is only used for third-person plural, e.g.
|
|
|
|
those who learn English as a second language in some parts of the
|
|
|
|
world.
|
|
|
|
|
2010-11-04 17:12:48 +00:00
|
|
|
Every user-visible change should be reflected in the documentation.
|
|
|
|
The same general rule as for code applies -- imitate the existing
|
2013-11-14 23:08:45 +00:00
|
|
|
conventions.
|
|
|
|
|
|
|
|
A few commented examples follow to provide reference when writing or
|
|
|
|
modifying command usage strings and synopsis sections in the manual
|
|
|
|
pages:
|
2010-11-04 17:12:48 +00:00
|
|
|
|
2011-02-15 19:02:56 +00:00
|
|
|
Placeholders are spelled in lowercase and enclosed in angle brackets:
|
2010-11-04 17:12:48 +00:00
|
|
|
<file>
|
|
|
|
--sort=<key>
|
|
|
|
--abbrev[=<n>]
|
|
|
|
|
2015-01-13 07:44:47 +00:00
|
|
|
If a placeholder has multiple words, they are separated by dashes:
|
|
|
|
<new-branch-name>
|
|
|
|
--template=<template-directory>
|
|
|
|
|
2011-01-03 19:03:34 +00:00
|
|
|
Possibility of multiple occurrences is indicated by three dots:
|
2010-11-04 17:12:48 +00:00
|
|
|
<file>...
|
|
|
|
(One or more of <file>.)
|
|
|
|
|
|
|
|
Optional parts are enclosed in square brackets:
|
2022-10-13 15:38:56 +00:00
|
|
|
[<file>...]
|
|
|
|
(Zero or more of <file>.)
|
2010-11-04 17:12:48 +00:00
|
|
|
|
|
|
|
--exec-path[=<path>]
|
|
|
|
(Option with an optional argument. Note that the "=" is inside the
|
|
|
|
brackets.)
|
|
|
|
|
|
|
|
[<patch>...]
|
|
|
|
(Zero or more of <patch>. Note that the dots are inside, not
|
|
|
|
outside the brackets.)
|
|
|
|
|
2015-01-13 07:44:47 +00:00
|
|
|
Multiple alternatives are indicated with vertical bars:
|
2010-11-04 17:12:48 +00:00
|
|
|
[-q | --quiet]
|
|
|
|
[--utf8 | --no-utf8]
|
|
|
|
|
2022-10-13 15:38:56 +00:00
|
|
|
Use spacing around "|" token(s), but not immediately after opening or
|
|
|
|
before closing a [] or () pair:
|
|
|
|
Do: [-q | --quiet]
|
|
|
|
Don't: [-q|--quiet]
|
|
|
|
|
2023-06-07 19:26:47 +00:00
|
|
|
Don't use spacing around "|" tokens when they're used to separate the
|
2022-10-13 15:38:56 +00:00
|
|
|
alternate arguments of an option:
|
|
|
|
Do: --track[=(direct|inherit)]
|
|
|
|
Don't: --track[=(direct | inherit)]
|
|
|
|
|
2010-11-04 17:12:48 +00:00
|
|
|
Parentheses are used for grouping:
|
2015-01-13 07:44:47 +00:00
|
|
|
[(<rev> | <range>)...]
|
2010-11-04 17:12:48 +00:00
|
|
|
(Any number of either <rev> or <range>. Parens are needed to make
|
|
|
|
it clear that "..." pertains to both <rev> and <range>.)
|
|
|
|
|
|
|
|
[(-p <parent>)...]
|
|
|
|
(Any number of option -p, each with one <parent> argument.)
|
|
|
|
|
|
|
|
git remote set-head <name> (-a | -d | <branch>)
|
|
|
|
(One and only one of "-a", "-d" or "<branch>" _must_ (no square
|
|
|
|
brackets) be provided.)
|
|
|
|
|
|
|
|
And a somewhat more contrived example:
|
|
|
|
--diff-filter=[(A|C|D|M|R|T|U|X|B)...[*]]
|
|
|
|
Here "=" is outside the brackets, because "--diff-filter=" is a
|
|
|
|
valid usage. "*" has its own pair of brackets, because it can
|
|
|
|
(optionally) be specified only when one or more of the letters is
|
|
|
|
also provided.
|
2013-01-21 19:16:20 +00:00
|
|
|
|
|
|
|
A note on notation:
|
|
|
|
Use 'git' (all lowercase) when talking about commands i.e. something
|
|
|
|
the user would type into a shell and use 'Git' (uppercase first letter)
|
|
|
|
when talking about the version control system and its properties.
|
2013-11-14 23:08:45 +00:00
|
|
|
|
|
|
|
A few commented examples follow to provide reference when writing or
|
|
|
|
modifying paragraphs or option/command explanations that contain options
|
|
|
|
or commands:
|
|
|
|
|
2016-06-07 22:35:05 +00:00
|
|
|
Literal examples (e.g. use of command-line options, command names,
|
2019-03-06 13:04:45 +00:00
|
|
|
branch names, URLs, pathnames (files and directories), configuration and
|
|
|
|
environment variables) must be typeset in monospace (i.e. wrapped with
|
|
|
|
backticks):
|
2013-11-14 23:08:45 +00:00
|
|
|
`--pretty=oneline`
|
|
|
|
`git rev-list`
|
2015-03-11 20:32:45 +00:00
|
|
|
`remote.pushDefault`
|
2019-03-06 13:04:45 +00:00
|
|
|
`http://git.example.com`
|
|
|
|
`.git/config`
|
2016-06-07 22:35:05 +00:00
|
|
|
`GIT_DIR`
|
2016-06-28 11:40:14 +00:00
|
|
|
`HEAD`
|
2016-06-07 22:35:05 +00:00
|
|
|
|
|
|
|
An environment variable must be prefixed with "$" only when referring to its
|
|
|
|
value and not when referring to the variable itself, in this case there is
|
|
|
|
nothing to add except the backticks:
|
|
|
|
`GIT_DIR` is specified
|
|
|
|
`$GIT_DIR/hooks/pre-receive`
|
2013-11-14 23:08:45 +00:00
|
|
|
|
|
|
|
Word phrases enclosed in `backtick characters` are rendered literally
|
|
|
|
and will not be further expanded. The use of `backticks` to achieve the
|
|
|
|
previous rule means that literal examples should not use AsciiDoc
|
|
|
|
escapes.
|
|
|
|
Correct:
|
|
|
|
`--pretty=oneline`
|
|
|
|
Incorrect:
|
|
|
|
`\--pretty=oneline`
|
|
|
|
|
|
|
|
If some place in the documentation needs to typeset a command usage
|
|
|
|
example with inline substitutions, it is fine to use +monospaced and
|
|
|
|
inline substituted text+ instead of `monospaced literal text`, and with
|
|
|
|
the former, the part that should not get substituted must be
|
|
|
|
quoted/escaped.
|