development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-06 00:09:53 +00:00
Code Issues Packages Projects Releases Wiki Activity
flutter/packages
History
auto-submit[bot] bc611f565b
Reverts "Fix TextField helper top padding on M3 (#145087)" (#145168) 
Reverts: flutter/flutter#145087
Initiated by: Jasguerrero
Reason for reverting: failing on accessibility checks b/329548765
Original PR Author: bleroux

Reviewed By: {justinmc}

This change reverts the following previous change:
## Description

`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.

This PR sets the correct values for M3 without changing the value for M2.

| Before | After | M3 Spec |
|--------|--------|--------|
| ![image](https://github.com/flutter/flutter/assets/840911/9947f334-d98f-4f7e-9da7-ca6d5c0770ac) | ![image](https://github.com/flutter/flutter/assets/840911/081dec4b-eb9f-4eee-a7dc-2538e7110ff0)| ![image](https://github.com/flutter/flutter/assets/840911/c8c8f045-3b79-43a5-a1a3-cc6d5460644f) |

If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144984

## Tests

Updates a value used by several existing tests.
2024-03-14 18:00:26 +00:00
..
flutter Reverts "Fix TextField helper top padding on M3 (#145087)" (#145168) 2024-03-14 18:00:26 +00:00
flutter_driver Manually roll pub packages (#145005) 2024-03-12 19:53:57 +00:00
flutter_goldens Rename isAvailableForEnvironment to isForEnvironment (#143176) (#144858) 2024-03-10 06:20:38 +00:00
flutter_localizations [framework] fix incorrect chinese localizations for Search Web and Share in selection controls (#144857) 2024-03-14 10:14:20 -07:00
flutter_test Turning if chains into shorter switch statements (#144977) 2024-03-13 17:16:17 +00:00
flutter_tools Update proxied devices to handle connection interface and diagnostics. (#145061) 2024-03-13 22:24:25 +00:00
flutter_web_plugins Upgrade vm_service. (#144845) 2024-03-08 17:09:07 -08:00
fuchsia_remote_debug_protocol Manually roll pub packages (#145005) 2024-03-12 19:53:57 +00:00
integration_test Manually roll pub packages (#145005) 2024-03-12 19:53:57 +00:00
analysis_options.yaml Unify analysis options (#108462) 2022-07-28 09:07:49 -07:00