Commit graph

12544 commits

Author SHA1 Message Date
Greg Spencer f20adcc428
Add docset generation (#24322)
(re-land of #24244)

This generates a zip file containing all of the docs, and uploads it when we publish docs, as well as a
Dash/Zeal docset that contains a feed of the docs.

Addresses at least part of #9955
2018-11-15 15:05:57 -08:00
Justin McCandless f9bccb0280
Handle a missing ListView separator as an error (#24312)
* Handle a missing ListView separator as an error

* Handle missing item, and errors in itemBuilder and separatorBuilder

* CR fixes and move error handling into sliver.dart to handle all ListView constructors

* Only show an error for null separatorBuilder value in debug mode
2018-11-15 14:40:13 -08:00
Jonah Williams 938dd5a4aa
Revert "Update driver script to execute test through test_core" (#24401)
* Revert "Add dashing config file for generating docset from flutter docs (#24374)"

This reverts commit ec8ca8606c.

* Revert "Update driver script to execute test through test_core (#24168)"

This reverts commit 6c62cf337f.
2018-11-15 11:17:00 -08:00
Daohan Chong ec8ca8606c Add dashing config file for generating docset from flutter docs (#24374) 2018-11-15 10:57:02 -08:00
Jonah Williams 6c62cf337f
Update driver script to execute test through test_core (#24168) 2018-11-15 10:50:25 -08:00
engine-flutter-autoroll c559f1def3
db5908815 Roll src/third_party/skia 7d2aae3165a2..2eccd58916ee (3 commits) (flutter/engine#6862) (#24387)
00e4abff84...db59088159

git log 00e4abff84a6..db59088159a5 --no-merges --oneline
db5908815 Roll src/third_party/skia 7d2aae3165a2..2eccd58916ee (3 commits) (flutter/engine#6862)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-15 13:09:04 -05:00
Diego Tori 9447be7370 Added support for passing in velocity and offset into Draggable.onDragCompleted (#22267)
* Added support for passing in velocity and offset into Draggable.onDragCompleted.

* Fixed documentation of DragCompletedCallback.

* Spun off previous onDragCompleted breaking changes into new callback called Draggable.onDragEnd.

* Revert "Fixed documentation of DragCompletedCallback."

This reverts commit 069051f5be.

* Revert "Added support for passing in velocity and offset into Draggable.onDragCompleted."

This reverts commit 7ef744aa56.

* DraggableDetails constructor is now declared first as per Flutter code style.

* Draggable.onDragEnd will only call back if its widget is currently mounted to the tree.

* Moved "});" in DraggableDetails constructor to new line, vertically aligned with the constructor name, as per Flutter code style.

* Added space between if statement in drag_target.dart.

* widget.onDragEnd call is now formated as per flutter code style.

* Added more details to DraggableDetails documentation.

* Added brackets to if statement block as per Flutter code style.

* Fixed minor nits in DraggableDetails documentation.

* Made DraggableDetails constructor public. Also added documentation for its constructor.
2018-11-15 09:11:04 -08:00
engine-flutter-autoroll 33f8030b32
Roll engine 498bbd5ef9c1..00e4abff84a6 (2 commits) (#24372)
498bbd5ef9...00e4abff84

git log 498bbd5ef9c1..00e4abff84a6 --no-merges --oneline
00e4abff8 Roll src/third_party/skia 44764000b49c..7d2aae3165a2 (1 commits) (flutter/engine#6861)
2c6be93fa Clean up stale cache entries in Skia's GrContext (flutter/engine#6859)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 23:06:49 -05:00
Dan Field 091b73ab6f
fix variable check in xcode_backend.sh (#24368)
* fix test in xcode_backend.sh

* -n

* fix devicelab test

* uncomment good code, check for \"\"
2018-11-14 18:54:51 -08:00
Alexander Aprelev 64a8d44764
Fix test so it doesn't leak frontend_server process (#24360)
* Fix test so it doesn't leak frontend_server process

* Stop FlutterTestDriver even if expectation is not met
2018-11-14 18:50:18 -08:00
engine-flutter-autoroll e8eea83472
Roll engine 289de46d3e55..498bbd5ef9c1 (3 commits) (#24364)
289de46d3e...498bbd5ef9

git log 289de46d3e55..498bbd5ef9c1 --no-merges --oneline
498bbd5ef Roll src/third_party/skia f152130ef910..44764000b49c (8 commits) (flutter/engine#6860)
f23862b25 Added delegate forwarding for didReceiveLocalNotification and willPresentNotification (flutter/engine#6858)
110a5f320 Reset a11y bridge state on hot restart (flutter/engine#6857)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 21:49:49 -05:00
Yegor 9c3754d92f
FlutterDriver: allow customizing timeouts using a multiplier (#24066)
FlutterDriver: allow customizing timeouts using a multiplier
2018-11-14 17:15:00 -08:00
Greg Spencer eb35f8923b
Reland: Make the 'time to update' message depend up on the channel. (#24173) (#24321)
Fixes #24158
Re-lands #24173
2018-11-14 16:51:12 -08:00
S McDowall 87156df6d9 Optionally show the text field length but not the max (#24183)
If maxLength is set to TextField.noMaxLength then continue to show the character counter but do not display the max input length value.
2018-11-14 16:04:39 -08:00
Zachary Anderson 779c68f691
[fuchsia] Fix BUILD and metadata file for Fuchsia (#24294) 2018-11-14 15:43:06 -08:00
Hans Muller 70d83cc7ac
Add support for the Marathi language, locale mr_IN (#24353) 2018-11-14 15:42:51 -08:00
liyuqian ba635a643a
Add golden tests for Opacity with offset (#24253)
See https://github.com/flutter/flutter/issues/23890
2018-11-14 15:00:39 -08:00
engine-flutter-autoroll 07c5c0ac1b
289de46d3e5598a265e2fd83c1d4004ec8a65f9b (#24359)
14ee957fb4...289de46d3e

git log 14ee957fb4d3..289de46d3e55 --no-merges --oneline
289de46d3 Return EngineLayer for all SceneBuilder pushXXX (flutter/engine#6814)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 17:30:50 -05:00
James D. Lin 26f94bdd49
Make examples/catalog instructions a bit less confusing (#24252)
Make the examples/catalog instructions a bit less confusing:
* Make the README.md file provide explicit instructions about how to
  run each example.
* Try to clarify that the lib/main.dart message is instructional and
  not an error message.

Additionally, adjust examples/layers/lib/main.dart to be consistent
with examples/catalog/lib/main.dart.

Fixes #22640.

Testing Done:
* Ran `flutter run` from examples/catalog and from examples/layers,
  saw the updated message.
2018-11-14 14:26:30 -08:00
James D. Lin 91cfc1fe31
Fix a few typos in comments (#24249) 2018-11-14 14:25:05 -08:00
Michael Goderbauer e71eb9a474
Make Link clickable in DartDocs (#24358) 2018-11-14 14:08:04 -08:00
Jason Simmons 9f28aefa9c
Call BorderRadiusGeometry.lerp where applicable in ShapeBorder subclasses (#24262)
Fixes https://github.com/flutter/flutter/issues/24257
2018-11-14 13:47:48 -08:00
stevemessick ff25edd3ad
Update idea template files (#24311)
* Update IntelliJ project template files

* Add ignored file

* Fix test

* Restore comma
2018-11-14 13:45:07 -08:00
Alexander Aprelev 0b940a4473
Flush write to disk with intent of reducing flakiness of the test. (#24144) 2018-11-14 13:26:24 -08:00
engine-flutter-autoroll 63532eb96a
Roll engine 99d848a9986c..14ee957fb4d3 (2 commits) (#24357)
99d848a998...14ee957fb4

git log 99d848a9986c..14ee957fb4d3 --no-merges --oneline
14ee957fb Set up secondary isolates with all kernel buffers rather than just one buffer. (flutter/engine#6832)
76522eb28 Roll src/third_party/skia 7f2b6fa66575..f152130ef910 (5 commits) (flutter/engine#6856)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 16:20:49 -05:00
Greg Spencer ada1d29075
Turn of use of compute credits for PR builds. (#24352) 2018-11-14 12:47:39 -08:00
engine-flutter-autoroll e189f0c27f
99d848a9986cb376b9858e2b7345fcea6637ff51 (#24350)
114d33d3ca...99d848a998

git log 114d33d3caa2..99d848a9986c --no-merges --oneline
99d848a99 Roll src/third_party/skia b45b53f01cf3..7f2b6fa66575 (1 commits) (flutter/engine#6855)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 15:17:49 -05:00
Stanislav Baranov 7669f7c05d
Trivial README changeq (#24356) 2018-11-14 11:24:23 -08:00
Greg Spencer d44aa57c12
Disable docs generation. (#24354)
Landing on red in order to fix the build.
2018-11-14 11:09:56 -08:00
Alexander Aprelev 3b7942c444
Fix multi-step build handling process. (#24310)
* Fix multi-step build handling process.

Stop listening for new step updates after 'all done.' log message. Make sure that we don't delete file too soon, until listener had a chance to process the 'all done' message.

Fixes https://github.com/flutter/flutter/issues/18750

* Emit 'all output' explicitly when build process is done.
2018-11-14 08:54:13 -08:00
Brian Wilkerson 29d5210d8b Use constant durations in more places (#24306) 2018-11-14 08:16:12 -08:00
engine-flutter-autoroll 2ae1379995
Roll engine b10b8e899029..114d33d3caa2 (3 commits) (#24345)
b10b8e8990...114d33d3ca

git log b10b8e899029..114d33d3caa2 --no-merges --oneline
114d33d3c Set and unset accessibility flags even when re-entrant (flutter/engine#6853)
396402f5b Flush UserSettings to window (flutter/engine#6850)
1e7e676e4 Remove unused import (flutter/engine#6854)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 11:07:51 -05:00
engine-flutter-autoroll d5a177f7a6
b10b8e899029193b75769ebb7fdec63e87ebb255 (#24332)
520746ed9c...b10b8e8990

git log 520746ed9c6b..b10b8e899029 --no-merges --oneline
b10b8e899 Roll src/third_party/skia 1e00aebd9a45..b45b53f01cf3 (3 commits) (flutter/engine#6852)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 08:54:50 -05:00
engine-flutter-autoroll 09cd111538
Roll engine 4959b71d6a1b..520746ed9c6b (11 commits) (#24326)
4959b71d6a...520746ed9c

git log 4959b71d6a1b..520746ed9c6b --no-merges --oneline
520746ed9 Roll src/third_party/skia 14b9f537c5ee..1e00aebd9a45 (5 commits) (flutter/engine#6848)
97b62938b Add missing pragma directive. (flutter/engine#6847)
0d0287780 Avoid a never-disappearing splash screen if the engine came from somewhere else on iOS (flutter/engine#6834)
71ade8278 Roll src/third_party/skia abde1adc5f0c..14b9f537c5ee (9 commits) (flutter/engine#6846)
4e89aa221 Roll src/third_party/skia 60b6bc3c2950..abde1adc5f0c (6 commits) (flutter/engine#6845)
6a132f80f Fix Windows Engine Bot (flutter/engine#6844)
e6d6f18eb - Roll engine to version f9ebf2129732fd2b606286fdf58e500384b8a0bc (flutter/engine#6839)
889f41f0d Roll src/third_party/skia 9e3109c99ea5..60b6bc3c2950 (1 commits) (flutter/engine#6843)
a68e21430 Roll src/third_party/skia 1e1ba0e0176f..9e3109c99ea5 (1 commits) (flutter/engine#6840)
1174193ce Roll src/third_party/skia f04fb3cacbad..1e1ba0e0176f (2 commits) (flutter/engine#6838)
09ef73ff6 Fix code smells reported by chrome's clang plugin (flutter/engine#6833)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 02:04:50 -05:00
Michael Goderbauer e5f0457261
Another typo fix (#24316) 2018-11-13 23:03:11 -08:00
Siva e8e1ae8f53
Revert the engine version back to 4959b71d6a1b1473911970428b16ac02397d930b (#24323)
This reverts all the merges done by the engine auto roller
6142e33
ab2bf18
ac9dcb5
cf0b385
9c93b0c
38e1dd1
2018-11-13 19:55:15 -08:00
Greg Spencer a2ed3ecb64
Revert "Make the 'time to update' message depend up on the channel. (#24173)" (#24320)
This reverts commit 97e03104a0.

Landing on red to hopefully make less red on the board.

TBR=@goderbauer
2018-11-13 17:18:06 -08:00
Michael Goderbauer f2370c4fa0
Switch engine.merge_method back to squash (#24319)
Unfortunately, device lab does not have the capacity for merge method
rebase. It's essentially DoSing device lab: The last engine rebase has
been processing for 6h now and it is still not done :(
2018-11-13 17:12:36 -08:00
Greg Spencer 1561815e6c
Revert "Generate a zip file of offline docs and a Dash/Zeal docset. (#24244)" (#24313)
This reverts commit f3a4f7e86d.

Accidental merge on red.
2018-11-13 16:02:34 -08:00
Greg Spencer f3a4f7e86d
Generate a zip file of offline docs and a Dash/Zeal docset. (#24244)
This generates a zip file containing all of the docs, and uploads it when we publish docs, as well as a
Dash/Zeal docset that contains a feed of the docs.

Addresses at least part of #9955
2018-11-13 15:58:06 -08:00
engine-flutter-autoroll 6142e33243 6a132f80f44880b4feaadfebe7daf18867bea5fa 2018-11-13 15:11:52 -05:00
engine-flutter-autoroll ab2bf187ce e6d6f18eb6678301e1893f318fa58edb75b105c9 2018-11-13 15:11:52 -05:00
engine-flutter-autoroll ac9dcb5e9e 889f41f0db97e6c5d8422f709380ee851370e651 2018-11-13 15:11:52 -05:00
engine-flutter-autoroll cf0b385ad4 a68e21430a7bd3fe208f12ef9bb333a1191b4ee1 2018-11-13 15:11:52 -05:00
engine-flutter-autoroll 9c93b0c3d3 1174193ceb7946d4f6770ac73f6774a995ff58ce 2018-11-13 15:11:52 -05:00
engine-flutter-autoroll 38e1dd10e0 09ef73ff6eb0d3306571be62c59176008a465de1 2018-11-13 15:11:52 -05:00
Michael Goderbauer f4af41e20e
type fix (#24297) 2018-11-13 10:31:22 -08:00
Greg Spencer 97e03104a0
Make the 'time to update' message depend up on the channel. (#24173)
Fixes #24158
2018-11-13 09:53:56 -08:00
Michael Klimushyn 72b6a7063d
Don't consider a timestamp "newer" when equal (#24251)
Fixes flutter/flutter#22062
2018-11-13 09:48:32 -08:00
Justin McCandless 1fde4d0366
Docs clarification for how RTL/LTR locale affects ButtonBar (#24264) 2018-11-13 09:46:04 -08:00