Commit graph

16048 commits

Author SHA1 Message Date
gaaclarke ed1d5a8f1c
Added SystemNavigator.pop "animated" argument. (#41820) 2019-10-08 10:05:30 -07:00
engine-flutter-autoroll 70e753a2a7
611c345a4 Roll src/third_party/skia a28cf7c08061..902cf1e12a74 (4 commits) (flutter/engine#12994) (#42244)
git@github.com:flutter/engine.git/compare/819b0cae0c23...611c345a4e76

git log 819b0cae0c23..611c345a4e76 --no-merges --oneline
2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia a28cf7c08061..902cf1e12a74 (4 commits) (flutter/engine#12994)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 12:51:43 -04:00
Alexandre Ardhuin 83e5a8a0e4
some formatting changes (#41640) 2019-10-08 18:32:10 +02:00
engine-flutter-autoroll 85a3da3a5e
Roll engine 4a849e0f8dd5..819b0cae0c23 (6 commits) (#42240)
git@github.com:flutter/engine.git/compare/4a849e0f8dd5...819b0cae0c23

git log 4a849e0f8dd5..819b0cae0c23 --no-merges --oneline
2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia f611d943fb73..a28cf7c08061 (29 commits) (flutter/engine#12993)
2019-10-08 garyq@google.com Unpublicize kDoNotResizeDimension (flutter/engine#12989)
2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4c82a9fc83a5..f611d943fb73 (1 commits) (flutter/engine#12831)
2019-10-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from kwa2O... to wOfz2... (flutter/engine#12827)
2019-10-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from by2LL... to gB_ii... (flutter/engine#12979)
2019-10-08 jason-simmons@users.noreply.github.com Roll Wuffs to 0.2.0-rc.1 (flutter/engine#12983)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 12:05:43 -04:00
engine-flutter-autoroll ff7e23ba52
Roll engine 1d62160fdb2f..4a849e0f8dd5 (17 commits) (#42200)
git@github.com:flutter/engine.git/compare/1d62160fdb2f...4a849e0f8dd5

git log 1d62160fdb2f..4a849e0f8dd5 --no-merges --oneline
2019-10-08 dnfield@google.com Color matrix doc (flutter/engine#12982)
2019-10-07 jason-simmons@users.noreply.github.com Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988)
2019-10-07 bkonyi@google.com Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981)
2019-10-07 liyuqian@google.com Unblock Fuchsia roll (flutter/engine#12977)
2019-10-06 chinmaygarde@google.com Update buildroot to pull in ubsan updates. (flutter/engine#12821)
2019-10-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818)
2019-10-05 chinmaygarde@google.com Enable sanitizer build variants. (flutter/engine#12816)
2019-10-05 katelovett@google.com Revert "Adding Link SemanticsFlag (#12453)" (flutter/engine#12815)
2019-10-04 jason-simmons@users.noreply.github.com Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809)
2019-10-04 yjbanov@google.com add option for bulk-updating screenshots; update screenshots (flutter/engine#12797)
2019-10-04 dnfield@google.com unbreak unopt fuchsia (flutter/engine#12805)
2019-10-04 jason-simmons@users.noreply.github.com Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802)
2019-10-04 dnfield@google.com [flutter_runner] a11y updates, tests! (flutter/engine#12380)
2019-10-04 WATER1350@gmail.com Fix crash in copypixelbuffer (flutter/engine#10326)
2019-10-04 bkonyi@google.com Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803)
2019-10-04 katelovett@google.com Adding Link SemanticsFlag (flutter/engine#12453)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 11:29:43 -04:00
Ian Hickson cdc2d9901d
More consistent temp directory naming (#42063)
Applying our style guide:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#have-good-hygiene-when-using-temporary-directories
2019-10-07 16:43:04 -07:00
LongCatIsLooong 9529d678fa
Cupertino { TabScafold, TextSelection, TextField } dark mode & minor fidelity update (#41431) 2019-10-07 16:41:50 -07:00
Mouad Debbar 1946fc4da0
[web] Always send the route name even if it's null (#41996) 2019-10-07 15:23:31 -07:00
Jonah Williams 9638756c2a
Apply mocks to test command to deflake web_fs test (#42118) 2019-10-07 15:20:33 -07:00
Yegor ebfe6020b8
Enable more web tests; use blacklist to filter them out (#41922)
Add more web tests;use blacklist instead of whitelist
2019-10-07 15:05:24 -07:00
Zachary Anderson cf0d4979c7
[flutter_tool] Re-work analytics events to use labels and values (#42016) 2019-10-07 15:04:55 -07:00
Darren Austin 2d642e95e1
Changed the dark theme elevation overlay to use the colorScheme.onSurface (#41857)
The Material Dark Theme spec has been updated (or soon will be) to clarify that the elevation overlay that is applied to surface colors to indicate elevation should be based off of the colorScheme.onSurface color and not white. This commit implements this change.
2019-10-07 11:02:29 -07:00
Dan Field 4566b34033
Do not validate the Android SDK when building an appbundle (#41946) 2019-10-07 10:38:19 -07:00
Dan Field 3af16678ad
Reland "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)" (#42038)
This reverts commit 142a8630ec.
2019-10-07 10:37:58 -07:00
Emmanuel Garcia fa4d31b311
Fix smoke test (#42022) 2019-10-07 10:05:40 -07:00
engine-flutter-autoroll 43a6626c0c
Roll engine 7d90779bb66f..1d62160fdb2f (7 commits) (#42011)
git@github.com:flutter/engine.git/compare/7d90779bb66f...1d62160fdb2f

git log 7d90779bb66f..1d62160fdb2f --no-merges --oneline
2019-10-04 iska.kaushik@gmail.com Prettify all CMX files (flutter/engine#12800)
2019-10-04 garyq@google.com Restart all modern Samsung keyboard IMM (flutter/engine#12780)
2019-10-04 dnfield@google.com Reland fuchsia build improvements (flutter/engine#12795)
2019-10-04 50856934+nturgut@users.noreply.github.com Fixing selection issues in Firefox (flutter/engine#12793)
2019-10-04 chinmaygarde@google.com Disable EmbedderTest::CanLaunchAndShutdownMultipleTimes. (flutter/engine#12799)
2019-10-04 iska.kaushik@gmail.com [flutter_runner] Update the cmx files to include TZ support (flutter/engine#12798)
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia fbdf48ecb204..95edac1c9a4a (1 commits) (flutter/engine#12790)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-07 13:03:43 -04:00
Zachary Anderson 3b66db6bf7
Updates packages (#41936) 2019-10-07 09:46:57 -07:00
Ian Hickson 97e00b2288 Skip sdk_validation_test again (#42091) 2019-10-07 08:11:45 -07:00
Ian Hickson 682e6383ac
Refactor sdk_validation_test (#42064) 2019-10-06 14:39:16 -07:00
Ian Hickson 1196f91f71
Fix local test failures in flutter_tools (#42015)
* Minor clean-up in terminal.dart

* Don't wrap text in tests (otherwise we'll be sensitive to the terminal width).
2019-10-06 14:38:17 -07:00
Dan Field f4b4616f87
Diagnose failure in CI, Mark III (#42037) 2019-10-04 20:01:04 -07:00
Ian Hickson a22f4e9be5
trying to diagnose failure in CI, mark II (#42036)
* remove prints

* Remove the setUpAll() to see if that changes the error message.
2019-10-04 19:43:54 -07:00
Ian Hickson 4e6b77c087
trying to diagnose failure in CI (#42035) 2019-10-04 19:01:37 -07:00
Ian Hickson 142a8630ec
Revert "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)
This reverts commit 3024053c82.
2019-10-04 17:51:51 -07:00
James D. Lin fcbe8f44ea
Restructure ProjectFileInvalidator.findInvalidated a bit (#42008)
Restructure ProjectFileInvalidator.findInvalidated a bit

I plan to modify `ProjectFileInvalidator.findInvalidated` to allow
it to use `FileStat.stat` instead of `FileStat.statSync`.
Restructure `findInvalidated` a bit so that `FileStat.statSync` is
called in only one place.

Note that this change now always counts the `.packages` file as one
of the files scanned, even if it does not exist.  I think that this
is okay since it more accurately reflects the number of times that we
hit the filesystem with `stat()`, and it is consistent with how other
files are counted.
2019-10-04 17:22:35 -07:00
engine-flutter-autoroll 71497367ef
Roll engine 759d3dba259b..7d90779bb66f (5 commits) (#42004)
git@github.com:flutter/engine.git/compare/759d3dba259b...7d90779bb66f

git log 759d3dba259b..7d90779bb66f --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VkAgX... to by2LL... (flutter/engine#12791)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 28f21d4e99..d6c6d12ebf (3 commits)
2019-10-04 jonahwilliams@google.com Fix bug in package script and add dev_compiler to list of uploaded packages (flutter/engine#12785)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7a7dcd1ed9..28f21d4e99 (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from wYLiQ... to JyZWz... (flutter/engine#12788)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-04 16:13:43 -04:00
James D. Lin 14c5c6e161
Clean up ProjectFileInvalidator.findInvalidated a bit (#41889)
In preparation for some refactoring that I will be doing to
`ProjectFileInvalidator.findInvalidated`, make its code a bit
clearer:
* Indicate which arguments may be null.
* Don't bother calling `FileStat.statSync` on the `.packages` file
  for the initial load.  This makes the checks for the `.packages`
  file consistent with those for other files.
* Use `DateTime.isAfter()` instead of comparing microseconds
  ourselves.

While I was touching this file, I also removed some unnecessary
comparisons to `false`. (`_ManifestAssetBundle.wasBuiltOnce()` is the
only implementation I can find of `AssetBundle.wasBuiltOnce()`, and
it never returns `null`.)
2019-10-04 12:55:17 -07:00
Jonah Williams 3024053c82
AOT support for Linux Desktop I: switch Linux builds to assemble (#41612) 2019-10-04 12:13:36 -07:00
Ryan Macnak cdb3578b14
Plumb --enable-asserts through to frontend_server invocation in debug mode. (#41832)
Bytecode generation will otherwise omit assert code, causing --enable-asserts to have no effect in the VM.
2019-10-04 12:07:23 -07:00
Rody Davis b730a993c1 Fix CupertinoTextField and TextField ToolbarOptions not changing (#40665) 2019-10-04 11:22:57 -07:00
krisgiesing 0e605cc4dd Revert "Fix ReorderableListView's use of child keys (#41334) (#41338)" (#41931)
This reverts commit 2b138fd7d2.
2019-10-04 07:52:15 -07:00
Erick Ghaumez 62ae5883a8 Fix 'popupTheme' variable name in a MaterialBannerTheme method (#41632) 2019-10-04 22:42:09 +08:00
Emmanuel Garcia 5961bcc505
Generate projects using the new Android embedding (#41666)
* Generate projects using the new Android embedding

* Add comment about usesNewEmbedding:true

* Feedback

* Rework way to detect new embedding in new apps
2019-10-04 06:23:03 -07:00
Alexandre Ardhuin 890b939401
indent formal parameters correctly (#41644) 2019-10-04 11:00:18 +02:00
engine-flutter-autoroll dc03c44321
759d3dba2 Roll src/third_party/skia 35a60f622c58..fbdf48ecb204 (2 commits) (flutter/engine#12787) (#41965)
git@github.com:flutter/engine.git/compare/ec9d487b0599...759d3dba259b

git log ec9d487b0599..759d3dba259b --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia 35a60f622c58..fbdf48ecb204 (2 commits) (flutter/engine#12787)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-04 04:01:43 -04:00
Jonah Williams ae18f07324
Ensure plugin registrants are generated in build_web (#41906) 2019-10-04 00:36:09 -07:00
engine-flutter-autoroll ea305c5050
ec9d487b0 Roll src/third_party/dart b4688e9172..7a7dcd1ed9 (5 commits) (#41961)
git@github.com:flutter/engine.git/compare/a0605af402ac...ec9d487b0599

git log a0605af402ac..ec9d487b0599 --no-merges --oneline
2019-10-04 bkonyi@google.com Roll src/third_party/dart b4688e9172..7a7dcd1ed9 (5 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-04 03:12:43 -04:00
engine-flutter-autoroll 3a728a9b5b
a0605af40 Roll src/third_party/skia d71344590a2f..35a60f622c58 (9 commits) (flutter/engine#12784) (#41958)
git@github.com:flutter/engine.git/compare/9db06370490d...a0605af402ac

git log 9db06370490d..a0605af402ac --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia d71344590a2f..35a60f622c58 (9 commits) (flutter/engine#12784)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-04 01:37:43 -04:00
Jonah Williams f25812bae5
Revert "replace package:vm_service_client with package:vm_service in the devicelab project (#41646)" (#41960) 2019-10-03 21:30:37 -07:00
engine-flutter-autoroll 96b4e8cf1a
9db063704 Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits) (#41957)
git@github.com:flutter/engine.git/compare/2e163b27805b...9db06370490d

git log 2e163b27805b..9db06370490d --no-merges --oneline
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 23:59:43 -04:00
Devon Carew 4de496a4e5 replace package:vm_service_client with package:vm_service in the devicelab project (#41646) 2019-10-03 20:43:34 -07:00
escamoteur 2713ee61f0 added questions on Platform / OS Version / Device (#41651)
* added questions on Platform / OS Version / Design

* changed following the comments

* removed the host platform question
2019-10-03 20:43:04 -07:00
Emmanuel Garcia 00f82d9021 Use mergeResourcesProvider instead of deprecated mergeResources (#41942) 2019-10-03 20:42:43 -07:00
Emmanuel Garcia ed49a79516 Include embedding transitive dependencies in plugins (#41885) 2019-10-03 20:42:24 -07:00
stuartmorgan 18d6d9bc7b Add Profile entry to macOS Podfile (#41747) 2019-10-03 20:41:48 -07:00
Greg Spencer 3e2dc8ca7b Revert ActivateAction PR (#41945) 2019-10-03 20:27:37 -07:00
engine-flutter-autoroll 780bddcca5
Roll engine 62e58c5d9fc2..2e163b27805b (4 commits) (#41954)
git@github.com:flutter/engine.git/compare/62e58c5d9fc2...2e163b27805b

git log 62e58c5d9fc2..2e163b27805b --no-merges --oneline
2019-10-04 dnfield@google.com Revert "Build AOT and test targets, generate FARs when building Fuchsia (#12761)" (flutter/engine#12781)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Enabled people to chose if SystemNavigator.pop is animated on iOS. (flutter/engine#12752)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Added some thread asserts to the code and made ios_surface_ safe since (flutter/engine#12775)
2019-10-03 dnfield@google.com Build AOT and test targets, generate FARs when building Fuchsia (flutter/engine#12761)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 23:11:43 -04:00
Jonah Williams db9ad60bfe
Deflake web_fs_test.dart in flutter_tools (#41952) 2019-10-03 19:07:38 -07:00
Dan Field 6048b62e21
Update label applied for performance template bugs (#41717) 2019-10-03 18:56:25 -07:00
LongCatIsLooong 97d191de13
Fix CupertinoActivityIndicator radius (#41892) 2019-10-03 18:37:57 -07:00